scratchfoundation/golangci-lint
1
0
Fork 0
mirror of https://github.com/scratchfoundation/golangci-lint.git synced 2025-08-28 22:28:43 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fill README section about performance

Browse source
This commit is contained in:
golangci 2018-05-19 22:09:20 +03:00
parent 3c2ca7b7c9
commit ab0ce75c06
8 changed files with 157 additions and 63 deletions
Download patch file Download diff file Expand all files Collapse all files

19
pkg/commands/run.go
View file

@ -56,6 +56,7 @@ func (e *Executor) initRun() {
runCmd.Flags().BoolVar(&rc.AnalyzeTests, "tests", false, "Analyze tests (*_test.go)")
runCmd.Flags().BoolVar(&rc.PrintResourcesUsage, "print-resources-usage", false, "Print avg and max memory usage of golangci-lint and total time")
runCmd.Flags().StringVarP(&rc.Config, "config", "c", "", "Read config from file path `PATH`")
runCmd.Flags().BoolVar(&rc.NoConfig, "no-config", false, "Don't read config")
// Linters settings config
lsc := &e.cfg.LintersSettings
@ -315,7 +316,15 @@ func (e *Executor) parseConfig(cmd *cobra.Command) {
viper.SetEnvKeyReplacer(strings.NewReplacer(".", "_"))
viper.AutomaticEnv()
configFile := viper.GetString("config")
configFile := e.cfg.Run.Config
if e.cfg.Run.NoConfig && configFile != "" {
log.Fatal("can't combine option --config and --no-config")
}
if e.cfg.Run.NoConfig {
return
}
if configFile == "" {
viper.SetConfigName(".golangci")
viper.AddConfigPath("./")
@ -323,6 +332,10 @@ func (e *Executor) parseConfig(cmd *cobra.Command) {
viper.SetConfigFile(configFile)
}
e.parseConfigImpl()
}
func (e *Executor) parseConfigImpl() {
commandLineConfig := *e.cfg // make copy
if err := viper.ReadInConfig(); err != nil {
@ -351,6 +364,10 @@ func (e *Executor) validateConfig(commandLineConfig *config.Config) error {
return errors.New("option run.cpuprofilepath in config isn't allowed")
}
if commandLineConfig.Run.MemProfilePath == "" && c.Run.MemProfilePath != "" {
return errors.New("option run.memprofilepath in config isn't allowed")
}
if !commandLineConfig.Run.IsVerbose && c.Run.IsVerbose {
return errors.New("can't set run.verbose option with config: only on command-line")
}