scratchfoundation/golangci-lint
1
0
Fork 0
mirror of https://github.com/scratchfoundation/golangci-lint.git synced 2025-08-01 00:50:58 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Sorting result.Issues implementation (golangci/golangci-lint#1217) ()

Browse source
This commit is contained in:
Oleg Butuzov 2020-07-13 00:35:08 +03:00 • committed by GitHub
parent 65e1b30ebd
commit 6e7c317610
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 409 additions and 0 deletions

35
test/run_test.go
View file

@ -126,6 +126,41 @@ func TestLineDirectiveProcessedFilesLiteLoading(t *testing.T) {
r.ExpectExitCode(exitcodes.IssuesFound).ExpectOutputEq(output + "\n")
}
func TestSortedResults(t *testing.T) {
var testCases = []struct {
opt string
want string
}{
{
"--sort-results=false",
strings.Join([]string{
"testdata/sort_results/main.go:12:5: `db` is unused (deadcode)",
"testdata/sort_results/main.go:15:13: Error return value of `returnError` is not checked (errcheck)",
"testdata/sort_results/main.go:8:6: func `returnError` is unused (unused)",
}, "\n"),
},
{
"--sort-results=true",
strings.Join([]string{
"testdata/sort_results/main.go:8:6: func `returnError` is unused (unused)",
"testdata/sort_results/main.go:12:5: `db` is unused (deadcode)",
"testdata/sort_results/main.go:15:13: Error return value of `returnError` is not checked (errcheck)",
}, "\n"),
},
}
dir := getTestDataDir("sort_results")
t.Parallel()
for i := range testCases {
test := testCases[i]
t.Run(test.opt, func(t *testing.T) {
r := testshared.NewLintRunner(t).Run("--print-issued-lines=false", test.opt, dir)
r.ExpectExitCode(exitcodes.IssuesFound).ExpectOutputEq(test.want + "\n")
})
}
}
func TestLineDirectiveProcessedFilesFullLoading(t *testing.T) {
r := testshared.NewLintRunner(t).Run("--print-issued-lines=false", "--no-config",
"--exclude-use-default=false", "-Egolint,govet", getTestDataDir("quicktemplate"))