feat: deprecate varcheck, deadcode, and structcheck (#3125)

This commit is contained in:
Ludovic Fernandez 2022-08-21 21:37:47 +02:00 committed by GitHub
parent e1afce4433
commit 37d3aa437a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
13 changed files with 67 additions and 60 deletions

View file

@ -128,16 +128,23 @@ func TestNolintInvalidLinterName(t *testing.T) {
{
Pos: token.Position{
Filename: fileName,
Line: 3,
Line: 10,
},
FromLinter: "varcheck",
FromLinter: "errcheck",
},
{
Pos: token.Position{
Filename: fileName,
Line: 6,
Line: 13,
},
FromLinter: "deadcode",
FromLinter: "errcheck",
},
{
Pos: token.Position{
Filename: fileName,
Line: 22,
},
FromLinter: "ineffassign",
},
}
@ -244,22 +251,22 @@ func TestIgnoredRangeMatches(t *testing.T) {
func TestNolintWholeFile(t *testing.T) {
fileName := filepath.Join("testdata", "nolint_whole_file.go")
p := newTestNolintProcessor(nil)
p := newTestNolintProcessor(getMockLog())
defer p.Finish()
processAssertEmpty(t, p, result.Issue{
Pos: token.Position{
Filename: fileName,
Line: 4,
Line: 9,
},
FromLinter: "varcheck",
FromLinter: "errcheck",
})
processAssertSame(t, p, result.Issue{
Pos: token.Position{
Filename: fileName,
Line: 4,
Line: 14,
},
FromLinter: "deadcode",
FromLinter: "govet",
})
}