scratchfoundation/golangci-lint
1
0
Fork 0
mirror of https://github.com/scratchfoundation/golangci-lint.git synced 2025-08-28 22:28:43 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

speed up a bit (#1064)

Browse source 
Ensure that `unused` is always the last
in execution order. It can speed up packages loading
a bit.

Refactor enabled linters set to remove extra logging.

Relates: #944
This commit is contained in:
Isaev Denis 2020-05-05 18:45:19 +03:00 • committed by GitHub
parent ca04ca6b59
commit 279b6d62d3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
10 changed files with 68 additions and 82 deletions
Download patch file Download diff file Expand all files Collapse all files

8
pkg/result/processors/nolint_test.go
View file

@ -253,9 +253,9 @@ func TestNolintUnused(t *testing.T) {
cfg := &config.Config{Linters: config.Linters{DisableAll: true, Enable: enabledLinters}}
dbManager := lintersdb.NewManager(cfg, nil)
enabledLintersSet := lintersdb.NewEnabledSet(dbManager, lintersdb.NewValidator(dbManager), enabledSetLog, cfg)
lcs, err := enabledLintersSet.Get(false)
enabledLintersMap, err := enabledLintersSet.GetEnabledLintersMap()
assert.NoError(t, err)
return NewNolint(log, dbManager, lcs)
return NewNolint(log, dbManager, enabledLintersMap)
}
// the issues below the nolintlint issues that would be generated for the test file
@ -297,9 +297,9 @@ func TestNolintUnused(t *testing.T) {
dbManager := lintersdb.NewManager(cfg, nil)
enabledLintersSet := lintersdb.NewEnabledSet(dbManager, lintersdb.NewValidator(dbManager), enabledSetLog, cfg)
lcs, err := enabledLintersSet.Get(false)
enabledLintersMap, err := enabledLintersSet.GetEnabledLintersMap()
assert.NoError(t, err)
p := NewNolint(log, dbManager, lcs)
p := NewNolint(log, dbManager, enabledLintersMap)
defer p.Finish()
processAssertEmpty(t, p, nolintlintIssueVarcheck)