scratchfoundation/golangci-lint
1
0
Fork 0
mirror of https://github.com/scratchfoundation/golangci-lint.git synced 2025-08-28 22:28:43 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

dev: refactor some test assertions (#4081)

Browse source
This commit is contained in:
Oleksandr Redko 2023-09-18 23:15:04 +03:00 • committed by GitHub
parent 615a52b9e3
commit 0704271d8d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 26 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

8
pkg/result/processors/nolint_test.go
View file

@ -8,6 +8,7 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
"github.com/stretchr/testify/require"
"github.com/golangci/golangci-lint/pkg/config"
"github.com/golangci/golangci-lint/pkg/golinters"
@ -173,9 +174,8 @@ func TestNolintInvalidLinterNameWithViolationOnTheSameLine(t *testing.T) {
processedIssues, err := p.Process(issues)
p.Finish()
assert.Len(t, processedIssues, 1)
require.NoError(t, err)
assert.Equal(t, issues, processedIssues)
assert.NoError(t, err)
}
func TestNolintAliases(t *testing.T) {
@ -288,7 +288,7 @@ func TestNolintUnused(t *testing.T) {
enabledLintersSet := lintersdb.NewEnabledSet(dbManager, lintersdb.NewValidator(dbManager), enabledSetLog, cfg)
enabledLintersMap, err := enabledLintersSet.GetEnabledLintersMap()
assert.NoError(t, err)
require.NoError(t, err)
return NewNolint(log, dbManager, enabledLintersMap)
}
@ -351,7 +351,7 @@ func TestNolintUnused(t *testing.T) {
enabledLintersSet := lintersdb.NewEnabledSet(dbManager, lintersdb.NewValidator(dbManager), enabledSetLog, cfg)
enabledLintersMap, err := enabledLintersSet.GetEnabledLintersMap()
assert.NoError(t, err)
require.NoError(t, err)
p := NewNolint(log, dbManager, enabledLintersMap)
defer p.Finish()