scratchfoundation/bgfx
1
0
Fork 0
mirror of https://github.com/scratchfoundation/bgfx.git synced 2024-11-28 10:35:43 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix for convexFill crash when path fillCount is 0

Browse source 
In our situation, the crash happened due to the view dimensions being reset to 0x0 after minimizing the window. This translated to fillCount of a path ending up at 0, which makes `fan` crash as it computes number of tris to -2 of fillCount. Since `numTris` is unsigned, this could lead to terrible things, but luckily it crashes soon.

There might be a cleaner fix for this further up the call stack, but this is a good solution in the meanwhile.
This commit is contained in:
Miha Lunar 2014-11-21 00:39:04 +01:00
parent 472ee8f27e
commit 6c6a550fd6
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
examples/common/nanovg/nanovg_bgfx.cpp
View file

@ -620,6 +620,7 @@ namespace
for (i = 0; i < npaths; i++)
{
if (paths[i].fillCount == 0) continue;
bgfx::setProgram(gl->prog);
bgfx::setState(gl->state);
bgfx::setVertexBuffer(&gl->tvb);