Fix code quirk (#676)

This commit is contained in:
Christian Semmler 2024-03-15 12:05:09 -04:00 committed by GitHub
parent 10ae05a888
commit 78f0455463
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -178,13 +178,10 @@ void MxDSAction::MergeFrom(MxDSAction& p_dsAction)
this->m_up[2] = p_dsAction.m_up[2];
}
MxU16 extraLength = p_dsAction.m_extraLength;
char* extraData = p_dsAction.m_extraData;
MxU16 extraLength;
char* extraData;
p_dsAction.GetExtra(extraLength, extraData);
// Taking those references forces the compiler to move the values onto the stack.
// The original code most likely looked different, but this yields a 100% match.
MxU16& extraLengthRef = extraLength;
char*& extraDataRef = extraData;
if (extraLength && extraData) {
if (!this->m_extraData || !strncmp("XXX", this->m_extraData, 3)) {
delete[] this->m_extraData;