mirror of
https://github.com/codeninjasllc/discourse.git
synced 2024-12-19 03:52:25 -05:00
6f2ce93ab2
FastImage might throw an exception when it isn't able to recognize a file as being an image (ie. happens when users changes the extension manually) Also improved upload specs a lot
187 lines
5.8 KiB
Ruby
187 lines
5.8 KiB
Ruby
require 'spec_helper'
|
|
require 'digest/sha1'
|
|
|
|
describe Upload do
|
|
|
|
it { should belong_to :user }
|
|
|
|
it { should have_many :post_uploads }
|
|
it { should have_many :posts }
|
|
|
|
it { should have_many :optimized_images }
|
|
|
|
it { should validate_presence_of :original_filename }
|
|
it { should validate_presence_of :filesize }
|
|
|
|
let(:upload) { build(:upload) }
|
|
let(:thumbnail) { build(:optimized_image, upload: upload) }
|
|
|
|
let(:user_id) { 1 }
|
|
let(:url) { "http://domain.com" }
|
|
|
|
let(:image) do
|
|
ActionDispatch::Http::UploadedFile.new({
|
|
filename: 'logo.png',
|
|
tempfile: File.new("#{Rails.root}/spec/fixtures/images/logo.png")
|
|
})
|
|
end
|
|
|
|
let(:image_sha1) { Digest::SHA1.file(image.tempfile).hexdigest }
|
|
|
|
let(:attachment) do
|
|
ActionDispatch::Http::UploadedFile.new({
|
|
filename: File.basename(__FILE__),
|
|
tempfile: File.new(__FILE__)
|
|
})
|
|
end
|
|
|
|
context ".create_thumbnail!" do
|
|
|
|
it "does not create a thumbnail when disabled" do
|
|
SiteSetting.stubs(:create_thumbnails?).returns(false)
|
|
SiteSetting.expects(:enable_s3_uploads?).never
|
|
upload.create_thumbnail!
|
|
end
|
|
|
|
it "does not create a thumbnail when using S3" do
|
|
SiteSetting.expects(:create_thumbnails?).returns(true)
|
|
SiteSetting.expects(:enable_s3_uploads?).returns(true)
|
|
upload.expects(:has_thumbnail?).never
|
|
upload.create_thumbnail!
|
|
end
|
|
|
|
it "does not create another thumbnail" do
|
|
SiteSetting.expects(:create_thumbnails?).returns(true)
|
|
SiteSetting.expects(:enable_s3_uploads?).returns(false)
|
|
upload.expects(:has_thumbnail?).returns(true)
|
|
OptimizedImage.expects(:create_for).never
|
|
upload.create_thumbnail!
|
|
end
|
|
|
|
it "creates a thumbnail" do
|
|
upload = Fabricate(:upload)
|
|
thumbnail = Fabricate(:optimized_image, upload: upload)
|
|
SiteSetting.expects(:create_thumbnails?).returns(true)
|
|
SiteSetting.expects(:enable_s3_uploads?).returns(false)
|
|
upload.expects(:has_thumbnail?).returns(false)
|
|
OptimizedImage.expects(:create_for).returns(thumbnail)
|
|
upload.create_thumbnail!
|
|
upload.reload
|
|
upload.optimized_images.count.should == 1
|
|
end
|
|
|
|
end
|
|
|
|
context ".create_for" do
|
|
|
|
it "does not create another upload if it already exists" do
|
|
Upload.expects(:where).with(sha1: image_sha1).returns([upload])
|
|
Upload.expects(:create!).never
|
|
Upload.create_for(user_id, image).should == upload
|
|
end
|
|
|
|
it "computes width & height for images" do
|
|
SiteSetting.expects(:authorized_image?).returns(true)
|
|
FastImage.any_instance.expects(:size).returns([100, 200])
|
|
ImageSizer.expects(:resize)
|
|
ActionDispatch::Http::UploadedFile.any_instance.expects(:rewind)
|
|
Upload.create_for(user_id, image)
|
|
end
|
|
|
|
it "does not create an upload when there is an error with FastImage" do
|
|
SiteSetting.expects(:authorized_image?).returns(true)
|
|
Upload.expects(:create!).never
|
|
expect { Upload.create_for(user_id, attachment) }.to raise_error(FastImage::UnknownImageType)
|
|
end
|
|
|
|
it "does not compute width & height for non-image" do
|
|
SiteSetting.expects(:authorized_image?).returns(false)
|
|
FastImage.any_instance.expects(:size).never
|
|
Upload.create_for(user_id, image)
|
|
end
|
|
|
|
it "saves proper information" do
|
|
Upload.expects(:store_file).returns(url)
|
|
upload = Upload.create_for(user_id, image)
|
|
upload.user_id.should == user_id
|
|
upload.original_filename.should == image.original_filename
|
|
upload.filesize.should == File.size(image.tempfile)
|
|
upload.sha1.should == Digest::SHA1.file(image.tempfile).hexdigest
|
|
upload.width.should == 244
|
|
upload.height.should == 66
|
|
upload.url.should == url
|
|
end
|
|
|
|
end
|
|
|
|
context ".store_file" do
|
|
|
|
it "store files on s3 when enabled" do
|
|
SiteSetting.expects(:enable_s3_uploads?).returns(true)
|
|
LocalStore.expects(:store_file).never
|
|
S3.expects(:store_file)
|
|
Upload.store_file(image, image_sha1, 1)
|
|
end
|
|
|
|
it "store files locally by default" do
|
|
S3.expects(:store_file).never
|
|
LocalStore.expects(:store_file)
|
|
Upload.store_file(image, image_sha1, 1)
|
|
end
|
|
|
|
end
|
|
|
|
context ".remove_file" do
|
|
|
|
it "remove files on s3 when enabled" do
|
|
SiteSetting.expects(:enable_s3_uploads?).returns(true)
|
|
LocalStore.expects(:remove_file).never
|
|
S3.expects(:remove_file)
|
|
Upload.remove_file(upload.url)
|
|
end
|
|
|
|
it "remove files locally by default" do
|
|
S3.expects(:remove_file).never
|
|
LocalStore.expects(:remove_file)
|
|
Upload.remove_file(upload.url)
|
|
end
|
|
|
|
end
|
|
|
|
context ".has_been_uploaded?" do
|
|
|
|
it "identifies internal or relatives urls" do
|
|
Discourse.expects(:base_url_no_prefix).returns("http://discuss.site.com")
|
|
Upload.has_been_uploaded?("http://discuss.site.com/uploads/default/42/0123456789ABCDEF.jpg").should == true
|
|
Upload.has_been_uploaded?("/upload/42/0123456789ABCDEF.jpg").should == true
|
|
end
|
|
|
|
it "identifies internal urls when using a CDN" do
|
|
ActionController::Base.expects(:asset_host).returns("http://my.cdn.com").twice
|
|
Upload.has_been_uploaded?("http://my.cdn.com/uploads/default/42/0123456789ABCDEF.jpg").should == true
|
|
end
|
|
|
|
it "identifies S3 uploads" do
|
|
SiteSetting.stubs(:enable_s3_uploads).returns(true)
|
|
SiteSetting.stubs(:s3_upload_bucket).returns("bucket")
|
|
Upload.has_been_uploaded?("//bucket.s3.amazonaws.com/1337.png").should == true
|
|
end
|
|
|
|
it "identifies external urls" do
|
|
Upload.has_been_uploaded?("http://domain.com/uploads/default/42/0123456789ABCDEF.jpg").should == false
|
|
Upload.has_been_uploaded?("//bucket.s3.amazonaws.com/1337.png").should == false
|
|
end
|
|
|
|
end
|
|
|
|
context ".get_from_url" do
|
|
|
|
it "works only when the file has been uploaded" do
|
|
Upload.expects(:has_been_uploaded?).returns(false)
|
|
Upload.expects(:where).never
|
|
Upload.get_from_url("discourse.org")
|
|
end
|
|
|
|
end
|
|
|
|
end
|