mirror of
https://github.com/codeninjasllc/discourse.git
synced 2024-11-23 23:58:31 -05:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
62 lines
2.5 KiB
Ruby
62 lines
2.5 KiB
Ruby
require "rails_helper"
|
|
require "spam_handler"
|
|
|
|
describe SpamHandler do
|
|
|
|
describe "#should_prevent_registration_from_ip?" do
|
|
|
|
it "works" do
|
|
# max_new_accounts_per_registration_ip = 0 disables the check
|
|
SiteSetting.stubs(:max_new_accounts_per_registration_ip).returns(0)
|
|
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[1])
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
|
|
# only prevents registration for TL0
|
|
SiteSetting.stubs(:max_new_accounts_per_registration_ip).returns(2)
|
|
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[1])
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[1])
|
|
expect { Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0]) }.to raise_error(ActiveRecord::RecordInvalid)
|
|
end
|
|
|
|
it "doesn't limit registrations since there is a TL2+ user with that IP" do
|
|
# setup
|
|
SiteSetting.stubs(:max_new_accounts_per_registration_ip).returns(0)
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[2])
|
|
|
|
# should not limit registration
|
|
SiteSetting.stubs(:max_new_accounts_per_registration_ip).returns(1)
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
end
|
|
|
|
it "doesn't limit registrations since there is a staff member with that IP" do
|
|
# setup
|
|
SiteSetting.stubs(:max_new_accounts_per_registration_ip).returns(0)
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
Fabricate(:moderator, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
|
|
Group.refresh_automatic_groups!(:staff)
|
|
|
|
# should not limit registration
|
|
SiteSetting.stubs(:max_new_accounts_per_registration_ip).returns(1)
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
end
|
|
|
|
it "doesn't limit registrations when the IP is whitelisted" do
|
|
# setup
|
|
SiteSetting.stubs(:max_new_accounts_per_registration_ip).returns(0)
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
ScreenedIpAddress.stubs(:is_whitelisted?).with("42.42.42.42").returns(true)
|
|
|
|
# should not limit registration
|
|
SiteSetting.stubs(:max_new_accounts_per_registration_ip).returns(1)
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
end
|
|
|
|
end
|
|
|
|
end
|