mirror of
https://github.com/codeninjasllc/discourse.git
synced 2024-12-11 08:11:15 -05:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
101 lines
2.9 KiB
Ruby
101 lines
2.9 KiB
Ruby
require 'rails_helper'
|
|
require_dependency "common_passwords/common_passwords"
|
|
|
|
describe PasswordValidator do
|
|
|
|
let(:validator) { described_class.new({attributes: :password}) }
|
|
subject(:validate) { validator.validate_each(record,:password,@password) }
|
|
|
|
context "password required" do
|
|
let(:record) { u = Fabricate.build(:user, password: @password); u.password_required!; u }
|
|
|
|
context "password is not common" do
|
|
before do
|
|
CommonPasswords.stubs(:common_password?).returns(false)
|
|
end
|
|
|
|
context "min password length is 8" do
|
|
before { SiteSetting.stubs(:min_password_length).returns(8) }
|
|
|
|
it "doesn't add an error when password is good" do
|
|
@password = "weron235alsfn234"
|
|
validate
|
|
expect(record.errors[:password]).not_to be_present
|
|
end
|
|
|
|
it "adds an error when password is too short" do
|
|
@password = "p"
|
|
validate
|
|
expect(record.errors[:password]).to be_present
|
|
end
|
|
|
|
it "adds an error when password is blank" do
|
|
@password = ''
|
|
validate
|
|
expect(record.errors[:password]).to be_present
|
|
end
|
|
|
|
it "adds an error when password is nil" do
|
|
@password = nil
|
|
validate
|
|
expect(record.errors[:password]).to be_present
|
|
end
|
|
end
|
|
|
|
context "min password length is 12" do
|
|
before { SiteSetting.stubs(:min_password_length).returns(12) }
|
|
|
|
it "adds an error when password length is 11" do
|
|
@password = "gt38sdt92bv"
|
|
validate
|
|
expect(record.errors[:password]).to be_present
|
|
end
|
|
end
|
|
end
|
|
|
|
context "password is commonly used" do
|
|
before do
|
|
CommonPasswords.stubs(:common_password?).returns(true)
|
|
end
|
|
|
|
it "adds an error when block_common_passwords is enabled" do
|
|
SiteSetting.stubs(:block_common_passwords).returns(true)
|
|
@password = "password"
|
|
validate
|
|
expect(record.errors[:password]).to be_present
|
|
end
|
|
|
|
it "doesn't add an error when block_common_passwords is disabled" do
|
|
SiteSetting.stubs(:block_common_passwords).returns(false)
|
|
@password = "password"
|
|
validate
|
|
expect(record.errors[:password]).not_to be_present
|
|
end
|
|
end
|
|
|
|
it "adds an error when password is the same as the username" do
|
|
@password = "porkchops1"
|
|
record.username = @password
|
|
validate
|
|
expect(record.errors[:password]).to be_present
|
|
end
|
|
|
|
it "adds an error when password is the same as the email" do
|
|
@password = "pork@chops.com"
|
|
record.email = @password
|
|
validate
|
|
expect(record.errors[:password]).to be_present
|
|
end
|
|
end
|
|
|
|
context "password not required" do
|
|
let(:record) { Fabricate.build(:user, password: @password) }
|
|
|
|
it "doesn't add an error if password is not required" do
|
|
@password = nil
|
|
validate
|
|
expect(record.errors[:password]).not_to be_present
|
|
end
|
|
end
|
|
|
|
end
|