mirror of
https://github.com/codeninjasllc/discourse.git
synced 2024-11-23 23:58:31 -05:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
58 lines
1.8 KiB
Ruby
58 lines
1.8 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe NotificationsController do
|
|
|
|
context 'when logged in' do
|
|
let!(:user) { log_in }
|
|
|
|
it 'should succeed for recent' do
|
|
xhr :get, :index, recent: true
|
|
expect(response).to be_success
|
|
end
|
|
|
|
it 'should succeed for history' do
|
|
xhr :get, :index
|
|
expect(response).to be_success
|
|
end
|
|
|
|
it 'should succeed' do
|
|
xhr :put, :mark_read
|
|
expect(response).to be_success
|
|
end
|
|
|
|
it 'should mark notifications as viewed' do
|
|
notification = Fabricate(:notification, user: user)
|
|
expect(user.reload.unread_notifications).to eq(1)
|
|
expect(user.reload.total_unread_notifications).to eq(1)
|
|
xhr :get, :index, recent: true
|
|
expect(user.reload.unread_notifications).to eq(0)
|
|
expect(user.reload.total_unread_notifications).to eq(1)
|
|
end
|
|
|
|
it 'should not mark notifications as viewed if silent param is present' do
|
|
notification = Fabricate(:notification, user: user)
|
|
expect(user.reload.unread_notifications).to eq(1)
|
|
expect(user.reload.total_unread_notifications).to eq(1)
|
|
xhr :get, :index, recent: true, silent: true
|
|
expect(user.reload.unread_notifications).to eq(1)
|
|
expect(user.reload.total_unread_notifications).to eq(1)
|
|
end
|
|
|
|
it "updates the `read` status" do
|
|
notification = Fabricate(:notification, user: user)
|
|
expect(user.reload.unread_notifications).to eq(1)
|
|
expect(user.reload.total_unread_notifications).to eq(1)
|
|
xhr :put, :mark_read
|
|
user.reload
|
|
expect(user.reload.unread_notifications).to eq(0)
|
|
expect(user.reload.total_unread_notifications).to eq(0)
|
|
end
|
|
end
|
|
|
|
context 'when not logged in' do
|
|
it 'should raise an error' do
|
|
expect { xhr :get, :index, recent: true }.to raise_error(Discourse::NotLoggedIn)
|
|
end
|
|
end
|
|
|
|
end
|