mirror of
https://github.com/codeninjasllc/discourse.git
synced 2024-12-24 22:42:27 -05:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
178 lines
3.7 KiB
Ruby
178 lines
3.7 KiB
Ruby
# encoding: utf-8
|
|
require 'rails_helper'
|
|
require 'scheduler/scheduler'
|
|
|
|
describe Scheduler::Manager do
|
|
|
|
module Testing
|
|
class RandomJob
|
|
extend ::Scheduler::Schedule
|
|
|
|
def self.runs=(val)
|
|
@runs = val
|
|
end
|
|
|
|
def self.runs
|
|
@runs ||= 0
|
|
end
|
|
|
|
every 5.minutes
|
|
|
|
def perform
|
|
self.class.runs+=1
|
|
sleep 0.001
|
|
end
|
|
end
|
|
|
|
class SuperLongJob
|
|
extend ::Scheduler::Schedule
|
|
|
|
every 10.minutes
|
|
|
|
def perform
|
|
sleep 1000
|
|
end
|
|
end
|
|
|
|
class PerHostJob
|
|
extend ::Scheduler::Schedule
|
|
|
|
per_host
|
|
every 10.minutes
|
|
|
|
def self.runs=(val)
|
|
@runs = val
|
|
end
|
|
|
|
def self.runs
|
|
@runs ||= 0
|
|
end
|
|
|
|
def perform
|
|
self.class.runs += 1
|
|
end
|
|
end
|
|
end
|
|
|
|
let(:manager) { Scheduler::Manager.new(DiscourseRedis.new) }
|
|
|
|
before do
|
|
$redis.del manager.class.lock_key
|
|
$redis.del manager.class.queue_key
|
|
manager.remove(Testing::RandomJob)
|
|
manager.remove(Testing::SuperLongJob)
|
|
manager.remove(Testing::PerHostJob)
|
|
end
|
|
|
|
after do
|
|
manager.stop!
|
|
manager.remove(Testing::RandomJob)
|
|
manager.remove(Testing::SuperLongJob)
|
|
manager.remove(Testing::PerHostJob)
|
|
end
|
|
|
|
describe 'per host jobs' do
|
|
it "correctly schedules on multiple hosts" do
|
|
Testing::PerHostJob.runs = 0
|
|
|
|
hosts = ['a','b','c']
|
|
|
|
hosts.map do |host|
|
|
|
|
manager = Scheduler::Manager.new(DiscourseRedis.new, hostname: host)
|
|
manager.ensure_schedule!(Testing::PerHostJob)
|
|
|
|
info = manager.schedule_info(Testing::PerHostJob)
|
|
info.next_run = Time.now.to_i - 1
|
|
info.write!
|
|
|
|
manager
|
|
|
|
end.each do |manager|
|
|
|
|
manager.blocking_tick
|
|
manager.stop!
|
|
|
|
end
|
|
|
|
expect(Testing::PerHostJob.runs).to eq(3)
|
|
|
|
end
|
|
end
|
|
|
|
describe '#sync' do
|
|
|
|
it 'increases' do
|
|
expect(Scheduler::Manager.seq).to eq(Scheduler::Manager.seq - 1)
|
|
end
|
|
end
|
|
|
|
describe '#tick' do
|
|
|
|
it 'should nuke missing jobs' do
|
|
$redis.zadd Scheduler::Manager.queue_key, Time.now.to_i - 1000, "BLABLA"
|
|
manager.tick
|
|
expect($redis.zcard(Scheduler::Manager.queue_key)).to eq(0)
|
|
end
|
|
|
|
it 'should recover from crashed manager' do
|
|
|
|
info = manager.schedule_info(Testing::SuperLongJob)
|
|
info.next_run = Time.now.to_i - 1
|
|
info.write!
|
|
|
|
manager.tick
|
|
manager.stop!
|
|
|
|
$redis.del manager.identity_key
|
|
|
|
manager = Scheduler::Manager.new(DiscourseRedis.new)
|
|
manager.reschedule_orphans!
|
|
|
|
info = manager.schedule_info(Testing::SuperLongJob)
|
|
expect(info.next_run).to be <= Time.now.to_i
|
|
end
|
|
|
|
it 'should only run pending job once' do
|
|
|
|
Testing::RandomJob.runs = 0
|
|
|
|
info = manager.schedule_info(Testing::RandomJob)
|
|
info.next_run = Time.now.to_i - 1
|
|
info.write!
|
|
|
|
(0..5).map do
|
|
Thread.new do
|
|
manager = Scheduler::Manager.new(DiscourseRedis.new)
|
|
manager.blocking_tick
|
|
manager.stop!
|
|
end
|
|
end.map(&:join)
|
|
|
|
expect(Testing::RandomJob.runs).to eq(1)
|
|
|
|
info = manager.schedule_info(Testing::RandomJob)
|
|
expect(info.prev_run).to be <= Time.now.to_i
|
|
expect(info.prev_duration).to be > 0
|
|
expect(info.prev_result).to eq("OK")
|
|
end
|
|
|
|
end
|
|
|
|
describe '#discover_schedules' do
|
|
it 'Discovers Testing::RandomJob' do
|
|
expect(Scheduler::Manager.discover_schedules).to include(Testing::RandomJob)
|
|
end
|
|
end
|
|
|
|
describe '#next_run' do
|
|
it 'should be within the next 5 mins if it never ran' do
|
|
|
|
manager.remove(Testing::RandomJob)
|
|
manager.ensure_schedule!(Testing::RandomJob)
|
|
|
|
expect(manager.next_run(Testing::RandomJob))
|
|
.to be_within(5.minutes.to_i).of(Time.now.to_i + 5.minutes)
|
|
end
|
|
end
|
|
end
|