mirror of
https://github.com/codeninjasllc/discourse.git
synced 2024-12-24 06:22:31 -05:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
55 lines
1.3 KiB
Ruby
55 lines
1.3 KiB
Ruby
require 'rails_helper'
|
|
require_dependency 'json_error'
|
|
|
|
shared_examples "a generic error" do
|
|
let(:result) { creator.create_errors_json(obj) }
|
|
|
|
it "should have a result object" do
|
|
expect(result).to be_present
|
|
end
|
|
|
|
it "has a generic error message" do
|
|
expect(result[:errors]).to eq([I18n.t('js.generic_error')])
|
|
end
|
|
end
|
|
|
|
describe JsonError do
|
|
|
|
let(:creator) { Object.new.extend(JsonError) }
|
|
|
|
describe "with a nil argument" do
|
|
it_behaves_like "a generic error" do
|
|
let(:obj) { nil }
|
|
end
|
|
end
|
|
|
|
describe "with an empty array" do
|
|
it_behaves_like "a generic error" do
|
|
let(:obj) { [] }
|
|
end
|
|
end
|
|
|
|
describe "with an activerecord object with no errors" do
|
|
it_behaves_like "a generic error" do
|
|
let(:obj) { Fabricate.build(:user) }
|
|
end
|
|
end
|
|
|
|
describe "with a string" do
|
|
it "returns the string in the error format" do
|
|
expect(creator.create_errors_json("test error")).to eq({errors: ["test error"]})
|
|
end
|
|
end
|
|
|
|
describe "an activerecord objec with errors" do
|
|
let(:invalid_user) { User.new }
|
|
it "returns the errors correctly" do
|
|
expect(invalid_user).not_to be_valid
|
|
result = creator.create_errors_json(invalid_user)
|
|
expect(result).to be_present
|
|
expect(result[:errors]).not_to be_blank
|
|
end
|
|
end
|
|
|
|
end
|
|
|