mirror of
https://github.com/codeninjasllc/discourse.git
synced 2024-11-27 17:46:05 -05:00
661f2057f7
* Make omniauth controller specs more robust by using shared examples for all authentication providers in controller spec. – Still passing. Yay! * Return "casuser", instead of "casuser@" when no cas_domainname is configured. * If no cas_domainname is configured, the CAS authentication would return "casuser@" for the users email field, because it tried to assume the email adress of the CAS user by it's username + cas_domainname. Now it just returns the username instead of adding an "@" if cas_domainname is not configured. This especially makes sense on CAS setups where the username equals the users email adress. The old behaviour, if cas_domainname is configured, was not changed. * Fetch the email from CAS attributes if provided If the cas:authenticationSuccess (handled via omniauth-cas) response gives us an email use that. If not, behave as before (username or username@cas_domainname). * Fetch the (full) name from CAS attributes if provided If the CAS response by omniauth provides a [:info][:name] field, prefer this over the uid, because we want the name to be a "Full Name", instead of just a "shortname"
167 lines
3.7 KiB
Ruby
167 lines
3.7 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe Users::OmniauthCallbacksController do
|
|
|
|
let(:auth) { {info: {email: 'eviltrout@made.up.email', name: 'Robin Ward', uid: 123456789}, "extra" => {"raw_info" => {} } } }
|
|
let(:cas_auth) { { 'uid' => 'casuser', extra: { user: 'casuser'} } }
|
|
|
|
shared_examples_for "an authenticaton provider" do |provider|
|
|
context "when #{provider} logins are disabled" do
|
|
before do
|
|
SiteSetting.stubs("enable_#{provider}_logins?").returns(false)
|
|
end
|
|
|
|
it "fails" do
|
|
get :complete, provider: provider
|
|
response.should_not be_success
|
|
end
|
|
|
|
end
|
|
|
|
context "when #{provider} logins are enabled" do
|
|
before do
|
|
SiteSetting.stubs("enable_#{provider}_logins?").returns(true)
|
|
end
|
|
|
|
it "succeeds" do
|
|
get :complete, provider: provider
|
|
response.should be_success
|
|
end
|
|
|
|
context "and 'invite only' site setting is enabled" do
|
|
before do
|
|
SiteSetting.stubs(:invite_only?).returns(true)
|
|
end
|
|
|
|
it "informs the user they are awaiting approval" do
|
|
xhr :get, :complete, provider: provider, format: :json
|
|
|
|
expect(
|
|
JSON.parse(response.body)['awaiting_approval']
|
|
).to be_true
|
|
end
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
describe 'invalid provider' do
|
|
|
|
it "fails" do
|
|
request.env["omniauth.auth"] = auth
|
|
get :complete, provider: 'hackprovider'
|
|
response.should_not be_success
|
|
end
|
|
|
|
end
|
|
|
|
describe 'twitter' do
|
|
|
|
before do
|
|
request.env["omniauth.auth"] = auth
|
|
end
|
|
|
|
it_behaves_like "an authenticaton provider", 'twitter'
|
|
|
|
end
|
|
|
|
describe 'facebook' do
|
|
|
|
before do
|
|
request.env["omniauth.auth"] = auth
|
|
end
|
|
|
|
it_behaves_like "an authenticaton provider", 'facebook'
|
|
|
|
end
|
|
|
|
describe 'cas' do
|
|
|
|
before do
|
|
request.env["omniauth.auth"] = cas_auth
|
|
end
|
|
|
|
it_behaves_like "an authenticaton provider", 'cas'
|
|
|
|
describe "extracted user data" do
|
|
before do
|
|
SiteSetting.stubs(:enable_cas_logins?).returns(true)
|
|
end
|
|
|
|
subject {
|
|
xhr :get, :complete, provider: 'cas', format: :json
|
|
OpenStruct.new(JSON.parse(response.body))
|
|
}
|
|
|
|
context "when no user infos are returned by cas" do
|
|
its(:username) { should eq 'casuser' }
|
|
its(:name) { should eq 'casuser' }
|
|
its(:email) { should eq 'casuser' } # No cas_domainname configured!
|
|
|
|
context "when cas_domainname is configured" do
|
|
before do
|
|
SiteSetting.stubs(:cas_domainname).returns("example.com")
|
|
end
|
|
|
|
its(:email) { should eq 'casuser@example.com' }
|
|
end
|
|
end
|
|
|
|
context "when user infos are returned by cas" do
|
|
before do
|
|
request.env["omniauth.auth"] = cas_auth.merge({
|
|
info: {
|
|
name: 'Proper Name',
|
|
email: 'public@example.com'
|
|
}
|
|
})
|
|
end
|
|
|
|
its(:username) { should eq 'casuser' }
|
|
its(:name) { should eq 'Proper Name' }
|
|
its(:email) { should eq 'public@example.com' }
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
describe 'open id handler' do
|
|
|
|
before do
|
|
request.env["omniauth.auth"] = { info: {email: 'eviltrout@made.up.email'}, extra: {identity_url: 'http://eviltrout.com'}}
|
|
end
|
|
|
|
describe "google" do
|
|
it_behaves_like "an authenticaton provider", 'google'
|
|
end
|
|
|
|
describe "yahoo" do
|
|
it_behaves_like "an authenticaton provider", 'yahoo'
|
|
end
|
|
|
|
end
|
|
|
|
describe 'github' do
|
|
|
|
before do
|
|
request.env["omniauth.auth"] = auth
|
|
end
|
|
|
|
it_behaves_like "an authenticaton provider", 'github'
|
|
|
|
end
|
|
|
|
describe 'persona' do
|
|
|
|
before do
|
|
request.env["omniauth.auth"] = auth
|
|
end
|
|
|
|
it_behaves_like "an authenticaton provider", 'persona'
|
|
|
|
end
|
|
|
|
end
|