mirror of
https://github.com/codeninjasllc/discourse.git
synced 2024-11-23 23:58:31 -05:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
37 lines
1 KiB
Ruby
37 lines
1 KiB
Ruby
require 'rails_helper'
|
|
require_dependency 'version'
|
|
|
|
describe Admin::VersionsController do
|
|
|
|
before do
|
|
Jobs::VersionCheck.any_instance.stubs(:execute).returns(true)
|
|
DiscourseUpdates.stubs(:updated_at).returns(2.hours.ago)
|
|
DiscourseUpdates.stubs(:latest_version).returns('1.2.33')
|
|
DiscourseUpdates.stubs(:critical_updates_available?).returns(false)
|
|
end
|
|
|
|
it "is a subclass of AdminController" do
|
|
expect(Admin::VersionsController < Admin::AdminController).to eq(true)
|
|
end
|
|
|
|
context 'while logged in as an admin' do
|
|
before do
|
|
@user = log_in(:admin)
|
|
end
|
|
|
|
describe 'show' do
|
|
subject { xhr :get, :show }
|
|
it { is_expected.to be_success }
|
|
|
|
it 'should return the currently available version' do
|
|
json = JSON.parse(subject.body)
|
|
expect(json['latest_version']).to eq('1.2.33')
|
|
end
|
|
|
|
it "should return the installed version" do
|
|
json = JSON.parse(subject.body)
|
|
expect(json['installed_version']).to eq(Discourse::VERSION::STRING)
|
|
end
|
|
end
|
|
end
|
|
end
|