mirror of
https://github.com/codeninjasllc/discourse.git
synced 2024-11-23 23:58:31 -05:00
0d01c33482
All models are now using ActiveModel::ForbiddenAttributesProtection, which shifts the responsibility for parameter whitelisting for mass-assignments from the model to the controller. attr_accessible has been disabled and removed as this functionality replaces that. The require_parameters method in the ApplicationController has been removed in favor of strong_parameters' #require method. It is important to note that there is still some refactoring required to get all parameters to pass through #require and #permit so that we can guarantee that parameter values are scalar. Currently strong_parameters, in most cases, is only being utilized to require parameters and to whitelist the few places that do mass-assignments.
64 lines
2.2 KiB
Ruby
64 lines
2.2 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe ClicksController do
|
|
|
|
context 'create' do
|
|
|
|
context 'missing params' do
|
|
it 'raises an error without the url param' do
|
|
lambda { xhr :get, :track, post_id: 123 }.should raise_error(ActionController::ParameterMissing)
|
|
end
|
|
|
|
it "redirects to the url even without the topic_id or post_id params" do
|
|
xhr :get, :track, url: 'http://google.com'
|
|
response.should redirect_to("http://google.com")
|
|
end
|
|
|
|
end
|
|
|
|
context 'correct params' do
|
|
|
|
before do
|
|
request.stubs(:remote_ip).returns('192.168.0.1')
|
|
end
|
|
|
|
context 'with a post_id' do
|
|
it 'calls create_from' do
|
|
TopicLinkClick.expects(:create_from).with('url' => 'http://discourse.org', 'post_id' => '123', 'ip' => '192.168.0.1')
|
|
xhr :get, :track, url: 'http://discourse.org', post_id: 123
|
|
response.should redirect_to("http://discourse.org")
|
|
end
|
|
|
|
it 'redirects to the url' do
|
|
TopicLinkClick.stubs(:create_from)
|
|
xhr :get, :track, url: 'http://discourse.org', post_id: 123
|
|
response.should redirect_to("http://discourse.org")
|
|
end
|
|
|
|
it 'will pass the user_id to create_from' do
|
|
TopicLinkClick.expects(:create_from).with('url' => 'http://discourse.org', 'post_id' => '123', 'ip' => '192.168.0.1')
|
|
xhr :get, :track, url: 'http://discourse.org', post_id: 123
|
|
response.should redirect_to("http://discourse.org")
|
|
end
|
|
|
|
it "doesn't redirect with the redirect=false param" do
|
|
TopicLinkClick.expects(:create_from).with('url' => 'http://discourse.org', 'post_id' => '123', 'ip' => '192.168.0.1', 'redirect' => 'false')
|
|
xhr :get, :track, url: 'http://discourse.org', post_id: 123, redirect: 'false'
|
|
response.should_not be_redirect
|
|
end
|
|
|
|
end
|
|
|
|
context 'with a topic_id' do
|
|
it 'calls create_from' do
|
|
TopicLinkClick.expects(:create_from).with('url' => 'http://discourse.org', 'topic_id' => '789', 'ip' => '192.168.0.1')
|
|
xhr :get, :track, url: 'http://discourse.org', topic_id: 789
|
|
response.should redirect_to("http://discourse.org")
|
|
end
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|