mirror of
https://github.com/codeninjasllc/discourse.git
synced 2024-11-23 15:48:43 -05:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
46 lines
1.5 KiB
Ruby
46 lines
1.5 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe PermalinksController do
|
|
describe 'show' do
|
|
it "should redirect to a permalink's target_url with status 301" do
|
|
permalink = Fabricate(:permalink)
|
|
Permalink.any_instance.stubs(:target_url).returns('/t/the-topic-slug/42')
|
|
get :show, url: permalink.url
|
|
expect(response).to redirect_to('/t/the-topic-slug/42')
|
|
expect(response.status).to eq(301)
|
|
end
|
|
|
|
it "should work for subfolder installs too" do
|
|
GlobalSetting.stubs(:relative_url_root).returns('/forum')
|
|
Discourse.stubs(:base_uri).returns("/forum")
|
|
permalink = Fabricate(:permalink)
|
|
Permalink.any_instance.stubs(:target_url).returns('/forum/t/the-topic-slug/42')
|
|
get :show, url: permalink.url
|
|
expect(response).to redirect_to('/forum/t/the-topic-slug/42')
|
|
expect(response.status).to eq(301)
|
|
end
|
|
|
|
it "should apply normalizations" do
|
|
SiteSetting.permalink_normalizations = "/(.*)\\?.*/\\1"
|
|
|
|
permalink = Fabricate(:permalink, url: '/topic/bla', external_url: '/topic/100')
|
|
|
|
get :show, url: permalink.url, test: "hello"
|
|
|
|
expect(response).to redirect_to('/topic/100')
|
|
expect(response.status).to eq(301)
|
|
|
|
SiteSetting.permalink_normalizations = "/(.*)\\?.*/\\1X"
|
|
|
|
get :show, url: permalink.url, test: "hello"
|
|
|
|
expect(response.status).to eq(404)
|
|
end
|
|
|
|
it 'return 404 if permalink record does not exist' do
|
|
get :show, url: '/not/a/valid/url'
|
|
expect(response.status).to eq(404)
|
|
end
|
|
end
|
|
|
|
end
|