mirror of
https://github.com/codeninjasllc/discourse.git
synced 2024-11-24 08:09:13 -05:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
88 lines
2.3 KiB
Ruby
88 lines
2.3 KiB
Ruby
require "rails_helper"
|
|
|
|
describe Admin::EmojisController do
|
|
|
|
let(:custom_emoji) do
|
|
Emoji.new("/path/to/hello").tap do |e|
|
|
e.name = "hello"
|
|
e.url = "/url/to/hello.png"
|
|
end
|
|
end
|
|
|
|
let(:custom_emoji2) do
|
|
Emoji.new("/path/to/hello2").tap do |e|
|
|
e.name = "hello2"
|
|
e.url = "/url/to/hello2.png"
|
|
end
|
|
end
|
|
|
|
it "is a subclass of AdminController" do
|
|
expect(Admin::EmojisController < Admin::AdminController).to eq(true)
|
|
end
|
|
|
|
context "when logged in" do
|
|
let!(:user) { log_in(:admin) }
|
|
|
|
context ".index" do
|
|
it "returns a list of custom emojis" do
|
|
Emoji.expects(:custom).returns([custom_emoji])
|
|
xhr :get, :index
|
|
expect(response).to be_success
|
|
json = ::JSON.parse(response.body)
|
|
expect(json[0]["name"]).to eq(custom_emoji.name)
|
|
expect(json[0]["url"]).to eq(custom_emoji.url)
|
|
end
|
|
end
|
|
|
|
context ".create" do
|
|
|
|
before { Emoji.expects(:custom).returns([custom_emoji]) }
|
|
|
|
context "name already exist" do
|
|
it "throws an error" do
|
|
message = MessageBus.track_publish do
|
|
xhr :post, :create, { name: "hello", file: "" }
|
|
end.first
|
|
|
|
expect(response).to be_success
|
|
expect(message.data["errors"]).to be
|
|
end
|
|
end
|
|
|
|
context "error while saving emoji" do
|
|
it "throws an error" do
|
|
Emoji.expects(:create_for).returns(nil)
|
|
message = MessageBus.track_publish do
|
|
xhr :post, :create, { name: "garbage", file: "" }
|
|
end.first
|
|
|
|
expect(response).to be_success
|
|
expect(message.data["errors"]).to be
|
|
end
|
|
end
|
|
|
|
it "works" do
|
|
Emoji.expects(:create_for).returns(custom_emoji2)
|
|
|
|
message = MessageBus.track_publish do
|
|
xhr :post, :create, { name: "hello2", file: ""}
|
|
end.first
|
|
|
|
expect(response).to be_success
|
|
|
|
expect(message.data["name"]).to eq(custom_emoji2.name)
|
|
expect(message.data["url"]).to eq(custom_emoji2.url)
|
|
end
|
|
end
|
|
|
|
context ".destroy" do
|
|
it "deletes the custom emoji" do
|
|
custom_emoji.expects(:remove)
|
|
Emoji.expects(:custom).returns([custom_emoji])
|
|
xhr :delete, :destroy, id: "hello"
|
|
expect(response).to be_success
|
|
end
|
|
end
|
|
end
|
|
|
|
end
|