mirror of
https://github.com/codeninjasllc/discourse.git
synced 2024-11-24 08:09:13 -05:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
141 lines
4.8 KiB
Ruby
141 lines
4.8 KiB
Ruby
require 'rails_helper'
|
|
require_dependency 'queued_post'
|
|
|
|
describe QueuedPost do
|
|
|
|
context "creating a post" do
|
|
let(:topic) { Fabricate(:topic) }
|
|
let(:user) { Fabricate(:user) }
|
|
let(:admin) { Fabricate(:admin) }
|
|
let(:qp) { Fabricate(:queued_post, topic: topic, user: user) }
|
|
|
|
it "returns the appropriate options for posting" do
|
|
create_options = qp.create_options
|
|
|
|
expect(create_options[:topic_id]).to eq(topic.id)
|
|
expect(create_options[:raw]).to eq('This post should be queued up')
|
|
expect(create_options[:reply_to_post_number]).to eq(1)
|
|
expect(create_options[:via_email]).to eq(true)
|
|
expect(create_options[:raw_email]).to eq('store_me')
|
|
expect(create_options[:auto_track]).to eq(true)
|
|
expect(create_options[:custom_fields]).to eq('hello' => 'world')
|
|
expect(create_options[:cooking_options]).to eq(cat: 'hat')
|
|
expect(create_options[:cook_method]).to eq(Post.cook_methods[:raw_html])
|
|
expect(create_options[:not_create_option]).to eq(nil)
|
|
expect(create_options[:image_sizes]).to eq("http://foo.bar/image.png" => {"width" => 0, "height" => 222})
|
|
end
|
|
|
|
it "follows the correct workflow for approval" do
|
|
qp.create_pending_action
|
|
post = qp.approve!(admin)
|
|
|
|
# Creates the post with the attributes
|
|
expect(post).to be_present
|
|
expect(post).to be_valid
|
|
expect(post.topic).to eq(topic)
|
|
expect(post.custom_fields['hello']).to eq('world')
|
|
|
|
# Updates the QP record
|
|
expect(qp.approved_by).to eq(admin)
|
|
expect(qp.state).to eq(QueuedPost.states[:approved])
|
|
expect(qp.approved_at).to be_present
|
|
|
|
# It removes the pending action
|
|
expect(UserAction.where(queued_post_id: qp.id).count).to eq(0)
|
|
|
|
# We can't approve twice
|
|
expect(-> { qp.approve!(admin) }).to raise_error(QueuedPost::InvalidStateTransition)
|
|
end
|
|
|
|
it "skips validations" do
|
|
qp.post_options[:title] = 'too short'
|
|
post = qp.approve!(admin)
|
|
expect(post).to be_present
|
|
end
|
|
|
|
it "follows the correct workflow for rejection" do
|
|
qp.create_pending_action
|
|
qp.reject!(admin)
|
|
|
|
# Updates the QP record
|
|
expect(qp.rejected_by).to eq(admin)
|
|
expect(qp.state).to eq(QueuedPost.states[:rejected])
|
|
expect(qp.rejected_at).to be_present
|
|
|
|
# It removes the pending action
|
|
expect(UserAction.where(queued_post_id: qp.id).count).to eq(0)
|
|
|
|
# We can't reject twice
|
|
expect(-> { qp.reject!(admin) }).to raise_error(QueuedPost::InvalidStateTransition)
|
|
end
|
|
end
|
|
|
|
context "creating a topic" do
|
|
let(:user) { Fabricate(:user) }
|
|
let(:admin) { Fabricate(:admin) }
|
|
|
|
context "with a valid topic" do
|
|
let!(:category) { Fabricate(:category) }
|
|
let(:qp) { QueuedPost.create(queue: 'eviltrout',
|
|
state: QueuedPost.states[:new],
|
|
user_id: user.id,
|
|
raw: 'This post should be queued up',
|
|
post_options: {
|
|
title: 'This is the topic title to queue up',
|
|
archetype: 'regular',
|
|
category: category.id,
|
|
meta_data: {evil: 'trout'}
|
|
}) }
|
|
|
|
|
|
it "returns the appropriate options for creating a topic" do
|
|
create_options = qp.create_options
|
|
|
|
expect(create_options[:category]).to eq(category.id)
|
|
expect(create_options[:archetype]).to eq('regular')
|
|
expect(create_options[:meta_data]).to eq('evil' => 'trout')
|
|
end
|
|
|
|
it "creates the post and topic" do
|
|
topic_count, post_count = Topic.count, Post.count
|
|
post = qp.approve!(admin)
|
|
|
|
expect(Topic.count).to eq(topic_count + 1)
|
|
expect(Post.count).to eq(post_count + 1)
|
|
|
|
expect(post).to be_present
|
|
expect(post).to be_valid
|
|
|
|
topic = post.topic
|
|
expect(topic).to be_present
|
|
expect(topic.category).to eq(category)
|
|
end
|
|
|
|
it "rejecting doesn't create the post and topic" do
|
|
topic_count, post_count = Topic.count, Post.count
|
|
|
|
qp.reject!(admin)
|
|
|
|
expect(Topic.count).to eq(topic_count)
|
|
expect(Post.count).to eq(post_count)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "visibility" do
|
|
it "works as expected in the invisible queue" do
|
|
qp = Fabricate(:queued_post, queue: 'invisible')
|
|
expect(qp).to_not be_visible
|
|
expect(QueuedPost.visible).to_not include(qp)
|
|
expect(QueuedPost.new_count).to eq(0)
|
|
end
|
|
|
|
it "works as expected in the visible queue" do
|
|
qp = Fabricate(:queued_post, queue: 'default')
|
|
expect(qp).to be_visible
|
|
expect(QueuedPost.visible).to include(qp)
|
|
expect(QueuedPost.new_count).to eq(1)
|
|
end
|
|
end
|
|
|
|
end
|