mirror of
https://github.com/codeninjasllc/discourse.git
synced 2024-12-12 08:41:23 -05:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
62 lines
1.7 KiB
Ruby
62 lines
1.7 KiB
Ruby
require 'rails_helper'
|
|
require_dependency 'topic_retriever'
|
|
|
|
describe TopicRetriever do
|
|
|
|
let(:embed_url) { "http://eviltrout.com/2013/02/10/why-discourse-uses-emberjs.html" }
|
|
let(:author_username) { "eviltrout" }
|
|
let(:topic_retriever) { TopicRetriever.new(embed_url, author_username: author_username) }
|
|
|
|
describe "#retrieve" do
|
|
context "when host is invalid" do
|
|
before do
|
|
topic_retriever.stubs(:invalid_host?).returns(true)
|
|
end
|
|
|
|
it "does not perform_retrieve" do
|
|
topic_retriever.expects(:perform_retrieve).never
|
|
topic_retriever.retrieve
|
|
end
|
|
end
|
|
|
|
context "when topics have been retrieived recently" do
|
|
before do
|
|
topic_retriever.stubs(:retrieved_recently?).returns(true)
|
|
end
|
|
|
|
it "does not perform_retrieve" do
|
|
topic_retriever.expects(:perform_retrieve).never
|
|
topic_retriever.retrieve
|
|
end
|
|
end
|
|
|
|
context "when host is not invalid" do
|
|
before do
|
|
topic_retriever.stubs(:invalid_host?).returns(false)
|
|
end
|
|
|
|
context "when topics have been retrieived recently" do
|
|
before do
|
|
topic_retriever.stubs(:retrieved_recently?).returns(true)
|
|
end
|
|
|
|
it "does not perform_retrieve" do
|
|
topic_retriever.expects(:perform_retrieve).never
|
|
topic_retriever.retrieve
|
|
end
|
|
end
|
|
|
|
context "when topics have not been retrieived recently" do
|
|
before do
|
|
topic_retriever.stubs(:retrieved_recently?).returns(false)
|
|
end
|
|
|
|
it "does perform_retrieve" do
|
|
topic_retriever.expects(:perform_retrieve).once
|
|
topic_retriever.retrieve
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
end
|