mirror of
https://github.com/codeninjasllc/discourse.git
synced 2024-12-20 12:32:39 -05:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
146 lines
4.5 KiB
Ruby
146 lines
4.5 KiB
Ruby
# encoding: utf-8
|
|
|
|
require 'rails_helper'
|
|
require 'slug'
|
|
|
|
describe Slug do
|
|
|
|
describe '#for' do
|
|
context 'ascii generator' do
|
|
before { SiteSetting.slug_generation_method = 'ascii' }
|
|
|
|
it 'generates the slug' do
|
|
expect(Slug.for("hello world")).to eq('hello-world')
|
|
end
|
|
|
|
it 'generates default slug when nothing' do
|
|
expect(Slug.for('')).to eq('topic')
|
|
end
|
|
|
|
it "doesn't generate slugs that are just numbers" do
|
|
expect(Slug.for('123')).to eq('topic')
|
|
end
|
|
end
|
|
|
|
context 'encoded generator' do
|
|
before { SiteSetting.slug_generation_method = 'encoded' }
|
|
after { SiteSetting.slug_generation_method = 'ascii' }
|
|
|
|
it 'generates the slug' do
|
|
expect(Slug.for("熱帶風暴畫眉")).to eq('熱帶風暴畫眉')
|
|
end
|
|
|
|
it 'generates default slug when nothing' do
|
|
expect(Slug.for('')).to eq('topic')
|
|
end
|
|
|
|
it "doesn't generate slugs that are just numbers" do
|
|
expect(Slug.for('123')).to eq('topic')
|
|
end
|
|
end
|
|
|
|
context 'none generator' do
|
|
before { SiteSetting.slug_generation_method = 'none' }
|
|
after { SiteSetting.slug_generation_method = 'ascii' }
|
|
|
|
it 'generates the slug' do
|
|
expect(Slug.for("hello world", 'category')).to eq('category')
|
|
expect(Slug.for("hello world")).to eq('topic')
|
|
expect(Slug.for('')).to eq('topic')
|
|
expect(Slug.for('123')).to eq('topic')
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#ascii_generator' do
|
|
before { SiteSetting.slug_generation_method = 'ascii' }
|
|
|
|
it 'replaces spaces with hyphens' do
|
|
expect(Slug.ascii_generator("hello world")).to eq('hello-world')
|
|
end
|
|
|
|
it 'changes accented characters' do
|
|
expect(Slug.ascii_generator('àllo')).to eq('allo')
|
|
end
|
|
|
|
it 'replaces symbols' do
|
|
expect(Slug.ascii_generator('evil#trout')).to eq('evil-trout')
|
|
end
|
|
|
|
it 'handles a.b.c properly' do
|
|
expect(Slug.ascii_generator("a.b.c")).to eq("a-b-c")
|
|
end
|
|
|
|
it 'handles double dots right' do
|
|
expect(Slug.ascii_generator("a....b.....c")).to eq("a-b-c")
|
|
end
|
|
|
|
it 'strips trailing punctuation' do
|
|
expect(Slug.ascii_generator("hello...")).to eq("hello")
|
|
end
|
|
|
|
it 'strips leading punctuation' do
|
|
expect(Slug.ascii_generator("...hello")).to eq("hello")
|
|
end
|
|
|
|
it 'handles our initial transliteration' do
|
|
from = "àáäâčďèéëěêìíïîľĺňòóöôŕřšťůùúüûýžñç"
|
|
to = "aaaacdeeeeeiiiillnoooorrstuuuuuyznc"
|
|
expect(Slug.ascii_generator(from)).to eq(to)
|
|
end
|
|
|
|
it 'replaces underscores' do
|
|
expect(Slug.ascii_generator("o_o_o")).to eq("o-o-o")
|
|
end
|
|
|
|
it "doesn't keep single quotes within word" do
|
|
expect(Slug.ascii_generator("Jeff hate's this")).to eq("jeff-hates-this")
|
|
end
|
|
|
|
it 'generates null when nothing' do
|
|
expect(Slug.ascii_generator('')).to eq('')
|
|
end
|
|
|
|
it "keeps number unchanged" do
|
|
expect(Slug.ascii_generator('123')).to eq('123')
|
|
end
|
|
end
|
|
|
|
describe '#encoded_generator' do
|
|
before { SiteSetting.slug_generation_method = 'encoded' }
|
|
after { SiteSetting.slug_generation_method = 'ascii' }
|
|
|
|
it 'generates precentage encoded string' do
|
|
expect(Slug.encoded_generator("Jeff hate's !~-_|,=#this")).to eq("Jeff-hates-this")
|
|
expect(Slug.encoded_generator("뉴스피드")).to eq("뉴스피드")
|
|
expect(Slug.encoded_generator("آموزش اضافه کردن لینک اختیاری به هدر")).to eq("آموزش-اضافه-کردن-لینک-اختیاری-به-هدر")
|
|
expect(Slug.encoded_generator("熱帶風暴畫眉")).to eq("熱帶風暴畫眉")
|
|
end
|
|
|
|
it 'reject RFC 3986 reserved character and blank' do
|
|
expect(Slug.encoded_generator(":/?#[]@!$ &'()*+,;=% -_`~.")).to eq("")
|
|
expect(Slug.encoded_generator(" - English and Chinese title with special characters / 中文标题 !@:?\\:'`#^& $%&*()` -- ")).to eq("English-and-Chinese-title-with-special-characters-中文标题")
|
|
end
|
|
|
|
it 'generates null when nothing' do
|
|
expect(Slug.encoded_generator('')).to eq('')
|
|
end
|
|
|
|
it "keeps number unchanged" do
|
|
expect(Slug.encoded_generator('123')).to eq('123')
|
|
end
|
|
end
|
|
|
|
describe '#none_generator' do
|
|
before { SiteSetting.slug_generation_method = 'none' }
|
|
after { SiteSetting.slug_generation_method = 'ascii' }
|
|
|
|
it 'generates nothing' do
|
|
expect(Slug.none_generator("Jeff hate's this")).to eq('')
|
|
expect(Slug.none_generator(nil)).to eq('')
|
|
expect(Slug.none_generator('')).to eq('')
|
|
expect(Slug.none_generator('31')).to eq('')
|
|
end
|
|
end
|
|
end
|
|
|