mirror of
https://github.com/codeninjasllc/discourse.git
synced 2024-11-30 02:56:26 -05:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
142 lines
4.6 KiB
Ruby
142 lines
4.6 KiB
Ruby
require 'rails_helper'
|
|
require 'digest/sha1'
|
|
|
|
describe Upload do
|
|
|
|
let(:upload) { build(:upload) }
|
|
let(:thumbnail) { build(:optimized_image, upload: upload) }
|
|
|
|
let(:user_id) { 1 }
|
|
let(:url) { "http://domain.com" }
|
|
|
|
let(:image_filename) { "logo.png" }
|
|
let(:image) { file_from_fixtures(image_filename) }
|
|
let(:image_filesize) { File.size(image) }
|
|
let(:image_sha1) { Digest::SHA1.file(image).hexdigest }
|
|
|
|
let(:image_svg_filename) { "image.svg" }
|
|
let(:image_svg) { file_from_fixtures(image_svg_filename) }
|
|
let(:image_svg_filesize) { File.size(image_svg) }
|
|
|
|
let(:attachment_path) { __FILE__ }
|
|
let(:attachment) { File.new(attachment_path) }
|
|
let(:attachment_filename) { File.basename(attachment_path) }
|
|
let(:attachment_filesize) { File.size(attachment_path) }
|
|
|
|
context ".create_thumbnail!" do
|
|
|
|
it "does not create a thumbnail when disabled" do
|
|
SiteSetting.stubs(:create_thumbnails?).returns(false)
|
|
OptimizedImage.expects(:create_for).never
|
|
upload.create_thumbnail!(100, 100)
|
|
end
|
|
|
|
it "creates a thumbnail" do
|
|
upload = Fabricate(:upload)
|
|
thumbnail = Fabricate(:optimized_image, upload: upload)
|
|
SiteSetting.expects(:create_thumbnails?).returns(true)
|
|
OptimizedImage.expects(:create_for).returns(thumbnail)
|
|
upload.create_thumbnail!(100, 100)
|
|
upload.reload
|
|
expect(upload.optimized_images.count).to eq(1)
|
|
end
|
|
|
|
end
|
|
|
|
context "#create_for" do
|
|
|
|
before do
|
|
Upload.stubs(:fix_image_orientation)
|
|
ImageOptim.any_instance.stubs(:optimize_image!)
|
|
end
|
|
|
|
it "does not create another upload if it already exists" do
|
|
Upload.expects(:find_by).with(sha1: image_sha1).returns(upload)
|
|
Upload.expects(:save).never
|
|
expect(Upload.create_for(user_id, image, image_filename, image_filesize)).to eq(upload)
|
|
end
|
|
|
|
it "fix image orientation" do
|
|
Upload.expects(:fix_image_orientation).with(image.path)
|
|
Upload.create_for(user_id, image, image_filename, image_filesize)
|
|
end
|
|
|
|
it "computes width & height for images" do
|
|
FastImage.any_instance.expects(:size).returns([100, 200])
|
|
ImageSizer.expects(:resize)
|
|
image.expects(:rewind).twice
|
|
Upload.create_for(user_id, image, image_filename, image_filesize)
|
|
end
|
|
|
|
it "does not compute width & height for non-image" do
|
|
FastImage.any_instance.expects(:size).never
|
|
upload = Upload.create_for(user_id, attachment, attachment_filename, attachment_filesize)
|
|
expect(upload.errors.size).to be > 0
|
|
end
|
|
|
|
it "generates an error when the image is too large" do
|
|
SiteSetting.stubs(:max_image_size_kb).returns(1)
|
|
upload = Upload.create_for(user_id, image, image_filename, image_filesize)
|
|
expect(upload.errors.size).to be > 0
|
|
end
|
|
|
|
it "generates an error when the attachment is too large" do
|
|
SiteSetting.stubs(:max_attachment_size_kb).returns(1)
|
|
upload = Upload.create_for(user_id, attachment, attachment_filename, attachment_filesize)
|
|
expect(upload.errors.size).to be > 0
|
|
end
|
|
|
|
it "saves proper information" do
|
|
store = {}
|
|
Discourse.expects(:store).returns(store)
|
|
store.expects(:store_upload).returns(url)
|
|
|
|
upload = Upload.create_for(user_id, image, image_filename, image_filesize)
|
|
|
|
expect(upload.user_id).to eq(user_id)
|
|
expect(upload.original_filename).to eq(image_filename)
|
|
expect(upload.filesize).to eq(image_filesize)
|
|
expect(upload.width).to eq(244)
|
|
expect(upload.height).to eq(66)
|
|
expect(upload.url).to eq(url)
|
|
end
|
|
|
|
context "when svg is authorized" do
|
|
|
|
before { SiteSetting.stubs(:authorized_extensions).returns("svg") }
|
|
|
|
it "consider SVG as an image" do
|
|
store = {}
|
|
Discourse.expects(:store).returns(store)
|
|
store.expects(:store_upload).returns(url)
|
|
|
|
upload = Upload.create_for(user_id, image_svg, image_svg_filename, image_svg_filesize)
|
|
|
|
expect(upload.user_id).to eq(user_id)
|
|
expect(upload.original_filename).to eq(image_svg_filename)
|
|
expect(upload.filesize).to eq(image_svg_filesize)
|
|
expect(upload.width).to eq(100)
|
|
expect(upload.height).to eq(50)
|
|
expect(upload.url).to eq(url)
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
context ".get_from_url" do
|
|
|
|
it "works when the file has been uploaded" do
|
|
Upload.expects(:find_by).returns(nil).once
|
|
Upload.get_from_url("/uploads/default/1/10387531.jpg")
|
|
end
|
|
|
|
it "works when using a cdn" do
|
|
Rails.configuration.action_controller.stubs(:asset_host).returns("http://my.cdn.com")
|
|
Upload.expects(:find_by).with(url: "/uploads/default/1/02395732905.jpg").returns(nil).once
|
|
Upload.get_from_url("http://my.cdn.com/uploads/default/1/02395732905.jpg")
|
|
end
|
|
|
|
end
|
|
|
|
end
|