mirror of
https://github.com/codeninjasllc/discourse.git
synced 2024-11-23 23:58:31 -05:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
21 lines
664 B
Ruby
21 lines
664 B
Ruby
require 'rails_helper'
|
|
|
|
describe S3RegionSiteSetting do
|
|
|
|
describe 'valid_value?' do
|
|
it 'returns true for a valid S3 region' do
|
|
expect(S3RegionSiteSetting.valid_value?('us-west-1')).to eq(true)
|
|
end
|
|
|
|
it 'returns false for an invalid S3 region' do
|
|
expect(S3RegionSiteSetting.valid_value?('the-moon')).to eq(false)
|
|
end
|
|
end
|
|
|
|
describe 'values' do
|
|
it 'returns all the S3 regions' do
|
|
expect(S3RegionSiteSetting.values.map {|x| x[:value]}.sort).to eq(['us-east-1', 'us-west-1', 'us-west-2', 'us-gov-west-1', 'eu-west-1', 'eu-central-1', 'ap-southeast-1', 'ap-southeast-2', 'ap-northeast-1', 'sa-east-1'].sort)
|
|
end
|
|
end
|
|
|
|
end
|