mirror of
https://github.com/codeninjasllc/discourse.git
synced 2024-11-23 15:48:43 -05:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
106 lines
2.9 KiB
Ruby
106 lines
2.9 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe UserBlocker do
|
|
|
|
before do
|
|
SystemMessage.stubs(:create)
|
|
end
|
|
|
|
describe 'block' do
|
|
let(:user) { stub_everything(save: true) }
|
|
let(:blocker) { UserBlocker.new(user) }
|
|
subject(:block_user) { blocker.block }
|
|
|
|
it 'blocks the user' do
|
|
u = Fabricate(:user)
|
|
expect { UserBlocker.block(u) }.to change { u.reload.blocked? }
|
|
end
|
|
|
|
it 'hides posts' do
|
|
blocker.expects(:hide_posts)
|
|
block_user
|
|
end
|
|
|
|
context 'given a staff user argument' do
|
|
it 'sends the correct message to the blocked user' do
|
|
SystemMessage.unstub(:create)
|
|
SystemMessage.expects(:create).with(user, :blocked_by_staff).returns(true)
|
|
UserBlocker.block(user, Fabricate.build(:admin))
|
|
end
|
|
|
|
# TODO: it 'logs the action'
|
|
end
|
|
|
|
context 'not given a staff user argument' do
|
|
it 'sends a default message to the user' do
|
|
SystemMessage.unstub(:create)
|
|
SystemMessage.expects(:create).with(user, :blocked_by_staff).returns(true)
|
|
UserBlocker.block(user, Fabricate.build(:admin))
|
|
end
|
|
end
|
|
|
|
context 'given a message option' do
|
|
it 'sends that message to the user' do
|
|
SystemMessage.unstub(:create)
|
|
SystemMessage.expects(:create).with(user, :the_custom_message).returns(true)
|
|
UserBlocker.block(user, Fabricate.build(:admin), {message: :the_custom_message})
|
|
end
|
|
end
|
|
|
|
it "doesn't send a pm if save fails" do
|
|
user.stubs(:save).returns(false)
|
|
SystemMessage.unstub(:create)
|
|
SystemMessage.expects(:create).never
|
|
block_user
|
|
end
|
|
|
|
it "doesn't send a pm if the user is already blocked" do
|
|
user.stubs(:blocked?).returns(true)
|
|
SystemMessage.unstub(:create)
|
|
SystemMessage.expects(:create).never
|
|
expect(block_user).to eq(false)
|
|
end
|
|
end
|
|
|
|
describe 'unblock' do
|
|
let(:user) { stub_everything(save: true) }
|
|
subject(:unblock_user) { UserBlocker.unblock(user, Fabricate.build(:admin)) }
|
|
|
|
it 'unblocks the user' do
|
|
u = Fabricate(:user, blocked: true)
|
|
expect { UserBlocker.unblock(u) }.to change { u.reload.blocked? }
|
|
end
|
|
|
|
it 'sends a message to the user' do
|
|
SystemMessage.unstub(:create)
|
|
SystemMessage.expects(:create).with(user, :unblocked).returns(true)
|
|
unblock_user
|
|
end
|
|
|
|
it "doesn't send a pm if save fails" do
|
|
user.stubs(:save).returns(false)
|
|
SystemMessage.unstub(:create)
|
|
SystemMessage.expects(:create).never
|
|
unblock_user
|
|
end
|
|
|
|
# TODO: it 'logs the action'
|
|
end
|
|
|
|
describe 'hide_posts' do
|
|
let(:user) { Fabricate(:user) }
|
|
let!(:post) { Fabricate(:post, user: user) }
|
|
subject { UserBlocker.new(user) }
|
|
|
|
it "hides all the user's posts" do
|
|
subject.block
|
|
expect(post.reload).to be_hidden
|
|
end
|
|
|
|
it "hides the topic if the post was the first post" do
|
|
subject.block
|
|
expect(post.topic.reload).to_not be_visible
|
|
end
|
|
end
|
|
|
|
end
|