Commit graph

10916 commits

Author SHA1 Message Date
Régis Hanol
fd6dd88afb FIX: dual modal when deleting spammer in the flag modal 2014-08-29 13:05:51 +02:00
Régis Hanol
521cb6bd0d FIX: dual modal when selecting 'delete spammer' in flags section 2014-08-29 12:54:24 +02:00
Jeff Atwood
8bda8a2235 Revert "UX: stop displaying "user deleted, OK" dialog"
This reverts commit 36405287b4.
2014-08-29 03:49:00 -07:00
Jeff Atwood
36405287b4 UX: stop displaying "user deleted, OK" dialog 2014-08-29 03:34:23 -07:00
Jeff Atwood
dd972856d6 Update INSTALL-digital-ocean.md 2014-08-29 00:42:32 -07:00
Sam
163bbb1d3a comment out test till fixed 2014-08-29 17:27:28 +10:00
Sam
911b8647cf FIX: Revert permalink support until implemented correctly 2014-08-29 17:06:14 +10:00
Jeff Atwood
2c7d694c34 UX: extremely confusing copy on setting 2014-08-28 23:09:37 -07:00
Sam
4a3f24ea24 Merge pull request #2705 from riking/live-lightbox
Publish lightboxing on the message bus
2014-08-29 15:36:44 +10:00
riking
085b18577c Remove unnecessary user/topic load in PostCreator 2014-08-28 22:07:40 -07:00
riking
24ba7ccfbb FEATURE: Add a plugin callback when editing a post
FIX: Wrap PostRevisor database work in a transaction
2014-08-28 21:27:40 -07:00
riking
3396e6fea3 Centralize MessageBus post updates
After this change, only two files directly publish to MessageBus with a
topic interpolated in the channel: Post and TopicUser.
2014-08-28 20:40:36 -07:00
cpradio
723798cc30 Correct Perform Search Test 2014-08-28 23:32:56 -04:00
cpradio
185769c07b Correct Perform Search Test 2014-08-28 23:21:43 -04:00
riking
0a7a4eae99 Publish lightboxing on the message bus
With this change, images appear to lightbox instantly on my development
machine.
2014-08-28 20:16:33 -07:00
Sam
b7e8bcda07 FIX: strip leading/trailing spaces from developer emails 2014-08-29 12:21:33 +10:00
Sam
fe6e4d7da1 FIX: fails on initial migration if default_locale is nil 2014-08-29 12:01:28 +10:00
cpradio
0784c52a24 FIX: Remove up/down key bindings for search results
Up/down key bindings make it difficult to access Show More on search results.
https://meta.discourse.org/t/keyboard-users-cant-select-show-more-in-search-results/19394
2014-08-28 21:39:19 -04:00
Sam
c07d76677d Merge pull request #2701 from riking/email-pr-ssl
Rename POP3 settings, fix multisite SSL state leak
2014-08-29 10:02:05 +10:00
Sam
1bef22bbb9 Merge pull request #2703 from riking/email-pr-receiver
Heavy refactor for Email::Receiver
2014-08-29 09:59:59 +10:00
cpradio
3e7084743c FIX: Remove up/down key bindings for search results
Up/down key bindings make it difficult to access Show More on search results.
https://meta.discourse.org/t/keyboard-users-cant-select-show-more-in-search-results/19394
2014-08-28 19:58:07 -04:00
Sam
8ab9c57ca5 Merge pull request #2707 from eyalev/rtl-email
Enable RTL direction in emails.
2014-08-29 09:54:57 +10:00
Sam
5b696ca25a Merge pull request #2708 from Wilhansen/sso_override_avatar
Fix SSO avatar downloading issues.
2014-08-29 09:53:48 +10:00
Jeff Atwood
bfb9fc4e99 FEATURE: reduce user edit window from 1y to 6m 2014-08-28 15:47:38 -07:00
Robin Ward
85c6eb9b08 SECURITY: Only redirect to our host by path on the login action 2014-08-28 17:45:13 -04:00
riking
8ddd90daa4 Have parse_body() recover from ASCII-8BIT encoding
Added a test to make sure that the result can be passed into TextCleaner
(which expects UTF-8)
2014-08-28 14:38:19 -07:00
riking
1c9f6159cd Update the Receiver and PollMailbox specs for the changes
Tests are both added, moved, and deleted.

Add test for topic not being created

Move html_only.eml to parse_body testing section
2014-08-28 14:38:19 -07:00
riking
0a09593f3b FIX: Prefer HTML in incoming emails, heavily refactor email receiver
This commit heavily refactors Email::Receiver to both better handle
different emails and improve testability.

A primary focus of the refactor is reducing the usage of class
variables, in favor of actually passing parameters - making it possible
for multiple tests to use the same Receiver instance.

The EmailLog reported when a topic is created is reflected to put the
user's email in the to_address field, instead of the system address.

The discourse_email_parser function is renamed to
discourse_email_trimmer, and additional stopping conditions are added to
make up for EmailReplyParser's inability to deal with html at the start
of a line.

The force_encoding calls are refactored out to a 'fix_charset' method.

parse_body is renamed to select_body, and the scrub_html method is
dropped in favor of the new HtmlCleaner class.

A new parse_body method is added, which performs the job of the removed
lines of code in the 'process' method.

EmailUnparsableError is redefined again, to be encoding errors (when the
declared encoding is not what was delivered).
2014-08-28 14:36:10 -07:00
riking
cb55ef4702 Add Email::HtmlCleaner for email processing
This class is in charge of stripping out most of the crap from the HTML
portion of emails that email clients generate, so that it can be sanely
post-processed for signatures and quoting boundaries.
2014-08-28 14:36:10 -07:00
riking
0d0225133c FIX: Failed incoming emails could create empty topics
A failure condition is eliminated where a topic would be created, but post
creation would fail, leaving the forum with a topic without any posts.
By asking PostCreator to create the topic instead, inside of its
transaction, this failure condition is eliminated.

Additionally, attachments are restored to working status. Previously,
the attachment code would build up the post raw, but then drop it and
not do anything with the result (creating orphaned uploads). By actually
placing the raw value back in the options hash, it is included in the
created post.
2014-08-28 14:35:43 -07:00
Robin Ward
9e2c72e277 Allow restoring from backups in development mode even if the setting is
off.
2014-08-28 17:02:48 -04:00
Neil Lalonde
464a922910 FIX: permalinks table: increase limit of url column, make url index unique 2014-08-28 16:16:39 -04:00
cpradio
1acb2a13f1 Added a:first 2014-08-28 16:06:48 -04:00
cpradio
4fd73a2b2f Set focus on site-map and user menu
Set focus on first item in the site-map and user drop down for keyboard users, so they can quickly tab to the link/item of their choosing.
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
2014-08-28 16:04:54 -04:00
Neil Lalonde
14890a6002 FEATURE: add a way to map arbitrary urls to a topic, post, or category. Useful for sites that have migrated to Discourse and want to redirect from their old site to Discourse with 301 redirects. 2014-08-28 15:58:24 -04:00
Robin Ward
8a6c4234fc FIX: Re-enable searching for topic by id when using the split topic
interface.
2014-08-28 15:42:29 -04:00
Robin Ward
b5b13b8c5f Revert "Merge pull request #2713 from cpradio/master"
This reverts commit a9de189682, reversing
changes made to b7ab43e454.
2014-08-28 15:08:06 -04:00
Robin Ward
a9de189682 Merge pull request #2713 from cpradio/master
Set focus on first item in drop down (textbox, link, whatever it may be)
2014-08-28 14:47:38 -04:00
Robin Ward
b7ab43e454 Merge pull request #2714 from techAPJ/patch-3
Update onebox gem
2014-08-28 14:45:27 -04:00
Robin Ward
8bf27642ad FIX: Refresh was losing top controls after bulk operation. Removed
console.log
2014-08-28 14:44:38 -04:00
Robin Ward
69cb5bc425 FIX: Centralize Top rendering, remove old code paths. Fix some bugs. 2014-08-28 14:34:31 -04:00
Arpit Jalan
30e034aa53 Update onebox gem 2014-08-28 23:50:46 +05:30
riking
9090df63ba Fix pop3 settings in locale file 2014-08-28 10:45:40 -07:00
Robin Ward
30b102aa98 FIX: Show uncategorized with badge/description in the category chooser 2014-08-28 12:42:31 -04:00
Robin Ward
c9262a8390 FIX: Resend activation email was busted 2014-08-28 12:07:13 -04:00
cpradio
a40b08f210 Set focus on first item in drop down (textbox, link, whatever it may be)
Set focus on first item in the drop down for keyboard users, so they can quickly tab to the link/item of their choosing.
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
2014-08-28 11:33:45 -04:00
Robin Ward
aed0285bc6 Update onebox gem 2014-08-28 11:28:46 -04:00
Régis Hanol
38f52f0f8e FIX: banner topic's max-width & max-height on both mobile & desktop 2014-08-28 16:15:48 +02:00
Luca Daniel
2cf92dbe7b Add translation for Romanian. 2014-08-28 14:01:14 +03:00
Sam
a1244043d3 FIX: when search finds a deep link in a topic it takes you to it 2014-08-28 17:16:39 +10:00