Commit graph

896 commits

Author SHA1 Message Date
Jeff Atwood
53af2abb20 copyedit on full name help 2014-09-04 13:39:54 -07:00
Robin Ward
1c5e8efa68 FEATURE: Show an email icon beside posts that arrived via email 2014-09-04 13:04:41 -04:00
Neil Lalonde
ff136ddeea FEATURE: accounts that have not been activated are grey in admin user lists 2014-09-03 10:09:30 -04:00
Sam
9c16dee843 Merge pull request #2742 from riking/patch-1
UX: Change Impersonate to btn-danger
2014-09-03 22:18:19 +10:00
Sam
d4f08f442c FIX: correct template for search in post (regression) 2014-09-03 17:09:01 +10:00
riking
8979020b9d Clean up unused translations 2014-09-02 15:40:23 -07:00
Sam
e0c8abc911 Merge pull request #2717 from riking/badge-solid
Admin badge interface improvements
2014-09-02 08:21:06 +10:00
Sam
202656a679 Merge pull request #2725 from cpradio/german-keyboard-support
FIX: Support J/K bindings on German Keyboards
2014-09-02 08:02:10 +10:00
Jeff Atwood
7ef056810c minor copy update 2014-08-31 23:32:41 -07:00
cpradio
6234284243 FIX: Remove the old keyboard bindings for next/prev section, update client.en.yml to reflect the new bindings 2014-08-31 21:42:03 -04:00
riking
1833b43ae2 FEATURE: Badge query validation, preview results, and EXPLAIN
Upon saving a badge or requesting a badge result preview,
BadgeGranter.contract_checks! will examine the provided badge SQL for
some contractual obligations - namely, the returned columns and use of
trigger parameters.

Saving the badge is wrapped in a transaction to make this easier, by
raising ActiveRecord::Rollback on a detected violation.

On the client, a modal view is added for the badge query sample run
results, named admin-badge-preview.
The preview action is moved up to the route.
The save action, on failure, triggers a 'saveError' action (also in the
route).

The preview action gains a new parameter, 'explain', which will give the
output of an EXPLAIN query for the badge sql, which can be used by forum
admins to estimate the cost of their badge queries.
The preview link is replaced by two links, one which omits (false) and
includes (true) the EXPLAIN query.

The Badge.save() method is amended to propogate errors.

Badge::Trigger gets some utility methods for use in the
BadgeGranter.contract_checks! method.

Additionally, extra checks outside of BadgeGranter.contract_checks! are
added in the preview() method, to cover cases of null granted_at
columns.

An uninitialized variable path is removed in the backfill() method.

TODO - it would be nice to be able to get the actual names of all
columns the provided query returns, so we could give more errors
2014-08-31 11:25:44 -07:00
Jeff Atwood
9aac004c0a minor copy update, Omit Needless Words 2014-08-31 04:47:27 -07:00
Jeff Atwood
6221a84ce8 minor copy updates 2014-08-31 04:46:20 -07:00
Arpit Jalan
82d4c29c88 TRIVIAL: add line break before time for post navigator 2014-08-30 16:14:00 +05:30
Arpit Jalan
289d9e4fe1 FIX: use short date format for topic summary 2014-08-30 12:07:43 +05:30
Jeff Atwood
7a50ba600a Merge pull request #2726 from techAPJ/patch-4
FIX: use short date format for post navigator
2014-08-29 23:11:31 -07:00
Arpit Jalan
3c005557e6 FIX: use short date format for post navigator 2014-08-30 11:34:33 +05:30
Jeff Atwood
70dbad16dc UX: simplify copy for summarize topic mode 2014-08-29 22:59:39 -07:00
cpradio
2e200ffbf0 Merge remote-tracking branch 'origin/master' into keyboard-binding-incoming-updated-topics
Conflicts:
	config/locales/client.en.yml
2014-08-29 20:05:59 -04:00
cpradio
875b39fb5f Merge remote-tracking branch 'origin/master' into keyboard-binding-incoming-updated-topics 2014-08-29 19:56:39 -04:00
Jeff Atwood
cb45d5fa25 Merge pull request #2724 from cpradio/key-binding-reply-new-topic
UX: Add keyboard binding for reply as new topic
2014-08-29 16:46:34 -07:00
Jeff Atwood
d74f94afa1 Merge pull request #2722 from cpradio/dismiss-keyboard-bindings
UX: Add key-bindings for Dismiss New, Dismiss Posts, and Dismiss Topics
2014-08-29 16:28:25 -07:00
cpradio
68e807f791 UX: Add keyboard binding for reply as new topic 2014-08-29 19:14:42 -04:00
Jeff Atwood
0eb367f9c3 UX: rename "Leader" to "Veteran" (first steps) 2014-08-29 15:57:13 -07:00
Jeff Atwood
72293073f6 UX: better copy on mailing_list_mode pref 2014-08-29 13:07:36 -07:00
cpradio
5ca96e741d UX: Add keyboard bidning for incoming/updated topics 2014-08-29 09:44:26 -04:00
cpradio
096bc0c0ae Merge branch 'keyboard-binding-new-topics-banner' into dismiss-keyboard-bindings
Conflicts:
	app/assets/javascripts/discourse/lib/keyboard_shortcuts.js
2014-08-29 09:36:34 -04:00
cpradio
3f085c3fd3 Change the Dismiss keybindings to use 'x' instead of 'd' 2014-08-29 09:22:47 -04:00
cpradio
ede9d1e057 Change the Dismiss keybindings to use 'x' instead of 'd' 2014-08-29 08:46:35 -04:00
cpradio
e4ce995369 FIX: Changed Dismiss New and Dismiss Posts to use d + r because p is reserved for the profile menu and n is reserved for the notifications menu 2014-08-29 08:11:23 -04:00
cpradio
ed8d828ff1 FIX: Added keyboard bindings for dismiss buttons 2014-08-29 08:04:57 -04:00
Arpit Jalan
3a76f9e79f FIX: allow localization in timestamp 2014-08-27 20:57:06 +05:30
Jeff Atwood
fa10aa4945 COPY: add quotes around badge for clarity 2014-08-26 23:54:13 -07:00
Jeff Atwood
d50b34b825 "earned" vs "you were granted" 2014-08-26 23:46:48 -07:00
cpradio
1678a91a60 Add shortcuts for Profile Menu and Hamburger Menu
Added shortcuts of p and = for the profile and hamburger menu
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
2014-08-26 20:30:20 -04:00
Robin Ward
105959c402 Merge pull request #2696 from riking/errors
Fix "Server Error: [missing {{code}} value]" page
2014-08-26 11:14:57 -04:00
Jeff Atwood
d63c6292b3 change "Visit Profile" to just "Profile" 2014-08-26 00:37:10 -07:00
riking
5261f2e751 Fix "Server Error: [missing {{code}} value]" page
The translation was expecting a non-existent parameter.
2014-08-25 17:20:48 -07:00
Jeff Atwood
024c503870 mobile login tweaks 2014-08-25 12:38:27 -07:00
Sam
e0a74e336a Add SSO diagnostics 2014-08-23 10:34:48 +10:00
Neil Lalonde
bbb358b356 Add likes given and likes received requirement for being TL3. Configure with site settings leader_requires_likes_given and leader_requires_likes_received. 2014-08-22 17:33:39 -04:00
Jeff Atwood
f171af5fe5 minor copyedit 2014-08-22 12:49:02 -07:00
Neil Lalonde
00c28f2391 Show total likes given. Put likes given/received and flags given/received together. 2014-08-22 15:23:19 -04:00
Neil Lalonde
dafc63e3a0 Show how many likes users received in the last 100 days on their admin profile page 2014-08-22 14:37:07 -04:00
Sam
136169bc73 Merge pull request #2676 from riking/logster-link
Add link to Logster in "Logs" tab of admin panel
2014-08-22 10:21:04 +10:00
riking
50d4e283dc Add link to Logster in "Logs" tab of admin panel 2014-08-20 14:40:16 -07:00
Jeff Atwood
21b18b1253 remove the "view all {number}.." from mobile cat 2014-08-20 13:51:10 -07:00
Régis Hanol
8a20d05ba5 FEATURE: backup without uploads 2014-08-20 18:53:58 +02:00
Robin Ward
2b5feda625 FIX: You need to be logged in to edit wiki posts. 2014-08-20 11:04:45 -04:00
Jeff Atwood
9c7bc57121 clarify on flag reply "more" indicator 2014-08-19 12:40:39 -07:00
Robin Ward
96afbd6656 TRIVIAL: Don't show 06 Aug, show 6 Aug 2014-08-19 14:46:35 -04:00
Jeff Atwood
107ac88f15 add back in "by default" on new/latest edu 2014-08-18 15:01:09 -07:00
Robin Ward
14c765ef11 UX: Tweak logic for showing times in topic entrance popup 2014-08-18 17:14:50 -04:00
Jeff Atwood
004749871f copyedit for new/latest "teaching" empty pages 2014-08-18 13:50:09 -07:00
Neil Lalonde
0841cd2ba6 FEATURE: Add education text to new and unread pages when there are no results 2014-08-18 16:17:40 -04:00
Robin Ward
db4abe76db CLEANUP: Remove dead resetRead code path 2014-08-18 14:35:33 -04:00
Jeff Atwood
b3d99a638c fix inverted post-to-like copy 2014-08-18 11:25:56 -07:00
Régis Hanol
9f72971d26 FEATURE: add the pencil glyph when the post was edited after the first flag 2014-08-18 18:56:39 +02:00
Jeff Atwood
d73a961b3a correct wiki help text 2014-08-18 00:28:39 -07:00
Gerhard Schlager
6b286ad4f4 Add missing translation 2014-08-17 00:29:39 +02:00
Jeff Atwood
dbf1a8b766 clarify on /top behavior 2014-08-16 12:57:23 -07:00
Robin Ward
aa41548e8e UX: When clicking an activity date, pop up a little menu with options to
go to beginning or end of the topic.
2014-08-15 16:39:57 -04:00
Robin Ward
eb5a3da10d UX: Include tooltip text when hovering over posts column 2014-08-15 11:49:30 -04:00
Arpit Jalan
d0736a06b6 FEATURE: export user list 2014-08-15 01:46:57 +05:30
Jeff Atwood
48051127fc improve keyboard shortcut help layout 2014-08-14 02:54:53 -07:00
Jeff Atwood
196a59ed16 c'mon, unhide? Show, baby, SHOW 2014-08-13 17:06:28 -07:00
Robin Ward
31f7addefa FIX: Don't capitalize category name in document title 2014-08-13 10:53:34 -04:00
Robin Ward
1684ff3015 UX: Add a separate "Sign Up" button 2014-08-12 13:47:23 -04:00
Robin Ward
0e5a79cf5d FIX: Missing translations, update title on About 2014-08-12 11:04:12 -04:00
Jeff Atwood
506162b719 clarification on delete and block 2014-08-12 03:14:50 -07:00
Jeff Atwood
c187196cd5 clarify too_few_topics warn only appears for staff 2014-08-12 03:04:03 -07:00
Jeff Atwood
5dc35488d2 few more "Sign In/Out" reverts to "Log In/Out" 2014-08-11 16:29:02 -07:00
Jeff Atwood
a51bf08346 change "Sign In" back to "Log In" for now 2014-08-11 16:08:55 -07:00
Robin Ward
c8767dc505 UX: Tweak about page 2014-08-11 18:15:49 -04:00
Robin Ward
996d14965e Minor UX tweaks 2014-08-11 17:03:12 -04:00
Robin Ward
c103398e9a First stab at About page 2014-08-11 16:59:15 -04:00
Robin Ward
15c7e01b90 FEATURE: Can bulk delete topics now using the modal. 2014-08-11 15:14:02 -04:00
Régis Hanol
ec6ba68098 FEATURE: use glyphs instead of text in flag's dispositions 2014-08-11 18:21:34 +02:00
Régis Hanol
85570ddc77 TRIVIAL: fix grammar on 'deferred' columns 2014-08-11 11:56:54 +02:00
Jeff Atwood
c410da4f7f minor copy tweak 2014-08-08 13:18:15 -07:00
Jeff Atwood
cf31463115 copyedit on dismiss buttons tooltips 2014-08-08 13:12:29 -07:00
Jeff Atwood
679e9957f0 misspelled "deferred" 2014-08-08 12:43:11 -07:00
Sam
49f738fe27 FEATURE: allow users to dismiss unread posts 2014-08-08 16:29:51 +10:00
Jeff Atwood
ddbcba145d add ellipsis to flag buttons, better tooltips 2014-08-07 16:39:12 -07:00
Jeff Atwood
08a67f0da5 add lowercase "translations" for topic map 2014-08-07 02:31:59 -07:00
Robin Ward
60e70f82b9 UX: title text for wiki icon 2014-08-06 17:14:01 -04:00
Jeff Atwood
33eca10860 admins don't need to be told to click buttons yo 2014-08-05 23:31:49 -07:00
Régis Hanol
3330f5907c FEATURE: restructure notification HTML layout 2014-08-05 23:36:37 +02:00
Sam
4536f772c1 FIX: more reliable topic list counts
- unread was not incrementing when you read last post on topic
- new notifications were being inserted even if they existed in list
- terminology was all mixed up "1 new posts", split to 3 messages
- latest behaves as expected, updating count of new and updated topics
2014-08-05 13:27:34 +10:00
Sam
ef5b18779e FEATURE: merge new and old unread counts on categories page
UI: restyle UI to match counts
2014-08-05 10:44:01 +10:00
Jeff Atwood
6fb683ff9a tone down new/unread on /categories 2014-08-04 15:41:46 -07:00
Régis Hanol
ec30086dea FEATURE: agree all the flags 2014-08-04 22:48:04 +02:00
Jeff Atwood
aec9d5962e minor topnav tooltip edits 2014-08-01 03:04:42 -07:00
Jeff Atwood
3a68201d53 Omit Needless Words, man 2014-08-01 00:46:31 -07:00
Jeff Atwood
71aa41ccac copyedits on new flagging behaviors 2014-07-31 16:17:38 -07:00
riking
f9ef715357 Improve email-in category settings UI 2014-07-30 09:58:41 -07:00
Sam
e7e70d14da Merge pull request #2591 from BenLubar/benlubar-edit-history-public
add profile option for edit history visibility
2014-07-30 14:09:10 +10:00
Régis Hanol
bddffa7f9a FEATURE: flag dispositions normalization
All flags should end up in one of the three dispositions
  - Agree
  - Disagree
  - Defer

In the administration area, the *active* flags section displays 4 buttons
  - Agree (hide post + send PM)
  - Disagree
  - Defer
  - Delete

Clicking "Delete" will open a modal that offer to
  - Delete Post & Defer Flags
  - Delete Post & Agree with Flags
  - Delete Spammer (if available)

When the flag has a list associated, the list will now display 1
response and 1 reply and a "show more..." link if there are more in the
conversation. Replying to the conversation will NOT give a disposition.
Moderators must click the buttons that does that.

If someone clicks one buttons, this will add a default moderator message
from that moderator saying what happened.

The *old* flags section now displays the proper dispositions and is
super duper fast (no more N+9999 queries).

FIX: the old list includes deleted topics
FIX: the lists now properly display the topic states (deleted, closed,
archived, hidden, PM)
FIX: flagging a topic that you've already flagged the first post
2014-07-28 19:28:07 +02:00
Sam
32cea9d8cc Feature: Show keyboard shortcuts link on desktop hamburger
(only shows up for desktop, hides "mobile view")

If you really need mobile view add ?mobile_view=1 to end of URL (also fixed)
2014-07-28 11:48:56 +10:00
Sam
1a6aa07611 FEATURE: editable badge groups 2014-07-27 18:22:01 +10:00
Ben Lubar
44dc4b4a17 add profile option for edit history, visible only when edit history is disabled globally. 2014-07-26 23:04:46 -05:00
Neil Lalonde
46bdd13491 FIX: too_few_topics_notice check and message should use basic_requires_read_posts site setting 2014-07-25 15:58:22 -04:00
Sam
ec03d135fa FEATURE: allow advanced badge options in admin screen
clean up serializer, allow simplistic preview
2014-07-24 18:28:23 +10:00
Sam
526da15b9e Improve badge UI add links to badge descriptions 2014-07-24 12:21:24 +10:00
Jeff Atwood
fc1fa2d104 Caps Lock clearly needs more exclamation sign 2014-07-22 21:15:54 -07:00
Sam
b9a7d945c3 Improve badge grouping UI
Start work on triggers
2014-07-23 11:43:17 +10:00
Robin Ward
c004ad1d51 Merge pull request #2563 from techAPJ/patch-2
FEATURE: group name is required for private topic invite
2014-07-22 14:44:26 -04:00
Arpit Jalan
e7e823129e FEATURE: group name is required for private topic invite 2014-07-23 00:03:15 +05:30
Neil Lalonde
386b6213a5 FEATURE: warn when caps lock is on during password input 2014-07-22 13:53:58 -04:00
Robin Ward
da717c55d7 FEATURE: Like button should act like a toggle and stay there once you've
clicked it.
2014-07-18 17:01:27 -04:00
Sam
ed6766ccad FEATURE: push Reader up to 100 2014-07-18 15:57:03 +10:00
Sam
c8284170ad FEATURE: badge grouping UI
FIX: not loading more badges on badge show page
2014-07-18 15:46:36 +10:00
riking
19b757b058 FEATURE: Hide deleted posts by default for staff 2014-07-17 10:40:15 -07:00
Sam
1713fd4b59 Add localization for moderators snooping through PMs 2014-07-17 18:01:17 +10:00
Sam
e8ca1a2469 FEATURE: allow overriding badge names
FEATURE: allow html in badge description
2014-07-17 16:11:09 +10:00
Erick Guan
9c233073f2 Saved draft tip is more likely a bar instead of box. 2014-07-17 09:59:49 +08:00
Régis Hanol
f43293a7bc FEATURE: replace 'deleted by' with the trashcan glyph 2014-07-16 22:38:39 +02:00
Sam
5ad519e2bc Rename Read Faq, Read Guidelines 2014-07-16 17:55:08 +10:00
Sam
4c25fedf70 FEATURE: Reader badge
Read a every post in a topic that if 50 posts or longer
2014-07-15 15:16:41 +10:00
Jeff Atwood
6412958d1e make Send Test Email easier to see 2014-07-14 13:58:06 -07:00
Sam
4a2cc269ab FIX: allow selection of no title 2014-07-14 18:07:07 +10:00
Sam
88469721b9 FEATURE: Allow admins to disable specific badges 2014-07-14 17:40:36 +10:00
Jeff Atwood
b2d17a09ff missing translation for new site settings category 2014-07-13 13:43:44 -07:00
Jeff Atwood
2a40c04480 don't need "new" here 2014-07-13 02:54:39 -07:00
Jeff Atwood
4093120ddf distinct FAQ vs guidelines copy 2014-07-11 23:49:51 -07:00
Sam
833c50c460 FEATURE: Read Faq badge 2014-07-11 17:32:29 +10:00
Sam
89fc989adb FEATURE: First Quote badge 2014-07-11 14:17:43 +10:00
Jeff Atwood
ed3bebfebe switch /faq to /guidelines in a bunch of places 2014-07-10 15:30:58 -07:00
Neil Lalonde
e565ae2528 FEATURE: /guidelines route will always show our FAQ, ignoring the faq_url site setting 2014-07-10 12:58:41 -04:00
Jeff Atwood
e4a7f652cc grammar tweak. It's shorter too! 2014-07-09 23:08:01 -07:00
Jeff Atwood
3deba15c18 minor copyedits 2014-07-09 22:35:50 -07:00
Sam
2f8d139ec0 BUGFIX: incorrect ordering in category permissions
FEATURE: UI for categories that we allow badges on
2014-07-10 12:02:16 +10:00
Sam
928848c0a8 FEATURE: First Link badge 2014-07-10 12:02:16 +10:00
Jeff Atwood
0a643353cf slight improvements to invite email copy 2014-07-09 12:57:04 -07:00
Jeff Atwood
71b18ce5e2 minor copyedit on invites 2014-07-09 12:45:01 -07:00
Sam
9c14385a86 FEATURE: explain which badges can be titles 2014-07-09 16:03:53 +10:00
Sam
e32e96dabb FEATURE: new badges
- Pay it forward renamed to first like
- First flag
- First share
2014-07-09 12:17:39 +10:00
Neil Lalonde
df8b25d2f5 FEATURE: don't demote trust level 3 users who were promoted less than SiteSetting.leader_promotion_min_duration days ago 2014-07-08 17:39:49 -04:00
Jeff Atwood
fd36142895 minor copyedit on email-in 2014-07-08 12:16:08 -07:00
Jeff Atwood
432f055315 none of this em@ail.com nonsense 2014-07-08 10:23:18 -07:00
Jeff Atwood
b175eee89f semi-colon-ing it up 2014-07-08 00:04:01 -07:00
Jeff Atwood
e407c3df71 better copy for summarize topic 2014-07-07 22:26:32 -07:00
Sam
81682b74b7 Feature: Paying it forward badge 2014-07-08 14:26:53 +10:00
Régis Hanol
59b5ba7c0f BUGFIX: IP lookup wasn't working when using HTTPS
REFACTOR: the ip locator into a ip-lookup component
2014-07-07 22:18:18 +02:00
Sam
0f25bbeaf7 FEATURE: Editor badge 2014-07-07 17:55:40 +10:00
Jeff Atwood
8de5f014fc FEATURE: fit a bit more on the progress bar 2014-07-04 02:44:49 -07:00
riking
0d4163e0a2 FEATURE: Nice error handling page 2014-07-03 07:52:14 -07:00
Sam
0de564f598 Correct reqs 2014-07-03 22:34:45 +10:00
Sam
6bbb083d47 FEATURE: support "unlisted" badges. 2014-07-03 17:44:36 +10:00
Sam
9a9ad9bda8 FEATURE: Badge progress
- Refactor model so it stores backfill query
- Implement autobiographer
- Remove sample badge
- Correct featured badges to only include a badge once
2014-07-03 17:29:44 +10:00