Commit graph

7620 commits

Author SHA1 Message Date
Jeff Atwood
c1ddda3e8f try removing "loading topic..." vs spinner 2015-02-02 23:10:07 -08:00
Sam
7e259375e9 PERF: properly pass topic_id to post action cache to avoid excessive query
in the past auto closing was forcing a consistency check on topic, which in
turn was triggering a full post action cache rebuild
2015-02-03 15:59:26 +11:00
Sam
85d9b2d227 regression, missing local storage would cause script to break 2015-02-03 13:17:03 +11:00
Sam
78b879d666 remove superflous rules break firefox 2015-02-03 11:56:57 +11:00
Sam
5ddec2e76d revert lodash upgrade, it is causing severe breakages elsewhere 2015-02-03 11:51:34 +11:00
Jeff Atwood
80d8b133d9 slight emoji dialog tweak 2015-02-02 15:41:53 -08:00
Jeff Atwood
2dbe747918 emoji dialog UX tweaks
https://meta.discourse.org/t/idea-design-window-emoticons/24654
2015-02-02 14:43:10 -08:00
Régis Hanol
03f7a12b52 UX: use 🌟 icon for recently used emoji tab 2015-02-02 22:28:58 +01:00
Régis Hanol
20308ecfd9 fix typo (stupid 🇫🇷) 2015-02-02 21:55:44 +01:00
Régis Hanol
69f95df297 FEATURE: recently used emoji tab
⬆️ update lodash to V.3.0.1
2015-02-02 21:54:15 +01:00
Robin Ward
06279b5c6a Add a new event for when a post is confirmed as spam 2015-02-02 15:52:21 -05:00
Régis Hanol
0a252d7785 FIX: quote whote post should insert at cursor position 2015-02-02 19:08:28 +01:00
Robin Ward
f15b0d205f FIX: The "too similar" check happened when trying to make a post a wiki 2015-02-02 12:44:56 -05:00
Neil Lalonde
b56999e984 show last 30 days on about page 2015-02-02 12:27:49 -05:00
Arpit Jalan
88306cc112 FIX: uncategorized category was not loading updates in edit mode 2015-02-02 21:50:29 +05:30
Régis Hanol
b9ff4a5e81 UX: fix 'revision details' styling in revision history window 2015-02-02 12:13:37 +01:00
Jeff Atwood
9d4ee9553d add some breathing room to quoted categories 2015-02-02 02:08:06 -08:00
Régis Hanol
e2a65a6605 Merge pull request #3159 from riking/patch-6
FIX: Add Google Analytics code to crawler view
2015-02-02 11:07:47 +01:00
Jeff Atwood
737f81b3a9 remove default bgcolor from code highlight 2015-02-02 01:53:24 -08:00
Jeff Atwood
e45b3c15c3 Revert "FIX: auto orientation code causing grey images to appear blackish"
This reverts commit f680374820.
2015-02-02 01:27:52 -08:00
riking
c6e27399b3 FIX: Add Google Analytics code to crawler view 2015-02-02 00:49:58 -08:00
Sam
8304c306a4 Merge pull request #3158 from techAPJ/patch-2
FIX: Not allow TL4 user to set staff color
2015-02-02 16:27:39 +11:00
Arpit Jalan
a29970275a FIX: Not allow TL4 user to set staff color 2015-02-02 10:38:42 +05:30
Sam
05a56b25a9 FIX: setting custom avatar would not work a lot of the time
Due to internal structure we were often caching "redirect" images.
2015-01-31 23:42:50 +11:00
Sam
f680374820 FIX: auto orientation code causing grey images to appear blackish 2015-01-31 18:05:50 +11:00
Sam
f4609fd6ae selection refactor caused wrench to show up in topic list for non-admins 2015-01-31 17:16:08 +11:00
Sam
8b95511816 correct bad styling in user->pref->categories 2015-01-31 17:04:53 +11:00
Arpit Jalan
3e7cc18276 FIX: Toggling staff color on a post doesn’t get applied 2015-02-02 01:11:35 +05:30
Jeff Atwood
cabd519f14 add a little breathing room for topic title tags 2015-01-30 15:45:04 -08:00
Robin Ward
d7b7ec9e0a FIX: Wiki editing was broken due to extra topic update 2015-01-30 18:02:11 -05:00
Robin Ward
f923d7e205 Support appending routes within the admin section by plugins 2015-01-30 18:02:11 -05:00
Neil Lalonde
750b27f973 FEATURE: show number of active users in the last 7 days on about page 2015-01-30 17:23:52 -05:00
Régis Hanol
79a7c7ce41 Merge pull request #3151 from lidlanca/patch-7
Fix: Resize event does not get cleared/unbind properly due to wrong usage of jQuery api.
2015-01-30 15:48:08 +01:00
Dan Singerman
64c4bd5dbf Fix force_avatar_update.to_i error as force_avatar_update is a boolean
If force_avatar_update is passed in sso attributes it errors on
force_avatar_update.to_i. The SingleSignOn class forces avatar_force_update
to a boolean, so it should be treated as such.
2015-01-30 09:51:38 +00:00
Sam
d9ae4e791e woops should be a bit more specific 2015-01-30 19:17:26 +11:00
Sam
833b7b8f0b fix header primary missing color 2015-01-30 17:57:46 +11:00
lidlanca
b4f1ffd4ea Fix: Resize event handler does not get cleared from window object,by wrong usage of jQuery api.
An handler get added each time a topic is loaded to the window object

jQuery resize api only pass data to the handler when triggered.
```.resize( [eventData ], handler ) ```

The unbind followed in willDestroyElement had no affect. 

.on(...) or bind(..) support the event.namespace

fix was not tested.
2015-01-30 01:57:44 -05:00
Sam
52bc03b5e6 FIX: summary mode was broken and missing a bunch of posts 2015-01-30 17:19:42 +11:00
Sam
784697bf12 added todo 2015-01-30 15:11:46 +11:00
Sam
1b1ea8e718 FEATURE: 'b' as a keyboard shortcut for bookmarking a topic 2015-01-30 15:11:24 +11:00
Sam
8b7afd644f regression, too many "new" badges on the "new" tab 2015-01-30 12:47:45 +11:00
Sam
e77eaf9c95 adjust styling for tagged topics 2015-01-30 12:33:27 +11:00
Sam
561278eb38 correct broken mobile styling 2015-01-30 12:09:42 +11:00
Sam
8264dbd971 Merge pull request #3140 from fullfatthings/fix_missing_sso_avatar_bug
Fix bug when sso_overrides_avatar is true but no avatar_url is passed
2015-01-30 10:45:25 +11:00
Sam
b1f81c0dca Merge pull request #3080 from riking/misc
Miscellaneous fixes from PR#3000
2015-01-30 10:23:17 +11:00
Sam
ea7af7a83b Merge pull request #3135 from longhotsummer/fix-no-user-params
FIX: creating a user shouldn't error when optional fields aren't given
2015-01-30 10:12:57 +11:00
Neil Lalonde
67b262b93e Merge branch 'master' of github.com:discourse/discourse 2015-01-29 17:39:52 -05:00
Neil Lalonde
644c7a4675 FEATURE: Add an option to show custom user fields on profiles. Default is to not show them. 2015-01-29 17:38:39 -05:00
Robin Ward
d1ec1e2681 Allow code to save custom fields without saving the attached object 2015-01-29 17:17:52 -05:00
riking
85a7b925c7 Miscellaneous fixes from PR#3000
FIX: Don't require login to view post raw
FIX: Don't submit read-guidelines for anonymous users (causes
unnecessary 403 errors from ensure_logged_in)
FIX: Don't pass nil to an array serializer
2015-01-29 13:56:32 -08:00
Sam
a6ce188f35 Merge pull request #3126 from riking/latest-posts
Latest posts endpoint at /posts.json
2015-01-30 08:55:45 +11:00
Régis Hanol
6a68e8c272 FIX: use CDN for user card/profile background and user avatars (for real this time) 2015-01-29 22:53:48 +01:00
Arpit Jalan
6c410ed093 FIX: strip whitespaces from user email 2015-01-30 01:44:24 +05:30
Régis Hanol
22adb682d8 revert - FIX: use CDN for user card/profile background and user avatars 2015-01-29 20:42:05 +01:00
Régis Hanol
14dc22f288 FIX: use CDN for user card/profile background and user avatars 2015-01-29 20:15:17 +01:00
Robin Ward
f028b51620 Add post parameters so plugins like akismet can use it for spam
prevention.
2015-01-29 13:09:35 -05:00
Robin Ward
1f40807001 Add extensibility point for whenever a post is created 2015-01-29 12:46:29 -05:00
Régis Hanol
2507f99135 FEATURE: background job to make sure emoticons aren't too big 2015-01-29 18:36:35 +01:00
Robin Ward
9a4e5c04d9 Fix weird indentation in CSS file 2015-01-29 12:08:42 -05:00
Régis Hanol
bdb0b45834 Merge pull request #3148 from techAPJ/patch-1
Do not allow TL0 users topics in email digest
2015-01-29 17:50:21 +01:00
Régis Hanol
3a24df6956 FIX: adding a custom emoji needed an application restart to work on the server-side rendering 2015-01-29 17:35:52 +01:00
Régis Hanol
b5a6193d36 Merge pull request #3147 from awesomerobot/master
simple change that grants a bit more flexibility to the category and title in the topic list
2015-01-29 17:30:39 +01:00
Kris Aubuchon
5621b1f663 simple change that grants a bit more flexibility to the category and title in the topic list 2015-01-29 10:53:13 -05:00
Arpit Jalan
21e94859a9 Do not allow TL0 users topics in email digest 2015-01-29 21:10:26 +05:30
Robin Ward
52d04935be Merge pull request #3145 from gdpelican/bugfix/like-toggle
Rerender actions on like/dislike
2015-01-29 10:32:11 -05:00
Régis Hanol
6556e1cb10 FIX: pasting image in the composer wasn't working in Chrome 2015-01-29 16:26:40 +01:00
Jeff Atwood
f4a9ba8c9d tighten up spacing on category dropdown button 2015-01-29 03:51:07 -08:00
James Kiesel
3b2dcf12b5 Rerender actions on like/dislike 2015-01-29 23:27:05 +13:00
Arpit Jalan
4e4bb736a8 build is failing :fired: 2015-01-29 15:18:38 +05:30
Jeff Atwood
605ae8a1a3 Merge pull request #3143 from techAPJ/patch-1
FIX: PMs were not allowed to be edited in some cases
2015-01-29 01:35:05 -08:00
Arpit Jalan
e8db47a1fe FIX: PMs were not allowed to be edited in some cases 2015-01-29 15:00:11 +05:30
Sam
ffee7ba789 fix style 2015-01-29 18:37:38 +11:00
Sam
8792909ff8 less rules ... less ie problems ... 2015-01-29 18:22:29 +11:00
Sam
a591c019d4 correct tests 2015-01-29 17:57:34 +11:00
Sam
1a694c04e4 correct box styles 2015-01-29 17:49:14 +11:00
Sam
cd5564f623 more styling tweaks 2015-01-29 17:49:14 +11:00
Sam
57dd4554f1 bar style fixes 2015-01-29 17:49:14 +11:00
Sam
6495bca540 bar style fixes 2015-01-29 17:49:14 +11:00
Sam
844467015d FEATURE: allow simple selection for category badge styles
clean up category badge styling
2015-01-29 17:49:14 +11:00
Robin Ward
d491d817a6 UX: Alwasy skip headers on topic lists on mobile.
Fixes topic lists filtered by tag on mobile.
2015-01-28 15:20:26 -05:00
Robin Ward
d6fa248093 UX: Update 404 page category badge to use centralized helper and style 2015-01-28 14:56:38 -05:00
Régis Hanol
cd2c9edb46 FIX: 🐛 upload on IE9 wasn't working :'(
- FIX: make sure we set a default name to a pasted image only on Chrome (the only browser that supports it)
- FIX: use ".json" extension to uploads endpoints since IE9 doesn't pass the correct header
- FIX: pass the CSRF token in a query parameter since IE9 doesn't pass it in the headers
- FIX: display error messages comming from the server when there is one over the default error message
- FIX: HACK around IE9 security issue when clicking a file input via JavaScript (use a label and set `visibility:hidden` on the input)
- FIX: hide the "cancel" upload on IE9 since it's not supported
- FIX: return "text/plain" content-type when uploading a file for IE9 in order to prevent it from displaying the save dialog
- FIX: check the maximum file size on the server 💥
- update jQuery File Upload Plugin to v. 5.42.2
- update JQuery IFram Transport Plugin to v. 1.8.5
- update jQuery UI Widget to v. 1.11.1
2015-01-28 19:43:20 +01:00
Robin Ward
053d3120f7 Updated incorrect comment 2015-01-28 13:38:40 -05:00
Robin Ward
8fc477ab07 More refactoring to support extensibility of history 2015-01-28 13:37:06 -05:00
Robin Ward
4a46d4ee35 Refactor and enable extensibility in PostRevisionSerializer 2015-01-28 13:37:06 -05:00
Robin Ward
d43944b3ed Extensibility for tracking changes to a topic 2015-01-28 13:37:06 -05:00
Dan Singerman
dbf2f4efec Fix bug when sso_overrides_avatar is true but no avatar_url is passed
If a user has a current avatar, and sso_overrides_avatar is true, but no avatar_url is
passed in the sso attributes, the current code errors, as it tries to parse a nil
as a URL. It seems to me valid that a third party system may not pass an avatar_url in
some cases (e.g. avatars may not be mandatory, so not all users may have them)

This might warrant a discussion about what should happen in this case; maybe the current
avatar in discourse should be removed? This branch merely stops the login process erroring.
2015-01-28 16:01:39 +00:00
Régis Hanol
b003c2b4f3 let's try category class again 2015-01-27 23:44:47 +01:00
Arpit Jalan
5128aa1052 Minor code optimization 2015-01-27 22:51:57 +05:30
Arpit Jalan
12c82bed59 Disable digest emails site setting 2015-01-27 22:41:36 +05:30
Greg Kempe
d99ccf6d27 FIX: creating a user shouldn't error when optional fields aren't provided
This fixes a bug where the server would 500 if the only user fields
where optional ones, and the create_user call didn't provide any
values so that params[:user_fields] was nil.

Additionally, don't bother double-checked for required fields, since we
iterate over all fields and will catch any that are required and blank.
2015-01-27 11:48:27 +02:00
Sam
fbd18f3b69 Merge pull request #3132 from lidlanca/patch-4
Perf UX : reduce page paint on scrolling, due to fixed header element union with progress bar area
2015-01-27 14:40:49 +11:00
Sam
d52b0a2458 temporarily disable category class on body while debugging issue with missing docking header 2015-01-27 13:43:40 +11:00
lidlanca
0ffea11ccb Perf UX : reduce page paint on scrolling, due to fixed header element union with progress bar
Should provide some performance improvement for scrolling on chrome
The fixed header and the fixed progress bar on both ends  of the screen will invoke a complete visible page redraw.

For whatever reason this css should make things better for low performance devices. only tested on chrome superficially.
2015-01-26 20:47:43 -05:00
Sam
497042ddf2 FIX: don't restrict to local filesystem for df check
FIX: check correct directory when looking at backup limits
2015-01-27 08:25:57 +11:00
Régis Hanol
efd65dcc8c hard match domains for automatic group membership 2015-01-26 23:17:29 +01:00
Régis Hanol
088260f053 BREAK: improve consistency by using 'category-<slug>' instead of 'category-<id>' as css class 2015-01-26 23:11:41 +01:00
Robin Ward
51827b06ac Merge pull request #3130 from techAPJ/master
FEATURE: suppress digest emails for users not seen on the site for more ...
2015-01-26 13:12:47 -05:00
Régis Hanol
3b3c0d7088 add category name as a css class to topic list item (props to @lagwagon) - closes #3129 2015-01-26 18:43:55 +01:00
Arpit Jalan
5c2ee8ec2a FEATURE: suppress digest emails for users not seen on the site for more than (n) days. 2015-01-26 22:04:02 +05:30
Robin Ward
30cd341b0d UX: Max width of .gifv videos 2015-01-26 11:00:18 -05:00
Robin Ward
b3a9f91bd3 UX: You should be able to tab to the "This is a warning" checkbox 2015-01-26 10:52:17 -05:00
Jeff Atwood
8ef2a111a0 fix left margin on tablet portrait w/topic + list 2015-01-25 23:45:36 -08:00
Régis Hanol
78a7fb4b07 Merge pull request #3125 from gschlager/bugfix_01
FIX: Loading of Emoji files depended on working directory
2015-01-25 17:42:16 +01:00
Jeff Atwood
bab5167566 tighten up suggested topic table layout 2015-01-25 00:33:52 -08:00
riking
9e9119d1c1 FEATURE: Enable pagination of /posts.json 2015-01-23 21:22:19 -08:00
riking
1d24d8471e FEATURE: Latest posts endpoint at /posts.json 2015-01-23 21:16:03 -08:00
riking
fb72e2665f PERF 🐎 Don't calculate preload data for non-xhr json requests
This will help out anyone querying as API instead of through a
browser.
2015-01-23 21:14:58 -08:00
Jeff Atwood
246ae75a31 FIX: language was not being inserted into RSS 2015-01-23 15:57:29 -08:00
Gerhard Schlager
361b3fb07a FIX: Loading of Emoji files depended on working directory
The importer scripts could not be used unless the working directory was
the Discourse root directory.
2015-01-24 00:07:39 +01:00
Jeff Atwood
4904eeaa67 more pastel (desaturated) progress bar 2015-01-23 14:03:27 -08:00
Jeff Atwood
545d5b4906 turn down lightness scale of progress bar a bit 2015-01-23 12:39:07 -08:00
Robin Ward
d06d050eb7 UX: When oneboxing a topic, use the stripe category badge 2015-01-23 15:12:42 -05:00
Régis Hanol
f7f5e39f75 FIX: Minor Admin bug with a setting when creating a new group 2015-01-23 20:31:48 +01:00
Régis Hanol
e6f849f873 FIX: make sure pasting an image in the composer is considered as an image instead of an attachment 2015-01-23 19:17:33 +01:00
Régis Hanol
256519dddf FEATURE: automatic group membership based on email address 2015-01-23 18:25:43 +01:00
Robin Ward
2ea4c1c9de FIX: Groups post page was broken.
Also added integration tests so we don't miss this breaking in the
future.
2015-01-23 11:13:27 -05:00
Robin Ward
848d60d459 FIX: Posts weren't highlighting on initial load 2015-01-23 10:46:44 -05:00
Régis Hanol
ea1d53f848 Merge pull request #3121 from techAPJ/patch-1
FIX: full user names were showing up in crawlers and rss feeds in spite ...
2015-01-22 18:28:50 +01:00
Robin Ward
b3a2c0c45b SECURITY: The SSO return_path was an open redirect
This security fix needs SSO to be configured, and the user has to go
through the entire auth process before being redirected to the wrong host so
it is probably lower priority for most installs.
2015-01-22 12:20:17 -05:00
Arpit Jalan
63556a904a FIX: full user names were showing up in crawlers and rss feeds in spite enables_names setting being disabled 2015-01-22 22:34:35 +05:30
Robin Ward
7741e4dc02 Change the admin-menu outlet to use a tagName of li 2015-01-21 16:21:27 -05:00
Robin Ward
9e82c41576 Merge pull request #3119 from techAPJ/patch-3
FIX: user name and title were not showing on post creation
2015-01-21 16:04:00 -05:00
Arpit Jalan
62c1291548 FIX: user name and title were not showing on post creation 2015-01-22 02:28:04 +05:30
Régis Hanol
141f697482 remove unused route 2015-01-21 20:54:07 +01:00
Régis Hanol
e300945879 FEATURE: split group admin in 2 tabs (custom & automatic)
FIX: clear the user-selector when adding new members
2015-01-21 20:52:48 +01:00
Robin Ward
03eb4752d1 Add categories-list css class to body for customization purposes 2015-01-21 14:34:01 -05:00
Robin Ward
48c7e20d80 DRY up the displaying of topic categories. Should not be duplicated. 2015-01-21 12:20:39 -05:00
Robin Ward
df8880a71a FIX: (for IE9) if console.log doesn't exist, make it an noop. 2015-01-21 11:53:41 -05:00
Jeff Atwood
1ed34be1b9 make topic list pin color consistent with lock 2015-01-21 03:15:56 -08:00
Jeff Atwood
e5cad726fd further tweaks to get post selection OK on mobile 2015-01-20 22:51:15 -08:00
Jeff Atwood
c4ddc5b983 quick mobile css fix for post selection buttons 2015-01-20 17:28:06 -08:00
Jeff Atwood
aa423212a0 make topic list bookmark color consistent with lock 2015-01-20 16:39:11 -08:00
Robin Ward
614ad4daa7 UX: Formatting on search categories looked weird 2015-01-20 17:51:12 -05:00
Robin Ward
649dfd8d23 Revert "Convert html.js to ES6 module format"
This reverts commit 60523d8e02.
2015-01-20 16:13:42 -05:00
Robin Ward
60523d8e02 Convert html.js to ES6 module format 2015-01-20 16:07:29 -05:00
Robin Ward
e3b4d12e46 Merge pull request #3110 from riking/notification_lanaguage
FIX: Respect user locale for reply notifications
2015-01-20 15:17:18 -05:00
Robin Ward
350554e198 UX: Change category badge style to use stripes 2015-01-20 14:56:06 -05:00
Robin Ward
f3c9310e12 Merge pull request #3117 from techAPJ/patch-1
FEATURE: rate limit invites for non-staff users
2015-01-20 10:45:00 -05:00
Neil Lalonde
4c0129ccdd PERF: slow user pages in admin. add an index for trust level 3 calculations, and memoize query results 2015-01-19 15:30:16 -05:00
Arpit Jalan
5e751ce90a FEATURE: 🎁 rate limit invites for non-staff users 2015-01-20 01:12:24 +05:30
Neil Lalonde
7412ff4da7 FIX: suspended users are logged out when they are suspended. Show a reason for suspension when they try to log in. 2015-01-19 12:37:02 -05:00
Arpit Jalan
7687c95e7b UX: add file size in CSV export notification 2015-01-19 19:21:53 +05:30
Jeff Atwood
90ff92e008 don't show self-bookmark avatar in user stream 2015-01-19 01:08:39 -08:00
Jeff Atwood
3f7fa46af7 remove unnecessary site header title height 2015-01-19 00:44:23 -08:00
Jeff Atwood
3d0e59942c IE9 doesn't support console.log 2015-01-19 00:33:51 -08:00
riking
03fd275b45 FIX: Respect user locale for reply notifications 2015-01-17 23:17:50 -08:00
riking
1ab0d6bd82 FEATURE: Log username changes by staff
Also fix the tests for changing username
2015-01-17 02:26:12 -08:00
Robin Ward
37d73ec488 Support customizing the composer below the textarea 2015-01-16 12:52:40 -05:00
Jeff Atwood
24b282e5e9 clicking expanded post date also jumps to post 2015-01-16 03:06:19 -08:00