Navin
4754216369
Simplify branching
2013-05-22 21:45:31 +02:00
Navin
ef93512de8
Extract quote parsing into a method
2013-05-22 21:38:45 +02:00
Robin Ward
b9a310f4b1
Search Refactor: Let's use a class to keep track of our state rather
...
than passing params everywhere. Also make the private API private.
2013-05-22 15:22:06 -04:00
Robin Ward
0f296cd42b
Refactor + Fix: Wasn't correctly loading activity streams. Code is a lot more Ember-y now.
2013-05-22 12:06:37 -04:00
Matt Van Horn
872995db57
refactor guardian class for clarity & correctness
...
introduce NullUser to avoid type-checking
DRY up code
reduce number of multiple returns
remove some redundant/impossible logic branches
add pending test for possible bug
add test & fix for ability to flag archived posts
add #secure_category? method to topic class
Fix bug that prevented flagging of archived topics
Rename NullUser to AnonymousUser
DRY up can_<action>? methods
Fix some ownership logic, and a test, for Guardian
2013-05-22 01:09:34 -07:00
Sam
96f8d79e83
Merge pull request #876 from chrishunt/chrishunt/observe-changes-for-topic-users
...
Trigger UserActionObserver when updating TopicUser
2013-05-21 23:02:27 -07:00
Sam
c4d8085fc5
remove moderator status posts from best feed
2013-05-22 15:04:53 +10:00
Chris Hunt
d0bc8c95d3
Trigger UserActionObserver when tracking visit
2013-05-21 20:45:03 -07:00
Chris Hunt
685f4960f1
Trigger UserActionObserver when updating TopicUser
2013-05-21 20:43:43 -07:00
Robin Ward
45361934b9
User the BasicUserSerializer for the invited user
2013-05-21 12:03:51 -04:00
Robin Ward
046e6e5d86
Simplified grouping on user views, fixed issue with messages not loading on initial load. Really
...
simplified the restricted user route.
2013-05-21 11:50:01 -04:00
Robin Ward
27828c5ec2
Merge pull request #871 from avdi/refactoring-with-josh-and-avdi
...
Various refactorings towards Ruby/Rails idiom from Josh Susser and Avdi Grimm
2013-05-21 07:18:50 -07:00
Sam
b5eff93a9d
update message bus to support per client filtering
...
start work on user_tracking_state
fix can_ban? in guardian
expose protected scopes on topic_query we need
move guardian spec to use build as opposed to creating topics / posts / users
start work on user tracking spec
2013-05-21 16:39:51 +10:00
Jeff Atwood
7e3e6ab78d
icon tweak on merge/split
2013-05-20 12:34:15 -07:00
Robin Ward
dee45d8dba
Changed elementId to be id
2013-05-20 15:31:05 -04:00
Robin Ward
42248a7164
Removed many unnecessary paths that included content.x when just x would do.
2013-05-20 15:27:58 -04:00
Robin Ward
9544cfd7dc
target="controller" is unnecessary. By default it will target the controller.
2013-05-20 14:37:05 -04:00
Robin Ward
a79d53c628
Removed many unnecessary controller. uses in templates.
2013-05-20 13:45:14 -04:00
Robin Ward
c7aebbf4d6
Replace Ember.Text* insertions with helpers.
2013-05-20 12:56:36 -04:00
Robin Ward
1097d51b33
Replaced {{view Discourse.TextField}} with {{textfield}} helper.
2013-05-20 12:47:59 -04:00
Robin Ward
b794830a25
Replaced Em.run.next with the more proper Em.run.schedule('afterRender')
...
when we are waiting for rendering to finish.
2013-05-20 12:20:10 -04:00
Sam
a3dce9afd7
don't error out on not posts if its a json request
2013-05-20 17:32:53 +10:00
Sam
fc57578c85
proper 404 for json request 404
2013-05-20 17:28:32 +10:00
Sam
e91ed83586
the private message stream is different to normal streams, improving the ui a bit and collapsing conversations
2013-05-20 16:44:06 +10:00
Sam
80fb20816c
get rid of nonsense 404.html
...
correct 404 handling for invalid pages
2013-05-20 10:29:49 +10:00
Sam
18b00d01d0
Merge pull request #859 from lengarvey/user_refactoring
...
Light refactoring of the User model
2013-05-19 16:41:20 -07:00
Neil Lalonde
5f7f87437c
Fix for topic excerpt being from the wrong post
2013-05-18 13:35:21 -04:00
Leonard Garvey
b16705be0d
Clean up update_visit_record!
...
update_visit_record! appears to add user_visit record if one
doesn't exist and days_visited is simply a counter for the number
of visit records.
2013-05-18 16:02:06 +10:00
Leonard Garvey
32f4dfd2fb
DRY up the user model slightly
...
regular? is just the inverse of staff?
2013-05-18 16:00:35 +10:00
Sam
25105082d5
Merge pull request #850 from bplexico/refactor_post_rb
...
Refactored post model to reduce duplication in validator methods
2013-05-17 15:56:53 -07:00
Neil Lalonde
546a2b654a
Improve style of security tab of category modal
2013-05-17 16:09:52 -04:00
Josh Susser and Avdi Grimm
2acc80d192
Various idiomatic User refactorings.
2013-05-17 15:44:35 -04:00
Josh Susser and Avdi Grimm
5659b66729
Refactor select().map() to use pluck.
...
Remove a method already provided by ActiveRecord.
2013-05-17 15:11:37 -04:00
Neil Lalonde
191d454589
Show Inbox before Sent Items
2013-05-17 14:11:33 -04:00
Josh Susser and Avdi Grimm
d30330441a
Refactored conditional to an || to be more idiomatic.
2013-05-17 14:06:58 -04:00
Brian Plexico
a86646312b
Refactored post model to reduce duplication in validator methods
2013-05-17 12:15:21 -04:00
Neil Lalonde
2265c046ba
Some tweaks to category modal
2013-05-17 11:19:58 -04:00
Neil Lalonde
f3282e33a3
Add tabs to category create/edit modal. Categories can have a default auto-close setting that applies to all new topics created in the category. Add rspec-given and write some integration tests. Tests for topic auto-close with category default
2013-05-17 11:05:35 -04:00
Sam
8f46653345
refactor
2013-05-17 09:03:52 +10:00
Robin Ward
a80ec535a3
Support for "Select All / Deselect All" while selecting posts to merge / delete.
2013-05-16 16:50:38 -04:00
Robin Ward
7daca77443
Remove modal state to choose move type. Instead use two buttons on the multi select popup, one
...
for split and one for merge.
2013-05-16 14:22:41 -04:00
Robin Ward
1e9497d9ef
FIX: Add unseen "*" icon on category list for new topics.
2013-05-16 13:36:58 -04:00
Robin Ward
d554a59102
Support for a new site setting: newuser_spam_host_threshold. If a new user posts a link
...
to the same host enough tiles, they will not be able to post the same link again.
Additionally, the site will flag all their previous posts with links as spam and they will
be instantly hidden via the auto hide workflow.
2013-05-16 12:19:50 -04:00
Sam
04b8cd5c95
consistency check, need to also ensure delete cleans stuff up, maybe make notifications trashable
2013-05-16 17:50:14 +10:00
Sam
88417725b5
we need some, albeit hacky way of clearing these old pms, make at least some way of finding them
2013-05-16 17:30:30 +10:00
Sam
7e1c5ae5b7
glyph in secure categories to the right, like pms
2013-05-16 16:55:07 +10:00
Sam
eb71e9de24
opening move, don't get rid of green notification till the pm is read
...
TODO a way to list all unread PMs
2013-05-16 16:37:47 +10:00
Sam
e9ebadb414
Nuke message_bus_observer move to service class and classes
...
Secure all messages triggered by post creation and all user actions so they don't leak
(meaning, if you have a browser open and secure topics are created you will only get them if you are allowed to see them)
2013-05-16 15:03:16 +10:00
Régis Hanol
27dfb7a948
FIX: @username mentions when there are multiple code blocks in a post.
...
Meta: [All of my internal users show as coming from 127.0.0.1!](http://meta.discourse.org/t/all-of-my-internal-users-show-as-coming-from-127-0-0-1/6607 )
This fixes the regular expression used to identify @ inside <code> or <pre> blocks in the `postConversion` hook.
2013-05-16 01:59:07 +02:00
Lee Machin
dadb7eaa23
fix crash caused by incorrect query in scope
...
setting all categories to be secured led to a blank screen on all pages
use stabby lambda for consistency in class
make the test a little more concise
- move the local assignments into let blocks for
reusability
- remove calls to `to_a`, which aren't needed
- use 'be_empty' instead of '[]' to be consistent
with the other matchers in the test
add a test for the `secured` scope with multiple
secured categories
2013-05-15 22:26:52 +01:00
Robin Ward
b1bfda0e11
Don't show new user education when editing a reply.
2013-05-15 15:16:42 -04:00
Neil Lalonde
ae78954fc0
Fix the 'no more topics' message for categories with non-ascii names
2013-05-15 11:44:45 -04:00
Neil Lalonde
18634ad00d
Don't cache the problems list with the rest of the dashboard data
2013-05-15 11:09:12 -04:00
Neil Lalonde
d4b8e727fc
Remove templateName from topic_closing_view because it doesn't use a template
2013-05-15 10:08:08 -04:00
Robin Ward
05ed2af08f
Add post count to similar posts popup. Fix alignment.
2013-05-14 16:53:17 -04:00
Neil Lalonde
21b4b8d5d5
Expire dashboard data when you upgrade to a new discourse version. Version check data was being cached and causing confusion to people who upgraded.
2013-05-14 16:17:25 -04:00
Robin Ward
008b308939
Fix: comma
2013-05-14 12:49:53 -04:00
Neil Lalonde
101ba5d8fe
Add Create Topic button to /categories page
2013-05-14 12:47:28 -04:00
Robin Ward
df2a718446
FIX: Load more user admin details, even when passed from a list
2013-05-14 12:03:46 -04:00
Neil Lalonde
957d95c1cc
Fix rerender of topic close message when you navigate away from a closing topic
2013-05-13 16:25:17 -04:00
Neil Lalonde
6d47d4854e
Don't reload the page when auto close time is changed
2013-05-13 16:25:17 -04:00
Neil Lalonde
b7cdee4d5c
Add title tag to the admin options button in the composer
2013-05-13 16:25:17 -04:00
Robin Ward
bdca804796
Add a touchend event to the admin menu. Hopefully helps IE11 Touch.
2013-05-13 15:29:16 -04:00
Robin Ward
be234ce9b9
You can now 'move' the first post of a topic to another topic as a merge. In that
...
case, the first post is cloned instead of being deleted from the original topic.
2013-05-13 14:07:31 -04:00
Neil Lalonde
9828c87525
Topic Auto-Close: admins and mods can set a topic to automatically close after a number of days
2013-05-13 12:53:52 -04:00
Sam
670b66ade3
better add some tests here tomorrow
2013-05-13 18:47:32 +10:00
Sam
b6bf95e741
speed up startup (avoid loading some gems on startup)
...
correct group permission leaks
add Discourse.cache for richer caching support
2013-05-13 18:04:03 +10:00
Sam
9b33e826f2
clear flags on reply to notify moderators
2013-05-13 11:48:01 +10:00
Sam
a27046bacd
fix cache hole
2013-05-13 11:09:03 +10:00
Sam
d68e3f7369
optimisations (cut down on category queries, cut down on expensive current_user query)
2013-05-13 11:07:22 +10:00
Sam
98d9f174ae
fix spec
2013-05-13 11:07:22 +10:00
Robin Ward
8900ba4779
Fixes staticController bug with requiring an HTML response.
2013-05-10 18:52:10 -04:00
Robin Ward
2f3dc63dd3
FIX: Oneboxes weren't being rendered
2013-05-10 18:50:05 -04:00
Robin Ward
cf01c98d81
Experimental: Interface to Move Posts to an Existing Topic
2013-05-10 14:55:51 -04:00
Régis Hanol
8ebed7a4b1
FIX: user education displays [object Object]
2013-05-10 15:15:21 +02:00
Sam
942f168ab6
UI still a tad rough, but we have a first pass of secure categories
2013-05-10 16:47:47 +10:00
Sam
5280b3a01b
more group progress, UI getting there, controller mostly done
...
changed it so notify moderators goes to the moderators group
allow admins to grant self moderation and revoke self moderation
2013-05-09 17:37:34 +10:00
Sam
4f328e3e45
+x on files makes no sense unless they really are executable
...
rails in the script dir makes no sense, use binstubs or bundler instead
2013-05-09 17:35:15 +10:00
Sam
0f0fd281a8
group progress, never email banned users
2013-05-09 11:34:58 +10:00
Robin Ward
c1185d92eb
Trivial: Remove extra comma
2013-05-08 12:13:23 -04:00
Robin Ward
0d8c962fdf
Fix: Multi-Select should close when an operation succeeds. A little refactoring, too.
2013-05-08 12:04:10 -04:00
Robin Ward
4e16badeae
Merge pull request #833 from kubabrecka/admin_api_l10n
...
Localize admin API section
2013-05-08 07:39:02 -07:00
Neil Lalonde
f35a44aeae
Add ability for admins and mods to send another activation email to a user, to activate an account, and deactivate an account
2013-05-08 10:10:47 -04:00
Kuba Brecka
05bc63b102
Localize admin API section
2013-05-08 09:13:10 +02:00
Sam
6b536dcde5
work in progress ... groups
2013-05-08 15:20:38 +10:00
Sam
7571152d1d
fix issue adding users to groups
2013-05-08 10:32:29 +10:00
Robin Ward
6843ba7ed6
Fix regression: default to JSON type on GET requests.
2013-05-07 17:17:21 -04:00
Neil Lalonde
52ee1928cc
Oops, I made a spec fail by refactoring after I made the test pass and didn't check the tests
2013-05-07 15:40:18 -04:00
Neil Lalonde
8e24a608b0
Show empty categories on categories page to people people who can edit and delete categories
2013-05-07 15:31:56 -04:00
Robin Ward
bd99d5a40c
Calls to Discourse.ajax no longer need getURL -- will be done automatically.
2013-05-07 15:16:27 -04:00
Robin Ward
0b4fc5d81c
Deprecate success and error in Discourse.ajax
2013-05-07 11:25:21 -04:00
Robin Ward
6cbcd6e4a6
The last of the callback style AJAX have been converted to promises.
2013-05-07 10:58:41 -04:00
Robin Ward
dfd423a188
Thanks JSHINT!
2013-05-07 10:33:04 -04:00
Robin Ward
be191a95da
More promises instead of callbacks.
2013-05-07 10:27:12 -04:00
Robin Ward
4200f4107b
Merge branch 'master' of github.com:discourse/discourse
2013-05-07 10:27:09 -04:00
Régis Hanol
4606cb4f3b
FIX: hide/show preview in composer preference is saved in local storage
2013-05-07 12:34:47 +02:00
Sam
20493106cd
fix post trashing
2013-05-07 17:56:56 +10:00
Sam
a232e77fa8
whitspace
2013-05-07 17:33:04 +10:00
Jeff Atwood
3bfd3c9723
Merge pull request #825 from ZogStriP/do-not-show-clic-count-in-category-tag
...
do not show the clic count in category tag
2013-05-06 21:56:04 -07:00
Sam
e9fc272db7
remove acts_as_paranoid, use .trash! , .recover! and .with_deleted as needed
...
makes upgrading to rails 4 possible
2013-05-07 14:39:01 +10:00
Robin Ward
397553e29c
More promises instead of callbacks.
2013-05-06 14:44:19 -04:00
Robin Ward
a71a15913c
Site Customization saving should use a promise instead of success callback.
2013-05-06 14:20:20 -04:00
Régis Hanol
53a430be9d
do not show the clic count in category tag
2013-05-06 19:40:39 +02:00
Neil Lalonde
e70526d851
Fix links to user pages on dashboard
2013-05-06 12:15:25 -04:00
Neil Lalonde
69be7d0ad1
Change the title Visits to Clicks in referral tables on admin dashboard
2013-05-06 11:56:35 -04:00
Neil Lalonde
b944157d88
Fix edit uncategorized when on the /category/uncategorized page
2013-05-06 11:22:58 -04:00
Sam
be1ab8b275
automatic group infrustructure
2013-05-06 14:49:56 +10:00
Sam
9b1263bb3e
Merge pull request #817 from ZogStriP/prevent-duplicates-actions-on-a-post
...
prevent duplicate actions on a post
2013-05-05 17:50:53 -07:00
Régis Hanol
4470c05457
prepend the username in the participant alt-text in the topic list
2013-05-06 01:00:44 +02:00
Régis Hanol
392b9696f4
prevent duplicate actions on a post
2013-05-04 02:52:45 +02:00
Neil Lalonde
5b33992604
Fix a case when editing uncategorized all the hidden form controls become visible
2013-05-03 18:58:07 -04:00
Neil Lalonde
52942d2de6
Merge pull request #813 from slainer68/ga_domain_name
...
Google Analytics Domain name site setting
2013-05-03 14:57:01 -07:00
Neil Lalonde
c6370a3479
Add ability to edit the uncategorized category name, color, and text_color in a modal
2013-05-03 17:55:04 -04:00
slainer68
ac66f25043
Google Analytics Domain name site setting
2013-05-03 21:58:10 +02:00
Neil Lalonde
16bc215c68
Make enter key work to submit the signup form
2013-05-03 12:33:08 -04:00
Neil Lalonde
3c322e6d3d
Reply button at bottom of topic doesn't ask you to abandon your post when you click it more than once
2013-05-03 12:13:34 -04:00
Sam
42494b5bb1
we can't trust CSRF for anon the way it is designed.
...
The page they have loaded may be cached we need a different way of delivering the CSRF potentially
2013-05-03 16:43:11 +10:00
Régis Hanol
63b221970d
Add a clear pin link in the list topics view
2013-05-02 23:31:43 +02:00
Neil Lalonde
7b44c83b50
Trying to improve dashboard layout with the referral stats on the right
2013-05-02 11:52:37 -04:00
Sam
40f631b5c1
fix style
2013-05-02 22:29:45 +10:00
Sam
99283e757f
staff rename forgotten
2013-05-02 20:08:32 +10:00
Sam
cb9a89940a
display admin/mod status on user page
2013-05-02 17:40:44 +10:00
Sam
5ec52bd2e9
:s/moderator?/staff/g ... our naming was kind of crazy, renamed moderator? to staff
2013-05-02 17:22:27 +10:00
Sam
65cd00cf25
moderators now have teeth, more at http://meta.discourse.org/t/moderator-permission-set/6307/5
...
allow pms to be targetted at groups
2013-05-02 15:15:53 +10:00
Sam
e59ab32210
Merge pull request #800 from goodbrews/imgur-api-v3
...
Update to Imgur API v3
2013-05-01 21:52:00 -07:00
David Celis
6be26f5316
Update to Imgur API v3
...
Version 2 of Imgur's API is deprecated. Their documentation for v2 is no
longer online, and applications can only be registered under version 3.
Version 3 of their API has a slightly different endpoint but, more
importantly, uses a Client ID/Secret pair instead of an API Key.
This PR updates Discourse to use the new version of Imgur's API.
Signed-off-by: David Celis <me@davidcel.is>
2013-05-01 21:39:10 -07:00
Régis Hanol
f71f7d166c
FIX: when topic is closed, you can still invite someone to reply
2013-05-02 02:22:54 +02:00
Sam
72aee82a07
Merge pull request #803 from ZogStriP/remove-rounded-corners-on-images-in-posts
...
removes rounded corners on images in posts
2013-05-01 16:27:13 -07:00
Régis Hanol
f67f62ccb2
removes rounded corners on images in posts
2013-05-02 01:20:12 +02:00
Neil Lalonde
3c7afeb233
Fix incoming links dashboard data when topic record can't be found
2013-05-01 19:10:31 -04:00
Neil Lalonde
38ed86d0c5
Add reports for IncomingLinks on admin dashboard
2013-05-01 18:12:02 -04:00
Neil Lalonde
5f4dbd6ddc
Use tos_url site setting in flag modal if it's set
2013-05-01 11:49:18 -04:00
Sam
e4a76812a6
this is a slightly round about way of making our self oneboxes sane
...
shrunk avatar to 60px, added global whitelisting
2013-05-01 16:38:13 +10:00
Sam
e5c5c0bbb3
no_js to use site customisations
2013-05-01 11:04:47 +10:00
Sam
08ce46e7ed
:s/POST/REPLY/g
2013-05-01 10:52:31 +10:00
Sam
7276542231
firefox used to display "loading..." on back sometimes
2013-05-01 09:49:28 +10:00
Sam
58dbfa1b91
Merge pull request #796 from ZogStriP/fix-shift-clicks-on-links
...
FIX: shift+click on links
2013-04-30 16:02:24 -07:00
Jeff Atwood
180c021940
normalize on "private message" vs "conversation"
2013-04-30 13:54:14 -07:00
Jeff Atwood
51f16333be
increase default max_likes to 50
...
WE LIKE LIKES MAN
2013-04-30 12:45:27 -07:00
Neil Lalonde
20d73a4151
Fix bookmarks admin dashboard counts to include bookmarks that were deleted
2013-04-30 12:52:12 -04:00
Neil Lalonde
6f0d68fe5f
Align star to the top of the line in topic list for topics showing excerpts
2013-04-30 12:35:41 -04:00
Régis Hanol
ff309cf024
FIX: shift+click on links
...
Default browser's behavior when shift+clicking was messed up.
This adds the shift key modifier to the list of click modifiers in both
`click_track` and `discourse`.
Also updated & refactored a bit the `click_track_spec`.
2013-04-30 15:48:58 +02:00
Fayimora Femi-Balogun
0cdeb88f29
Fix misspelling
2013-04-30 11:09:30 +02:00
Sam
cef9a74053
route for markdown /md/topic_id/post_number
2013-04-30 16:30:41 +10:00
Sam
8a04cc05aa
render :json appears to have changed ... this is odd ... better add some tests
2013-04-30 14:01:34 +10:00
Sam
855ba562ac
api was not showing api key cause model in ember is just partial advice that is sometimes followed up
2013-04-30 13:49:01 +10:00
Sam
b25a5a20bb
option to strip links from excerpts
2013-04-30 13:25:55 +10:00
Sam
fc56e51cc6
Merge pull request #792 from ZogStriP/fix-shift-click-to-select-text-does-not-work-in-topics
...
FIX: Shift+Click to select text does not work in topics
2013-04-29 19:35:13 -07:00
Régis Hanol
52bad538a1
FIX: Shift+Click to select text does not work in topics
2013-04-30 03:16:38 +02:00
Régis Hanol
017ee7c2da
FIX: [security bug] XHR check bypass
2013-04-30 02:34:19 +02:00
