Sam
fc3c93d237
almost fixed the regression of not allowing top level filters
2013-05-24 09:54:39 +10:00
Robin Ward
84fd366322
Navigating should set a searchContext (unused right now).
2013-05-23 18:51:40 -04:00
Robin Ward
eb0c102931
Migration logic from SearchView to a controller, where it should be.
2013-05-23 17:42:57 -04:00
Neil Lalonde
4492d06a9f
Don't send notifications for moderator action posts
2013-05-23 11:42:52 -04:00
Robin Ward
0bd61df34c
Merge pull request #884 from mattvanhorn/refactor_topic
...
Refactor topic
2013-05-23 07:26:22 -07:00
Matt Van Horn
c4b5821ef8
Revert annotation and non-English I18n changes
2013-05-23 06:44:47 -07:00
Sam
3dfc034e8d
Merge pull request #881 from novemberkilo/master
...
Improve flog metric for Post#extract_quoted_post_numbers
2013-05-23 00:21:27 -07:00
Matt Van Horn
7271b90655
annotate topic model
2013-05-22 22:36:01 -07:00
Matt Van Horn
806255b3c4
refactor Topic validation
...
introduce a couple of custom validators
fix minor discrepancies in tests
copy I18n error message keys to default location
clean up validation invocation
move some responsibilities out of validator into class
2013-05-22 22:31:52 -07:00
Sam
fcc7192fd2
User tracking state implementation progress for live unread / new counts
2013-05-23 15:22:06 +10:00
Robin Ward
7a31630837
Search Refactor: Remove some manual SQL, make search data tables more idomatic Rails/AR
2013-05-22 16:31:13 -04:00
Navin
4754216369
Simplify branching
2013-05-22 21:45:31 +02:00
Navin
ef93512de8
Extract quote parsing into a method
2013-05-22 21:38:45 +02:00
Robin Ward
b9a310f4b1
Search Refactor: Let's use a class to keep track of our state rather
...
than passing params everywhere. Also make the private API private.
2013-05-22 15:22:06 -04:00
Robin Ward
0f296cd42b
Refactor + Fix: Wasn't correctly loading activity streams. Code is a lot more Ember-y now.
2013-05-22 12:06:37 -04:00
Matt Van Horn
872995db57
refactor guardian class for clarity & correctness
...
introduce NullUser to avoid type-checking
DRY up code
reduce number of multiple returns
remove some redundant/impossible logic branches
add pending test for possible bug
add test & fix for ability to flag archived posts
add #secure_category? method to topic class
Fix bug that prevented flagging of archived topics
Rename NullUser to AnonymousUser
DRY up can_<action>? methods
Fix some ownership logic, and a test, for Guardian
2013-05-22 01:09:34 -07:00
Sam
96f8d79e83
Merge pull request #876 from chrishunt/chrishunt/observe-changes-for-topic-users
...
Trigger UserActionObserver when updating TopicUser
2013-05-21 23:02:27 -07:00
Sam
c4d8085fc5
remove moderator status posts from best feed
2013-05-22 15:04:53 +10:00
Chris Hunt
d0bc8c95d3
Trigger UserActionObserver when tracking visit
2013-05-21 20:45:03 -07:00
Chris Hunt
685f4960f1
Trigger UserActionObserver when updating TopicUser
2013-05-21 20:43:43 -07:00
Robin Ward
45361934b9
User the BasicUserSerializer for the invited user
2013-05-21 12:03:51 -04:00
Robin Ward
046e6e5d86
Simplified grouping on user views, fixed issue with messages not loading on initial load. Really
...
simplified the restricted user route.
2013-05-21 11:50:01 -04:00
Robin Ward
27828c5ec2
Merge pull request #871 from avdi/refactoring-with-josh-and-avdi
...
Various refactorings towards Ruby/Rails idiom from Josh Susser and Avdi Grimm
2013-05-21 07:18:50 -07:00
Sam
b5eff93a9d
update message bus to support per client filtering
...
start work on user_tracking_state
fix can_ban? in guardian
expose protected scopes on topic_query we need
move guardian spec to use build as opposed to creating topics / posts / users
start work on user tracking spec
2013-05-21 16:39:51 +10:00
Jeff Atwood
7e3e6ab78d
icon tweak on merge/split
2013-05-20 12:34:15 -07:00
Robin Ward
dee45d8dba
Changed elementId to be id
2013-05-20 15:31:05 -04:00
Robin Ward
42248a7164
Removed many unnecessary paths that included content.x when just x would do.
2013-05-20 15:27:58 -04:00
Robin Ward
9544cfd7dc
target="controller" is unnecessary. By default it will target the controller.
2013-05-20 14:37:05 -04:00
Robin Ward
a79d53c628
Removed many unnecessary controller. uses in templates.
2013-05-20 13:45:14 -04:00
Robin Ward
c7aebbf4d6
Replace Ember.Text* insertions with helpers.
2013-05-20 12:56:36 -04:00
Robin Ward
1097d51b33
Replaced {{view Discourse.TextField}} with {{textfield}} helper.
2013-05-20 12:47:59 -04:00
Robin Ward
b794830a25
Replaced Em.run.next with the more proper Em.run.schedule('afterRender')
...
when we are waiting for rendering to finish.
2013-05-20 12:20:10 -04:00
Sam
a3dce9afd7
don't error out on not posts if its a json request
2013-05-20 17:32:53 +10:00
Sam
fc57578c85
proper 404 for json request 404
2013-05-20 17:28:32 +10:00
Sam
e91ed83586
the private message stream is different to normal streams, improving the ui a bit and collapsing conversations
2013-05-20 16:44:06 +10:00
Sam
80fb20816c
get rid of nonsense 404.html
...
correct 404 handling for invalid pages
2013-05-20 10:29:49 +10:00
Sam
18b00d01d0
Merge pull request #859 from lengarvey/user_refactoring
...
Light refactoring of the User model
2013-05-19 16:41:20 -07:00
Neil Lalonde
5f7f87437c
Fix for topic excerpt being from the wrong post
2013-05-18 13:35:21 -04:00
Leonard Garvey
b16705be0d
Clean up update_visit_record!
...
update_visit_record! appears to add user_visit record if one
doesn't exist and days_visited is simply a counter for the number
of visit records.
2013-05-18 16:02:06 +10:00
Leonard Garvey
32f4dfd2fb
DRY up the user model slightly
...
regular? is just the inverse of staff?
2013-05-18 16:00:35 +10:00
Sam
25105082d5
Merge pull request #850 from bplexico/refactor_post_rb
...
Refactored post model to reduce duplication in validator methods
2013-05-17 15:56:53 -07:00
Neil Lalonde
546a2b654a
Improve style of security tab of category modal
2013-05-17 16:09:52 -04:00
Josh Susser and Avdi Grimm
2acc80d192
Various idiomatic User refactorings.
2013-05-17 15:44:35 -04:00
Josh Susser and Avdi Grimm
5659b66729
Refactor select().map() to use pluck.
...
Remove a method already provided by ActiveRecord.
2013-05-17 15:11:37 -04:00
Neil Lalonde
191d454589
Show Inbox before Sent Items
2013-05-17 14:11:33 -04:00
Josh Susser and Avdi Grimm
d30330441a
Refactored conditional to an || to be more idiomatic.
2013-05-17 14:06:58 -04:00
Brian Plexico
a86646312b
Refactored post model to reduce duplication in validator methods
2013-05-17 12:15:21 -04:00
Neil Lalonde
2265c046ba
Some tweaks to category modal
2013-05-17 11:19:58 -04:00
Neil Lalonde
f3282e33a3
Add tabs to category create/edit modal. Categories can have a default auto-close setting that applies to all new topics created in the category. Add rspec-given and write some integration tests. Tests for topic auto-close with category default
2013-05-17 11:05:35 -04:00
Sam
8f46653345
refactor
2013-05-17 09:03:52 +10:00
