Robin Ward
85c6eb9b08
SECURITY: Only redirect to our host by path on the login action
2014-08-28 17:45:13 -04:00
riking
8ddd90daa4
Have parse_body() recover from ASCII-8BIT encoding
...
Added a test to make sure that the result can be passed into TextCleaner
(which expects UTF-8)
2014-08-28 14:38:19 -07:00
riking
1c9f6159cd
Update the Receiver and PollMailbox specs for the changes
...
Tests are both added, moved, and deleted.
Add test for topic not being created
Move html_only.eml to parse_body testing section
2014-08-28 14:38:19 -07:00
riking
0a09593f3b
FIX: Prefer HTML in incoming emails, heavily refactor email receiver
...
This commit heavily refactors Email::Receiver to both better handle
different emails and improve testability.
A primary focus of the refactor is reducing the usage of class
variables, in favor of actually passing parameters - making it possible
for multiple tests to use the same Receiver instance.
The EmailLog reported when a topic is created is reflected to put the
user's email in the to_address field, instead of the system address.
The discourse_email_parser function is renamed to
discourse_email_trimmer, and additional stopping conditions are added to
make up for EmailReplyParser's inability to deal with html at the start
of a line.
The force_encoding calls are refactored out to a 'fix_charset' method.
parse_body is renamed to select_body, and the scrub_html method is
dropped in favor of the new HtmlCleaner class.
A new parse_body method is added, which performs the job of the removed
lines of code in the 'process' method.
EmailUnparsableError is redefined again, to be encoding errors (when the
declared encoding is not what was delivered).
2014-08-28 14:36:10 -07:00
riking
cb55ef4702
Add Email::HtmlCleaner for email processing
...
This class is in charge of stripping out most of the crap from the HTML
portion of emails that email clients generate, so that it can be sanely
post-processed for signatures and quoting boundaries.
2014-08-28 14:36:10 -07:00
riking
0d0225133c
FIX: Failed incoming emails could create empty topics
...
A failure condition is eliminated where a topic would be created, but post
creation would fail, leaving the forum with a topic without any posts.
By asking PostCreator to create the topic instead, inside of its
transaction, this failure condition is eliminated.
Additionally, attachments are restored to working status. Previously,
the attachment code would build up the post raw, but then drop it and
not do anything with the result (creating orphaned uploads). By actually
placing the raw value back in the options hash, it is included in the
created post.
2014-08-28 14:35:43 -07:00
Robin Ward
9e2c72e277
Allow restoring from backups in development mode even if the setting is
...
off.
2014-08-28 17:02:48 -04:00
Neil Lalonde
464a922910
FIX: permalinks table: increase limit of url column, make url index unique
2014-08-28 16:16:39 -04:00
cpradio
1acb2a13f1
Added a:first
2014-08-28 16:06:48 -04:00
cpradio
4fd73a2b2f
Set focus on site-map and user menu
...
Set focus on first item in the site-map and user drop down for keyboard users, so they can quickly tab to the link/item of their choosing.
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
2014-08-28 16:04:54 -04:00
Neil Lalonde
14890a6002
FEATURE: add a way to map arbitrary urls to a topic, post, or category. Useful for sites that have migrated to Discourse and want to redirect from their old site to Discourse with 301 redirects.
2014-08-28 15:58:24 -04:00
Robin Ward
8a6c4234fc
FIX: Re-enable searching for topic by id when using the split topic
...
interface.
2014-08-28 15:42:29 -04:00
Robin Ward
b5b13b8c5f
Revert "Merge pull request #2713 from cpradio/master"
...
This reverts commit a9de189682b7ab43e454
2014-08-28 15:08:06 -04:00
Robin Ward
a9de189682
Merge pull request #2713 from cpradio/master
...
Set focus on first item in drop down (textbox, link, whatever it may be)
2014-08-28 14:47:38 -04:00
Robin Ward
b7ab43e454
Merge pull request #2714 from techAPJ/patch-3
...
Update onebox gem
2014-08-28 14:45:27 -04:00
Robin Ward
8bf27642ad
FIX: Refresh was losing top controls after bulk operation. Removed
...
console.log
2014-08-28 14:44:38 -04:00
Robin Ward
69cb5bc425
FIX: Centralize Top rendering, remove old code paths. Fix some bugs.
2014-08-28 14:34:31 -04:00
Arpit Jalan
30e034aa53
Update onebox gem
2014-08-28 23:50:46 +05:30
riking
9090df63ba
Fix pop3 settings in locale file
2014-08-28 10:45:40 -07:00
Robin Ward
30b102aa98
FIX: Show uncategorized with badge/description in the category chooser
2014-08-28 12:42:31 -04:00
Robin Ward
c9262a8390
FIX: Resend activation email was busted
2014-08-28 12:07:13 -04:00
cpradio
a40b08f210
Set focus on first item in drop down (textbox, link, whatever it may be)
...
Set focus on first item in the drop down for keyboard users, so they can quickly tab to the link/item of their choosing.
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
2014-08-28 11:33:45 -04:00
Robin Ward
aed0285bc6
Update onebox gem
2014-08-28 11:28:46 -04:00
Régis Hanol
38f52f0f8e
FIX: banner topic's max-width & max-height on both mobile & desktop
2014-08-28 16:15:48 +02:00
Sam
a1244043d3
FIX: when search finds a deep link in a topic it takes you to it
2014-08-28 17:16:39 +10:00
Sam
9897660a36
Merge pull request #2710 from techAPJ/patch-2
...
Update Translations
2014-08-28 16:30:45 +10:00
Arpit Jalan
be8249f113
Update Translations
2014-08-28 08:52:11 +05:30
Sam
3a9f0445bb
HACK: remove jarring scroll when hitting back from topic
2014-08-28 11:57:24 +10:00
Robin Ward
fc71662a13
FIX: Don't show topics as unread when hitting back
2014-08-27 18:01:02 -04:00
Robin Ward
0ae3c327de
Add a message to the staff logs indicating why a user was purged
2014-08-27 16:05:07 -04:00
Neil Lalonde
940c0d5dbb
FIX: topicCountStats was depending on the wrong properties
2014-08-27 15:58:32 -04:00
Neil Lalonde
99d26cef1a
FIX: uncategorized counts were always 0. topics_year, topics_month, topics_week, topics_day
2014-08-27 15:58:32 -04:00
Robin Ward
f05d2ed7cf
PERF: Do far fewer checks and use a lot less memory when loading more
2014-08-27 15:31:06 -04:00
Robin Ward
965ff51efe
FIX: Better boundary checking for emoji
2014-08-27 14:40:29 -04:00
Robin Ward
aab8eaac03
FIX: Double clicking quote expansion shouldn't break stuff.
2014-08-27 14:04:00 -04:00
Robin Ward
09ea159afc
UX: Add link to change username on admin page
2014-08-27 13:52:01 -04:00
Robin Ward
b1c0a3d01c
FIX: Retain back button scroll position even if we don't load more.
2014-08-27 13:33:52 -04:00
Robin Ward
f10d6ed88a
FIX: RSS feeds should use created_at not bumped_at
2014-08-27 12:42:54 -04:00
Robin Ward
bf8528b6ec
FIX: Use the bumped_at date for the RSS feed for a topic
2014-08-27 12:34:47 -04:00
Robin Ward
443f3812ab
Merge pull request #2709 from techAPJ/patch-2
...
FIX: allow localization in timestamp
2014-08-27 11:46:21 -04:00
Arpit Jalan
3a76f9e79f
FIX: allow localization in timestamp
2014-08-27 20:57:06 +05:30
Wilhansen Li
bba3f7c0ac
Fix SSO avatar downloading issues.
...
* Follow redirects when downloading SSO avatars.
* Add proper image ext. to downloaded SSO avatars.
2014-08-27 21:35:54 +08:00
Eyal Levin
e0c2f3df3a
Enable RTL direction in emails.
2014-08-27 14:38:03 +03:00
Jeff Atwood
009dc7ded3
missed a spot in CSS
2014-08-27 02:58:32 -07:00
Jeff Atwood
f557f7eeb9
change fix for [quote] padding
2014-08-27 02:45:57 -07:00
Jeff Atwood
dc6dd26b10
FIX: [quote][/quote] missing top padding
2014-08-27 02:22:58 -07:00
Sam
87d2be3ecf
FIX: ensure triggered badges are never triggered if filter is missing
2014-08-27 18:02:13 +10:00
Sam
f48b78c0bb
FEATURE: Allow localization sessions
...
use: I18n.verbose_localization_session()
2014-08-27 17:50:29 +10:00
Jeff Atwood
587f7f56c8
FIX: share link pushing viewport on mobile
2014-08-27 00:46:26 -07:00
Jeff Atwood
b3d896723b
Merge pull request #2706 from techAPJ/patch-2
...
FIX: use short date format for timestamp
2014-08-27 00:42:56 -07:00
