Commit graph

3783 commits

Author SHA1 Message Date
Robin Ward
e8522e839b FIX: undefined label on Top dropdown on mobile 2014-09-22 12:23:37 -04:00
Robin Ward
626e896c13 FEATURE: Enable topic entrance on mobile 2014-09-22 11:49:11 -04:00
Sam
7ae72dc2ff FIX: while header drop down is dropped, header is in front 2014-09-22 12:38:48 +10:00
Sam
fd5dde4ab5 Merge pull request #2811 from Elberet/fix-bbcode-blocks
FIX: BBCode blocks parser no longer mangles JsonML arrays
2014-09-22 12:01:09 +10:00
Sam
cfa0d66548 Merge pull request #2807 from techAPJ/patch-2
UX: show category when moving post to exisiting topic
2014-09-22 11:59:02 +10:00
Sam
aa39a3b4b0 Merge pull request #2810 from cpradio/opera-composer-keyboard-shortucts
FIX: Opera Composer Keyboard Shortcuts
2014-09-22 11:50:14 +10:00
Jens Maier
9cca64cf69 FIX: BBCode blocks parser no longer mangles JsonML arrays 2014-09-22 03:27:39 +02:00
Gerhard Schlager
a6714e252e FIX: Category creation failed when translation was missing 2014-09-20 22:06:00 +02:00
cpradio
9e3060a6f7 FIX: Opera Improvements (v12)
Fix issues with Opera 12 and its ability to utilize Discourse Composer window
https://meta.discourse.org/t/support-for-opera/20218
2014-09-19 22:47:27 -04:00
Arpit Jalan
ae8f7748f8 UX: show category when moving post to exisiting topic 2014-09-19 21:00:35 +05:30
Sam
14936ed9c9 Merge pull request #2795 from lidlanca/fix-link-release
Fix: Cancel link click if triggered as part of text selection
2014-09-19 13:35:13 +10:00
Sam
bf51fbf030 Merge pull request #2806 from Elberet/fix-escape-single-quotes
FIX: double-escaped single quotes in URLs
2014-09-19 13:32:43 +10:00
Jeff Atwood
6aff562883 UX: gutter links use link color, no glyphs 2014-09-18 20:01:49 -07:00
Sam Saffron
5132f217c4 FIX: link to sub category not working in search 2014-09-19 12:55:30 +10:00
Jens Maier
543bc53598 FIX: double-escaped single quotes in URLs 2014-09-18 22:07:42 +02:00
Neil Lalonde
c4e285f3ec SECURITY: rate limit change email requests 2014-09-18 10:48:56 -04:00
Sam Saffron
b0875f8332 Revert "Revert "FEATURE: fenced code blocks can hint with "pre" or "text"""
This reverts commit 4487d6a4c2.
2014-09-18 15:15:42 +10:00
Robin Ward
4487d6a4c2 Revert "FEATURE: fenced code blocks can hint with "pre" or "text""
This reverts commit 943ad8d1d5.
2014-09-17 12:17:32 -04:00
Robin Ward
c16b8364ab FIX: Support ember app routing to topics with only slugs 2014-09-17 11:18:59 -04:00
Sam Saffron
943ad8d1d5 FEATURE: fenced code blocks can hint with "pre" or "text"
Use ```pre or ```text for unhiglighted code blocks
2014-09-17 01:40:10 +10:00
Sam Saffron
b62aaf5a53 FEATURE: display reply to post on mobile 2014-09-17 01:20:15 +10:00
Sam
0855fe5438 Merge pull request #2798 from lidlanca/patch-3
Fix: rapid/continuous keyboard Next event under Topics List view may lose selected item on "load more"
2014-09-17 00:25:12 +10:00
Sam
a3276c042d Merge pull request #2802 from cpradio/firefox-use-k-to-scroll-up
FIX: Firefox - Topic List Keyboard shortcut Previous(K) does not scroll properly leaving selected item hidden
2014-09-17 00:20:48 +10:00
Sam
9ace1521f6 Merge pull request #2797 from fantasticfears/master
return true when invoke verbose_localization_session
2014-09-16 14:42:46 +10:00
cpradio
eaf0cf0519 FIX: Using k on Firefox to navigate up the topic list
Using k wouldn't always bring the topic in focus as you moved up the topic list
https://meta.discourse.org/t/topic-list-keyboard-shortcut-previous-k-does-not-scroll-properly-leaving-selected-item-hidden-firefox/20050
2014-09-15 21:10:24 -04:00
Sam Saffron
bb64c2236b SECURITY: Escape strings in logs 2014-09-16 07:53:17 +10:00
lidlanca
e277287b2e Fix: rapid/continuous keyboard Next event under Topics List view may lose selected item on "load more"
Using Next keyboard shortcut (J) rapidly while reaching last item in the topic list and
causing a "load more". The handler might get into a state where it can not detect any selected item due to the delay from Em.run.next
and will result in position reset.

+added boundary check of last item on next, early in the handler to avoid unnecessary computations 


https://meta.discourse.org/t/keyboard-shortcut-next-previous-continues-key-down-reset-to-first-item-in-list-on-load-more/20042
2014-09-13 23:59:20 -04:00
Erick Guan
bd59a5caba return true when invoke verbose_localization_session 2014-09-14 10:10:48 +08:00
lidlanca
13cedce0cf Fix: Cancel link click if triggered as part of text selection
Prevent a click if the user select content in a topic and release the mouse over a link.

https://meta.discourse.org/t/selecting-a-link-results-in-it-being-opened/14846
2014-09-13 04:05:03 -04:00
Robin Ward
0c32bf9c34 Removed stupid {{log}} message that I left in because I'm stupid. 2014-09-12 16:29:25 -04:00
Robin Ward
46d8db3d70 Use dashed names for all templates when using {{render}} for future
Ember compatibility
2014-09-12 15:03:33 -04:00
Robin Ward
22fd7fb07d Better resolver support for underscored templates. Eventually we'll
migrate to dashed only.
2014-09-12 14:44:35 -04:00
Robin Ward
1de9c3b04a Migrate more helpers to ES6 format. 2014-09-12 14:27:34 -04:00
Robin Ward
6f149edecc FIX: Scroll position when hitting back button to category filter 2014-09-12 14:07:04 -04:00
Zane Beckman
216ee9f2f1 Add css selector for 'star' th element
Allows custom css rules to hide this column.
2014-09-12 11:04:47 -04:00
Martin Feckie
b266b16b6a Make style more consistent with rest of site 2014-09-12 16:44:40 +08:00
Robin Ward
fbf86c4e2e FIX: Badge scroll position 2014-09-11 17:50:47 -04:00
Robin Ward
e1826e3025 Remove constants from initializers 2014-09-11 17:50:47 -04:00
Neil Lalonde
9b5f506339 FIX: in activity stream, move category badge to be under topic title. Long titles could cause it to be cut off. Category badge replaces the text that was there. 2014-09-11 17:26:09 -04:00
Robin Ward
52094fe554 Remove the last of the Discourse globals in our templates 2014-09-11 17:13:03 -04:00
Robin Ward
cedc409461 Remove deprecation notices for Discourse.banner 2014-09-11 17:01:35 -04:00
Robin Ward
f322b500a7 Replaced many global Discourse.SiteSetting calls in templates with
computed properties due to deprecations.
2014-09-11 16:46:34 -04:00
Robin Ward
8559bbe508 Remove many usages of Discourse in templates as it's deprecated in new
releases of Ember
2014-09-11 16:30:47 -04:00
Robin Ward
af6936cf72 Refactor some deprecations for newer versions of Ember. Also set up
injection for some globals so we can migrate away from them.
2014-09-11 16:16:21 -04:00
Jeff Atwood
0446a0e19e set maxlength="200" attrib on password field 2014-09-11 12:41:03 -07:00
Neil Lalonde
d492bac587 Remove the git commits widget from the admin dashboard 2014-09-11 14:45:42 -04:00
Robin Ward
15936f4742 Use the {{fa-icon}} helper on user expansion 2014-09-11 14:42:45 -04:00
Robin Ward
3c26bca56a Migrated more helpers to ES6 preferred format 2014-09-11 13:32:57 -04:00
Robin Ward
d010eee5d8 Remove unused titled-link-to helper 2014-09-11 13:14:11 -04:00
Robin Ward
ad813e57ec FIX: Badges scrolling 2014-09-11 13:10:54 -04:00
Robin Ward
57e3865d18 FIX: Scroll position when using the back button 2014-09-11 13:06:01 -04:00
Robin Ward
4a3e46ee4a Merge pull request #2783 from chapel/proper-responsive-extra-info
Make extra info header properly responseive
2014-09-11 12:42:34 -04:00
Neil Lalonde
dd8e7fd7d1 Use a label tag on the checkbox for 'I have read and accept the TOS' 2014-09-11 11:11:14 -04:00
Neil Lalonde
91d114756c FIX: don't always say that an email is not verified in admin 2014-09-11 10:58:07 -04:00
Régis Hanol
9a668a7e7b FIX: clear selection when transitioning out of a topic 2014-09-11 16:35:04 +02:00
Régis Hanol
e56fcf0c43 FEATURE: add 'rebake post' in post wrench menu 2014-09-11 16:04:40 +02:00
Jacob Chapel
0d0d9adb80 FIX: Make extra info header properly responseive
The current solution assumed the width of the logo which caused
the user info and icons bar to shift down when the title is shown.

This fixes that by making the extra info wrapper responsive
and use up the full width, not needing manual breakpoints.
2014-09-11 01:21:19 -07:00
Sam
61bcde6284 FEATURE: inform users if forgot password works or not
FIX: flash dialog in forgot password often had wrong color

(this can be disabled by setting forgot_password_verbose to false)
2014-09-11 12:04:44 +10:00
Sam
306d31b92e fix test 2014-09-11 11:15:49 +10:00
Sam
5cb7c8ee11 FEATURE: suppress admin glyph for admins
If you want to a shield you must grant moderation to the admin.
2014-09-11 10:54:25 +10:00
Sam
70eb7b8fdf FEATURE: All on user page is now only should posts + topics 2014-09-11 10:45:59 +10:00
cpradio
1ac7a8277d UX: Add Suspension Message to User Card
Add the suspension message to the user card of the user. This replaces the about me (bio) just like it does on their profile page.
https://meta.discourse.org/t/profile-page-on-mobile-selecting-menu-item-should-jump-to-the-selected-content/19896/2
2014-09-10 19:16:36 -04:00
Sam
fd29fe503d Merge pull request #2778 from Elberet/fix-parser-block-ordering
FIX: fix dialect block ordering
2014-09-11 08:14:17 +10:00
Régis Hanol
18f8038015 FEATURE: add new 'convert to staff message' in post wrench menu 2014-09-10 23:08:33 +02:00
Robin Ward
ffc136e9ac FIX: Category topic new posts were the wrong color 2014-09-10 16:10:49 -04:00
Robin Ward
5dea3720a4 FIX: Only use cached list when we have less than 1 page worth of topics.
We only need it then to maintain the scroll position.
2014-09-10 15:17:51 -04:00
Régis Hanol
dbcaf1276a FIX: move wiki/via-email glyphs + add green background on wiki posts 2014-09-10 15:25:31 +02:00
Jens Maier
30dbb570e5 FIX: fix dialect block ordering 2014-09-10 13:29:40 +02:00
Sam
b9c8ae588a minor refactor 2014-09-10 16:33:39 +10:00
riking
637371e60a Switch to count of all notifications 2014-09-09 20:13:36 -07:00
riking
bf06878601 FIX: Broken notification history 2014-09-09 17:25:25 -07:00
Sam
51d9a59d53 copy, "notification history" is just too long 2014-09-10 10:14:42 +10:00
riking
5994b630b7 Final dirty diff cleanup 2014-09-09 16:29:08 -07:00
riking
69bc552054 FEATURE: Actually show more notifications
The "Show more notifications..." link in the notifications dropdown now
links to /my/notifications, which is a historical view of all
notifications you have recieved.

Notification history is loaded in blocks of 60 at a time.

Admins can see others' notification history. (This was requested for
'debugging purposes', though that's what impersonation is for, IMO.)
2014-09-09 16:29:08 -07:00
Sam
5001e826ff Merge pull request #2756 from cpradio/add-go-to-top-shortcut
UX: Add g, t keyboard shortcut to modal window for go to top
2014-09-10 09:11:16 +10:00
Sam
4edbb5b98c Merge pull request #2773 from riking/post-handlebars
(Trivial) Handlebars structure tweaks to post.handlebars
2014-09-10 09:04:12 +10:00
Robin Ward
2d32325ac7 FIX: Show user expansion on user stream too 2014-09-09 17:55:55 -04:00
Robin Ward
62c9e4228d Rename {{icon}} helper to {{fa-icon}} for future Ember
compatibility.
2014-09-09 17:29:05 -04:00
Robin Ward
cec6b64a45 FIX: Don't show filter on user card if not in topic 2014-09-09 16:53:43 -04:00
Robin Ward
a09ff29dd9 UX: Only intercept Cmd-F/Ctrl-F for search on a topic when not all posts
are available in the DOM.
2014-09-09 16:05:17 -04:00
Robin Ward
504d61de94 FIX: Clicking on expanded user actions uses user expansion. Also added
integration test.
2014-09-09 15:18:04 -04:00
Régis Hanol
79030c874e FIX: allow staff members to restore withdrawn posts that are flagged 2014-09-09 20:26:40 +02:00
riking
7bb1b8bc97 Handlebars structure tweaks to post.handlebars
- Combine bind-attrs on the <article> (seriously that made no sense)
 - Hoist a bind-attr class to the view, allowing more fancy styling
 - Hoist a <div> outside a conditional
 - Change href='#' to unvalued hrefs
2014-09-09 11:20:25 -07:00
Robin Ward
8b33e659a1 FIX: Only use cached topic lists on popState 2014-09-09 12:57:51 -04:00
Robin Ward
a96ba8ed78 Revert "FIX: unread/new counts out of sync with tabs"
This reverts commit c093187d34.
2014-09-09 12:57:51 -04:00
Régis Hanol
eb34ecfc0c FEATURE: new 'prevent anons from download files' site setting 2014-09-09 18:41:13 +02:00
Régis Hanol
69bc24a16d FIX: clicking a button that disappears in a modal would close the modal (take 2) 2014-09-09 10:44:26 +02:00
Régis Hanol
357c43e941 FIX: clicking the 'edit permission' button would close the category modal 2014-09-09 10:16:12 +02:00
Sam
c093187d34 FIX: unread/new counts out of sync with tabs
We were serving cached lists of topics to non popstate reqs
2014-09-09 16:56:20 +10:00
Robin Ward
2f04b53c9f FIX: Clicking outside of modal wasn't closing it 2014-09-08 16:53:05 -04:00
Robin Ward
9d9d93ad3c Merge pull request #2771 from techAPJ/patch-1
Don't show new topic indicator on New tab
2014-09-08 15:35:23 -04:00
Arpit Jalan
80510c5114 Don't show new topic indicator on New tab 2014-09-09 01:02:16 +05:30
Robin Ward
56eda5abf9 FIX: Don't allow profile bios longer than 3k chars 2014-09-08 15:23:21 -04:00
Régis Hanol
948e0740c9 FEATURE: add glyphs in the composer 'save' button 2014-09-08 19:02:53 +02:00
Régis Hanol
ea6cab66cb FIX: remove curvy arrow on reply to topic button 2014-09-08 19:02:14 +02:00
Régis Hanol
00bd665c96 FEATURE: add count of previous flags on the post 2014-09-08 17:53:29 +02:00
Robin Ward
7d6f3a5089 FIX: Only show warning creation to staff. Server side was OK. 2014-09-08 11:22:11 -04:00
Robin Ward
334e21a03a Revert "Revert "FEATURE: Can create warnings for users via PM""
This reverts commit 1c7559380c.
2014-09-08 11:11:56 -04:00
Robin Ward
1c7559380c Revert "FEATURE: Can create warnings for users via PM"
This reverts commit b0bfc1f93f.
2014-09-08 10:38:59 -04:00
Robin Ward
b0bfc1f93f FEATURE: Can create warnings for users via PM 2014-09-08 10:27:06 -04:00
Jeff Atwood
9b2e850553 UX: suppress outgoing right arrow on gutter links 2014-09-08 01:15:40 -07:00
Jeff Atwood
107cffcc84 FIX: revert readonly on share link field 2014-09-08 01:03:50 -07:00
Sam
563a313179 Merge pull request #2767 from gschlager/i18n_fix04
FIX: Some default group names could not be translated
2014-09-08 13:06:29 +10:00
Sam
2a7355405e FEATURE: add age to results of search 2014-09-08 10:02:47 +10:00
Jeff Atwood
65e941f652 UX: remove current username from header 2014-09-07 14:01:51 -07:00
Jeff Atwood
3cf433ab1e FIX: quote icon in Quote Reply not clickable 2014-09-07 13:55:31 -07:00
Jeff Atwood
aa0d14825a add spaces for flag/admin glyphs on hamburger 2014-09-07 13:24:33 -07:00
Gerhard Schlager
970aafecb4 FIX: Some default group names could not be translated 2014-09-07 14:48:03 +02:00
Jeff Atwood
3bdc6f9fad UX: remove email display from profile page 2014-09-05 13:11:50 -07:00
Robin Ward
66501190bd FIX: Missing id attribute caused failing test 2014-09-05 13:15:50 -04:00
Robin Ward
4bec839d9d Using Discourse.XYZ in templates is deprecated. This fixes that, plus
adds some more integration tests to make sure login required is working.
2014-09-05 13:09:01 -04:00
Neil Lalonde
ca5f361d0a FEATURE: restrict admin access based on IP address 2014-09-05 12:06:01 -04:00
Jeff Atwood
dc8fc8c9e4 UX: move "show more" in search to bottom of results 2014-09-05 02:19:06 -07:00
Arpit Jalan
0db66d3a18 Add education panel for starred tab 2014-09-05 11:15:10 +05:30
cpradio
2ef499d021 UX: Add g, t keyboard shortcut to modal window for go to top
https://meta.discourse.org/t/add-shortcut-g-t-to-go-to-top-page/19586
2014-09-04 18:28:03 -04:00
Jeff Atwood
bbbca820d8 FIX: edit history user setting was appearing 2014-09-04 13:47:05 -07:00
Jeff Atwood
fad0394a40 more renaming of trust level settings 2014-09-04 13:32:00 -07:00
Jeff Atwood
fcca64c0cf rename site settings for trust levels as numbers 2014-09-04 13:16:51 -07:00
Robin Ward
229566fc32 Remove deprecated Ember.Set 2014-09-04 15:01:12 -04:00
Robin Ward
52e25c9272 FIX: tabindex was not set on the category chooser when creating a topic. 2014-09-04 13:50:51 -04:00
Jeff Atwood
742e2b1fa9 FIX: add classes to mobile education panels 2014-09-04 10:39:47 -07:00
Robin Ward
1c5e8efa68 FEATURE: Show an email icon beside posts that arrived via email 2014-09-04 13:04:41 -04:00
Robin Ward
8ac955247c Convert category helpers to ES6. 2014-09-04 11:32:30 -04:00
Sam
a3863b52db More highlight tweaking for search, makes it much easier to theme 2014-09-04 18:00:01 +10:00
Sam
9d75f41172 try softening highlight on topic stop highlighting categories 2014-09-04 15:30:17 +10:00
Sam
0ade9bafff FIX: highlight in yellow, not blue
FEATURE: highlight in title
2014-09-04 15:01:13 +10:00
Sam
b8c36bd2da FIX: broken search for admins when selecting topics 2014-09-04 12:21:57 +10:00
Robin Ward
a67e400027 FIX: Remove contents class 2014-09-03 17:17:53 -04:00
riking
824dadbc1b FIX: Add .cooked class to composer preview
This should make any custom styling apply to both the rendered posts and
the composer equally, as long as a .topic-body parent or a #wmd-preview
parent is not specified.
2014-09-03 13:18:48 -07:00
Robin Ward
dac4ed5a1e Prune dead code for search keyboard navigation in search, remove bad
tests.
2014-09-03 15:05:22 -04:00
Robin Ward
40b1558f83 Merge pull request #2747 from cpradio/remove-additional-search-code
FIX: Remove additional search code related to the up/down navigation
2014-09-03 14:46:09 -04:00
Robin Ward
e9600d7cb1 Convert some application helpers to ES6 format. 2014-09-03 13:30:22 -04:00
Robin Ward
0b6c84e292 UX: Remove background color from new badge. DRY up lots of repeated code
for rendering badges on topics.
2014-09-03 12:22:18 -04:00
Neil Lalonde
6489c1d7e3 FIX: admin page for users who have not been activated makes it more clear that the account is inactive, and won't offer actions that don't work yet 2014-09-03 10:41:13 -04:00
Neil Lalonde
ff136ddeea FEATURE: accounts that have not been activated are grey in admin user lists 2014-09-03 10:09:30 -04:00
Sam
c6aab831ed Merge pull request #2741 from riking/badges_create_checks
FIX: Apply contract checks when first creating a badge
2014-09-03 22:19:09 +10:00
Sam
9c16dee843 Merge pull request #2742 from riking/patch-1
UX: Change Impersonate to btn-danger
2014-09-03 22:18:19 +10:00
cpradio
44a25271f1 FIX: Remove additional search code related to the up/down navigation
Removed additional search code that was related to the up/down navigation and their related tests.
https://meta.discourse.org/t/magic-search-code-for-keyboard-shortcuts/19563
2014-09-03 06:51:52 -04:00
Sam
d4f08f442c FIX: correct template for search in post (regression) 2014-09-03 17:09:01 +10:00
Sam
921dd75dd9 FIX: anonymous had <a> items for pin/unpin
FEATURE: display category in search results
FEATURE: display topic state (locked/pinned/etc) in search results

UI cleanup for search results, clearing floats and so on.
2014-09-03 12:13:26 +10:00
Sam
4f09d552ed FEATURE: increase search expansion to 50 results
refactor search code to deal with proper objects
use proper serializers, test the controllers
2014-09-03 12:13:25 +10:00
riking
71b7c80257 UX: CSS tweaks for badge query previews 2014-09-02 19:09:51 -07:00
riking
8979020b9d Clean up unused translations 2014-09-02 15:40:23 -07:00
riking
3413228e89 UX: Change Impersonate to btn-danger 2014-09-02 15:33:54 -07:00
Robin Ward
b04a52676e FIX: Don't show wrong flag choices after undo 2014-09-02 17:37:54 -04:00
Jeff Atwood
defe1dd86f Merge pull request #2739 from techAPJ/patch-1
hide poster avatars when only two posts
2014-09-02 09:54:52 -07:00
Robin Ward
abd84cd2a1 FIX: Redirect to Top was showing "latest" content because it was in the
preload store.
2014-09-02 12:29:22 -04:00
Robin Ward
d09f109b2c FIX: Re-enable filtering on user expansions on topics 2014-09-02 12:08:02 -04:00
Robin Ward
ce745b737e Renamed poster-expansion to user-expansion because it's not specific
to a poster anymore.
2014-09-02 12:08:02 -04:00
Robin Ward
2b0e11dad8 Merge pull request #2711 from hydrarulz/localize_romanian
Add translation for Romanian.
2014-09-02 10:48:38 -04:00
Robin Ward
065101afac Merge pull request #2734 from cpradio/readd-dismiss-bindings
FIX: Readd the dismiss keybindings
2014-09-02 10:42:53 -04:00
Arpit Jalan
8955bf02d8 hide poster avatars when only two posts 2014-09-02 20:10:36 +05:30
Sam
e0c8abc911 Merge pull request #2717 from riking/badge-solid
Admin badge interface improvements
2014-09-02 08:21:06 +10:00
Sam
202656a679 Merge pull request #2725 from cpradio/german-keyboard-support
FIX: Support J/K bindings on German Keyboards
2014-09-02 08:02:10 +10:00
cpradio
02a7a579f4 FIX: Duplicate badge titles can still occur
Send false instead of true to .uniq as the badges are not sorted.
https://meta.discourse.org/t/set-title-dialog-shows-multiple-instances-of-the-same-badge-2/19495
2014-09-01 13:56:19 -04:00
Jeff Atwood
03a7b01e4b Merge pull request #2735 from techAPJ/patch-3
suppress post count on avatar for single post
2014-09-01 08:11:32 -07:00
Arpit Jalan
eba3f6b408 suppress post count on avatar for single post 2014-09-01 14:23:34 +05:30
Sam
69e418facf FEATURE: wider search with more context 2014-09-01 17:04:57 +10:00
cpradio
42c052d21b FIX: Readd the dismiss keybindings
https://meta.discourse.org/t/new-updated-bar-and-dismiss-new-button-unreachable-by-keyboard/18946/10?u=cpradio
2014-08-31 21:56:38 -04:00
cpradio
6234284243 FIX: Remove the old keyboard bindings for next/prev section, update client.en.yml to reflect the new bindings 2014-08-31 21:42:03 -04:00
riking
1833b43ae2 FEATURE: Badge query validation, preview results, and EXPLAIN
Upon saving a badge or requesting a badge result preview,
BadgeGranter.contract_checks! will examine the provided badge SQL for
some contractual obligations - namely, the returned columns and use of
trigger parameters.

Saving the badge is wrapped in a transaction to make this easier, by
raising ActiveRecord::Rollback on a detected violation.

On the client, a modal view is added for the badge query sample run
results, named admin-badge-preview.
The preview action is moved up to the route.
The save action, on failure, triggers a 'saveError' action (also in the
route).

The preview action gains a new parameter, 'explain', which will give the
output of an EXPLAIN query for the badge sql, which can be used by forum
admins to estimate the cost of their badge queries.
The preview link is replaced by two links, one which omits (false) and
includes (true) the EXPLAIN query.

The Badge.save() method is amended to propogate errors.

Badge::Trigger gets some utility methods for use in the
BadgeGranter.contract_checks! method.

Additionally, extra checks outside of BadgeGranter.contract_checks! are
added in the preview() method, to cover cases of null granted_at
columns.

An uninitialized variable path is removed in the backfill() method.

TODO - it would be nice to be able to get the actual names of all
columns the provided query returns, so we could give more errors
2014-08-31 11:25:44 -07:00
Sam
5c244c6f8f FIX: autocomplete username failing to pop up
Janky autocomplete behavior due to debounce not being accounted for
correctly when dealing with promises

This also fixes a promise leak
2014-09-01 01:48:17 +10:00
Jeff Atwood
6d1be665a1 Merge pull request #2729 from cpradio/firefox-kbd-post-navigation
FIX: j/k navigation for posts using Firefox
2014-08-30 13:32:15 -07:00
cpradio
37639308c0 FIX: Firefox j/k post navigation is inconsistent
https://meta.discourse.org/t/j-k-navigation-in-lengthy-topics/18945
2014-08-30 08:59:08 -04:00
cpradio
3f5d530553 Change SHIFT+J and SHIFT+K to move up/down sections instead of posts. 2014-08-30 07:31:38 -04:00
Arpit Jalan
82d4c29c88 TRIVIAL: add line break before time for post navigator 2014-08-30 16:14:00 +05:30
Jeff Atwood
7a50ba600a Merge pull request #2726 from techAPJ/patch-4
FIX: use short date format for post navigator
2014-08-29 23:11:31 -07:00
Arpit Jalan
3c005557e6 FIX: use short date format for post navigator 2014-08-30 11:34:33 +05:30
Jeff Atwood
4281b16616 UX: dim the new and unread education 2014-08-29 22:54:11 -07:00
cpradio
89eb03aff0 FIX: Support J/K bindings on German Keyboards
J/K are not supported on German keyboards, shift+j and shift+k have been added to remedy this.
https://meta.discourse.org/t/keyboard-shortcuts-for-next-previous-section-do-not-work-with-german-keyboard-layout/18902
2014-08-29 22:18:03 -04:00
cpradio
8b349b43a5 UX: Add keyboard binding for reply as new topic
Removed extra translation in the keyboard shortcut modal window
2014-08-29 20:10:34 -04:00
cpradio
2e200ffbf0 Merge remote-tracking branch 'origin/master' into keyboard-binding-incoming-updated-topics
Conflicts:
	config/locales/client.en.yml
2014-08-29 20:05:59 -04:00
cpradio
875b39fb5f Merge remote-tracking branch 'origin/master' into keyboard-binding-incoming-updated-topics 2014-08-29 19:56:39 -04:00
Jeff Atwood
cb45d5fa25 Merge pull request #2724 from cpradio/key-binding-reply-new-topic
UX: Add keyboard binding for reply as new topic
2014-08-29 16:46:34 -07:00
Jeff Atwood
d74f94afa1 Merge pull request #2722 from cpradio/dismiss-keyboard-bindings
UX: Add key-bindings for Dismiss New, Dismiss Posts, and Dismiss Topics
2014-08-29 16:28:25 -07:00
cpradio
68e807f791 UX: Add keyboard binding for reply as new topic 2014-08-29 19:14:42 -04:00
cpradio
bc07bc4819 Remove incoming/updated topics logic (not sure how that got in here, but it is causing a conflict) 2014-08-29 18:19:06 -04:00
Neil Lalonde
1291e94c78 Merge pull request #2715 from cpradio/master
UX: Add focus to menu only if it comes from a keyboard shortcut and improve keyboard functionality for search
2014-08-29 17:04:52 -04:00
Robin Ward
6dcde9ccc3 FIX: Navigating to None was not working 2014-08-29 15:51:28 -04:00
Robin Ward
926e45d030 SECURITY: User action route was returning too much data 2014-08-29 13:46:50 -04:00
Robin Ward
16c9f073b5 FIX: Back button breaks translation of incoming stuff 2014-08-29 12:53:06 -04:00
Neil Lalonde
ec42b61a4d FIX: suspended users cannot be trust level 3 2014-08-29 12:33:34 -04:00
cpradio
8033972536 UX: Add keyboard bidning for incoming/updated topics
Fixed the selector used to gain access to the clickable div
2014-08-29 10:01:36 -04:00
cpradio
5ca96e741d UX: Add keyboard bidning for incoming/updated topics 2014-08-29 09:44:26 -04:00
cpradio
096bc0c0ae Merge branch 'keyboard-binding-new-topics-banner' into dismiss-keyboard-bindings
Conflicts:
	app/assets/javascripts/discourse/lib/keyboard_shortcuts.js
2014-08-29 09:36:34 -04:00
cpradio
cde64580b1 Change the Dismiss keybindings to use 'x' instead of 'd' - moved it to a function binding 2014-08-29 09:35:38 -04:00
cpradio
3f085c3fd3 Change the Dismiss keybindings to use 'x' instead of 'd' 2014-08-29 09:22:47 -04:00
cpradio
ede9d1e057 Change the Dismiss keybindings to use 'x' instead of 'd' 2014-08-29 08:46:35 -04:00
cpradio
9e72b97a75 Corrected an issue with using the same ID for the header/footer of the buttons 2014-08-29 08:33:45 -04:00
cpradio
e4ce995369 FIX: Changed Dismiss New and Dismiss Posts to use d + r because p is reserved for the profile menu and n is reserved for the notifications menu 2014-08-29 08:11:23 -04:00
cpradio
ed8d828ff1 FIX: Added keyboard bindings for dismiss buttons 2014-08-29 08:04:57 -04:00
Régis Hanol
fd6dd88afb FIX: dual modal when deleting spammer in the flag modal 2014-08-29 13:05:51 +02:00
Régis Hanol
521cb6bd0d FIX: dual modal when selecting 'delete spammer' in flags section 2014-08-29 12:54:24 +02:00
Jeff Atwood
8bda8a2235 Revert "UX: stop displaying "user deleted, OK" dialog"
This reverts commit 36405287b4.
2014-08-29 03:49:00 -07:00
Jeff Atwood
36405287b4 UX: stop displaying "user deleted, OK" dialog 2014-08-29 03:34:23 -07:00
riking
3396e6fea3 Centralize MessageBus post updates
After this change, only two files directly publish to MessageBus with a
topic interpolated in the channel: Post and TopicUser.
2014-08-28 20:40:36 -07:00
cpradio
0784c52a24 FIX: Remove up/down key bindings for search results
Up/down key bindings make it difficult to access Show More on search results.
https://meta.discourse.org/t/keyboard-users-cant-select-show-more-in-search-results/19394
2014-08-28 21:39:19 -04:00
cpradio
3e7084743c FIX: Remove up/down key bindings for search results
Up/down key bindings make it difficult to access Show More on search results.
https://meta.discourse.org/t/keyboard-users-cant-select-show-more-in-search-results/19394
2014-08-28 19:58:07 -04:00
Robin Ward
9e2c72e277 Allow restoring from backups in development mode even if the setting is
off.
2014-08-28 17:02:48 -04:00
cpradio
1acb2a13f1 Added a:first 2014-08-28 16:06:48 -04:00
cpradio
4fd73a2b2f Set focus on site-map and user menu
Set focus on first item in the site-map and user drop down for keyboard users, so they can quickly tab to the link/item of their choosing.
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
2014-08-28 16:04:54 -04:00
Robin Ward
8a6c4234fc FIX: Re-enable searching for topic by id when using the split topic
interface.
2014-08-28 15:42:29 -04:00
Robin Ward
b5b13b8c5f Revert "Merge pull request #2713 from cpradio/master"
This reverts commit a9de189682, reversing
changes made to b7ab43e454.
2014-08-28 15:08:06 -04:00
Robin Ward
a9de189682 Merge pull request #2713 from cpradio/master
Set focus on first item in drop down (textbox, link, whatever it may be)
2014-08-28 14:47:38 -04:00
Robin Ward
8bf27642ad FIX: Refresh was losing top controls after bulk operation. Removed
console.log
2014-08-28 14:44:38 -04:00
Robin Ward
69cb5bc425 FIX: Centralize Top rendering, remove old code paths. Fix some bugs. 2014-08-28 14:34:31 -04:00
Robin Ward
30b102aa98 FIX: Show uncategorized with badge/description in the category chooser 2014-08-28 12:42:31 -04:00
cpradio
a40b08f210 Set focus on first item in drop down (textbox, link, whatever it may be)
Set focus on first item in the drop down for keyboard users, so they can quickly tab to the link/item of their choosing.
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
2014-08-28 11:33:45 -04:00
Luca Daniel
2cf92dbe7b Add translation for Romanian. 2014-08-28 14:01:14 +03:00
Sam
3a9f0445bb HACK: remove jarring scroll when hitting back from topic 2014-08-28 11:57:24 +10:00
Robin Ward
fc71662a13 FIX: Don't show topics as unread when hitting back 2014-08-27 18:01:02 -04:00
Neil Lalonde
940c0d5dbb FIX: topicCountStats was depending on the wrong properties 2014-08-27 15:58:32 -04:00
Robin Ward
f05d2ed7cf PERF: Do far fewer checks and use a lot less memory when loading more 2014-08-27 15:31:06 -04:00
Robin Ward
aab8eaac03 FIX: Double clicking quote expansion shouldn't break stuff. 2014-08-27 14:04:00 -04:00
Robin Ward
09ea159afc UX: Add link to change username on admin page 2014-08-27 13:52:01 -04:00
Robin Ward
b1c0a3d01c FIX: Retain back button scroll position even if we don't load more. 2014-08-27 13:33:52 -04:00
Arpit Jalan
3a76f9e79f FIX: allow localization in timestamp 2014-08-27 20:57:06 +05:30
Sam
f48b78c0bb FEATURE: Allow localization sessions
use: I18n.verbose_localization_session()
2014-08-27 17:50:29 +10:00
Arpit Jalan
0453da6fa5 FIX: use short date format for timestamp 2014-08-27 12:56:52 +05:30
Sam
16c34c206d FEATURE: verbose localization option 2014-08-27 14:12:11 +10:00
cpradio
1678a91a60 Add shortcuts for Profile Menu and Hamburger Menu
Added shortcuts of p and = for the profile and hamburger menu
https://meta.discourse.org/t/keyboard-shortcuts-wish-list/15952
2014-08-26 20:30:20 -04:00
Robin Ward
105959c402 Merge pull request #2696 from riking/errors
Fix "Server Error: [missing {{code}} value]" page
2014-08-26 11:14:57 -04:00
Jens Maier
c58565d09f Fix: dialect block parser should not eat next block's whitespace 2014-08-26 14:11:23 +02:00
Jeff Atwood
d63c6292b3 change "Visit Profile" to just "Profile" 2014-08-26 00:37:10 -07:00
Jeff Atwood
553e0290a6 mods can use shield glyph as well, don't need two 2014-08-25 23:49:39 -07:00
Jeff Atwood
95f9943d28 remove <br/> from top non-mobile layout 2014-08-25 22:42:41 -07:00
Jeff Atwood
b6b0cd5c15 add glyph to move posts to new topic button 2014-08-25 22:38:28 -07:00
Sam
3ea76815e4 Merge pull request #2686 from meglio/ru-plurals
Update RU pluralization to use 3 keys: one, few, other (as by Transifex)
2014-08-26 12:42:59 +10:00
Sam
c412d74369 HACK: suppress "1 reply" when directly below for quotes posts 2014-08-26 12:00:16 +10:00
Sam
f331855482 FIX: username autocomplete more reliable, cancel old reqs 2014-08-26 11:32:50 +10:00
riking
5261f2e751 Fix "Server Error: [missing {{code}} value]" page
The translation was expecting a non-existent parameter.
2014-08-25 17:20:48 -07:00
Sam
96af48d903 Merge pull request #2694 from riking/logster-link
Fix Logster link by bypassing Ember router
2014-08-26 09:30:16 +10:00
riking
4db5c8d617 Add data-auto-route=true to Logster link 2014-08-25 15:59:48 -07:00
Robin Ward
a568696098 FIX: Add the <br/> without removing stuff 2014-08-25 18:56:27 -04:00
Robin Ward
939b7ce7e2 Revert "FIX: Added <br/> for @coding-horror"
This reverts commit d62218fb5b.
2014-08-25 18:56:27 -04:00
Robin Ward
d62218fb5b FIX: Added <br/> for @coding-horror 2014-08-25 17:21:01 -04:00
Robin Ward
c820c65172 Merge pull request #2692 from riking/sorted_badges
Sort the badges on the user profile page
2014-08-25 15:56:27 -04:00
Jeff Atwood
de1e0345df proper fix for top page bottom buttons on mobile 2014-08-25 12:55:45 -07:00
riking
234956234b Fix badge type ordering 2014-08-25 12:48:31 -07:00
riking
99c11e2184 Sort the badges on the user profile page
Also clean up UserBadgesController so it isn't doing two things in one
method
2014-08-25 12:40:51 -07:00
Robin Ward
0fba445bc1 FIX: Broken build 2014-08-25 13:35:40 -04:00
Robin Ward
f10f9585ae Better Support for whitelisting caja tags 2014-08-25 13:11:20 -04:00
Régis Hanol
7aaf718cf3 update bbcode dialect and fix vBulletin importer 2014-08-25 10:48:29 +02:00
Jeff Atwood
bd66c67398 whoops, used font awesome 3.2 styles :( 2014-08-24 22:20:59 -07:00
Jeff Atwood
01853fb9d3 replace trophy with shield to indicate admin 2014-08-24 22:05:11 -07:00
Sam
56a0a40175 Merge pull request #2677 from keskuskentta/fi_locale
Add Finnish
2014-08-25 08:44:00 +10:00
Sam
643d0dfc13 FIX: use CDN when expanding avatar templates 2014-08-25 08:18:41 +10:00
Anton Andriyevskyy
c42a5551a1 Update RU pluralization to use 3 keys: one, few, other (as by Transifex) 2014-08-23 15:28:14 +03:00
Sam
e0a74e336a Add SSO diagnostics 2014-08-23 10:34:48 +10:00
Robin Ward
db376d16d3 FIX: Topic entrance widget wasn't disappearing 2014-08-22 18:45:48 -04:00
Neil Lalonde
bbb358b356 Add likes given and likes received requirement for being TL3. Configure with site settings leader_requires_likes_given and leader_requires_likes_received. 2014-08-22 17:33:39 -04:00
Neil Lalonde
00c28f2391 Show total likes given. Put likes given/received and flags given/received together. 2014-08-22 15:23:19 -04:00
Robin Ward
2ae46b4742 REMOVE: Auto quoting confused more people than it helped. 2014-08-22 14:51:31 -04:00
Neil Lalonde
dafc63e3a0 Show how many likes users received in the last 100 days on their admin profile page 2014-08-22 14:37:07 -04:00
Robin Ward
300dbdc88b FIX: BBCode contents can span multiple lines 2014-08-22 14:32:29 -04:00
Neil Lalonde
7756b72a59 FIX: after bulk change category, refresh topic list 2014-08-22 13:01:08 -04:00
Robin Ward
104b39540a FIX: BBCode with params couldn't span lines 2014-08-22 12:14:10 -04:00
Arpit Jalan
6a0309365f Suppress share link for anonymous users 2014-08-22 13:53:28 +05:30
Sam
c865bf0d71 Merge pull request #2670 from Wilhansen/sso_override_avatar
Implement SSO overriding avatars.
2014-08-22 10:22:06 +10:00
Sam
136169bc73 Merge pull request #2676 from riking/logster-link
Add link to Logster in "Logs" tab of admin panel
2014-08-22 10:21:04 +10:00
Sam
9ecbfad5fa only hijack search on topic page 2014-08-22 08:53:00 +10:00
Robin Ward
c713cc57d0 FIX: Firefox floating CSS, added calendar glyph to pop up 2014-08-21 16:42:50 -04:00
Robin Ward
dd84b9d79f FIX: Don't skip TOS check when using 3rd party auth 2014-08-21 16:23:02 -04:00
Robin Ward
c1aa2458f8 UX: Add drop down for top lists, big refactor of repeated code. 2014-08-21 16:08:47 -04:00
Jeff Atwood
2fed513ea2 remove admin link on user drop down 2014-08-21 11:26:57 -07:00
probus
1a28fcf486 Add Finnish 2014-08-21 13:48:42 +03:00
riking
50d4e283dc Add link to Logster in "Logs" tab of admin panel 2014-08-20 14:40:16 -07:00
Jeff Atwood
7dd6b43e8a missed the posts TH on /categories 2014-08-20 13:54:31 -07:00
Jeff Atwood
21b18b1253 remove the "view all {number}.." from mobile cat 2014-08-20 13:51:10 -07:00
Régis Hanol
b2232b4dcf FIX: banner on small desktop screen 2014-08-20 22:45:57 +02:00
Jeff Atwood
5f0b8e3d93 remove posts column from /categories 2014-08-20 13:43:00 -07:00
Régis Hanol
5b1785157d TRIVIAL: fix deprecations due to momentjs upgrade 2014-08-20 22:22:58 +02:00
Robin Ward
33de48dc0c FIX: Float site settings were marked as overridden, reset didn't work. 2014-08-20 15:24:56 -04:00
Robin Ward
d35633deab FIX: Using a binding in an {{avatar}} was broken 2014-08-20 15:12:18 -04:00
Robin Ward
506dca6d4e FIX: Moving posts was not updating reply_count and
`reply_to_post_number` so reply linkage was broken.
2014-08-20 14:15:23 -04:00
Robin Ward
eb02619d1f UX: Move topic entrance widget to posts column 2014-08-20 14:15:23 -04:00
Régis Hanol
dbb4258e86 FIX: user avatar in flags list 2014-08-20 19:21:19 +02:00
Régis Hanol
8a20d05ba5 FEATURE: backup without uploads 2014-08-20 18:53:58 +02:00
Robin Ward
2b5feda625 FIX: You need to be logged in to edit wiki posts. 2014-08-20 11:04:45 -04:00
Sam
4522451920 Merge pull request #2672 from cpradio/master
Only show unique badge titles in the Badge Title dropdown
2014-08-20 11:47:05 +10:00
cpradio
765b099513 Only show unique badge titles in the Badge Title dropdown
Filter the preference Badge Title to only show unique badge title names.
Updated to use lodash
https://meta.discourse.org/t/set-title-dialog-shows-multiple-instances-of-the-same-badge/19071
2014-08-19 21:30:36 -04:00
cpradio
04cd3c0551 Only show unique badge titles in the Badge Title dropdown
Filter the preference Badge Title to only show unique badge title names.
https://meta.discourse.org/t/set-title-dialog-shows-multiple-instances-of-the-same-badge/19071
2014-08-19 20:59:20 -04:00
Jeff Atwood
c24b326c04 add glyph to move dialog button 2014-08-19 15:01:32 -07:00
Robin Ward
65297533fa FIX: Allow links to name attributes 2014-08-19 16:51:53 -04:00
Robin Ward
5667cfe6cb FIX: Load user-avatar first. 2014-08-19 16:32:35 -04:00
Robin Ward
b46a373ff9 UX: Show User popup when clicking on a user in the topic list. 2014-08-19 16:22:37 -04:00
Wilhansen Li
e0f970326f Implement SSO overriding avatars.
Implemented by having Discourse download the image from the provided URL
and treating it as a custom upload.

Adds two more parameters to the SSO site’s response:

* `avatar_url` specifies the URL of the overriding avatar.
* `avatar_force_update` Discourse does not re-download avatars that
has already been download from the same URL. Setting this to true forces
Discourse to re-download the avatar in `avatar_url`

Note that both parameters are ignored if `sso_overrides_avatar` is set
to false.
2014-08-19 15:53:34 +08:00
Sam
2d16255185 FIX: make filter bindable 2014-08-19 16:50:30 +10:00
Sam
1a2070b4d9 FIX: exception in an interval 2014-08-19 11:13:19 +10:00
Robin Ward
68fca9398d FIX: Topic entrace considered the same day of a different month as today. 2014-08-18 17:40:50 -04:00
Robin Ward
14c765ef11 UX: Tweak logic for showing times in topic entrance popup 2014-08-18 17:14:50 -04:00
Neil Lalonde
0841cd2ba6 FEATURE: Add education text to new and unread pages when there are no results 2014-08-18 16:17:40 -04:00
Robin Ward
f1486c7728 FIX: Inconsistency between unread counter and unread filter 2014-08-18 16:15:26 -04:00
Robin Ward
c5d6f6a034 UX: Allow users to tab to the activity column 2014-08-18 14:44:31 -04:00
Robin Ward
db4abe76db CLEANUP: Remove dead resetRead code path 2014-08-18 14:35:33 -04:00
Robin Ward
454c634b7e UX: Make posts columns link to the last post in a topic. 2014-08-18 14:17:14 -04:00
Robin Ward
b175abbfb5 FIX: Admin group search was failing 2014-08-18 14:08:21 -04:00
Régis Hanol
9f72971d26 FEATURE: add the pencil glyph when the post was edited after the first flag 2014-08-18 18:56:39 +02:00
Robin Ward
05193deb4d Merge pull request #2659 from riking/wrong-progress-pos
Hopefully fix once and for all the 172/160 problem
2014-08-18 11:30:09 -04:00
Neil Lalonde
6c10cc3788 FIX: top_menu with category links like category/Meta are not case sensitive 2014-08-18 11:07:49 -04:00
Robin Ward
49f0eaea13 Merge pull request #2650 from Elberet/fix-parser
Fix: block parser uses regexes for stop tags, allows stricter matching
2014-08-18 11:06:08 -04:00
Jeff Atwood
efb8dec951 Reset Read Data not needed here 2014-08-18 02:17:40 -07:00
Jeff Atwood
ff03f98945 remove coldmapping from topic map 2014-08-18 00:24:56 -07:00
Jeff Atwood
e9bfb1c89e make share link input field readonly, with css tweaks 2014-08-17 23:08:53 -07:00
Sam
24932009a5 FIX: don't make an ajax request when password or user is blank 2014-08-18 12:50:25 +10:00
Sam
e0a82d3088 FIX: rate limit password reset email 2014-08-18 10:55:30 +10:00
Jeff Atwood
582ec5954f fix incorrect translation string 2014-08-16 23:18:13 -07:00
Jeff Atwood
967120f23e Merge pull request #2663 from gschlager/i18n_fix01
Add missing translation
2014-08-16 23:11:58 -07:00
Jeff Atwood
6795d378b4 remove a few strings on admin in favor of glyphs 2014-08-16 22:53:41 -07:00
Gerhard Schlager
6b286ad4f4 Add missing translation 2014-08-17 00:29:39 +02:00
Jeff Atwood
80f3cdd9a2 move arrow for topic entry 2014-08-16 13:24:58 -07:00
Robin Ward
aa41548e8e UX: When clicking an activity date, pop up a little menu with options to
go to beginning or end of the topic.
2014-08-15 16:39:57 -04:00
Robin Ward
f7b0c31418 Post history heatmap should use site settings for thresholds 2014-08-15 12:22:06 -04:00
Robin Ward
2f4f5d56e1 Use Site Settings for the cold date ranges 2014-08-15 12:09:31 -04:00
Robin Ward
26ca197be9 Adds Site settings to configure post:like ratio thresholds 2014-08-15 12:02:29 -04:00
Robin Ward
eb5a3da10d UX: Include tooltip text when hovering over posts column 2014-08-15 11:49:30 -04:00
Robin Ward
8f51878d73 FIX: Remove seen flag status from viewed topics 2014-08-15 10:46:58 -04:00
Sam
465c2a2ba8 FEATURE: logout redirect support
Allow users to also logout on an external site after logging out locally
2014-08-15 12:57:29 +10:00
Sam
e16dd96b6d FIX: dispatch correct modal on auto login 2014-08-15 12:13:10 +10:00
Robin Ward
00c791b12e FIX: Issues signing in without local logins 2014-08-14 22:09:12 -04:00
riking
903c760a9b Use progress bar indices in jump control, too 2014-08-14 17:52:21 -07:00
riking
8539c08d35 Fix assignment of post number to progress position 2014-08-14 17:31:34 -07:00
Robin Ward
c2c256cdd9 FIX: Bug with cached topics not being marked as read in your topics
list.
2014-08-14 18:31:02 -04:00
Jeff Atwood
6cc8ec87b5 we don't need this "or" separator on login page 2014-08-14 14:41:45 -07:00
Robin Ward
167f393a03 Merge pull request #2655 from techAPJ/patch-3
FEATURE: export user list
2014-08-14 17:19:49 -04:00
Arpit Jalan
d0736a06b6 FEATURE: export user list 2014-08-15 01:46:57 +05:30
Robin Ward
6f3db0e386 UX: Squash activity columns together. Show a cold map on the difference
between the last post and original post dates. Fix some missing classes
in the mobile templates and topic map.
2014-08-14 16:06:27 -04:00
Neil Lalonde
26a404f4d0 FIX: confusing UI when clicking Delete All Posts button 2014-08-14 15:21:16 -04:00
Robin Ward
5aac2822ed FIX: Metamorph error due to malformed HTML 2014-08-14 14:36:43 -04:00
Robin Ward
2850ce46b8 FIX: If local logins are disabled, sign up button should not show the
form.
2014-08-14 13:14:56 -04:00
Robin Ward
a0d0f859ba Add login buttons to create account template. 2014-08-14 12:51:16 -04:00
Robin Ward
649329e420 Add support for max_posts query param. Also make it easier to let
Ember support query params for sorting our tables. Just add it in one
place.
2014-08-14 11:51:45 -04:00
Robin Ward
4dfe5fd1ca FIX: Edit category should use the id always in case two categories have
the same slug.
2014-08-14 10:56:47 -04:00
Jeff Atwood
41e582e1ca make keyboard shortcut help 3 columns vs 2 2014-08-14 02:25:07 -07:00
Sam
985b356fe9 FIX: work better if there is only one LoginMethod
If there is only 1 login method and local logins are disabled
take user directly to the login provider
2014-08-14 15:13:28 +10:00
Jens Maier
23002ae01c Fix: block parser now uses regexes for end tags. solves code block case, where end tag must be on a line of its own. 2014-08-14 01:58:01 +02:00
Jeff Atwood
578d4ac5f4 I hate hearts, I HATE LOVE 2014-08-13 13:52:11 -07:00
Robin Ward
ac89b3eb7e ES6: grouped-each helper and moved event dispatcher to an initializer 2014-08-13 16:46:59 -04:00
Régis Hanol
9b4c18baf1 Merge pull request #2636 from meglio/color-tags
Show color for values of type:list site settings with word 'colors' in t...
2014-08-13 21:52:14 +02:00
riking
6b22776160 Style & structure fixes for mobile user page 2014-08-13 12:38:55 -07:00
Robin Ward
106aed9dd3 UX: We can link an invited user without a topic to /my/invited 2014-08-13 11:19:29 -04:00
Robin Ward
31f7addefa FIX: Don't capitalize category name in document title 2014-08-13 10:53:34 -04:00
Robin Ward
0adfeb1cff ES6: Mega update of controllers 2014-08-13 10:22:47 -04:00
Robin Ward
1c9ccc6eb1 ES6: More controllers converted over 2014-08-13 10:22:47 -04:00
Jeff Atwood
c89a354fb1 clean up some flag page styles and alignment 2014-08-12 23:52:43 -07:00
Robin Ward
19ea20e4cc UX: Don't show sign up button when the header has extra info in it 2014-08-12 17:38:21 -04:00
Robin Ward
914bbd2a7b FIX: Only show like heat map when there are 10 posts 2014-08-12 17:35:44 -04:00
Jeff Atwood
fcbab8e9b0 fix incorrect link to category position change 2014-08-12 14:33:07 -07:00
Robin Ward
f1572a43e1 UX: Remove drag and drop reordering of categories. It was not working
perfectly and you can re-order using the modal number.
2014-08-12 17:14:02 -04:00
Robin Ward
11e43bd434 FIX: Don't show Sign Up button in cases where users can't sign up 2014-08-12 16:55:23 -04:00
Robin Ward
dd8e5583d7 ES6: Transition helper 2014-08-12 16:33:53 -04:00
Robin Ward
3930d933ca Revert "CLEANUP: This file no longer seems to be used"
This reverts commit 5c2893c8f9.
2014-08-12 16:23:44 -04:00
Robin Ward
5c2893c8f9 CLEANUP: This file no longer seems to be used 2014-08-12 16:22:06 -04:00
Robin Ward
de73e9fb56 UX: Remove likes column, use heat map on posts count 2014-08-12 14:03:52 -04:00
Robin Ward
e49ef042f1 UX: Remove icon from sign up button, change button order 2014-08-12 13:51:00 -04:00
Robin Ward
1684ff3015 UX: Add a separate "Sign Up" button 2014-08-12 13:47:23 -04:00
Robin Ward
36f081bf43 FIX: Don't show the category edit button unless the user can edit the
category
2014-08-12 13:31:05 -04:00
Robin Ward
d1f6c31382 TESTS: Adds integration test for new about route 2014-08-12 11:15:32 -04:00
Robin Ward
0e5a79cf5d FIX: Missing translations, update title on About 2014-08-12 11:04:12 -04:00
Jeff Atwood
506162b719 clarification on delete and block 2014-08-12 03:14:50 -07:00
Jeff Atwood
3451785aa3 add gavel glyph to Take Action for consistency 2014-08-11 15:56:42 -07:00
Robin Ward
c8767dc505 UX: Tweak about page 2014-08-11 18:15:49 -04:00
Robin Ward
996d14965e Minor UX tweaks 2014-08-11 17:03:12 -04:00
Robin Ward
c103398e9a First stab at About page 2014-08-11 16:59:15 -04:00
Régis Hanol
5e41408b55 FEATURE: use less space for flag dispositions 2014-08-11 22:28:11 +02:00
Neil Lalonde
93a6203378 FIX: guidelines route was redirecting to faq in ember app 2014-08-11 16:21:17 -04:00
Robin Ward
15c7e01b90 FEATURE: Can bulk delete topics now using the modal. 2014-08-11 15:14:02 -04:00
Robin Ward
21185617b0 Show the reason the topic couldn't be split rather than a generic error. 2014-08-11 14:43:19 -04:00
Anton Andriyevskyy
f58bf751bc Show color for values of type:list site settings with word 'colors' in their name 2014-08-11 19:54:03 +03:00
Régis Hanol
ec6ba68098 FEATURE: use glyphs instead of text in flag's dispositions 2014-08-11 18:21:34 +02:00
Régis Hanol
45faf07ba6 Merge pull request #2629 from gschlager/fix_badge_header
Use the translated display name of badge instead of English one.
2014-08-11 10:58:13 +02:00
Régis Hanol
e64d3b8a42 FIX: disagree flag should unhide hidden post 2014-08-11 10:48:00 +02:00
Robin Ward
3f316b29f0 FIX: Don't trigger scrolled while the router is transitioning. 2014-08-08 17:38:30 -04:00
Robin Ward
dc260110fa FIX: If editing a reply, the quote button should target the post it was
a reply to, not the post you're editing.
2014-08-08 16:41:58 -04:00
Robin Ward
3b76fd82fd ES6: user-search lib and autocomplete. Cancels many promises rather than
leaving them as pending forever.
2014-08-08 13:10:13 -04:00
Robin Ward
d7f28baf77 FIX: delegation error when reloading user activity 2014-08-08 09:44:21 -04:00
Sam
49f738fe27 FEATURE: allow users to dismiss unread posts 2014-08-08 16:29:51 +10:00
Sam
cd20c8e55f HACK: to be fixed later by @eviltrout 2014-08-08 15:07:04 +10:00
Sam
3ea38b5749 PERF: safeguard to ensure similarity search does not fire too much 2014-08-08 15:06:37 +10:00
Sam
16b7004767 PERF: optimise and improve topic similarity search
FIX: shows up similarity search with blank results
2014-08-08 12:12:53 +10:00
Jeff Atwood
ddbcba145d add ellipsis to flag buttons, better tooltips 2014-08-07 16:39:12 -07:00
Robin Ward
271374a8c6 Remove some Ember.Deferred usage. It's deprecated. 2014-08-07 17:22:00 -04:00
Robin Ward
39c7101c4b TWEAK: Remove TransitionAborted exceptions from logging. They are
apparently normal when you abort a router transition and can be ignored.
2014-08-07 16:52:31 -04:00
Robin Ward
7b317c1ad7 FIX: When navigating to a topic via a link that's not found, the
formatting was broken.
2014-08-07 15:56:09 -04:00
Robin Ward
becfcefb3c FIX: Compatibility layer load order 2014-08-07 15:46:58 -04:00
Robin Ward
f83fb49741 FIX: Category topic list should support search filter too 2014-08-07 15:14:05 -04:00
Robin Ward
37a9747f53 ES6: Convert Discourse.Resolver to ES6 2014-08-07 11:48:02 -04:00
Jeff Atwood
2690a758e6 use hide icon for Agree and Hide Post 2014-08-07 03:12:23 -07:00
Jeff Atwood
08a67f0da5 add lowercase "translations" for topic map 2014-08-07 02:31:59 -07:00
Robin Ward
8279752d3c REFACTOR: Don't use Discourse.Capabilities, instead use injection.
Also fix broken test. /cc @Sam
2014-08-06 18:28:02 -04:00
Robin Ward
60e70f82b9 UX: title text for wiki icon 2014-08-06 17:14:01 -04:00
Gerhard Schlager
b17b539c36 Use the (translated) display name of badge instead of English one. 2014-08-06 22:07:45 +02:00
Robin Ward
417d287813 FIX: Don't link to notifications without URLs 2014-08-06 15:24:20 -04:00
Régis Hanol
4589bce21b FIX: proper property brace expansion syntax :( 2014-08-06 21:22:36 +02:00
Robin Ward
fe04a8d8a3 UX: Clicking the large wiki glyph should edit the post. 2014-08-06 14:33:59 -04:00
Sam
ce942fe324 FIX: never cache ajax GET requests unless specified 2014-08-06 16:16:29 +10:00
Sam
bbcb6ba3f1 Always show toggle in mobile theme 2014-08-06 15:03:51 +10:00
Sam
cbc71e693e FIX: base keyboard shortcuts on touch vs no touch. 2014-08-06 15:01:23 +10:00
Sam
df30cb43ec FIX: reverse insert order when grabbing new topics 2014-08-06 13:24:55 +10:00
Sam
70b5dfc4fa FIX: don't maintain list ordering when grabbing topics, trust server 2014-08-06 10:23:07 +10:00
Régis Hanol
3330f5907c FEATURE: restructure notification HTML layout 2014-08-05 23:36:37 +02:00
Robin Ward
4366ae43d6 FIX: Clicking on "view latest topics" in a forum with few topics was
broken.
2014-08-05 16:26:28 -04:00
Robin Ward
d29822e4cb TWEAK: Sum new and unread in the site map category list 2014-08-05 16:01:49 -04:00
Robin Ward
06c681b0de Merge pull request #2617 from techAPJ/patch-2
FEATURE: dynamically load more invites
2014-08-05 12:54:06 -04:00
Arpit Jalan
4cd8abc905 FEATURE: dynamically load invites 2014-08-05 22:20:23 +05:30
Sam
4536f772c1 FIX: more reliable topic list counts
- unread was not incrementing when you read last post on topic
- new notifications were being inserted even if they existed in list
- terminology was all mixed up "1 new posts", split to 3 messages
- latest behaves as expected, updating count of new and updated topics
2014-08-05 13:27:34 +10:00
Sam
1958b0205e FIX: sloppy topic draft handling
Will open in categories page and category drill down
2014-08-05 11:33:15 +10:00
Sam
ef5b18779e FEATURE: merge new and old unread counts on categories page
UI: restyle UI to match counts
2014-08-05 10:44:01 +10:00
Jeff Atwood
6fb683ff9a tone down new/unread on /categories 2014-08-04 15:41:46 -07:00
Régis Hanol
ec30086dea FEATURE: agree all the flags 2014-08-04 22:48:04 +02:00
Régis Hanol
b36273e4ac TRIVIAL: forgot to remove the href 2014-08-03 23:01:51 +02:00
Régis Hanol
d13d42f3f6 FIX: automatic redirection to /top was a bit janky 2014-08-02 00:34:58 +02:00
Robin Ward
3c66e48573 TESTS: Remove URL_FIXTURES constant for pretender 2014-08-01 17:27:01 -04:00
Robin Ward
27273ac848 Merge pull request #2615 from riking/stream-len-prop
FIX: Topic progress bar was not updating after expanding gaps
2014-08-01 16:28:45 -04:00
riking
4a75065b62 FIX: Topic progress bar was not updating after expanding gaps 2014-08-01 13:23:53 -07:00
Neil Lalonde
443caaa8f7 FIX: don't let admins skip post validations, unless it's faq, tos, or privacy 2014-08-01 14:53:35 -04:00
Régis Hanol
b414a3590a FIX: flag count displayed at wrong position 2014-08-01 19:03:12 +02:00
Sam
7d331760db FIX: not clearing floats in firefox 2014-08-01 12:52:37 +10:00
Jeff Atwood
71aa41ccac copyedits on new flagging behaviors 2014-07-31 16:17:38 -07:00
Robin Ward
d7ad3bb2b6 TESTS: Integration tests for badge pages 2014-07-31 18:44:47 -04:00
Robin Ward
adea5b36a0 TESTS: Integration tests for login_required 2014-07-31 17:59:52 -04:00
Robin Ward
d3cc85c784 TESTS: Use Pretender in test mode for more flexible server responses 2014-07-31 16:49:30 -04:00
Robin Ward
c5b5db48cf TESTS: Reset the preload store for testing 2014-07-31 13:25:40 -04:00
Sam
5a8919e87a FIX: we don't need buttons that do nothing
Leading to v1 we don't need UI reminders in our product.
2014-07-31 18:59:18 +10:00
Sam
9926382185 FIX: can't create badges 2014-07-31 09:09:03 +10:00
Robin Ward
87ca49e26e Merge pull request #2609 from BenLubar/benlubar-edit-history-public-2
FIX: save edit_history_public
2014-07-30 13:20:32 -04:00
Ben Lubar
4e80a4d091 FIX: save edit_history_public 2014-07-30 12:03:22 -05:00
riking
f9ef715357 Improve email-in category settings UI 2014-07-30 09:58:41 -07:00
Robin Ward
a6848bd9e9 FIX: Latest should link to /latest since the homepage can be
customized
2014-07-30 11:59:22 -04:00
Régis Hanol
0b648f4b18 FIX: make sure the quote-reply button is never squished on mobile 2014-07-30 17:39:53 +02:00
Régis Hanol
78e33f1931 FIX: link to the flagged post instead of its topic 2014-07-30 11:16:49 +02:00
Sam
662845f8be FIX: don't display category for PMs 2014-07-30 14:56:19 +10:00
Sam
e7e70d14da Merge pull request #2591 from BenLubar/benlubar-edit-history-public
add profile option for edit history visibility
2014-07-30 14:09:10 +10:00
Sam
f29a761445 FIX: not highlighting stuff a second time 2014-07-30 12:32:14 +10:00
Sam
e227b68f8d FEATURE: make # more useful for keyboard users 2014-07-30 12:16:11 +10:00
Sam
b143b64511 FIX: searchContext set too early
This was firing before previous route deactivated.
2014-07-30 11:55:38 +10:00
Sam
871f2113e4 BUGFIX: don't move selection when nothing is selected 2014-07-30 11:22:41 +10:00
Sam
5c72297695 FEATURE: clean up badges admin 2014-07-30 08:56:46 +10:00
Sam
ebf385aedc FEATURE: allow title overridable 2014-07-30 08:46:59 +10:00
Sam
367d699247 FIX: enter on invite to PM was broken 2014-07-30 08:46:59 +10:00
Régis Hanol
b196de0821 TRIVIAL: use class instead of id for the 'topic-list' 2014-07-29 23:38:36 +02:00
Robin Ward
6844edc564 FIX: User email was changing in the HTML when you invited a user 2014-07-29 16:02:30 -04:00
Robin Ward
ac4a33a656 FIX: Display proper error message when changing a trust level fails 2014-07-29 15:54:20 -04:00
Robin Ward
55457810ba FIX: Was not filtering correctly on the user's stream 2014-07-29 15:39:01 -04:00
Régis Hanol
86a4a1f220 export the Button class so that we can use it in plugins 2014-07-29 20:56:05 +02:00
Robin Ward
16dfedef8f ES6: Remove dynamically generated static routes. They were causing lots
of confusion and bugs.
2014-07-29 14:24:16 -04:00
Robin Ward
df9bd3d666 FIX: Clicking logo when login_required threw an error 2014-07-29 13:46:42 -04:00
Robin Ward
af36df057c FIX: Show correct login page when login_required 2014-07-29 13:38:04 -04:00
Robin Ward
04643898c9 FIX: Typo in SiteSetting 2014-07-29 13:27:01 -04:00
Dung Quang
97507bbd87 Update categories.js.handlebars 2014-07-29 17:24:19 +07:00