Commit graph

1306 commits

Author SHA1 Message Date
Sam
a3863b52db More highlight tweaking for search, makes it much easier to theme 2014-09-04 18:00:01 +10:00
Sam
ce067a404f Update topic-post.scss
fix read state position
2014-09-04 15:14:58 +10:00
Sam
f79b2963fb Revert "fixing alignment of unread post dot"
This reverts commit 80f87e15d2.
2014-09-04 15:09:07 +10:00
Sam
0ade9bafff FIX: highlight in yellow, not blue
FEATURE: highlight in title
2014-09-04 15:01:13 +10:00
Kris Aubuchon
80f87e15d2 fixing alignment of unread post dot 2014-09-04 00:11:43 -04:00
Kris Aubuchon
06e048bf89 minor unread circle alignment fix 2014-09-04 00:02:29 -04:00
Sam
1f42dda939 factor common code 2014-09-04 13:19:10 +10:00
Sam
a050fa887f FIX: regression, go to quoted post missing in quotes
refactors common code as well
2014-09-04 13:16:19 +10:00
Sam
d6a5552340 tweak new topic styling 2014-09-04 11:07:32 +10:00
Jeff Atwood
7543b37f86 UX: add dot before new topics via css 2014-09-03 13:33:56 -07:00
Robin Ward
17b79fdeda Increase the contrast of the "new" text 2014-09-03 15:37:42 -04:00
Robin Ward
0b6c84e292 UX: Remove background color from new badge. DRY up lots of repeated code
for rendering badges on topics.
2014-09-03 12:22:18 -04:00
Neil Lalonde
6489c1d7e3 FIX: admin page for users who have not been activated makes it more clear that the account is inactive, and won't offer actions that don't work yet 2014-09-03 10:41:13 -04:00
Neil Lalonde
ff136ddeea FEATURE: accounts that have not been activated are grey in admin user lists 2014-09-03 10:09:30 -04:00
Sam
c6aab831ed Merge pull request #2741 from riking/badges_create_checks
FIX: Apply contract checks when first creating a badge
2014-09-03 22:19:09 +10:00
Jeff Atwood
c41d47b8f5 suppress search topic status color a bit 2014-09-03 01:03:53 -07:00
Jeff Atwood
6681d8ab81 Revert "UX: suppress new indicator style"
This reverts commit 870fd70525.
2014-09-03 00:11:25 -07:00
Jeff Atwood
870fd70525 UX: suppress new indicator style 2014-09-02 23:48:41 -07:00
Sam
921dd75dd9 FIX: anonymous had <a> items for pin/unpin
FEATURE: display category in search results
FEATURE: display topic state (locked/pinned/etc) in search results

UI cleanup for search results, clearing floats and so on.
2014-09-03 12:13:26 +10:00
riking
71b7c80257 UX: CSS tweaks for badge query previews 2014-09-02 19:09:51 -07:00
Robin Ward
ce745b737e Renamed poster-expansion to user-expansion because it's not specific
to a poster anymore.
2014-09-02 12:08:02 -04:00
Sam
e0c8abc911 Merge pull request #2717 from riking/badge-solid
Admin badge interface improvements
2014-09-02 08:21:06 +10:00
Sam
68cc4fb285 we need more height 2014-09-01 17:42:27 +10:00
Sam
60559b42be got to move inidicator a bit 2014-09-01 17:17:50 +10:00
Sam
69e418facf FEATURE: wider search with more context 2014-09-01 17:04:57 +10:00
riking
1833b43ae2 FEATURE: Badge query validation, preview results, and EXPLAIN
Upon saving a badge or requesting a badge result preview,
BadgeGranter.contract_checks! will examine the provided badge SQL for
some contractual obligations - namely, the returned columns and use of
trigger parameters.

Saving the badge is wrapped in a transaction to make this easier, by
raising ActiveRecord::Rollback on a detected violation.

On the client, a modal view is added for the badge query sample run
results, named admin-badge-preview.
The preview action is moved up to the route.
The save action, on failure, triggers a 'saveError' action (also in the
route).

The preview action gains a new parameter, 'explain', which will give the
output of an EXPLAIN query for the badge sql, which can be used by forum
admins to estimate the cost of their badge queries.
The preview link is replaced by two links, one which omits (false) and
includes (true) the EXPLAIN query.

The Badge.save() method is amended to propogate errors.

Badge::Trigger gets some utility methods for use in the
BadgeGranter.contract_checks! method.

Additionally, extra checks outside of BadgeGranter.contract_checks! are
added in the preview() method, to cover cases of null granted_at
columns.

An uninitialized variable path is removed in the backfill() method.

TODO - it would be nice to be able to get the actual names of all
columns the provided query returns, so we could give more errors
2014-08-31 11:25:44 -07:00
Jeff Atwood
4281b16616 UX: dim the new and unread education 2014-08-29 22:54:11 -07:00
Régis Hanol
38f52f0f8e FIX: banner topic's max-width & max-height on both mobile & desktop 2014-08-28 16:15:48 +02:00
Robin Ward
09ea159afc UX: Add link to change username on admin page 2014-08-27 13:52:01 -04:00
Jeff Atwood
009dc7ded3 missed a spot in CSS 2014-08-27 02:58:32 -07:00
Jeff Atwood
f557f7eeb9 change fix for [quote] padding 2014-08-27 02:45:57 -07:00
Jeff Atwood
dc6dd26b10 FIX: [quote][/quote] missing top padding 2014-08-27 02:22:58 -07:00
Jeff Atwood
587f7f56c8 FIX: share link pushing viewport on mobile 2014-08-27 00:46:26 -07:00
Jeff Atwood
180430de93 LAYOUT: add more space around topic map links 2014-08-27 00:24:58 -07:00
Sam
64331e2ac1 row style is common, its the way we clear divs 2014-08-26 07:41:29 +10:00
Jeff Atwood
de1e0345df proper fix for top page bottom buttons on mobile 2014-08-25 12:55:45 -07:00
Jeff Atwood
a11cc46c73 remove global margin right on mobile btn 2014-08-25 12:47:02 -07:00
Jeff Atwood
024c503870 mobile login tweaks 2014-08-25 12:38:27 -07:00
Jeff Atwood
3a010c34cc smallenate anon drop-down topic counts 2014-08-25 12:14:47 -07:00
Sam
af71307363 Add 10px margin for buttons in mobile 2014-08-23 10:41:48 +10:00
Jeff Atwood
ae9fcf17ef make period chooser (/top h2) unselectable on touch 2014-08-22 17:01:12 -07:00
Kris Aubuchon
a8e6e1e3d5 adding highlight back to topic-list 2014-08-22 10:45:51 -04:00
Robin Ward
c1aa2458f8 UX: Add drop down for top lists, big refactor of repeated code. 2014-08-21 16:08:47 -04:00
Régis Hanol
b2232b4dcf FIX: banner on small desktop screen 2014-08-20 22:45:57 +02:00
Régis Hanol
8a20d05ba5 FEATURE: backup without uploads 2014-08-20 18:53:58 +02:00
Jeff Atwood
4c66362dd1 remove right-arrow on cross-topic oneboxes 2014-08-19 15:19:01 -07:00
Robin Ward
b46a373ff9 UX: Show User popup when clicking on a user in the topic list. 2014-08-19 16:22:37 -04:00
Régis Hanol
9f72971d26 FEATURE: add the pencil glyph when the post was edited after the first flag 2014-08-18 18:56:39 +02:00
Jeff Atwood
e9bfb1c89e make share link input field readonly, with css tweaks 2014-08-17 23:08:53 -07:00
Jeff Atwood
09291fcba0 make entire first/last entry popup unselectable 2014-08-16 23:16:13 -07:00