Commit graph

7908 commits

Author SHA1 Message Date
Neil Lalonde
d5712e43cf FIX: auto-close time can be a date like 2015-2-22 2015-02-10 17:10:20 -05:00
Robin Ward
c0856daf13 Merge pull request #3192 from riking/patch-xss
SECURITY: missed html escaping
2015-02-10 15:24:09 -05:00
Régis Hanol
c4e427cf73 FEATURE: filter screened IP addresses 2015-02-10 19:38:59 +01:00
Robin Ward
9b12e53d9c Merge pull request #3195 from techAPJ/patch-1
FIX: set base_url for usage_tips
2015-02-10 12:53:33 -05:00
Robin Ward
d8c616a68a Add a store so we can start using ES6 modules for models, finally. 2015-02-10 12:35:53 -05:00
Robin Ward
8d46de4819 Add a spec for the new plugins controller 2015-02-10 12:35:53 -05:00
Arpit Jalan
9d5baf12ff FIX: set base_url for usage_tips 2015-02-10 23:04:00 +05:30
Sam
39e828dee4 improve formatting 2015-02-10 15:59:08 +11:00
Sam
d5405eebde Add basic snapshot comparison for tracking memory leaks 2015-02-10 15:54:16 +11:00
Sam
1d99f5c9c0 FEATURE: add process stats to memory report 2015-02-10 12:34:01 +11:00
Sam
3aea00473b FEATURE: improve memory reporting of /admin/memory_stats 2015-02-10 11:48:30 +11:00
riking
83b51875bb Use html_escape method instead of gsub 2015-02-09 15:03:17 -08:00
riking
7e79daf9af SECURITY: missed html escaping 2015-02-09 14:34:05 -08:00
riking
68ccd2d664 FEATURE: All 500 errors now show up in Logster
Added Discourse.handle_request_exception()
2015-02-09 12:48:33 -08:00
riking
5657006aca Rename handle_exception to handle_job_exception 2015-02-09 12:47:46 -08:00
Robin Ward
62b1969c4b Merge pull request #3185 from techAPJ/patch-1
FIX: uncategorized is showing up in title tag on topics
2015-02-09 14:30:19 -05:00
Arpit Jalan
e87ff31d4c FIX: uncategorized is showing up in title tag on topics 2015-02-10 00:54:43 +05:30
riking
8d39480831 use symbols for error types (squash me) 2015-02-09 10:20:00 -08:00
Régis Hanol
1e6f886886 FIX: use distributed mutex to prevent errors when uploading emojis in batches 2015-02-09 18:54:57 +01:00
Régis Hanol
e9d5c5c0a8 Merge pull request #3187 from linc01n/fix_custom_mobile_top_footer
Fix customize HTML/CSS only show desktop code
2015-02-09 18:44:29 +01:00
Régis Hanol
b809e02c6c FIX: clicking an attachment link works only once 2015-02-09 17:49:59 +01:00
Lincoln Lee
02f3f8c1b3 Fix customize HTML/CSS only show desktop code
custom_top and custom_footer method in SiteCustomization is setting
:desktop as default argument for `target`

It output the desktop version of the custom_top, custom_footer even
user in mobile_view.

This fix is adding the missing target into method argument.
2015-02-10 00:48:42 +08:00
Régis Hanol
e0703dbbc7 FIX: broken gravatar link when using S3
Don't break the optimized image workflow when there was an issue downloading a copy of the original image
2015-02-09 17:00:58 +01:00
Régis Hanol
c9a007d5fb FIX: backup logs on Firefox
FIX: debounce backup logs in order to prevent Firefox crash
FIX: 'Invalid date' in backup logs in Firefox
2015-02-09 16:53:28 +01:00
Arpit Jalan
4c602f60c6 Add Telugu translation files 2015-02-09 20:46:31 +05:30
Sam
e8323fa534 FIX: removing a group from a user was not removing primary group 2015-02-09 16:03:09 +11:00
Sam
4a5d79ad89 Merge pull request #3184 from awesomerobot/master
fixing unread count alignment
2015-02-09 10:44:21 +11:00
Kris Aubuchon
0bc35a6360 fixing unread count alignment 2015-02-08 18:09:12 -05:00
riking
a16aa9fde8 HACK: Keep old behavior for topics#show 2015-02-08 13:56:56 -08:00
riking
8cf21f2363 FEATURE: Refactor error returns in application_controller 2015-02-08 13:40:38 -08:00
riking
8812f95839 FIX: Ember regression in read-only banner 2015-02-08 12:42:19 -08:00
Jeff Atwood
2f8e29bd04 Merge pull request #3180 from awesomerobot/master
fixing missing border on dropdown
2015-02-08 10:24:08 -08:00
Kris Aubuchon
29490209e7 fixing missing border on dropdown 2015-02-08 12:01:51 -05:00
Sam
32b40503d0 Merge pull request #3179 from awesomerobot/master
updating the composer category selector style
2015-02-08 16:46:22 +11:00
Kris Aubuchon
834378f996 updating the composer category selector style 2015-02-07 23:16:46 -05:00
Jeff Atwood
10403676d7 minor /categories CSS tweaks 2015-02-07 15:46:04 -08:00
Robin Ward
3cfa37b1e6 FIX: Support adminPlugins resource even if no plugins use it 2015-02-06 19:26:45 -05:00
Robin Ward
7dea65122e Support a url field in plugin metadata 2015-02-06 18:08:57 -05:00
Robin Ward
3d7b534564 FEATURE: New "Plugins" admin section with extensibility support 2015-02-06 17:33:24 -05:00
Neil Lalonde
96b15cbba6 FIX: dashboard report date range calculations include time zone, and application request data too 2015-02-06 17:20:11 -05:00
Robin Ward
a65e0a80ba Add support for more ES6 features 2015-02-06 13:26:33 -05:00
Régis Hanol
4db3caec7c Merge pull request #3175 from chapel/fix-autolink-regex
FIX: Remove g and m flags from autolink regex
2015-02-06 09:56:52 +01:00
Régis Hanol
8e2d84ee27 Merge pull request #3174 from riking/patch-poll
FIX: Allow closing polls in multi-locale sites
2015-02-06 09:44:44 +01:00
Jacob Chapel
e57be55979 FIX: Remove g and m flags from autolink regex 2015-02-06 00:41:38 -08:00
Sam
dea05e6041 Revert "UI: use tertiary color to generate topic progress bg"
This reverts commit 0e93bae310.
2015-02-06 18:31:10 +11:00
Sam
0e93bae310 UI: use tertiary color to generate topic progress bg 2015-02-06 17:56:45 +11:00
Sam
ab25ddcc3b we were forced to bind here 2015-02-06 16:46:28 +11:00
Sam
dd9c23eb5e we need access to badge category bg in drop down for extensibility 2015-02-06 16:20:55 +11:00
Sam
95f8b3ed4c FIX: status route should be served as text not html 2015-02-06 15:56:21 +11:00
riking
06f02ce9fc FIX: 🈂️ Allow closing polls in multi-locale sites 2015-02-05 19:55:03 -08:00
Sam
820ce8765e refactor traffic report
split traffic report in 2, page view vs raw traffic
hide raw traffic report by default
improve flushing logic for application reqs
2015-02-06 14:39:16 +11:00
Sam
1d3f4f6935 only send track view on get requests 2015-02-06 14:39:15 +11:00
Jeff Atwood
1ec46e3efd add whee fun border emoji radius
BECAUSE FUN GOD DAMN IT
2015-02-05 16:36:52 -08:00
riking
193bf62dee FIX: 'all' filter never de-highlighting 2015-02-05 15:02:11 -08:00
Sam
3a0cd0b760 make custom fields a bit more permissive input wise 2015-02-06 09:03:23 +11:00
Robin Ward
a852f6c56f Add Discourse-Track-View header to XHR when transitioning 2015-02-05 16:07:51 -05:00
Robin Ward
4e64d16a47 FEATURE: Allow plugins to log staff actions 2015-02-05 15:26:34 -05:00
Régis Hanol
2fcd199f48 FIX: send a PM to moderators when a post has been flagged as sockpuppet 2015-02-05 19:58:49 +01:00
Régis Hanol
d0b83c6fb2 Merge pull request #3172 from techAPJ/patch-1
FIX: check for full name in invite email subject
2015-02-05 18:32:17 +01:00
Arpit Jalan
c90251ea25 FIX: check for full name in invite email subject 2015-02-05 22:35:25 +05:30
Régis Hanol
521d3de10d revert: ⬆️ update font-awesome 2015-02-05 17:26:18 +01:00
Robin Ward
68c2eb9a5b Remove deprecated Discourse.ajax methods. 2015-02-05 11:07:15 -05:00
Robin Ward
c3874b6ec9 Remove deprecated error callback to Discourse.ajax 2015-02-05 10:44:33 -05:00
Régis Hanol
ef6868d870 forgot the *actual* font (SO :fired:) 2015-02-05 14:32:04 +01:00
Régis Hanol
4ac82f45bf FIX: force font-awesome update 2015-02-05 14:25:27 +01:00
Régis Hanol
0774bd28b8 remove unused font-awesome file 2015-02-05 14:20:01 +01:00
Régis Hanol
f1403206ca Merge pull request #3169 from riking/patch-3
SECURITY: Don't leak topic title in the redirect
2015-02-05 12:47:58 +01:00
Régis Hanol
48de485f72 Merge pull request #3170 from riking/show_mentions
FEATURE: Mentions stream on user profile
2015-02-05 12:47:22 +01:00
Régis Hanol
ea50d22302 ⬆️ update font-awesome 2015-02-05 12:47:02 +01:00
Arpit Jalan
026df5185e FIX: subcategory url was incorrect in rss 2015-02-05 13:22:28 +05:30
riking
2154f5478a FEATURE: Mentions stream on user profile 2015-02-04 22:03:44 -08:00
Sam
08b790b3c2 improve metrics gathered using in our traffic section
this also pulls out the middleware into its own home and inserts in front
2015-02-05 16:08:52 +11:00
Sam
c9adfa65a0 FEATURE: dashboard stats for application traffic 2015-02-05 11:18:21 +11:00
Robin Ward
25daca8f23 Helpers for plugins to support enabling/disabling 2015-02-04 16:23:56 -05:00
Neil Lalonde
27557b8402 ApplicationRequest can return a report 2015-02-04 15:05:22 -05:00
riking
4c8850108a SECURITY: Don't leak topic title in the redirect 2015-02-04 11:55:39 -08:00
Jeff Atwood
3948a960cd minor tweak for new topic alignment 2015-02-04 11:29:56 -08:00
Régis Hanol
8a5a229c3f FIX: category backgrounds were broken 2015-02-04 16:38:42 +01:00
Sam
3fc930526c fix typo 2015-02-04 18:25:37 +11:00
Sam
67eccee990 FEATURE: basic disk space usage stats 2015-02-04 18:05:17 +11:00
Sam
21402d9d9e annotations 2015-02-04 16:34:25 +11:00
Sam
e105f0965c infrustructure for tracking application web requests 2015-02-04 16:15:16 +11:00
Sam
06edfb85a9 annotations 2015-02-04 16:15:16 +11:00
Jeff Atwood
dc96d6bafe move admin topic wrench down a bit 2015-02-03 15:01:23 -08:00
Neil Lalonde
8689c85b54 add error handling when granting admin and moderator privileges 2015-02-03 17:42:08 -05:00
Arpit Jalan
68377ba4ab add class for container div on 404 page 2015-02-04 00:40:21 +05:30
Régis Hanol
0e5c9b2590 small upload code refactor 2015-02-03 18:44:18 +01:00
Arpit Jalan
a092944582 FIX: URL encoding was not working for %23 in links 2015-02-03 22:06:49 +05:30
Jeff Atwood
c1ddda3e8f try removing "loading topic..." vs spinner 2015-02-02 23:10:07 -08:00
Sam
7e259375e9 PERF: properly pass topic_id to post action cache to avoid excessive query
in the past auto closing was forcing a consistency check on topic, which in
turn was triggering a full post action cache rebuild
2015-02-03 15:59:26 +11:00
Sam
85d9b2d227 regression, missing local storage would cause script to break 2015-02-03 13:17:03 +11:00
Sam
78b879d666 remove superflous rules break firefox 2015-02-03 11:56:57 +11:00
Sam
5ddec2e76d revert lodash upgrade, it is causing severe breakages elsewhere 2015-02-03 11:51:34 +11:00
Jeff Atwood
80d8b133d9 slight emoji dialog tweak 2015-02-02 15:41:53 -08:00
Jeff Atwood
2dbe747918 emoji dialog UX tweaks
https://meta.discourse.org/t/idea-design-window-emoticons/24654
2015-02-02 14:43:10 -08:00
Régis Hanol
03f7a12b52 UX: use 🌟 icon for recently used emoji tab 2015-02-02 22:28:58 +01:00
Régis Hanol
20308ecfd9 fix typo (stupid 🇫🇷) 2015-02-02 21:55:44 +01:00
Régis Hanol
69f95df297 FEATURE: recently used emoji tab
⬆️ update lodash to V.3.0.1
2015-02-02 21:54:15 +01:00
Robin Ward
06279b5c6a Add a new event for when a post is confirmed as spam 2015-02-02 15:52:21 -05:00
Régis Hanol
0a252d7785 FIX: quote whote post should insert at cursor position 2015-02-02 19:08:28 +01:00
Robin Ward
f15b0d205f FIX: The "too similar" check happened when trying to make a post a wiki 2015-02-02 12:44:56 -05:00
Neil Lalonde
b56999e984 show last 30 days on about page 2015-02-02 12:27:49 -05:00
Arpit Jalan
88306cc112 FIX: uncategorized category was not loading updates in edit mode 2015-02-02 21:50:29 +05:30
Régis Hanol
b9ff4a5e81 UX: fix 'revision details' styling in revision history window 2015-02-02 12:13:37 +01:00
Jeff Atwood
9d4ee9553d add some breathing room to quoted categories 2015-02-02 02:08:06 -08:00
Régis Hanol
e2a65a6605 Merge pull request #3159 from riking/patch-6
FIX: Add Google Analytics code to crawler view
2015-02-02 11:07:47 +01:00
Jeff Atwood
737f81b3a9 remove default bgcolor from code highlight 2015-02-02 01:53:24 -08:00
Jeff Atwood
e45b3c15c3 Revert "FIX: auto orientation code causing grey images to appear blackish"
This reverts commit f680374820.
2015-02-02 01:27:52 -08:00
riking
c6e27399b3 FIX: Add Google Analytics code to crawler view 2015-02-02 00:49:58 -08:00
Sam
8304c306a4 Merge pull request #3158 from techAPJ/patch-2
FIX: Not allow TL4 user to set staff color
2015-02-02 16:27:39 +11:00
Arpit Jalan
a29970275a FIX: Not allow TL4 user to set staff color 2015-02-02 10:38:42 +05:30
Sam
05a56b25a9 FIX: setting custom avatar would not work a lot of the time
Due to internal structure we were often caching "redirect" images.
2015-01-31 23:42:50 +11:00
Sam
f680374820 FIX: auto orientation code causing grey images to appear blackish 2015-01-31 18:05:50 +11:00
Sam
f4609fd6ae selection refactor caused wrench to show up in topic list for non-admins 2015-01-31 17:16:08 +11:00
Sam
8b95511816 correct bad styling in user->pref->categories 2015-01-31 17:04:53 +11:00
Arpit Jalan
3e7cc18276 FIX: Toggling staff color on a post doesn’t get applied 2015-02-02 01:11:35 +05:30
Jeff Atwood
cabd519f14 add a little breathing room for topic title tags 2015-01-30 15:45:04 -08:00
Robin Ward
d7b7ec9e0a FIX: Wiki editing was broken due to extra topic update 2015-01-30 18:02:11 -05:00
Robin Ward
f923d7e205 Support appending routes within the admin section by plugins 2015-01-30 18:02:11 -05:00
Neil Lalonde
750b27f973 FEATURE: show number of active users in the last 7 days on about page 2015-01-30 17:23:52 -05:00
Régis Hanol
79a7c7ce41 Merge pull request #3151 from lidlanca/patch-7
Fix: Resize event does not get cleared/unbind properly due to wrong usage of jQuery api.
2015-01-30 15:48:08 +01:00
Dan Singerman
64c4bd5dbf Fix force_avatar_update.to_i error as force_avatar_update is a boolean
If force_avatar_update is passed in sso attributes it errors on
force_avatar_update.to_i. The SingleSignOn class forces avatar_force_update
to a boolean, so it should be treated as such.
2015-01-30 09:51:38 +00:00
Sam
d9ae4e791e woops should be a bit more specific 2015-01-30 19:17:26 +11:00
Sam
833b7b8f0b fix header primary missing color 2015-01-30 17:57:46 +11:00
lidlanca
b4f1ffd4ea Fix: Resize event handler does not get cleared from window object,by wrong usage of jQuery api.
An handler get added each time a topic is loaded to the window object

jQuery resize api only pass data to the handler when triggered.
```.resize( [eventData ], handler ) ```

The unbind followed in willDestroyElement had no affect. 

.on(...) or bind(..) support the event.namespace

fix was not tested.
2015-01-30 01:57:44 -05:00
Sam
52bc03b5e6 FIX: summary mode was broken and missing a bunch of posts 2015-01-30 17:19:42 +11:00
Sam
784697bf12 added todo 2015-01-30 15:11:46 +11:00
Sam
1b1ea8e718 FEATURE: 'b' as a keyboard shortcut for bookmarking a topic 2015-01-30 15:11:24 +11:00
Sam
8b7afd644f regression, too many "new" badges on the "new" tab 2015-01-30 12:47:45 +11:00
Sam
e77eaf9c95 adjust styling for tagged topics 2015-01-30 12:33:27 +11:00
Sam
561278eb38 correct broken mobile styling 2015-01-30 12:09:42 +11:00
Sam
8264dbd971 Merge pull request #3140 from fullfatthings/fix_missing_sso_avatar_bug
Fix bug when sso_overrides_avatar is true but no avatar_url is passed
2015-01-30 10:45:25 +11:00
Sam
b1f81c0dca Merge pull request #3080 from riking/misc
Miscellaneous fixes from PR#3000
2015-01-30 10:23:17 +11:00
Sam
ea7af7a83b Merge pull request #3135 from longhotsummer/fix-no-user-params
FIX: creating a user shouldn't error when optional fields aren't given
2015-01-30 10:12:57 +11:00
Neil Lalonde
67b262b93e Merge branch 'master' of github.com:discourse/discourse 2015-01-29 17:39:52 -05:00
Neil Lalonde
644c7a4675 FEATURE: Add an option to show custom user fields on profiles. Default is to not show them. 2015-01-29 17:38:39 -05:00
Robin Ward
d1ec1e2681 Allow code to save custom fields without saving the attached object 2015-01-29 17:17:52 -05:00
riking
85a7b925c7 Miscellaneous fixes from PR#3000
FIX: Don't require login to view post raw
FIX: Don't submit read-guidelines for anonymous users (causes
unnecessary 403 errors from ensure_logged_in)
FIX: Don't pass nil to an array serializer
2015-01-29 13:56:32 -08:00
Sam
a6ce188f35 Merge pull request #3126 from riking/latest-posts
Latest posts endpoint at /posts.json
2015-01-30 08:55:45 +11:00
Régis Hanol
6a68e8c272 FIX: use CDN for user card/profile background and user avatars (for real this time) 2015-01-29 22:53:48 +01:00
Arpit Jalan
6c410ed093 FIX: strip whitespaces from user email 2015-01-30 01:44:24 +05:30
Régis Hanol
22adb682d8 revert - FIX: use CDN for user card/profile background and user avatars 2015-01-29 20:42:05 +01:00
Régis Hanol
14dc22f288 FIX: use CDN for user card/profile background and user avatars 2015-01-29 20:15:17 +01:00
Robin Ward
f028b51620 Add post parameters so plugins like akismet can use it for spam
prevention.
2015-01-29 13:09:35 -05:00
Robin Ward
1f40807001 Add extensibility point for whenever a post is created 2015-01-29 12:46:29 -05:00
Régis Hanol
2507f99135 FEATURE: background job to make sure emoticons aren't too big 2015-01-29 18:36:35 +01:00
Robin Ward
9a4e5c04d9 Fix weird indentation in CSS file 2015-01-29 12:08:42 -05:00
Régis Hanol
bdb0b45834 Merge pull request #3148 from techAPJ/patch-1
Do not allow TL0 users topics in email digest
2015-01-29 17:50:21 +01:00
Régis Hanol
3a24df6956 FIX: adding a custom emoji needed an application restart to work on the server-side rendering 2015-01-29 17:35:52 +01:00
Régis Hanol
b5a6193d36 Merge pull request #3147 from awesomerobot/master
simple change that grants a bit more flexibility to the category and title in the topic list
2015-01-29 17:30:39 +01:00
Kris Aubuchon
5621b1f663 simple change that grants a bit more flexibility to the category and title in the topic list 2015-01-29 10:53:13 -05:00
Arpit Jalan
21e94859a9 Do not allow TL0 users topics in email digest 2015-01-29 21:10:26 +05:30
Robin Ward
52d04935be Merge pull request #3145 from gdpelican/bugfix/like-toggle
Rerender actions on like/dislike
2015-01-29 10:32:11 -05:00
Régis Hanol
6556e1cb10 FIX: pasting image in the composer wasn't working in Chrome 2015-01-29 16:26:40 +01:00
Jeff Atwood
f4a9ba8c9d tighten up spacing on category dropdown button 2015-01-29 03:51:07 -08:00
James Kiesel
3b2dcf12b5 Rerender actions on like/dislike 2015-01-29 23:27:05 +13:00
Arpit Jalan
4e4bb736a8 build is failing :fired: 2015-01-29 15:18:38 +05:30
Jeff Atwood
605ae8a1a3 Merge pull request #3143 from techAPJ/patch-1
FIX: PMs were not allowed to be edited in some cases
2015-01-29 01:35:05 -08:00
Arpit Jalan
e8db47a1fe FIX: PMs were not allowed to be edited in some cases 2015-01-29 15:00:11 +05:30
Sam
ffee7ba789 fix style 2015-01-29 18:37:38 +11:00
Sam
8792909ff8 less rules ... less ie problems ... 2015-01-29 18:22:29 +11:00
Sam
a591c019d4 correct tests 2015-01-29 17:57:34 +11:00
Sam
1a694c04e4 correct box styles 2015-01-29 17:49:14 +11:00
Sam
cd5564f623 more styling tweaks 2015-01-29 17:49:14 +11:00
Sam
57dd4554f1 bar style fixes 2015-01-29 17:49:14 +11:00
Sam
6495bca540 bar style fixes 2015-01-29 17:49:14 +11:00
Sam
844467015d FEATURE: allow simple selection for category badge styles
clean up category badge styling
2015-01-29 17:49:14 +11:00
Robin Ward
d491d817a6 UX: Alwasy skip headers on topic lists on mobile.
Fixes topic lists filtered by tag on mobile.
2015-01-28 15:20:26 -05:00
Robin Ward
d6fa248093 UX: Update 404 page category badge to use centralized helper and style 2015-01-28 14:56:38 -05:00
Régis Hanol
cd2c9edb46 FIX: 🐛 upload on IE9 wasn't working :'(
- FIX: make sure we set a default name to a pasted image only on Chrome (the only browser that supports it)
- FIX: use ".json" extension to uploads endpoints since IE9 doesn't pass the correct header
- FIX: pass the CSRF token in a query parameter since IE9 doesn't pass it in the headers
- FIX: display error messages comming from the server when there is one over the default error message
- FIX: HACK around IE9 security issue when clicking a file input via JavaScript (use a label and set `visibility:hidden` on the input)
- FIX: hide the "cancel" upload on IE9 since it's not supported
- FIX: return "text/plain" content-type when uploading a file for IE9 in order to prevent it from displaying the save dialog
- FIX: check the maximum file size on the server 💥
- update jQuery File Upload Plugin to v. 5.42.2
- update JQuery IFram Transport Plugin to v. 1.8.5
- update jQuery UI Widget to v. 1.11.1
2015-01-28 19:43:20 +01:00
Robin Ward
053d3120f7 Updated incorrect comment 2015-01-28 13:38:40 -05:00
Robin Ward
8fc477ab07 More refactoring to support extensibility of history 2015-01-28 13:37:06 -05:00
Robin Ward
4a46d4ee35 Refactor and enable extensibility in PostRevisionSerializer 2015-01-28 13:37:06 -05:00
Robin Ward
d43944b3ed Extensibility for tracking changes to a topic 2015-01-28 13:37:06 -05:00
Dan Singerman
dbf2f4efec Fix bug when sso_overrides_avatar is true but no avatar_url is passed
If a user has a current avatar, and sso_overrides_avatar is true, but no avatar_url is
passed in the sso attributes, the current code errors, as it tries to parse a nil
as a URL. It seems to me valid that a third party system may not pass an avatar_url in
some cases (e.g. avatars may not be mandatory, so not all users may have them)

This might warrant a discussion about what should happen in this case; maybe the current
avatar in discourse should be removed? This branch merely stops the login process erroring.
2015-01-28 16:01:39 +00:00
Régis Hanol
b003c2b4f3 let's try category class again 2015-01-27 23:44:47 +01:00
Arpit Jalan
5128aa1052 Minor code optimization 2015-01-27 22:51:57 +05:30
Arpit Jalan
12c82bed59 Disable digest emails site setting 2015-01-27 22:41:36 +05:30
Greg Kempe
d99ccf6d27 FIX: creating a user shouldn't error when optional fields aren't provided
This fixes a bug where the server would 500 if the only user fields
where optional ones, and the create_user call didn't provide any
values so that params[:user_fields] was nil.

Additionally, don't bother double-checked for required fields, since we
iterate over all fields and will catch any that are required and blank.
2015-01-27 11:48:27 +02:00
Sam
fbd18f3b69 Merge pull request #3132 from lidlanca/patch-4
Perf UX : reduce page paint on scrolling, due to fixed header element union with progress bar area
2015-01-27 14:40:49 +11:00
Sam
d52b0a2458 temporarily disable category class on body while debugging issue with missing docking header 2015-01-27 13:43:40 +11:00
lidlanca
0ffea11ccb Perf UX : reduce page paint on scrolling, due to fixed header element union with progress bar
Should provide some performance improvement for scrolling on chrome
The fixed header and the fixed progress bar on both ends  of the screen will invoke a complete visible page redraw.

For whatever reason this css should make things better for low performance devices. only tested on chrome superficially.
2015-01-26 20:47:43 -05:00
Sam
497042ddf2 FIX: don't restrict to local filesystem for df check
FIX: check correct directory when looking at backup limits
2015-01-27 08:25:57 +11:00
Régis Hanol
efd65dcc8c hard match domains for automatic group membership 2015-01-26 23:17:29 +01:00
Régis Hanol
088260f053 BREAK: improve consistency by using 'category-<slug>' instead of 'category-<id>' as css class 2015-01-26 23:11:41 +01:00
Robin Ward
51827b06ac Merge pull request #3130 from techAPJ/master
FEATURE: suppress digest emails for users not seen on the site for more ...
2015-01-26 13:12:47 -05:00
Régis Hanol
3b3c0d7088 add category name as a css class to topic list item (props to @lagwagon) - closes #3129 2015-01-26 18:43:55 +01:00
Arpit Jalan
5c2ee8ec2a FEATURE: suppress digest emails for users not seen on the site for more than (n) days. 2015-01-26 22:04:02 +05:30
Robin Ward
30cd341b0d UX: Max width of .gifv videos 2015-01-26 11:00:18 -05:00
Robin Ward
b3a9f91bd3 UX: You should be able to tab to the "This is a warning" checkbox 2015-01-26 10:52:17 -05:00
Jeff Atwood
8ef2a111a0 fix left margin on tablet portrait w/topic + list 2015-01-25 23:45:36 -08:00
Régis Hanol
78a7fb4b07 Merge pull request #3125 from gschlager/bugfix_01
FIX: Loading of Emoji files depended on working directory
2015-01-25 17:42:16 +01:00
Jeff Atwood
bab5167566 tighten up suggested topic table layout 2015-01-25 00:33:52 -08:00
riking
9e9119d1c1 FEATURE: Enable pagination of /posts.json 2015-01-23 21:22:19 -08:00
riking
1d24d8471e FEATURE: Latest posts endpoint at /posts.json 2015-01-23 21:16:03 -08:00
riking
fb72e2665f PERF 🐎 Don't calculate preload data for non-xhr json requests
This will help out anyone querying as API instead of through a
browser.
2015-01-23 21:14:58 -08:00
Jeff Atwood
246ae75a31 FIX: language was not being inserted into RSS 2015-01-23 15:57:29 -08:00
Gerhard Schlager
361b3fb07a FIX: Loading of Emoji files depended on working directory
The importer scripts could not be used unless the working directory was
the Discourse root directory.
2015-01-24 00:07:39 +01:00
Jeff Atwood
4904eeaa67 more pastel (desaturated) progress bar 2015-01-23 14:03:27 -08:00
Jeff Atwood
545d5b4906 turn down lightness scale of progress bar a bit 2015-01-23 12:39:07 -08:00
Robin Ward
d06d050eb7 UX: When oneboxing a topic, use the stripe category badge 2015-01-23 15:12:42 -05:00
Régis Hanol
f7f5e39f75 FIX: Minor Admin bug with a setting when creating a new group 2015-01-23 20:31:48 +01:00
Régis Hanol
e6f849f873 FIX: make sure pasting an image in the composer is considered as an image instead of an attachment 2015-01-23 19:17:33 +01:00
Régis Hanol
256519dddf FEATURE: automatic group membership based on email address 2015-01-23 18:25:43 +01:00
Robin Ward
2ea4c1c9de FIX: Groups post page was broken.
Also added integration tests so we don't miss this breaking in the
future.
2015-01-23 11:13:27 -05:00
Robin Ward
848d60d459 FIX: Posts weren't highlighting on initial load 2015-01-23 10:46:44 -05:00
Régis Hanol
ea1d53f848 Merge pull request #3121 from techAPJ/patch-1
FIX: full user names were showing up in crawlers and rss feeds in spite ...
2015-01-22 18:28:50 +01:00
Robin Ward
b3a2c0c45b SECURITY: The SSO return_path was an open redirect
This security fix needs SSO to be configured, and the user has to go
through the entire auth process before being redirected to the wrong host so
it is probably lower priority for most installs.
2015-01-22 12:20:17 -05:00
Arpit Jalan
63556a904a FIX: full user names were showing up in crawlers and rss feeds in spite enables_names setting being disabled 2015-01-22 22:34:35 +05:30
Robin Ward
7741e4dc02 Change the admin-menu outlet to use a tagName of li 2015-01-21 16:21:27 -05:00
Robin Ward
9e82c41576 Merge pull request #3119 from techAPJ/patch-3
FIX: user name and title were not showing on post creation
2015-01-21 16:04:00 -05:00
Arpit Jalan
62c1291548 FIX: user name and title were not showing on post creation 2015-01-22 02:28:04 +05:30
Régis Hanol
141f697482 remove unused route 2015-01-21 20:54:07 +01:00
Régis Hanol
e300945879 FEATURE: split group admin in 2 tabs (custom & automatic)
FIX: clear the user-selector when adding new members
2015-01-21 20:52:48 +01:00
Robin Ward
03eb4752d1 Add categories-list css class to body for customization purposes 2015-01-21 14:34:01 -05:00
Robin Ward
48c7e20d80 DRY up the displaying of topic categories. Should not be duplicated. 2015-01-21 12:20:39 -05:00
Robin Ward
df8880a71a FIX: (for IE9) if console.log doesn't exist, make it an noop. 2015-01-21 11:53:41 -05:00
Jeff Atwood
1ed34be1b9 make topic list pin color consistent with lock 2015-01-21 03:15:56 -08:00
Jeff Atwood
e5cad726fd further tweaks to get post selection OK on mobile 2015-01-20 22:51:15 -08:00
Jeff Atwood
c4ddc5b983 quick mobile css fix for post selection buttons 2015-01-20 17:28:06 -08:00
Jeff Atwood
aa423212a0 make topic list bookmark color consistent with lock 2015-01-20 16:39:11 -08:00
Robin Ward
614ad4daa7 UX: Formatting on search categories looked weird 2015-01-20 17:51:12 -05:00
Robin Ward
649dfd8d23 Revert "Convert html.js to ES6 module format"
This reverts commit 60523d8e02.
2015-01-20 16:13:42 -05:00
Robin Ward
60523d8e02 Convert html.js to ES6 module format 2015-01-20 16:07:29 -05:00
Robin Ward
e3b4d12e46 Merge pull request #3110 from riking/notification_lanaguage
FIX: Respect user locale for reply notifications
2015-01-20 15:17:18 -05:00
Robin Ward
350554e198 UX: Change category badge style to use stripes 2015-01-20 14:56:06 -05:00
Robin Ward
f3c9310e12 Merge pull request #3117 from techAPJ/patch-1
FEATURE: rate limit invites for non-staff users
2015-01-20 10:45:00 -05:00
Neil Lalonde
4c0129ccdd PERF: slow user pages in admin. add an index for trust level 3 calculations, and memoize query results 2015-01-19 15:30:16 -05:00
Arpit Jalan
5e751ce90a FEATURE: 🎁 rate limit invites for non-staff users 2015-01-20 01:12:24 +05:30
Neil Lalonde
7412ff4da7 FIX: suspended users are logged out when they are suspended. Show a reason for suspension when they try to log in. 2015-01-19 12:37:02 -05:00
Arpit Jalan
7687c95e7b UX: add file size in CSV export notification 2015-01-19 19:21:53 +05:30
Jeff Atwood
90ff92e008 don't show self-bookmark avatar in user stream 2015-01-19 01:08:39 -08:00
Jeff Atwood
3f7fa46af7 remove unnecessary site header title height 2015-01-19 00:44:23 -08:00
Jeff Atwood
3d0e59942c IE9 doesn't support console.log 2015-01-19 00:33:51 -08:00
riking
03fd275b45 FIX: Respect user locale for reply notifications 2015-01-17 23:17:50 -08:00
riking
1ab0d6bd82 FEATURE: Log username changes by staff
Also fix the tests for changing username
2015-01-17 02:26:12 -08:00
Robin Ward
37d73ec488 Support customizing the composer below the textarea 2015-01-16 12:52:40 -05:00
Jeff Atwood
24b282e5e9 clicking expanded post date also jumps to post 2015-01-16 03:06:19 -08:00
Régis Hanol
7a86abd105 Merge pull request #3084 from jmay/group-managers
table & model changes for group managers with permission to edit members
2015-01-16 12:02:38 +01:00
Jeff Atwood
2b877e4fc4 post expansion arrow CSS cleanup 2015-01-16 02:24:49 -08:00
Jeff Atwood
d890248963 normalize post expansion arrow on right 2015-01-16 01:56:36 -08:00
Jeff Atwood
992ad7991b UX: change private category to lock glyph 2015-01-15 14:07:21 -08:00
Robin Ward
987504c6ab Rename no_js layout to no_ember
While *sometimes* `no_js` was used for visitors without js (for example
disabling it on your browser) it was also used for some pages that were
disabled to JS capable browsers, including the 404 page.

Even worse, sometimes it was used on pages that *had* Javascript, such
as our `/activate-account` route. It has been renamed to `no_ember` to
indicate what it really is, a layout for the site that doesn't load our
Ember.js application.
2015-01-15 15:56:53 -05:00
Robin Ward
e4e239c159 Add some safety when rendering a dropdown button to make sure it has
content.
2015-01-15 15:43:37 -05:00
Robin Ward
dc801bb442 Merge pull request #3102 from techAPJ/patch-2
Add username and date-time in exported file name
2015-01-15 15:35:06 -05:00
Robin Ward
505fa9f1cf FIX: 🐛 Saving the same custom field array twice would raise an error 2015-01-15 15:31:50 -05:00
Jeff Atwood
3ab2f105b4 switch no_js view back to old layout 2015-01-15 12:29:37 -08:00
Arpit Jalan
c619aed8f9 💄 add username and date-time in exported file name 2015-01-16 01:39:46 +05:30
Robin Ward
9c977a08cd FIX: 🐛 supress the category badge even when refreshing 2015-01-15 14:59:51 -05:00
Jason W. May
a2b284a0a4 table & model changes for group managers with permission to edit membership 2015-01-15 11:44:42 -08:00
Régis Hanol
20d2908c50 FEATURE: add a global notice whenever emails are disabled (disable_emails site setting) 2015-01-15 19:32:19 +01:00
Robin Ward
6c4c542ae3 FIX: Triggering a refresh while subcategory lists was broken.
It would then list all categories isntead of the subcategory you were
viewing at that time.
2015-01-15 13:01:35 -05:00
Régis Hanol
b4e5937850 FIX: 🐛 ensure emoji are case insensitive 2015-01-15 19:00:55 +01:00
Régis Hanol
beea92a74b FIX: 🐛 show email button wasn't working on user's profile page 2015-01-15 17:58:50 +01:00
Jeff Atwood
ef8976d68a better no-js and crawler image sizing 2015-01-15 02:20:38 -08:00
Jeff Atwood
71bfde3b4d meant device-width there, oops 2015-01-15 01:37:02 -08:00
Jeff Atwood
6b30f8444e normalize crawler and no-js views 2015-01-15 01:31:30 -08:00
Jeff Atwood
4cf4f1f252 Merge pull request #3101 from techAPJ/patch-1
set csv compression to optimal speed/size
2015-01-15 00:43:38 -08:00
Jeff Atwood
5c92c39003 remove csrf, font-face, css from js-off + crawler 2015-01-15 00:41:30 -08:00
Jeff Atwood
6a6e254096 move viewport meta tag out of shared header 2015-01-15 00:24:39 -08:00
Arpit Jalan
5039213840 set csv compression to optimal speed/size 2015-01-15 09:07:53 +05:30
Jeff Atwood
655dd66884 change JS-off "emergency" viewport to 720px 2015-01-14 17:06:45 -08:00
Jeff Atwood
0a4582fbc7 add meta viewport tag to JS-off view just in case 2015-01-14 16:56:01 -08:00
Robin Ward
a28784c8f7 Add a {{plugin-outlet}} for the admin-menu 2015-01-14 16:05:29 -05:00
Robin Ward
f8d3764d5e Convert many buttons to d-button 2015-01-14 15:50:20 -05:00
Robin Ward
e7443247dd Adds plugin-outlet for topic menu buttons. Also a d-button component. 2015-01-14 15:50:20 -05:00
Robin Ward
28f702a5b6 Refactor app events to more efficiently handle post highlighting 2015-01-14 15:50:19 -05:00
Robin Ward
78d5d22776 FIX: Posts weren't highlighting when jumping using the progress widget 2015-01-14 15:50:19 -05:00
Régis Hanol
07d3f0fc26 Merge pull request #3100 from riking/patch-1
Set Turkish pluralization rules
2015-01-14 19:52:37 +01:00
Kane York
31c8b5763f Set Turkish pluralization rules
Turkish does not have different forms for singulars next to numerals
https://meta.discourse.org/t/turkish-translation-missing-many-singular-strings/23334/
2015-01-14 10:39:31 -08:00
Arpit Jalan
c4da9ce62f FIX: old csv's were not getting deleted 2015-01-15 00:00:39 +05:30
Régis Hanol
6734a51b6a move SiteText.{head,top,bottom} to SiteCustomization 2015-01-14 12:15:53 +01:00
Arpit Jalan
835835832f FIX: user list export was failing 2015-01-14 16:24:42 +05:30
Régis Hanol
b34ef26f90 Merge pull request #3096 from techAPJ/patch-1
gzip csv export files
2015-01-14 09:23:15 +01:00
Arpit Jalan
b94c7922c5 🐎 gzip csv export files 2015-01-14 13:38:37 +05:30
Robin Ward
8b87d8ac2d Refactor sharing dialog for extensibility 2015-01-13 17:26:05 -05:00
Robin Ward
0de6226a20 FIX: Remove Bookmark was broken on bookmarks page
This was particularaly bad now that we removed stars :)
2015-01-13 13:14:58 -05:00
Arpit Jalan
7771d2fb31 remove enable_email_names setting 2015-01-13 13:35:40 +05:30
Jeff Atwood
935df99acf fix minor mobile topic styling issue 2015-01-12 17:26:04 -08:00
Robin Ward
f3b72f5d96 Revert "move SiteText.{head,bottom} to SiteCustomization and remove redundant SiteText.top"
This reverts commit 6ee2849df6.
2015-01-12 20:21:22 -05:00
Robin Ward
1e6dea46dd FIX: Jump to post was not respecting gaps 2015-01-12 18:10:30 -05:00
Arpit Jalan
bbb23bb736 FIX: users tab in admin panel doesn’t stay highlighted 2015-01-13 02:04:59 +05:30
Robin Ward
dba57a4a25 Add title to user header. Refactor statusIcon a bit. 2015-01-12 14:45:43 -05:00
Régis Hanol
6ee2849df6 move SiteText.{head,bottom} to SiteCustomization and remove redundant SiteText.top 2015-01-12 19:59:43 +01:00
Régis Hanol
03b053c800 FIX: bookmark button is now solid black by default & blue when bookmarked 2015-01-12 17:48:54 +01:00
Régis Hanol
645a22fdd5 FIX: background fade-in for modal dialogs 2015-01-12 16:29:38 +01:00
Régis Hanol
f0f1afff03 FIX: forgot i18n associated with bookmark button (:fired:) 2015-01-12 16:05:17 +01:00
Régis Hanol
c681b353f2 FEATURE: bookmark topic button 2015-01-12 12:10:15 +01:00
Jeff Atwood
a9ef92f3d8 latest topics on category page too damn small 2015-01-12 02:56:55 -08:00
Jeff Atwood
84286fb501 normalize topic post first element top-margins:0 2015-01-12 02:24:06 -08:00
Jeff Atwood
5f05e1394b consistent post top margins 2015-01-12 00:35:04 -08:00
Jeff Atwood
8d49aec789 clean up leftover bottom-round padding 2015-01-11 23:51:19 -08:00
Jeff Atwood
76c750be68 get rid of .bottom-round css class used once 2015-01-11 23:39:48 -08:00
Jeff Atwood
e572ad35ad new topic/post alert div regressed a bit on mobile 2015-01-23 23:39:44 -08:00
Jeff Atwood
7d268ff49f give home icon more breathing room 2015-01-09 15:18:42 -08:00
Robin Ward
38e4defaee Support adding items to the site map via plugin outlet. 2015-01-09 16:15:16 -05:00
Sam
d54e2770a1 correct build 2015-01-09 16:54:58 +11:00
Jeff Atwood
625c920c4f fix mobile layout issue with download posts btn 2015-01-08 17:32:24 -08:00
Sam
1358ed2aad FEATURE: show bookmarked topics in topic list 2015-01-09 11:41:10 +11:00
Robin Ward
7124456ae4 Merge pull request #3083 from cpradio/pr-add-class-to-gutter-links
UX: Add class to gutter links so you can infer if they are inbound or outbound using CSS
2015-01-08 17:35:25 -05:00
Robin Ward
0bc0bd7a21 Pass the current_user to the topic saved event 2015-01-08 17:29:11 -05:00
cpradio
fdfde22d0b UX: Add class to gutter links so you can infer if they are inbound or outbound using CSS 2015-01-08 17:20:50 -05:00
Robin Ward
74051a2df4 Allow plugins to build topic lists 2015-01-08 16:44:27 -05:00
Sam
69cfab62b8 PERF: don't bind all these things
TODO - cleaner pattern and helper for this
2015-01-08 14:50:20 +11:00
Sam
3347a48275 FEATURE: add liked and bookmarked classes to topic list item rows 2015-01-08 14:35:56 +11:00
Sam
df7def6628 annotate 2015-01-08 11:18:43 +11:00
Robin Ward
c02a31d8b4 Raw templates should resolve their views with the resolver 2015-01-07 14:21:31 -05:00
Régis Hanol
8627a1e507 FIX: making sure {{fa-icon}} don't break when we'll update to latest ember 2015-01-07 18:14:31 +01:00
Régis Hanol
2b3e311e8e FIX: emoji rebuild when changing emoji set for the 1st time 2015-01-07 17:54:09 +01:00
Robin Ward
114cc1c851 FIX: We missed some references to /category/xyz in the ruby code base. 2015-01-07 11:47:01 -05:00
Régis Hanol
65f0339146 FIX: un-delete topic wasn't working 2015-01-07 10:53:12 +01:00
Régis Hanol
66882155f0 FIX: emoji toolbar wasn't showing up after a page reload 2015-01-07 10:46:43 +01:00
Régis Hanol
6512e403ae FIX: each helper in raw templates 2015-01-07 09:30:32 +01:00
Sam
6785675150 clean up support for filter=liked and filter=bookmarked 2015-01-07 18:50:28 +11:00
Sam
984f8f0c27 FEATURE: show bookmarked topics when doing filter=bookmarked 2015-01-07 18:20:41 +11:00
Sam
ea87f5fd8a FEATURE: support for filter=bookmarked and filter=liked in topic list 2015-01-07 18:20:10 +11:00
Sam
da3da6feee each ... in ... support for ember compat handlebars 2015-01-07 18:18:26 +11:00
Sam
95f9788a77 FEATURE: add ?bookmarked=true for topic lists 2015-01-07 13:58:34 +11:00
Sam
efc717c14a FEATURE: remove star concept from Discourse 2015-01-07 13:43:27 +11:00
Jeff Atwood
fa8493118b remove underline on composer cancel, hide preview 2015-01-06 16:35:57 -08:00
Jeff Atwood
86c13ada44 fix a few places we were using /category vs /c 2015-01-06 15:56:07 -08:00
Neil Lalonde
880dcbb365 Merge branch 'master' of github.com:discourse/discourse 2015-01-06 17:28:58 -05:00
Neil Lalonde
58385248a6 Show contact_email on about page 2015-01-06 17:28:42 -05:00
Jeff Atwood
a398f356ae clean up unused category page CSS 2015-01-06 14:15:12 -08:00
Robin Ward
704ac91a22 FIX: Broken spec 2015-01-06 17:06:24 -05:00
Robin Ward
6d539c0afd You don't need to call buildRoutes anymore.
Just export a function in a module called `route-map` and discourse's
rotuer will do the rest. This makes it a lot easier to define routes in
plugins.
2015-01-06 17:00:25 -05:00
Jeff Atwood
b9d773ddcd private category layout on /categories was busted 2015-01-06 13:42:41 -08:00
Robin Ward
5667478b4d A common, extensible interface for sending topic columns across the wire
This allows plugins to specify topic columns to serialize and save in
the database via the composer when creating topics and editing their
first posts.
2015-01-06 14:53:12 -05:00
Robin Ward
97b4dec96c Move the new composer-fields outlet into the proper div 2015-01-06 12:19:52 -05:00
Robin Ward
8ee0f4d1e7 Use javascript to resize the composer properly rather than using the
type of composer being used.
2015-01-06 12:05:11 -05:00
Robin Ward
4318d6a2bd FIX: Deactivate check was removed from JSON by accident 2015-01-06 11:06:05 -05:00
Jeff Atwood
9497258912 billions and billions of stars? I DONT THINK SO 2015-01-06 01:53:20 -08:00
Jeff Atwood
76b9aa22d6 f**k stars right in their little star-holes 2015-01-06 01:38:00 -08:00
Jeff Atwood
d1b0939e02 add contact info to /about 2015-01-05 22:42:13 -08:00
Sam
a99c3c3df9 FEATURE: allow users to persist customization with &sticky=true 2015-01-06 17:39:08 +11:00
Sam
e6dba8adc2 SECURITY: don't echo the "strategy" param returned by auto provider 2015-01-06 16:28:45 +11:00
Jeff Atwood
77f5c74ddd FEATURE: add std /staff page link from /faq 2015-01-05 16:33:21 -08:00
Sam
d036d461dc FEATURE: only expand globally pinned topics on front page 2015-01-06 07:44:52 +11:00
Robin Ward
c7d86f89e4 Add more plugin outlets for the topic header 2015-01-05 15:34:41 -05:00
Sam
e089f699c1 upgrade pg to version 0.18, may fix encoding issue 2015-01-06 06:16:22 +11:00
Régis Hanol
e20078a9dc PERF: fix performance issue when displaying the user card for admins 2015-01-05 19:49:32 +01:00
Régis Hanol
47c4179e29 make jshint happy ❤️ 2015-01-05 18:58:36 +01:00
Régis Hanol
060cda7772 FIX: proper handling of group memberships 2015-01-05 18:51:45 +01:00
Neil Lalonde
4975fc2890 Remove old access_password_removal cruft from 1.5 years ago 2015-01-05 12:04:27 -05:00
Neil Lalonde
024b88e9c2 FIX: dashboard should be warning about invalid notification_email site setting 2015-01-05 12:04:27 -05:00
Sam
fce74e64a1 correct missing new/unread badges 2015-01-05 19:31:29 +11:00
Sam
e97aa3f544 fix params that are send to category route 2015-01-05 18:34:06 +11:00
Sam
9c250444ff regression, navigating to category leaves phantom columns 2015-01-05 18:18:50 +11:00
Sam
222964b27b add perf note 2015-01-05 17:54:38 +11:00
Sam
0396fd66f6 FEATURE: sorting by op likes shows the op likes count 2015-01-05 17:39:49 +11:00