Commit graph

590 commits

Author SHA1 Message Date
riking
8979020b9d Clean up unused translations 2014-09-02 15:40:23 -07:00
riking
3413228e89 UX: Change Impersonate to btn-danger 2014-09-02 15:33:54 -07:00
riking
1833b43ae2 FEATURE: Badge query validation, preview results, and EXPLAIN
Upon saving a badge or requesting a badge result preview,
BadgeGranter.contract_checks! will examine the provided badge SQL for
some contractual obligations - namely, the returned columns and use of
trigger parameters.

Saving the badge is wrapped in a transaction to make this easier, by
raising ActiveRecord::Rollback on a detected violation.

On the client, a modal view is added for the badge query sample run
results, named admin-badge-preview.
The preview action is moved up to the route.
The save action, on failure, triggers a 'saveError' action (also in the
route).

The preview action gains a new parameter, 'explain', which will give the
output of an EXPLAIN query for the badge sql, which can be used by forum
admins to estimate the cost of their badge queries.
The preview link is replaced by two links, one which omits (false) and
includes (true) the EXPLAIN query.

The Badge.save() method is amended to propogate errors.

Badge::Trigger gets some utility methods for use in the
BadgeGranter.contract_checks! method.

Additionally, extra checks outside of BadgeGranter.contract_checks! are
added in the preview() method, to cover cases of null granted_at
columns.

An uninitialized variable path is removed in the backfill() method.

TODO - it would be nice to be able to get the actual names of all
columns the provided query returns, so we could give more errors
2014-08-31 11:25:44 -07:00
Neil Lalonde
ec42b61a4d FIX: suspended users cannot be trust level 3 2014-08-29 12:33:34 -04:00
Régis Hanol
fd6dd88afb FIX: dual modal when deleting spammer in the flag modal 2014-08-29 13:05:51 +02:00
Régis Hanol
521cb6bd0d FIX: dual modal when selecting 'delete spammer' in flags section 2014-08-29 12:54:24 +02:00
Jeff Atwood
8bda8a2235 Revert "UX: stop displaying "user deleted, OK" dialog"
This reverts commit 36405287b4.
2014-08-29 03:49:00 -07:00
Jeff Atwood
36405287b4 UX: stop displaying "user deleted, OK" dialog 2014-08-29 03:34:23 -07:00
Robin Ward
9e2c72e277 Allow restoring from backups in development mode even if the setting is
off.
2014-08-28 17:02:48 -04:00
Robin Ward
09ea159afc UX: Add link to change username on admin page 2014-08-27 13:52:01 -04:00
Jeff Atwood
553e0290a6 mods can use shield glyph as well, don't need two 2014-08-25 23:49:39 -07:00
riking
4db5c8d617 Add data-auto-route=true to Logster link 2014-08-25 15:59:48 -07:00
Jeff Atwood
bd66c67398 whoops, used font awesome 3.2 styles :( 2014-08-24 22:20:59 -07:00
Jeff Atwood
01853fb9d3 replace trophy with shield to indicate admin 2014-08-24 22:05:11 -07:00
Sam
e0a74e336a Add SSO diagnostics 2014-08-23 10:34:48 +10:00
Neil Lalonde
bbb358b356 Add likes given and likes received requirement for being TL3. Configure with site settings leader_requires_likes_given and leader_requires_likes_received. 2014-08-22 17:33:39 -04:00
Neil Lalonde
00c28f2391 Show total likes given. Put likes given/received and flags given/received together. 2014-08-22 15:23:19 -04:00
Neil Lalonde
dafc63e3a0 Show how many likes users received in the last 100 days on their admin profile page 2014-08-22 14:37:07 -04:00
Sam
136169bc73 Merge pull request #2676 from riking/logster-link
Add link to Logster in "Logs" tab of admin panel
2014-08-22 10:21:04 +10:00
riking
50d4e283dc Add link to Logster in "Logs" tab of admin panel 2014-08-20 14:40:16 -07:00
Régis Hanol
5b1785157d TRIVIAL: fix deprecations due to momentjs upgrade 2014-08-20 22:22:58 +02:00
Robin Ward
33de48dc0c FIX: Float site settings were marked as overridden, reset didn't work. 2014-08-20 15:24:56 -04:00
Robin Ward
d35633deab FIX: Using a binding in an {{avatar}} was broken 2014-08-20 15:12:18 -04:00
Régis Hanol
dbb4258e86 FIX: user avatar in flags list 2014-08-20 19:21:19 +02:00
Régis Hanol
8a20d05ba5 FEATURE: backup without uploads 2014-08-20 18:53:58 +02:00
Régis Hanol
9f72971d26 FEATURE: add the pencil glyph when the post was edited after the first flag 2014-08-18 18:56:39 +02:00
Jeff Atwood
582ec5954f fix incorrect translation string 2014-08-16 23:18:13 -07:00
Jeff Atwood
967120f23e Merge pull request #2663 from gschlager/i18n_fix01
Add missing translation
2014-08-16 23:11:58 -07:00
Jeff Atwood
6795d378b4 remove a few strings on admin in favor of glyphs 2014-08-16 22:53:41 -07:00
Gerhard Schlager
6b286ad4f4 Add missing translation 2014-08-17 00:29:39 +02:00
Robin Ward
167f393a03 Merge pull request #2655 from techAPJ/patch-3
FEATURE: export user list
2014-08-14 17:19:49 -04:00
Arpit Jalan
d0736a06b6 FEATURE: export user list 2014-08-15 01:46:57 +05:30
Neil Lalonde
26a404f4d0 FIX: confusing UI when clicking Delete All Posts button 2014-08-14 15:21:16 -04:00
Régis Hanol
9b4c18baf1 Merge pull request #2636 from meglio/color-tags
Show color for values of type:list site settings with word 'colors' in t...
2014-08-13 21:52:14 +02:00
Robin Ward
0adfeb1cff ES6: Mega update of controllers 2014-08-13 10:22:47 -04:00
Jeff Atwood
c89a354fb1 clean up some flag page styles and alignment 2014-08-12 23:52:43 -07:00
Jeff Atwood
506162b719 clarification on delete and block 2014-08-12 03:14:50 -07:00
Régis Hanol
5e41408b55 FEATURE: use less space for flag dispositions 2014-08-11 22:28:11 +02:00
Anton Andriyevskyy
f58bf751bc Show color for values of type:list site settings with word 'colors' in their name 2014-08-11 19:54:03 +03:00
Régis Hanol
ec6ba68098 FEATURE: use glyphs instead of text in flag's dispositions 2014-08-11 18:21:34 +02:00
Jeff Atwood
ddbcba145d add ellipsis to flag buttons, better tooltips 2014-08-07 16:39:12 -07:00
Jeff Atwood
2690a758e6 use hide icon for Agree and Hide Post 2014-08-07 03:12:23 -07:00
Régis Hanol
4589bce21b FIX: proper property brace expansion syntax :( 2014-08-06 21:22:36 +02:00
Régis Hanol
ec30086dea FEATURE: agree all the flags 2014-08-04 22:48:04 +02:00
Jeff Atwood
71aa41ccac copyedits on new flagging behaviors 2014-07-31 16:17:38 -07:00
Régis Hanol
78e33f1931 FIX: link to the flagged post instead of its topic 2014-07-30 11:16:49 +02:00
Sam
5c72297695 FEATURE: clean up badges admin 2014-07-30 08:56:46 +10:00
Sam
ebf385aedc FEATURE: allow title overridable 2014-07-30 08:46:59 +10:00
Robin Ward
ac4a33a656 FIX: Display proper error message when changing a trust level fails 2014-07-29 15:54:20 -04:00
Régis Hanol
a49a8e8c05 FIX: no primary action on disposition buttons 2014-07-29 09:36:12 +02:00
Régis Hanol
9d864ab28a FIX: show disposition buttons when flagging a topic 2014-07-29 09:34:58 +02:00
Régis Hanol
bddffa7f9a FEATURE: flag dispositions normalization
All flags should end up in one of the three dispositions
  - Agree
  - Disagree
  - Defer

In the administration area, the *active* flags section displays 4 buttons
  - Agree (hide post + send PM)
  - Disagree
  - Defer
  - Delete

Clicking "Delete" will open a modal that offer to
  - Delete Post & Defer Flags
  - Delete Post & Agree with Flags
  - Delete Spammer (if available)

When the flag has a list associated, the list will now display 1
response and 1 reply and a "show more..." link if there are more in the
conversation. Replying to the conversation will NOT give a disposition.
Moderators must click the buttons that does that.

If someone clicks one buttons, this will add a default moderator message
from that moderator saying what happened.

The *old* flags section now displays the proper dispositions and is
super duper fast (no more N+9999 queries).

FIX: the old list includes deleted topics
FIX: the lists now properly display the topic states (deleted, closed,
archived, hidden, PM)
FIX: flagging a topic that you've already flagged the first post
2014-07-28 19:28:07 +02:00
Sam
f9162d6add FIX: moderators had no access to admin user page 2014-07-28 11:59:46 +10:00
Sam
1a6aa07611 FEATURE: editable badge groups 2014-07-27 18:22:01 +10:00
riking
8af4ab2a63 Use settingName in settings_list like the others 2014-07-25 13:19:43 -07:00
Robin Ward
15a51c6316 ES6: Patch up a few issues with the admin controllers conversion 2014-07-25 14:17:58 -04:00
Joshua Gorner
e242368266 Convert admin section controllers to ES6 modules 2014-07-25 14:17:58 -04:00
Sam
ae686e8188 FIX: no new badges could be created 2014-07-25 15:48:43 +10:00
Sam
ec03d135fa FEATURE: allow advanced badge options in admin screen
clean up serializer, allow simplistic preview
2014-07-24 18:28:23 +10:00
Sam
469e74316b FIX: don't show broken button 2014-07-24 18:28:23 +10:00
Robin Ward
c8a0bf35c5 FIX: Navigating to a user's admin page would not populate
`availableGroups`
2014-07-23 16:54:04 -04:00
Sam
b9a7d945c3 Improve badge grouping UI
Start work on triggers
2014-07-23 11:43:17 +10:00
Robin Ward
d9e5c2317f FIX: If a topic title edit fails, revert to previous title. 2014-07-21 13:39:23 -04:00
Robin Ward
f06f8abedd Merge pull request #2537 from ligthyear/group-member-management-on-user
Improved Group Member Management on User Administration
2014-07-17 11:00:05 -04:00
Sam
e8ca1a2469 FEATURE: allow overriding badge names
FEATURE: allow html in badge description
2014-07-17 16:11:09 +10:00
Neil Lalonde
823061a2cf FIX: handle enter key with a better way on site setting string inputs 2014-07-15 17:32:45 -04:00
Benjamin Kampmann
67d127ec5c make jshint happy: missing semicolon 2014-07-15 17:12:03 +02:00
Benjamin Kampmann
518207aa90 move ajax into models 2014-07-15 16:11:39 +02:00
Benjamin Kampmann
5025e97712 move available groups loader into router 2014-07-15 15:48:02 +02:00
Benjamin Kampmann
2435961b58 use computed 2014-07-15 15:43:53 +02:00
Benjamin Kampmann
6710637904 renamed 2014-07-15 15:35:16 +02:00
Jeff Atwood
6412958d1e make Send Test Email easier to see 2014-07-14 13:58:06 -07:00
Sam
88469721b9 FEATURE: Allow admins to disable specific badges 2014-07-14 17:40:36 +10:00
Benjamin Kampmann
ac3f1ba3d6 Improved Group Member Management on User Administration
Allows for a quick and easy group membership management on the
user-administration page. Uses the select2 UI component to
autosuggest other groups, remove existing ones and lock in automatic
groups.
2014-07-13 20:11:38 +02:00
Neil Lalonde
d13dbaaa36 FEATURE: enter key in site setting input saves it 2014-07-11 14:44:30 -04:00
Jeff Atwood
95282a4c6d add badge glyph to edit button 2014-07-09 22:01:03 -07:00
Neil Lalonde
df8b25d2f5 FEATURE: don't demote trust level 3 users who were promoted less than SiteSetting.leader_promotion_min_duration days ago 2014-07-08 17:39:49 -04:00
Régis Hanol
59b5ba7c0f BUGFIX: IP lookup wasn't working when using HTTPS
REFACTOR: the ip locator into a ip-lookup component
2014-07-07 22:18:18 +02:00
Sam
6bbb083d47 FEATURE: support "unlisted" badges. 2014-07-03 17:44:36 +10:00
Neil Lalonde
292e9bb611 TL3: Add requirements for min all-time topics viewed, and min all-time posts read 2014-07-01 13:34:57 -04:00
Sam
777371bf14 Merge pull request #2480 from vikhyat/badge-system
Add consistency check to revoke invalid badges
2014-06-30 14:13:12 +10:00
Neil Lalonde
807bfbd9bb FEATURE: Trust level 3 promotion and demotion. Job is disabled for now. 2014-06-27 18:42:03 -04:00
Vikhyat Korrapati
228a2a8992 Show number of grants on the admin badge pages. 2014-06-28 01:24:07 +05:30
Vikhyat Korrapati
0d16ae0ecf Fix typo. 2014-06-28 01:24:07 +05:30
Robin Ward
85747137ef FIX: Put in admin title when browsing admin section 2014-06-27 11:58:46 -04:00
Neil Lalonde
b69bc5a5f5 Trust level 3 measurements redone 2014-06-26 17:33:22 -04:00
Sam
c23a4fcbee FEATURE: flag resolution in admin screen 2014-06-24 13:20:57 +10:00
Neil Lalonde
3fb74fd880 FIX: list site settings with no choices will not show the 'No results found' dropdown 2014-06-20 18:03:11 -04:00
riking
2d5f667160 Make ?preview-style make sense
New behavior:
?preview-style=(sha) -- see that stylesheet
?preview-style= -- see the currently selected stylesheet
?preview-style=default -- see the default stylesheet ("rescue mode")
2014-06-20 09:06:36 -07:00
Sam
56a04366ec Merge pull request #2431 from vikhyat/badge-system
Custom badge icons
2014-06-20 09:13:29 +10:00
Neil Lalonde
cefdb98b79 Make the Visit topic link a button in flags UI 2014-06-19 18:18:09 -04:00
Neil Lalonde
7d58c43006 FIX: clearfix at bottom of customize/colors UI 2014-06-19 12:33:02 -04:00
Vikhyat Korrapati
e0fd1f6f5e Add ability to specify custom font awesome icon for badges. 2014-06-19 16:56:18 +05:30
Vikhyat Korrapati
67a2b2598d Cosmetic changes. 2014-06-19 16:56:18 +05:30
Benjamin Kampmann
2aabf4fdcd ip locator on ipinfo.io basis added to admin 2014-06-18 09:22:44 +02:00
Jeff Atwood
a0d9dcce17 improve hint on admin user search 2014-06-16 16:17:41 -07:00
Robin Ward
f822491886 ES6: Convert a couple view helpers. They should probably be components
evnetually!
2014-06-11 11:05:49 -04:00
Régis Hanol
3b6b2770f3 BUGFIX: date of the post in the share dialog is now properly bound
CLEANUP: removed all unused handlebars helpers
REFACTOR: removed 'unbound' prefix (for performance reasons, helpers are unbound by default)
REFACTOR: added 'bound' prefix to bound helpers
REFACTOR: renamed helper using 'foo-bar-foo' syntax (instead of camel case)
2014-06-10 19:04:31 +02:00
Robin Ward
580a1bf8b0 ES6: Migrated and deprecated a bunch of views 2014-06-10 11:54:38 -04:00
Neil Lalonde
c61462662b Add ability to run validation on site settings. notification_email and other email address settings are now validated. 2014-06-09 16:59:20 -04:00