Matt Van Horn
872995db57
refactor guardian class for clarity & correctness
...
introduce NullUser to avoid type-checking
DRY up code
reduce number of multiple returns
remove some redundant/impossible logic branches
add pending test for possible bug
add test & fix for ability to flag archived posts
add #secure_category? method to topic class
Fix bug that prevented flagging of archived topics
Rename NullUser to AnonymousUser
DRY up can_<action>? methods
Fix some ownership logic, and a test, for Guardian
2013-05-22 01:09:34 -07:00
Chris Hunt
d0bc8c95d3
Trigger UserActionObserver when tracking visit
2013-05-21 20:45:03 -07:00
Chris Hunt
685f4960f1
Trigger UserActionObserver when updating TopicUser
2013-05-21 20:43:43 -07:00
Robin Ward
27828c5ec2
Merge pull request #871 from avdi/refactoring-with-josh-and-avdi
...
Various refactorings towards Ruby/Rails idiom from Josh Susser and Avdi Grimm
2013-05-21 07:18:50 -07:00
Sam
b5eff93a9d
update message bus to support per client filtering
...
start work on user_tracking_state
fix can_ban? in guardian
expose protected scopes on topic_query we need
move guardian spec to use build as opposed to creating topics / posts / users
start work on user tracking spec
2013-05-21 16:39:51 +10:00
Sam
e91ed83586
the private message stream is different to normal streams, improving the ui a bit and collapsing conversations
2013-05-20 16:44:06 +10:00
Sam
18b00d01d0
Merge pull request #859 from lengarvey/user_refactoring
...
Light refactoring of the User model
2013-05-19 16:41:20 -07:00
Neil Lalonde
5f7f87437c
Fix for topic excerpt being from the wrong post
2013-05-18 13:35:21 -04:00
Leonard Garvey
b16705be0d
Clean up update_visit_record!
...
update_visit_record! appears to add user_visit record if one
doesn't exist and days_visited is simply a counter for the number
of visit records.
2013-05-18 16:02:06 +10:00
Leonard Garvey
32f4dfd2fb
DRY up the user model slightly
...
regular? is just the inverse of staff?
2013-05-18 16:00:35 +10:00
Sam
25105082d5
Merge pull request #850 from bplexico/refactor_post_rb
...
Refactored post model to reduce duplication in validator methods
2013-05-17 15:56:53 -07:00
Josh Susser and Avdi Grimm
2acc80d192
Various idiomatic User refactorings.
2013-05-17 15:44:35 -04:00
Josh Susser and Avdi Grimm
5659b66729
Refactor select().map() to use pluck.
...
Remove a method already provided by ActiveRecord.
2013-05-17 15:11:37 -04:00
Neil Lalonde
191d454589
Show Inbox before Sent Items
2013-05-17 14:11:33 -04:00
Josh Susser and Avdi Grimm
d30330441a
Refactored conditional to an || to be more idiomatic.
2013-05-17 14:06:58 -04:00
Brian Plexico
a86646312b
Refactored post model to reduce duplication in validator methods
2013-05-17 12:15:21 -04:00
Neil Lalonde
f3282e33a3
Add tabs to category create/edit modal. Categories can have a default auto-close setting that applies to all new topics created in the category. Add rspec-given and write some integration tests. Tests for topic auto-close with category default
2013-05-17 11:05:35 -04:00
Sam
8f46653345
refactor
2013-05-17 09:03:52 +10:00
Robin Ward
d554a59102
Support for a new site setting: newuser_spam_host_threshold. If a new user posts a link
...
to the same host enough tiles, they will not be able to post the same link again.
Additionally, the site will flag all their previous posts with links as spam and they will
be instantly hidden via the auto hide workflow.
2013-05-16 12:19:50 -04:00
Sam
04b8cd5c95
consistency check, need to also ensure delete cleans stuff up, maybe make notifications trashable
2013-05-16 17:50:14 +10:00
Sam
eb71e9de24
opening move, don't get rid of green notification till the pm is read
...
TODO a way to list all unread PMs
2013-05-16 16:37:47 +10:00
Sam
e9ebadb414
Nuke message_bus_observer move to service class and classes
...
Secure all messages triggered by post creation and all user actions so they don't leak
(meaning, if you have a browser open and secure topics are created you will only get them if you are allowed to see them)
2013-05-16 15:03:16 +10:00
Lee Machin
dadb7eaa23
fix crash caused by incorrect query in scope
...
setting all categories to be secured led to a blank screen on all pages
use stabby lambda for consistency in class
make the test a little more concise
- move the local assignments into let blocks for
reusability
- remove calls to `to_a`, which aren't needed
- use 'be_empty' instead of '[]' to be consistent
with the other matchers in the test
add a test for the `secured` scope with multiple
secured categories
2013-05-15 22:26:52 +01:00
Neil Lalonde
18634ad00d
Don't cache the problems list with the rest of the dashboard data
2013-05-15 11:09:12 -04:00
Neil Lalonde
21b4b8d5d5
Expire dashboard data when you upgrade to a new discourse version. Version check data was being cached and causing confusion to people who upgraded.
2013-05-14 16:17:25 -04:00
Robin Ward
be234ce9b9
You can now 'move' the first post of a topic to another topic as a merge. In that
...
case, the first post is cloned instead of being deleted from the original topic.
2013-05-13 14:07:31 -04:00
Neil Lalonde
9828c87525
Topic Auto-Close: admins and mods can set a topic to automatically close after a number of days
2013-05-13 12:53:52 -04:00
Sam
670b66ade3
better add some tests here tomorrow
2013-05-13 18:47:32 +10:00
Sam
b6bf95e741
speed up startup (avoid loading some gems on startup)
...
correct group permission leaks
add Discourse.cache for richer caching support
2013-05-13 18:04:03 +10:00
Sam
9b33e826f2
clear flags on reply to notify moderators
2013-05-13 11:48:01 +10:00
Robin Ward
cf01c98d81
Experimental: Interface to Move Posts to an Existing Topic
2013-05-10 14:55:51 -04:00
Sam
942f168ab6
UI still a tad rough, but we have a first pass of secure categories
2013-05-10 16:47:47 +10:00
Sam
5280b3a01b
more group progress, UI getting there, controller mostly done
...
changed it so notify moderators goes to the moderators group
allow admins to grant self moderation and revoke self moderation
2013-05-09 17:37:34 +10:00
Sam
4f328e3e45
+x on files makes no sense unless they really are executable
...
rails in the script dir makes no sense, use binstubs or bundler instead
2013-05-09 17:35:15 +10:00
Sam
0f0fd281a8
group progress, never email banned users
2013-05-09 11:34:58 +10:00
Neil Lalonde
f35a44aeae
Add ability for admins and mods to send another activation email to a user, to activate an account, and deactivate an account
2013-05-08 10:10:47 -04:00
Sam
6b536dcde5
work in progress ... groups
2013-05-08 15:20:38 +10:00
Sam
7571152d1d
fix issue adding users to groups
2013-05-08 10:32:29 +10:00
Neil Lalonde
52ee1928cc
Oops, I made a spec fail by refactoring after I made the test pass and didn't check the tests
2013-05-07 15:40:18 -04:00
Neil Lalonde
8e24a608b0
Show empty categories on categories page to people people who can edit and delete categories
2013-05-07 15:31:56 -04:00
Sam
e9fc272db7
remove acts_as_paranoid, use .trash! , .recover! and .with_deleted as needed
...
makes upgrading to rails 4 possible
2013-05-07 14:39:01 +10:00
Neil Lalonde
69be7d0ad1
Change the title Visits to Clicks in referral tables on admin dashboard
2013-05-06 11:56:35 -04:00
Neil Lalonde
b944157d88
Fix edit uncategorized when on the /category/uncategorized page
2013-05-06 11:22:58 -04:00
Sam
be1ab8b275
automatic group infrustructure
2013-05-06 14:49:56 +10:00
Régis Hanol
392b9696f4
prevent duplicate actions on a post
2013-05-04 02:52:45 +02:00
Neil Lalonde
52942d2de6
Merge pull request #813 from slainer68/ga_domain_name
...
Google Analytics Domain name site setting
2013-05-03 14:57:01 -07:00
Neil Lalonde
c6370a3479
Add ability to edit the uncategorized category name, color, and text_color in a modal
2013-05-03 17:55:04 -04:00
slainer68
ac66f25043
Google Analytics Domain name site setting
2013-05-03 21:58:10 +02:00
Sam
5ec52bd2e9
:s/moderator?/staff/g ... our naming was kind of crazy, renamed moderator? to staff
2013-05-02 17:22:27 +10:00
Sam
65cd00cf25
moderators now have teeth, more at http://meta.discourse.org/t/moderator-permission-set/6307/5
...
allow pms to be targetted at groups
2013-05-02 15:15:53 +10:00
