Commit graph

411 commits

Author SHA1 Message Date
Jeff Atwood
107cffcc84 FIX: revert readonly on share link field 2014-09-08 01:03:50 -07:00
Kris Aubuchon
9eed47f7c5 dark themes now carry over to admin without looking absolutely terrible 2014-09-07 22:46:04 -04:00
Jeff Atwood
65e941f652 UX: remove current username from header 2014-09-07 14:01:51 -07:00
Jeff Atwood
3cf433ab1e FIX: quote icon in Quote Reply not clickable 2014-09-07 13:55:31 -07:00
Jeff Atwood
f5e1a5a669 UX: remove bookmark icon from Unread topnav 2014-09-07 13:20:40 -07:00
Kris Aubuchon
127c2f3d21 making topic/post selection left border stronger 2014-09-06 12:12:22 -04:00
Jeff Atwood
3772102972 better display of topic glyphs in search 2014-09-05 13:17:26 -07:00
Jeff Atwood
dc8fc8c9e4 UX: move "show more" in search to bottom of results 2014-09-05 02:19:06 -07:00
Sam
a3863b52db More highlight tweaking for search, makes it much easier to theme 2014-09-04 18:00:01 +10:00
Sam
0ade9bafff FIX: highlight in yellow, not blue
FEATURE: highlight in title
2014-09-04 15:01:13 +10:00
Kris Aubuchon
06e048bf89 minor unread circle alignment fix 2014-09-04 00:02:29 -04:00
Sam
1f42dda939 factor common code 2014-09-04 13:19:10 +10:00
Sam
a050fa887f FIX: regression, go to quoted post missing in quotes
refactors common code as well
2014-09-04 13:16:19 +10:00
Sam
d6a5552340 tweak new topic styling 2014-09-04 11:07:32 +10:00
Jeff Atwood
7543b37f86 UX: add dot before new topics via css 2014-09-03 13:33:56 -07:00
Robin Ward
17b79fdeda Increase the contrast of the "new" text 2014-09-03 15:37:42 -04:00
Robin Ward
0b6c84e292 UX: Remove background color from new badge. DRY up lots of repeated code
for rendering badges on topics.
2014-09-03 12:22:18 -04:00
Neil Lalonde
6489c1d7e3 FIX: admin page for users who have not been activated makes it more clear that the account is inactive, and won't offer actions that don't work yet 2014-09-03 10:41:13 -04:00
Neil Lalonde
ff136ddeea FEATURE: accounts that have not been activated are grey in admin user lists 2014-09-03 10:09:30 -04:00
Sam
c6aab831ed Merge pull request #2741 from riking/badges_create_checks
FIX: Apply contract checks when first creating a badge
2014-09-03 22:19:09 +10:00
Jeff Atwood
c41d47b8f5 suppress search topic status color a bit 2014-09-03 01:03:53 -07:00
Jeff Atwood
6681d8ab81 Revert "UX: suppress new indicator style"
This reverts commit 870fd70525.
2014-09-03 00:11:25 -07:00
Jeff Atwood
870fd70525 UX: suppress new indicator style 2014-09-02 23:48:41 -07:00
Sam
921dd75dd9 FIX: anonymous had <a> items for pin/unpin
FEATURE: display category in search results
FEATURE: display topic state (locked/pinned/etc) in search results

UI cleanup for search results, clearing floats and so on.
2014-09-03 12:13:26 +10:00
riking
71b7c80257 UX: CSS tweaks for badge query previews 2014-09-02 19:09:51 -07:00
riking
1833b43ae2 FEATURE: Badge query validation, preview results, and EXPLAIN
Upon saving a badge or requesting a badge result preview,
BadgeGranter.contract_checks! will examine the provided badge SQL for
some contractual obligations - namely, the returned columns and use of
trigger parameters.

Saving the badge is wrapped in a transaction to make this easier, by
raising ActiveRecord::Rollback on a detected violation.

On the client, a modal view is added for the badge query sample run
results, named admin-badge-preview.
The preview action is moved up to the route.
The save action, on failure, triggers a 'saveError' action (also in the
route).

The preview action gains a new parameter, 'explain', which will give the
output of an EXPLAIN query for the badge sql, which can be used by forum
admins to estimate the cost of their badge queries.
The preview link is replaced by two links, one which omits (false) and
includes (true) the EXPLAIN query.

The Badge.save() method is amended to propogate errors.

Badge::Trigger gets some utility methods for use in the
BadgeGranter.contract_checks! method.

Additionally, extra checks outside of BadgeGranter.contract_checks! are
added in the preview() method, to cover cases of null granted_at
columns.

An uninitialized variable path is removed in the backfill() method.

TODO - it would be nice to be able to get the actual names of all
columns the provided query returns, so we could give more errors
2014-08-31 11:25:44 -07:00
Jeff Atwood
4281b16616 UX: dim the new and unread education 2014-08-29 22:54:11 -07:00
Régis Hanol
38f52f0f8e FIX: banner topic's max-width & max-height on both mobile & desktop 2014-08-28 16:15:48 +02:00
Robin Ward
09ea159afc UX: Add link to change username on admin page 2014-08-27 13:52:01 -04:00
Sam
64331e2ac1 row style is common, its the way we clear divs 2014-08-26 07:41:29 +10:00
Jeff Atwood
3a010c34cc smallenate anon drop-down topic counts 2014-08-25 12:14:47 -07:00
Jeff Atwood
ae9fcf17ef make period chooser (/top h2) unselectable on touch 2014-08-22 17:01:12 -07:00
Kris Aubuchon
a8e6e1e3d5 adding highlight back to topic-list 2014-08-22 10:45:51 -04:00
Robin Ward
c1aa2458f8 UX: Add drop down for top lists, big refactor of repeated code. 2014-08-21 16:08:47 -04:00
Régis Hanol
8a20d05ba5 FEATURE: backup without uploads 2014-08-20 18:53:58 +02:00
Régis Hanol
9f72971d26 FEATURE: add the pencil glyph when the post was edited after the first flag 2014-08-18 18:56:39 +02:00
Jeff Atwood
e9bfb1c89e make share link input field readonly, with css tweaks 2014-08-17 23:08:53 -07:00
Jeff Atwood
c04b7cfe8a only do two levels of coldmapping 2014-08-14 22:27:10 -07:00
Jeff Atwood
f8cb0b6452 we have two sets of heatmap colors, apparently 2014-08-14 21:55:17 -07:00
Jeff Atwood
c32f64fe94 more betterer heat/coldmap color scheme 2014-08-14 21:36:35 -07:00
Jeff Atwood
e539e6ff21 try grey instead of blue for coldmap range 2014-08-14 16:42:31 -07:00
Kris Aubuchon
56e7ca10fe swapping around heatmap low/high 2014-08-14 09:33:41 -04:00
Jeff Atwood
48051127fc improve keyboard shortcut help layout 2014-08-14 02:54:53 -07:00
Kris Aubuchon
982b007604 heatmap/coldmap should stay red/blue despite theming 2014-08-13 16:38:49 -04:00
Jeff Atwood
c89a354fb1 clean up some flag page styles and alignment 2014-08-12 23:52:43 -07:00
Jeff Atwood
c83a742bec notification dropdown should not be selectable 2014-08-12 23:32:16 -07:00
Kris Aubuchon
6166e78888 adding hover state to notification menu, and small additional fixes 2014-08-13 00:03:29 -04:00
Robin Ward
e49ef042f1 UX: Remove icon from sign up button, change button order 2014-08-12 13:51:00 -04:00
Robin Ward
1684ff3015 UX: Add a separate "Sign Up" button 2014-08-12 13:47:23 -04:00
Jeff Atwood
63d71fde80 tighten spacing on flags page 2014-08-12 03:49:19 -07:00
Kris Aubuchon
2ce291c2ab small fixes for dark themes 2014-08-12 00:11:58 -04:00
Robin Ward
c8767dc505 UX: Tweak about page 2014-08-11 18:15:49 -04:00
Robin Ward
996d14965e Minor UX tweaks 2014-08-11 17:03:12 -04:00
Robin Ward
c103398e9a First stab at About page 2014-08-11 16:59:15 -04:00
Régis Hanol
5e41408b55 FEATURE: use less space for flag dispositions 2014-08-11 22:28:11 +02:00
Jeff Atwood
5a1162418d lightbox size was black on black 2014-08-09 15:21:53 -07:00
Jeff Atwood
70d639c241 fix irritating padding asymmetry on notifications 2014-08-08 12:30:44 -07:00
Régis Hanol
4f60eb6c77 FIX: banner on mobile 2014-08-08 12:31:32 +02:00
Régis Hanol
7e7938e37f FIX: smaller agree/delete flag modals on mobile 2014-08-08 12:10:32 +02:00
Régis Hanol
fb0ee2401e FIX: alignment in notifications 2014-08-06 19:08:12 +02:00
Kris Aubuchon
38696e5a30 bettering support for dark ez-themes 2014-08-06 09:31:13 -04:00
Régis Hanol
3330f5907c FEATURE: restructure notification HTML layout 2014-08-05 23:36:37 +02:00
Jeff Atwood
40bcead099 add a better style for anon cat hamburger 2014-08-04 22:01:08 -07:00
Jeff Atwood
1efc4e2098 tone down new/unread on hamburger categories 2014-08-04 21:17:38 -07:00
Sam
ef5b18779e FEATURE: merge new and old unread counts on categories page
UI: restyle UI to match counts
2014-08-05 10:44:01 +10:00
Jeff Atwood
6fb683ff9a tone down new/unread on /categories 2014-08-04 15:41:46 -07:00
Régis Hanol
ec30086dea FEATURE: agree all the flags 2014-08-04 22:48:04 +02:00
Neil Lalonde
212d580745 FIX: styling of bouncing validation errors in composer was broken 2014-08-01 15:11:55 -04:00
Régis Hanol
b414a3590a FIX: flag count displayed at wrong position 2014-08-01 19:03:12 +02:00
Jeff Atwood
05e2f5c4a9 missed a few #topic-progress spots, go 145px 2014-08-01 01:41:06 -07:00
Jeff Atwood
2c44ac4454 slightly wider topic-progress bar 2014-07-31 21:53:28 -07:00
Régis Hanol
b196de0821 TRIVIAL: use class instead of id for the 'topic-list' 2014-07-29 23:38:36 +02:00
Régis Hanol
bddffa7f9a FEATURE: flag dispositions normalization
All flags should end up in one of the three dispositions
  - Agree
  - Disagree
  - Defer

In the administration area, the *active* flags section displays 4 buttons
  - Agree (hide post + send PM)
  - Disagree
  - Defer
  - Delete

Clicking "Delete" will open a modal that offer to
  - Delete Post & Defer Flags
  - Delete Post & Agree with Flags
  - Delete Spammer (if available)

When the flag has a list associated, the list will now display 1
response and 1 reply and a "show more..." link if there are more in the
conversation. Replying to the conversation will NOT give a disposition.
Moderators must click the buttons that does that.

If someone clicks one buttons, this will add a default moderator message
from that moderator saying what happened.

The *old* flags section now displays the proper dispositions and is
super duper fast (no more N+9999 queries).

FIX: the old list includes deleted topics
FIX: the lists now properly display the topic states (deleted, closed,
archived, hidden, PM)
FIX: flagging a topic that you've already flagged the first post
2014-07-28 19:28:07 +02:00
Kris Aubuchon
22efc2147b fixing tiger striping on mobile 2014-07-28 10:33:23 -04:00
Sam
1a6aa07611 FEATURE: editable badge groups 2014-07-27 18:22:01 +10:00
Jeff Atwood
f66c39c63b Merge pull request #2589 from awesomerobot/master
reverting notification style
2014-07-25 20:43:14 -07:00
Kris Aubuchon
1557f07e87 reverting notification style 2014-07-25 23:06:14 -04:00
Robin Ward
f4f46aea48 FIX: No, for real don't show Uploading... for non-admin users when they
aren't uploading.
2014-07-25 17:08:54 -04:00
Kris Aubuchon
ab8bade9c6 fixing PM notification badge 2014-07-25 13:37:42 -04:00
Kris Aubuchon
f050d3e917 fixing notification style update 2014-07-25 12:22:55 -04:00
Kris Aubuchon
4a1ec20585 adding border to poster expansion, changing media screen to media all, trying new notification style 2014-07-24 12:21:22 -04:00
Sam
526da15b9e Improve badge UI add links to badge descriptions 2014-07-24 12:21:24 +10:00
Régis Hanol
b9bd2ddda6 Revert "FIX: hidden helper class is important" 2014-07-23 12:25:09 +02:00
Erick Guan
f2cd2f1d3c FIX: hidden helper class is important 2014-07-23 11:50:59 +08:00
Kris Aubuchon
fff0f82bfb fixing wmd-editor button background 2014-07-22 22:38:15 -04:00
Neil Lalonde
6f749b9765 FIX: move duplicated scss to common file 2014-07-22 16:42:19 -04:00
Kris Aubuchon
52334ddda0 a few mobile admin enhancements 2014-07-22 16:30:32 -04:00
Jeff Atwood
c712b0f4b8 add dimmed style to base for flagged/hidden posts 2014-07-21 23:52:26 -07:00
Jeff Atwood
8781f7855e bad reply-where-modal styles caused mobile issues 2014-07-20 00:34:43 -07:00
Jeff Atwood
1c4e3c4a96 mobile category layout fixes 2014-07-19 23:54:57 -07:00
Sam
c8284170ad FEATURE: badge grouping UI
FIX: not loading more badges on badge show page
2014-07-18 15:46:36 +10:00
Jeff Atwood
612dcb5805 we can't resize images on desktop, very dangerous 2014-07-16 12:23:54 -07:00
Sam
e347eea629 FEATURE: show user what badges they have 2014-07-16 17:55:08 +10:00
Kris Aubuchon
89167be99a fitting images in posts without violating max width/height 2014-07-16 01:01:03 -04:00
Kris Aubuchon
8da4046d79 minor alignment fixes on badge page w/description 2014-07-12 00:36:01 -04:00
Kris Aubuchon
9398504332 fixing appearance of horizontal scrollbar on topic list at about 996px wide 2014-07-12 00:12:50 -04:00
Jeff Atwood
314f154def line up modal nav pills better 2014-07-11 13:28:51 -07:00
Jeff Atwood
ed3bebfebe switch /faq to /guidelines in a bunch of places 2014-07-10 15:30:58 -07:00
Jeff Atwood
cf61ef7138 category-list-item only used in mobile layout 2014-07-10 13:28:53 -07:00
Jeff Atwood
91af347dfa remove legacy category "footer" styles 2014-07-10 13:02:15 -07:00
Eyal Levin
d7139555e5 Add RTL support. 2014-07-10 19:36:19 +03:00
Jeff Atwood
d053ad07fb we don't want danger color on mobile category 2014-07-10 00:47:25 -07:00
Jeff Atwood
97979c1a32 Merge pull request #2522 from awesomerobot/master
adapting the layout to fit more viewports
2014-07-09 17:28:32 -07:00
Kris Aubuchon
291459bb91 first steps to making discourse more responsive 2014-07-09 19:56:35 -04:00
Sam
9c14385a86 FEATURE: explain which badges can be titles 2014-07-09 16:03:53 +10:00
Régis Hanol
59b5ba7c0f BUGFIX: IP lookup wasn't working when using HTTPS
REFACTOR: the ip locator into a ip-lookup component
2014-07-07 22:18:18 +02:00
Régis Hanol
ab3d664ce0 BUGFIX: share alert styling with mobile 2014-07-07 17:46:32 +02:00
Kris Aubuchon
f0f47fd045 truncating long names in the @ autocompleter 2014-07-04 20:43:49 -04:00
Kris Aubuchon
42fdb9bc9c fixing d-dropdown heading overlap 2014-07-04 02:20:41 -04:00
Kris Aubuchon
d74d5fb39e truncating loooooooooong name fields 2014-07-03 23:40:49 -04:00
riking
0d4163e0a2 FEATURE: Nice error handling page 2014-07-03 07:52:14 -07:00
Kris Aubuchon
aee73d901a fixing a handful of issues 2014-07-02 23:21:45 -04:00
Régis Hanol
7feab2fc99 Revert "background on topic-list, more width on extra-info-wrapper, meta viewport fix" 2014-07-02 16:55:43 +02:00
Kris Aubuchon
e0194e69a5 adding background to topic-list, making max-width larger on extra-info-wrapper, and changing viewport config 2014-07-02 09:54:40 -04:00
Sam
a4b7b561dc Add link to badge reason on badge details page. 2014-07-02 09:46:28 +10:00
Robin Ward
7a739eb373 FIX: Don't lose background class while navigating from /latest to
`/new`
2014-07-01 16:06:47 -04:00
Robin Ward
288bb5588f Use different approach for background image 2014-07-01 13:40:09 -04:00
Jeff Atwood
e64758fe3c FIX: blockquote inside aside had top-margin 2014-07-01 00:19:56 -07:00
Jeff Atwood
334d9eaa53 add default style for aside.quote (expand quote) 2014-06-30 15:53:31 -07:00
Jeff Atwood
d379012dbc centralize shared .cooked and #wmd-preview styles 2014-06-30 02:06:13 -07:00
Jeff Atwood
0ffe77d7dc correct h1 line-height, centralize .cooked styles 2014-06-30 00:05:24 -07:00
Sam
777371bf14 Merge pull request #2480 from vikhyat/badge-system
Add consistency check to revoke invalid badges
2014-06-30 14:13:12 +10:00
Jeff Atwood
c67c88cee8 add sexy sexy download icon to expanded post images 2014-06-28 01:30:35 -07:00
Kris Aubuchon
51f85206ff making menu highlights consistent 2014-06-27 20:10:33 -04:00
Vikhyat Korrapati
228a2a8992 Show number of grants on the admin badge pages. 2014-06-28 01:24:07 +05:30
Kris Aubuchon
d280390cd3 horizontal scroll on search dropdown be gone! 2014-06-25 11:39:46 -04:00
Sam
d5d1473ced BUGFIX: better seperation of action from act too.
Also create spans for styling.
2014-06-25 10:39:55 +10:00
Neil Lalonde
8762e6aa34 FIX: centre category-dropdown-menu text 2014-06-24 14:27:58 -04:00
Jeff Atwood
1513d5ecb1 css error 2014-06-24 01:01:37 -07:00
Jeff Atwood
eeb2e48f4f fix share link styles for mobile 2014-06-24 00:55:43 -07:00
Jeff Atwood
a7ce8c6418 move .cooked word-wrap: break-word into base CSS 2014-06-24 00:40:20 -07:00
Kris Aubuchon
6029ef960d moving more topic-list styles to base, aligning badges in poster expansion 2014-06-23 16:11:55 -04:00
Jeff Atwood
fc12091a93 get rid of some needless (?) img styles on mobile 2014-06-23 01:17:23 -07:00
Jeff Atwood
26c8538e4c remove extra border on flags/flaggers td 2014-06-23 00:09:18 -07:00
Neil Lalonde
c2efa0b3c3 FIX: styling of select2 inputs in site settings. make it wide enough so autocomplete dropdown is readable. 2014-06-20 18:03:11 -04:00
Neil Lalonde
84f9809a6f FIX: topic wrench button wasn't visible when there's a custom header 2014-06-20 18:03:11 -04:00
Régis Hanol
f733237075 TRIVIAL: remove default 'Read more' link in the banner 2014-06-20 19:05:26 +02:00
Régis Hanol
4878d88cbd FEATURE: overlay the banner when reading a topic 2014-06-20 19:05:26 +02:00
Neil Lalonde
d704991609 FIX: subcategory badge styling problems 2014-06-20 10:49:51 -04:00
Sam
56a04366ec Merge pull request #2431 from vikhyat/badge-system
Custom badge icons
2014-06-20 09:13:29 +10:00
Kris Aubuchon
e4d90038cf handful of alignment fixes 2014-06-19 14:09:25 -04:00
Vikhyat Korrapati
fcfc6177c2 Allow specifying URLs as badge certificates. 2014-06-19 16:56:19 +05:30
Régis Hanol
62a73f48cc BUGFIX: first pass on default banner styling 2014-06-19 00:02:57 +02:00
Régis Hanol
00117c18c3 FEATURE: dismissable banner topic 2014-06-18 20:05:19 +02:00
Benjamin Kampmann
2aabf4fdcd ip locator on ipinfo.io basis added to admin 2014-06-18 09:22:44 +02:00
Sam
012923186b BUGFIX: CSS animation based spinner was buggy
There seems to be no sane way to get the CSS spinner to work without
hosing the stacking context. Use gif based spinner.
2014-06-17 17:55:00 +10:00
Robin Ward
cf165320e2 Keyboard shortcuts for new progress expansion 2014-06-13 14:03:12 -04:00
Jeff Atwood
ae46e439b8 make autocomplete use highlight color for selecting 2014-06-12 15:30:21 -07:00
Neil Lalonde
c61462662b Add ability to run validation on site settings. notification_email and other email address settings are now validated. 2014-06-09 16:59:20 -04:00
Arpit Jalan
42d6cf90f6 Fix Badge Spacing 2014-06-08 00:17:33 +05:30