Sam Saffron
b7f6df7d0c
fix specs and tests
2015-12-15 18:18:20 +11:00
Régis Hanol
15c229195f
FEATURE: notification_level on a per-group basis
2015-12-14 23:17:09 +01:00
Arpit Jalan
e65a7370ef
FIX: disable avatar education message when 'allow_uploaded_avatars' is
...
disabled
FEATURE: setting to disable avatar education message
2015-12-14 22:47:35 +05:30
Régis Hanol
02279c41cb
Merge pull request #3918 from techAPJ/better-email-parsing
...
FEATURE: better email reply parsing
2015-12-11 14:51:24 +01:00
Arpit Jalan
1f003e3472
fix inline reply test case
2015-12-11 14:48:42 +05:30
Régis Hanol
323e3cee22
when creating a staged account, use the display name provided in the email
2015-12-10 23:52:20 +01:00
Régis Hanol
93d1cc6294
add support for incoming emails in CC/BCC fields
2015-12-10 23:49:16 +01:00
Arpit Jalan
7a8e5a50ff
FEATURE: better email reply parsing
2015-12-09 23:47:01 +05:30
Arpit Jalan
e52852dd0f
FIX: Autoclose message was not correct when immediate
...
FEATURE: Warn when setting auto-close for right now
2015-12-08 18:16:48 +05:30
Régis Hanol
1cde276656
FEATURE: ability to send emails to a group
2015-12-07 17:01:08 +01:00
Régis Hanol
578f606a1a
add 'incoming_email' to groups
2015-12-07 12:39:28 +01:00
Guo Xiang Tan
68bfecef8f
FIX: Broken categories controller specs.
2015-12-07 00:09:02 +08:00
Guo Xiang Tan
8b6b3cf858
FIX: Admin logging should not log permissions if none has been set.
2015-12-06 15:29:13 +08:00
Sam
9899e8d4a5
FEATURE: First class messages to groups, you can select a group as a target of a message
2015-12-02 15:49:43 +11:00
Andy Waite
3e50313fdc
Prepare for separation of RSpec helper files
...
Since rspec-rails 3, the default installation creates two helper files:
* `spec_helper.rb`
* `rails_helper.rb`
`spec_helper.rb` is intended as a way of running specs that do not
require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's
current `spec_helper.rb` does).
For more information:
https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files
In this commit, I've simply replaced all instances of `spec_helper` with
`rails_helper`, and renamed the original `spec_helper.rb`.
This brings the Discourse project closer to the standard usage of RSpec
in a Rails app.
At present, every spec relies on loading Rails, but there are likely
many that don't need to. In a future pull request, I hope to introduce a
separate, minimal `spec_helper.rb` which can be used in tests which
don't rely on Rails.
2015-12-01 20:39:42 +00:00
Régis Hanol
5b9594277a
skip most post validations for staged accounts
2015-12-01 10:40:23 +01:00
Sam
46d2e17194
Remove mock that was breaking tests
2015-12-01 17:04:16 +11:00
Sam
d1a5d8ea62
FEATURE: show group mentions and topics in groups page
2015-12-01 16:52:43 +11:00
Régis Hanol
7c694139ec
trust staged accounts when validating posts
2015-11-30 19:08:35 +01:00
Sam
ad3dd161e7
FEATURE: first class group mentions built in
...
If you allow a group to be mentioned it can be mentioned with the @ symbol.
Keep in mind as a safety mechanism max_users_notified_per_group_mention is set to 100
2015-11-30 17:08:43 +11:00
Neil Lalonde
84342ecdef
FIX: anonymized user's preferences should have system assigned avatar chosen
2015-11-27 14:37:30 -05:00
Régis Hanol
540933dce3
don't notify users about sequential replies in messages
2015-11-27 19:29:44 +01:00
Régis Hanol
914b854d92
send invite & message notification emails immediately
2015-11-27 19:09:35 +01:00
Régis Hanol
76692235ae
FIX: don't ever fetch staged accounts in unseen mentions
2015-11-27 18:16:50 +01:00
Robin Ward
5e93140f85
FEATURE: Can override any translation via an admin interface
2015-11-27 11:35:19 -05:00
Arpit Jalan
6354324f2f
FIX: validate automatic membership email domains
2015-11-27 12:35:33 +05:30
Sam
f74a6457ee
FEATURE: allow CJK to be tokenized in non CJK sites.
...
Meaning a mixed English/Chinese site can still have a functioning search.
2015-11-27 16:35:27 +11:00
Sam
43d63367fd
PERF: stop loading handlebars and ember compilers in prod
...
(this removes a nice 50K from our initial payload and saves memory)
Also fixes invalid HTML automatically if added to HEAD or /BODY
2015-11-27 11:59:01 +11:00
Régis Hanol
ba0df7e4cd
rename 'is_support' to 'contains_messages'
2015-11-26 18:40:54 +01:00
Régis Hanol
e8a6ff4808
prevent users from ever changing the category of a topic in a support category
2015-11-26 18:31:24 +01:00
Régis Hanol
0d54c18c8b
new hidden 'allow_staged_accounts' setting
2015-11-26 18:31:23 +01:00
Neil Lalonde
f4d44187c8
FIX: site_contact_user should default to system user, not first admin user
2015-11-24 14:37:41 -05:00
Robin Ward
d65ec1af2e
Rename ninja_edit_window to editing_grace_period :'(
2015-11-24 14:28:42 -05:00
Robin Ward
1506eba28d
Support for overriding client side translation keys
2015-11-20 17:14:01 -05:00
Neil Lalonde
523138f1fd
FEATURE: add setting pending_users_reminder_delay to configure when to send reminders to moderators about user approvals based on how long new users have been waiting
2015-11-20 16:06:07 -05:00
Neil Lalonde
5597957cc6
FIX: don't send repeat notifications to moderators about the same pending approval users
2015-11-20 16:06:07 -05:00
Robin Ward
e168c5fde3
PERF: Much more performant, multisite aware I18n overrides
2015-11-19 16:36:59 -05:00
Sam
88f1a8f0b1
Merge pull request #3821 from mpalmer/letter-avatar-proxy
...
Proxy letter avatars by default
2015-11-19 20:02:16 +11:00
Régis Hanol
31a54377be
staged users automatically watches all topics they participates in
2015-11-18 22:24:46 +01:00
Robin Ward
2196160549
FIX: Allow emails to begin with a quote (but skip it!)
2015-11-18 15:23:10 -05:00
Régis Hanol
85580cd243
fix user_search spec
2015-11-18 21:08:50 +01:00
Régis Hanol
8ba5397f0d
can't find staged users with search
2015-11-18 21:06:59 +01:00
Régis Hanol
ff10eb32a6
don't return staged users in mentions
2015-11-18 20:57:49 +01:00
Jeff Wong
cf86f27415
FEATURE: New setting to allow all caps posts
...
Adds a setting to ignore text_sentinel's check on all caps content.
2015-11-18 09:50:50 -08:00
Robin Ward
bb76c389fd
Merge pull request #3817 from gschlager/locale-pluralization
...
FIX: Pluralizations in English locale files
2015-11-17 12:35:24 -05:00
Régis Hanol
92ba6125c4
FEATURE: new 'automatically_unpin_topics' user preference
2015-11-17 18:21:40 +01:00
Robin Ward
060ce9bf2a
FEATURE: Overwrite server side I18n keys with API
2015-11-13 16:35:02 -05:00
Robin Ward
3720783c1b
Refactor to our own Discourse I18n backend
...
This removes some monkey patches and makes testing easier.
It will also support database backed I18n changes.
2015-11-13 16:35:02 -05:00
Gerhard Schlager
5f9b7c67cd
Add tests to ensure correct pluralization
2015-11-13 21:18:41 +01:00
Régis Hanol
43614439e6
FEATURE: can take over a staged account
2015-11-13 19:07:28 +01:00
Robin Ward
3939331dec
FIX: Staff was getting 500 when editing post in deleted topic
2015-11-13 11:35:23 -05:00
Régis Hanol
16f509afb9
FIX: enforce 'allow_uploaded_avatars' & 'sso_overrides_avatar' server-side
2015-11-12 10:26:45 +01:00
Régis Hanol
7d3be0f8f1
forgot password on a staged account does nothing
2015-11-09 17:37:33 +01:00
Sam Saffron
448a1413d3
left over specs
2015-11-10 00:56:57 +11:00
Sam Saffron
6dd4bc7d57
FEATURE: support group owner, capable of controlling group membership
...
Group owners are regular users that can add or remove users to a group
The Admin UX allows admins to appoint group owners
The public group UX will display group owners first and unlock UI to
add and remove members
Group owners can only be appointed on non automatic groups
Group owners may not appoint another group owner
2015-11-10 00:56:57 +11:00
Sam Saffron
ffa523a543
FIX: when moving posts, retain creator and date from OP
2015-11-07 15:17:47 +11:00
Robin Ward
e2a663bff1
Merge pull request #3812 from gwwar/emoji-embed
...
FIX: allow emoji class when crawling embedded content
2015-11-06 14:52:59 -05:00
Robin Ward
b699d43b1b
Okay disable uploads for now, looks like a PhantomJS bug
2015-11-06 14:21:52 -05:00
Robin Ward
7baed4eb51
Updated smoke test to try in build server
2015-11-06 14:09:16 -05:00
Régis Hanol
acecfeb37f
Add 'staged' boolean to User
2015-11-06 19:19:13 +01:00
Robin Ward
47495a5713
FEATURE: Replace composer editor with ember version
2015-11-06 09:49:16 -05:00
Matt Palmer
c09f345cff
Proxy letter avatars by default
...
On sites that don't otherwise configure an avatar fallback, Discourse will
now tell the client to get its letter avatars from a location which nginx
proxies to the centralised `avatars.discourse.org` service. This alleviates
privacy concerns, whilst still providing some degree of performance benefit
(no need for every site to delay avatar response by 300ms for image
rendering).
It is still possible to gain the benefits of global image caching and the
lower latency of requesting directly from a CDN, by explicitly changing the
`external_system_avatars_url` site setting to
`https://avatars.discourse.org/letter/{first_letter}/{color}/{size}.png `.
2015-11-06 14:13:44 +11:00
kerryliu
b7803fc68e
FIX: allow emoji class when crawling embedded content, add rspc-html-matchers
2015-11-05 18:51:26 -08:00
Robin Ward
d00762dcd5
Merge pull request #3787 from gschlager/locale-keys
...
FIX: Some strings in locale files were not translatable
2015-11-02 13:40:22 -05:00
Régis Hanol
ff0c12efa2
Merge pull request #3878 from gdpelican/optimize-all-allowed-users
...
Optimize all_allowed_users query
2015-11-02 17:06:36 +01:00
Arpit Jalan
700c005c26
PERF: optimize export user list CSV queries
2015-11-02 13:15:58 +05:30
Sam
48ef609003
correct implementation add tests
2015-11-02 15:05:08 +11:00
Leo McArdle
fe5264f9e9
filter by username in email digest preview
...
adds a user prompt on the email digest preview page to generate a preview for a particular user
also fixes some broken styling on the page
2015-10-30 18:11:38 +00:00
Seth Reeser
85da9c6ff8
Digital Ocean should be DigitalOcean https://www.digitalocean.com/legal/terms/
2015-10-30 13:31:48 -04:00
Arpit Jalan
9f8d6b6088
FIX: allow exisiting users to be invited to topic/message when enable_local_logins is disabled
2015-10-30 11:28:05 +05:30
James Kiesel
2fc52e26a6
Optimize all_allowed_users query
2015-10-29 19:39:30 +02:00
Régis Hanol
93cb2813cf
Merge pull request #3863 from tgxworld/fix_last_posted_at_not_updated
...
FIX: Topic#last_posted_at was not being set when changing topic times…
2015-10-29 10:00:57 +01:00
Régis Hanol
bb79e6aff7
FEATURE: new hide_user_profiles_from_public site setting
2015-10-28 19:56:08 +01:00
Robin Ward
23371b026d
FIX: Don't raise an error if you try to assign a group that exists
2015-10-28 12:21:54 -04:00
Robin Ward
6b236d3c83
FEATURE: Bulk Unlisting of topics
2015-10-27 16:57:40 -04:00
Robin Ward
47e25648df
FEATURE: Change user groups in bulk via admin
2015-10-26 15:57:30 -04:00
Arpit Jalan
c28843e87b
FIX: redirect to return_url when working as SSO provider
2015-10-25 11:30:38 +05:30
Arpit Jalan
897563a309
FIX: List-ID should not contain space
2015-10-21 00:00:06 +05:30
Guo Xiang Tan
d9fe78da20
FIX: Topic#last_posted_at was not being set when changing topic timestamp.
2015-10-20 10:12:52 +08:00
Robin Ward
eacd75bcf8
SECURITY: Unread post notifications should respect whispers
2015-10-19 16:32:10 -04:00
Arpit Jalan
59a011e6a9
FIX: min_trust_to_create_topic affects private messages
2015-10-17 15:30:18 +05:30
Robin Ward
f155ff8270
FIX: Tests would fail if your test db's optimized image ids were high
2015-10-16 17:08:41 -04:00
Arpit Jalan
a439500bac
FIX: do not mark post as spam if the previous flag was disagreed
2015-10-17 01:30:53 +05:30
Régis Hanol
06b799bfbf
Merge pull request #3857 from gdpelican/fix-for-untopiced-posts
...
Don't error on posts#latest if a post does not have a topic
2015-10-16 14:59:36 +02:00
James Kiesel
695b366a03
Don't error on posts#latest if a post does not have a topic
2015-10-16 14:44:48 +03:00
Régis Hanol
de344bcd7e
Merge pull request #3854 from tgxworld/fix_transactional_race_condition
...
FIX: Race condition when wrapping `PostCreator#create` in a transaction.
2015-10-15 11:07:20 +02:00
Guo Xiang Tan
600e42c2ba
FIX: Race condition when wrapping PostCreator#create in a transaction.
2015-10-15 14:42:40 +08:00
Robin Ward
a527c58c7d
UX: Show a nicer "Log In" screen if the user follows /my/preferences
2015-10-14 13:39:31 -04:00
Arpit Jalan
b60bceba36
fix the build
2015-10-14 19:20:30 +05:30
Neil Lalonde
3ef16a7711
FIX: permalinks redirect on subfolder installs could add the subfolder to the url twice
2015-10-12 16:54:53 -04:00
Sam
e29fe77b45
FEATURE: make trust level for message sending configurable
...
- add min_trust_to_send_messages site setting (default 1) to allow admins
to configure when messages can be sent between members
2015-10-12 11:15:48 +11:00
Sam
6f43b575a8
FEATURE: no need to cap new and unread together anymore
...
- leave unread alone
- cap new at 500 per site, with a site setting
2015-10-01 17:17:15 +10:00
Robin Ward
33e58c0587
FIX: You can click to see your own PMs from flags
...
Also refactors post action users to be a new object type since they can
have `post_url` which is not a field of a `User`
2015-09-30 12:28:55 -04:00
Régis Hanol
54d6d24cbf
FIX: timing issue with edits and cook post processing
2015-09-29 18:51:26 +02:00
Sam
6c37b26b24
Correct site spec
2015-09-28 16:50:24 +10:00
Robin Ward
43c7320f55
FIX: Allow really long links to work
2015-09-25 14:07:20 -04:00
Robin Ward
c4b1b848bc
More extension points for login buttons, used by OAuth2 plugin
2015-09-25 11:29:40 -04:00
Robin Ward
64598ceaba
FIX: Replies to whispers *must* be whispers
2015-09-25 11:29:40 -04:00
Sam
fc2d61136d
FEATURE: add context for cross topic links
2015-09-25 14:52:43 +10:00
Sam
150ad01111
improve UX remove username said if we have a title
2015-09-25 14:18:38 +10:00
Sam
e5234b38b8
FEATURE: add title expansion for off topic quotes
2015-09-25 13:35:14 +10:00
Sam
2422289c8b
FIX: whispers should not be revealed in reply to, or reply expansion
...
FEATURE: mark whisper as experimental
FIX: badges should never apply to whispers
2015-09-25 10:16:19 +10:00
Sam
ffb8cb8cac
FEATURE: remove dependency of Redcarpet
...
PERF: cache fancy_title in topics table
New pure ruby implementation is far more flexible and easier to amend.
2015-09-24 13:37:53 +10:00
Gerhard Schlager
454a628d58
Add tests for I18n.exists? freedom patch
2015-09-23 20:41:51 +02:00
Neil Lalonde
5ca26a7707
FEATURE: add site setting use_admin_ip_whitelist to enable/disable the whitelisting of admins by IP address
2015-09-23 12:15:08 -04:00
Régis Hanol
36309e50cc
Merge pull request #3767 from tgxworld/track_user_profile_views
...
Track user profile views
2015-09-23 11:38:18 +02:00
Régis Hanol
ed717ccb6e
Merge pull request #3794 from tgxworld/add_web_manifes
...
FEATURE: Add web manifest for Chrome users.
2015-09-23 11:35:14 +02:00
Régis Hanol
1aad58b642
Merge pull request #3781 from tgxworld/feature_log_category_settings
...
Feature log category settings
2015-09-23 11:34:08 +02:00
Sam
3853e3cfdc
PERF: omit 2 queries on every full page load
2015-09-23 16:47:17 +10:00
Sam
613761d1cd
FEATURE: upgrade to Rails 4.2.4
2015-09-23 15:24:30 +10:00
Robin Ward
79beb9f409
FIX: You could set reply_to_post_number when replying as a new topic
2015-09-22 13:32:19 -04:00
Sam
a0524ea4d1
FIX: render canonical URLs
2015-09-22 09:37:52 +10:00
Régis Hanol
4f7140fb32
FIX: properly filter whispers in user stream
2015-09-22 00:50:52 +02:00
Neil Lalonde
2ae032c9b0
FIX: categories page would sometimes show no topics, even if there are some visible topics to show
2015-09-21 18:13:14 -04:00
Régis Hanol
fe656fb04d
FIX: select appropriate period when redirecting to top
2015-09-21 20:28:20 +02:00
Guo Xiang Tan
71eab8f4df
FEATURE: Add web manifest for Chrome users.
2015-09-21 10:34:03 +08:00
Gerhard Schlager
49dc470a28
Add spec to check locale files for duplicate keys
2015-09-19 00:14:26 +02:00
Robin Ward
c1a9e32b48
FIX: When recovering a post, it should recreate user actions
2015-09-18 12:48:43 -04:00
Robin Ward
cc516d3be0
Merge pull request #3743 from sitepoint/topic-embed-info
...
Add embed/info endpoint for TopicEmbed queries
2015-09-18 11:00:01 -04:00
Kane York
c9e4745fe8
FIX: Return 410 Gone for deleted topics you could otherwise see
2015-09-18 00:14:43 -07:00
Guo Xiang Tan
f39b9124b6
FEATURE: Log staff actions for Category changes.
2015-09-18 10:53:08 +08:00
Régis Hanol
07e7b07b63
FIX: refreshing gravatar wasn't working
2015-09-17 19:42:44 +02:00
Régis Hanol
e211bf7d0b
change smoke test timeout to 15 seconds
2015-09-16 12:18:48 +02:00
Guo Xiang Tan
7acc93b2a0
FEATURE: Track user profile views.
2015-09-16 14:48:31 +08:00
Jude Aakjaer
9cca510944
Add embed/info endpoint for TopicEmbed queries
2015-09-16 03:22:24 +00:00
Sam
a7b34cd16b
rename to badge, better more consistent name
2015-09-16 08:51:28 +10:00
Régis Hanol
7e1a24e205
FEATURE: ensure localStorage is disabled in smoke tests
2015-09-15 18:26:09 +02:00
Sam
6496895096
FEATURE: search for all posts by a group
2015-09-15 17:39:14 +10:00
Sam
17d999ab12
FEATURE: search for all posts of users that have a badge
...
with_badge:"badge name" will allow you to search only
posts of users with a particular badge
2015-09-15 17:22:08 +10:00
Sam
83efde79f0
specs to account for new default letter avatar location
2015-09-15 13:25:15 +10:00
Régis Hanol
b9a9a91335
FIX: couldn't set 'never' for the default email digest frequency setting
2015-09-14 10:36:25 +02:00
Kane York
b6febb0638
fix the build ( 460243d7)
2015-09-11 11:37:36 -07:00
Robin Ward
5af0f5f80e
FEATURE: Whisper posts
2015-09-11 14:05:21 -04:00
Kane York
460243d7a3
FIX: Give 403 for deleted topics, +lots of tests
2015-09-11 08:29:44 -07:00
Régis Hanol
18d7c1c75d
fix the build - take 2
2015-09-11 15:47:48 +02:00
Arpit Jalan
d73d4d4769
FIX: UserNameSuggester should not suggest usernames with a sequence of 2 or more special chars
2015-09-11 16:53:26 +05:30
Neil Lalonde
354a3f9638
add test for auth_token being cleared by user anonymizer, which it already does
2015-09-10 11:17:48 -04:00
Régis Hanol
3ee5cea9e2
fix the build
2015-09-09 15:34:53 +02:00
Régis Hanol
31e8309f05
FIX: ensure we never have a string when an enum is Fixnum - Take 2
2015-09-09 14:34:44 +02:00
Régis Hanol
9a999bfe84
FIX: ensure we never have a string when an enum is Fixnum
2015-09-09 12:59:49 +02:00
Robin Ward
b6343b1e10
Merge pull request #3697 from riking/patch-6
...
FEATURE: Allow plugins to add admin dashboard warnings
2015-09-08 16:49:58 -04:00
Régis Hanol
e3a80936c8
prefer empty href attribute to #
2015-09-08 18:27:20 +02:00
Sam
335be272ff
FEATURE: implement capping of new/unread
...
We cap new and unread at 2/5th of SiteSetting.max_tracked_new_unread
This dynamic capping is applied under 2 conditions:
1. New capping is applied once every 15 minutes in the periodical job, this effectively ensures that usually even super active sites are capped at 200 new items
2. Unread capping is applied if a user hits max_tracked_new_unread,
meaning if new + unread == 500, we defer a job that runs within 15 minutes that will cap user at 200 unread
This logic ensures that at worst case a user gets "bad" numbers for 15 minutes and then the system goes ahead and fixes itself up
2015-09-07 12:03:17 +10:00
Kane York
342eba4374
FEATURE: Category reordering dialog
2015-09-06 16:53:52 -07:00
Guo Xiang Tan
cbb86f9bf6
FEATURE: Add a trigger for plugins to include their own jobs.
2015-09-04 22:59:39 +08:00
Régis Hanol
5984b62347
FIX: ensure we remove 'category_users' records when a user is deleted
2015-09-02 20:43:15 +02:00
Régis Hanol
a501947d67
FEATURE: suppress categories from the homepage
2015-09-02 20:25:18 +02:00
Sam
262f561a87
FEATURE: relax username rules to allow - and . and leading _
...
This relaxes our very strict username rules to allow for some long asked for requests
- leading _ is now allowed
- . is allowed except for trailing char and confusing extensions like .gif .json
- dash (-) is now permitted
2015-09-02 12:13:44 +10:00
Neil Lalonde
1bd0f5b015
FEATURE: group can grant a trust level when a user is added
2015-09-01 16:52:12 -04:00
Kane York
65790452d8
Clean up the test checks when done
2015-09-01 13:32:35 -07:00
