Commit graph

2368 commits

Author SHA1 Message Date
Robin Ward
4dc20e6855 FIX: Sanitize custom quote attributes 2014-04-21 10:19:39 -04:00
Régis Hanol
756ea0178a Merge pull request #2276 from vikhyat/badge-system
Badge system updates
2014-04-18 11:46:19 +02:00
Régis Hanol
b014d66b65 Merge pull request #2277 from vikhyat/fix-title-html
Fix HTML tags in topic titles
2014-04-18 11:37:33 +02:00
Jeff Atwood
b846eb4544 backup size column does not need to be so large 2014-04-17 23:49:58 -07:00
Vikhyat Korrapati
25a080a8e1 Fix HTML tags in topic titles.
We no longer sanitize titles before saving to the database since it
would cause problems like HTML entities showing up when you try to edit
a topic title. It isn't even really necessary since we only render
fancy_title directly and never title.

The escaping logic used here is the same that is used both in lodash and
onebox. See:

1. https://github.com/discourse/onebox/pull/190/files
2. https://github.com/lodash/lodash/blob/2.4.1/dist/lodash.compat.js#L6194
2014-04-18 10:47:00 +05:30
Vikhyat Korrapati
27b62df48b Change "awarded" to "granted". 2014-04-18 09:20:55 +05:30
Vikhyat Korrapati
e6eb16ee73 Fix infinite loading spinner for badges that have not been granted yet. 2014-04-18 09:20:55 +05:30
Vikhyat Korrapati
8113e8d897 Basic UI for selecting gold/silver badges as titles. 2014-04-18 09:20:51 +05:30
Vikhyat Korrapati
95b430df72 Link poster expansion "+x more" to user badges page. 2014-04-18 08:24:48 +05:30
Vikhyat Korrapati
5bb3a1a05a Show badges filter in user profiles only when the user has badges. 2014-04-18 04:03:13 +05:30
Neil Lalonde
6c7863bbba Show installed version on dashboard after upgrade 2014-04-17 14:26:44 -04:00
Robin Ward
ffc1634193 FIX: Only show link clicks on the title of a onebox, not repeatedly in
its body.
2014-04-17 13:01:44 -04:00
Robin Ward
b3ed8b6a32 Use query params for sortable table headings 2014-04-17 10:52:57 -04:00
Robin Ward
2eab288dc9 Port "Summarize Topic" to query-params-new 2014-04-17 10:46:33 -04:00
Robin Ward
fdb751296a FIX: ZALGO test suite was causing failures in the wrong place due to
missing `async` bits.
2014-04-17 10:46:33 -04:00
Robin Ward
c9c95a9ac2 FIX: Ember doesn't allow one route name, basic, and Discourse used it! 2014-04-17 10:45:06 -04:00
Robin Ward
c820747ea3 FIX: Malformed HTML in templates 2014-04-17 10:45:06 -04:00
Robin Ward
fc65bc28be FIX: Use the container to register Discourse's custom location handler 2014-04-17 10:45:06 -04:00
Robin Ward
2f9bb6b88f FIX: Deprecation warnings on Ember.js for render without quotes. 2014-04-17 10:45:06 -04:00
Robin Ward
73cc722ed5 Update Ember.js, Handlebars and jQuery to latest 2014-04-17 10:45:06 -04:00
Onaldanm
bf8d727a91 Add badges class
Add badges class to the container to custom this new page differently.
2014-04-17 11:40:06 +02:00
Vikhyat Korrapati
89f45901bc Create notification when badge is granted. 2014-04-17 01:58:01 +05:30
Vikhyat Korrapati
b55734da91 Add badges tab to user profile. 2014-04-17 01:58:01 +05:30
Vikhyat Korrapati
3136217fc1 Add badge page. 2014-04-17 01:57:57 +05:30
Vikhyat Korrapati
acfcf0b64e Add /badges route that lists all defined badges. 2014-04-16 18:42:06 +05:30
Vikhyat Korrapati
4c0f85650e Display badge count in the user admin page. 2014-04-16 18:08:10 +05:30
Vikhyat Korrapati
057c56ef9b Add user-badge component. 2014-04-16 18:08:00 +05:30
Neil Lalonde
8b79debde2 Merge pull request #2266 from fantasticfears/locale
add pluralization rules in ember for Chinese
2014-04-15 11:08:22 -04:00
Neil Lalonde
3b53c1814b FIX: don't reload page when creating account with external auth and must_approve_users is enabled. 2014-04-15 10:13:57 -04:00
Erick Guan
2c6b7d8bed add pluralization rules in ember for Chinese 2014-04-15 19:59:20 +08:00
Régis Hanol
2505d18aa9 FEATURE: support email attachments 2014-04-14 22:55:57 +02:00
Robin Ward
ed6e2b1d79 Remove Zalgo API from Discourse.Mention:
http://blog.izs.me/post/59142742143/designing-apis-for-asynchrony -
Thanks @riking for finding it.
2014-04-14 16:51:18 -04:00
Neil Lalonde
2c4ada6c7d FIX: give an accurate reason why a user's posts can be deleted from admin 2014-04-14 15:10:41 -04:00
Sam
4a0c63ec7f Tweak badge styling 2014-04-14 15:58:52 +10:00
Sam
cfccf8b4ed Tweak live reload due to CSS bundling in dev 2014-04-14 15:58:52 +10:00
Sam
b0ed9082b3 FEATURE: Hidden site setting for max username length 2014-04-14 12:55:33 +10:00
Sam
d3810ba3bc Merge pull request #2212 from vikhyat/badge-system
Show badges in the poster expansion card
2014-04-14 10:54:43 +10:00
Robin Ward
1ae6c726dc Removes duplicate Controller definition 2014-04-11 12:51:09 -04:00
Robin Ward
0b42228663 FIX: Double clicking the home logo could leave you in a perpetual
"Loading" state.
2014-04-11 11:57:12 -04:00
Neil Lalonde
6e939c28fb Remove topic.notifications.title translation key since it's always an empty string 2014-04-11 10:54:02 -04:00
Vikhyat Korrapati
3f4c5ed451 Show badges in the poster expansion card. 2014-04-11 06:59:11 +05:30
Sam
668a5ff526 FEATURE: lock icon for archived topics
remove model sniffing hack
2014-04-11 10:27:04 +10:00
Sam
fe6153ba96 Merge pull request #2232 from vikhyat/username-on-top-setting
Add option to show username on top of posts instead of the left gutter
2014-04-11 10:13:18 +10:00
Brad Wilson
836b0c41ab BUGFIX: adjust page padding when composer view open
From https://meta.discourse.org/t/discourse-general-polish/13184 :

"Footer padding gets out of sync: start typing a new topic in the composer ... size it big ... got to random topic ... footer padding is not added so you can not see the last post on topic. (workaround, resize composer once more so footer padding is added). This need to be added everywhere automatically. Including admin screens."
2014-04-11 09:54:14 +10:00
Neil Lalonde
cb11967715 Add transifex config. Reconcile client.yml and server.yml translations in github and transifex. Transifex is now the source of all client.yml and server.yml files. 2014-04-10 15:42:38 -04:00
Vikhyat Korrapati
af69b78ecb Changes to posts template to make it easier to display posts on top. 2014-04-10 21:56:13 +05:30
Régis Hanol
d0591c18f8 Merge pull request #2245 from ligthyear/category-double-selection-fix
Bugfix: double selection of categories in user preferences
2014-04-10 10:52:57 +02:00
Sam
cd8b30bfcb BUGFIX: clicking on home was broke 2014-04-10 18:31:39 +10:00
Benjamin Kampmann
72a6566bfd Prevent user from selecting the same category twice for different notification levels in their preferences 2014-04-10 10:08:59 +02:00
Sam
49386412ca Merge pull request #2247 from bradx3/fix_null_topic_error
BUGFIX: suppress error when scrolling at bottom of topic
2014-04-10 16:33:01 +10:00
Sam
97269fc918 FEATURE: education panel on pinning at bottom of topics 2014-04-10 15:53:58 +10:00
Brad Wilson
629e6f4158 BUGFIX: suppress error when scrolling at bottom of topic
fixes "Uncaught TypeError: Cannot call method 'get' of null" when 
scrolling at the bottom of the topic screen.
2014-04-10 15:36:44 +10:00
Sam
b9d4edd91a FEATURE: display unpinned state, allow unpinning by clicking on pin 2014-04-10 10:59:02 +10:00
Jeff Atwood
3f6764ce22 don't need the external link glyph in summary now 2014-04-09 17:10:07 -07:00
Régis Hanol
3e72de7dc1 BUGFIX: share pop-up wasn't properly positioned when activated using keyboard 2014-04-09 16:01:09 +02:00
Sam
4c82386f80 BUGFIX: bust for anon 2014-04-09 11:24:33 +10:00
Sam
8cdf25532c Merge pull request #2207 from riking/list-setting
UI for list site settings
2014-04-09 09:34:50 +10:00
Sam
b0dc9279ff Merge pull request #2203 from riking/change-owner
Change post owner functionality
2014-04-09 09:31:46 +10:00
riking
6779bec58c Add UI for list site settings 2014-04-08 14:17:55 -07:00
Robin Ward
c3bc49d5d4 Ditch params when showing link domains 2014-04-08 15:15:22 -04:00
Régis Hanol
79ad879170 BUGFIX: uses markdown instead of HTML when inserting hyperlinked images 2014-04-08 19:33:14 +02:00
riking
1540a3d5e5 Allow changing ownwership of posts by admins 2014-04-08 01:47:42 -07:00
Sam
01cf3cf0c8 Merge pull request #2219 from fantasticfears/notifications_button
set visual indicator for active notification level
2014-04-08 16:36:52 +10:00
Robin Ward
7e3ea5d644 Support for crawling topic links 2014-04-07 14:08:34 -04:00
Neil Lalonde
a784583004 FIX: search of site settings supports space or underscore 2014-04-07 11:14:12 -04:00
Sam
0372b81d11 FEATURE: allow moderators to globally pin topics 2014-04-07 16:38:51 +10:00
Sam
fcd463cc36 disabled scroll sync pending fixes to be discussed in meta 2014-04-07 10:55:31 +10:00
Sam
f7644e2cdf BUGFIX: scroll sync messing with loose lists 2014-04-07 10:51:15 +10:00
Sam
af6e376ee3 Merge pull request #2231 from arunisrael/fix_search_key_shortcut
[bugfix] Fix for '/' keyboard shortcut putting '/' into search input
2014-04-07 06:22:00 +10:00
Robin Ward
802ee04e9d FIX: Can click on links in expanded blog posts 2014-04-05 20:05:48 -04:00
Robin Ward
06913474b4 Add new class to expanded content so it can be styled 2014-04-05 15:01:28 -04:00
Arun Israel
9ced796674 [bugfix] Fix for '/' keyboard shortcut putting '/' into search input
Changed the search button binding from a click binding in mousetrap.js to a function binding.
Added a showSearch function that uses jquery to click the '#search-button' element
and the function returns false preventing the default action and stops the keydown event
from bubbling upwards.

Meta Discourse Bug Thread: https://meta.discourse.org/t/shortcut-for-search-leaves-a-in-the-search-field/14394
Mousetrap reference: http://craig.is/killing/mice
2014-04-05 01:38:00 -04:00
Neil Lalonde
45e75f3d48 FIX: normalize category badge code on edit category modal 2014-04-04 16:48:14 -04:00
Wojciech Zawistowski
2566d106d7 Markdown Editor clean up. 2014-04-04 20:22:18 +02:00
Neil Lalonde
dc3739d49f Replace underscore with space when showing site setting names 2014-04-03 16:08:14 -04:00
Régis Hanol
7fd0db857f BUGFIX: check image size before uploading an avatar/background 2014-04-03 19:19:38 +02:00
Robin Ward
faa341148e FIX: Escape name on activity feed 2014-04-03 11:54:51 -04:00
Erick Guan
5226d8345c set visual indicator for active notification level 2014-04-03 12:01:31 +00:00
Wojciech Zawistowski
6dd3909e38 FIX: broken Pagedown editor for About, Site Content and similar places. 2014-04-03 02:33:47 -04:00
Robin Ward
d1e7fa1c47 Minor tweaks to importing first posts 2014-04-02 15:54:21 -04:00
Robin Ward
558a06a117 Adds better reusable error message support. Added to fetching remote
posts. /cc @riking
2014-04-02 13:22:10 -04:00
Robin Ward
b250aa36a0 Remote fetching of blog contents 2014-04-02 10:26:46 -04:00
Robin Ward
50fb048b99 Interface for expanding OP contents 2014-04-02 10:26:46 -04:00
Vikhyat Korrapati
dea978d7fc Fix missing avatar while a post is being created. 2014-04-01 19:26:54 +05:30
Régis Hanol
b925827e5b Merge pull request #2100 from velesin/synchronized_editor
Synced editor scrolling PoC.
2014-04-01 15:19:55 +02:00
Robin Ward
08917e71bd Merge pull request #2211 from velesin/delayed_tab_switch_spinner
Delays loading spinner when switching between tabs.
2014-03-31 16:02:13 -04:00
Robin Ward
e3db0add5b Merge pull request #2213 from vikhyat/fix-title-lt
Unescape topic title before setting it as the document title
2014-03-31 16:00:13 -04:00
Wojciech Zawistowski
c0a11adbc5 Moves Markdown Editor from vendor to discourse. 2014-03-31 21:56:19 +02:00
Wojciech Zawistowski
297c25ca1f Synced editor scrolling PoC. 2014-03-31 20:57:45 +02:00
Robin Ward
7baa8ea0af FIX: Upwards scrolling. Updates ember-cloaking 2014-03-31 14:32:51 -04:00
Vikhyat Korrapati
d62017c598 Unescape topic title before setting it as the document title. 2014-03-31 23:03:14 +05:30
Régis Hanol
7e33834afe FEATURE: create hyperlinked images from the image insertion dialog 2014-03-31 18:19:16 +02:00
Wojciech Zawistowski
a561cbc5fa Delays loading spinner when switching between tabs. 2014-03-31 17:56:23 +02:00
Benjamin Kampmann
2815e98e6d Make autohighighting for all Code-Blocks a SiteSetting 2014-03-31 09:44:35 +02:00
riking
0828cf52ee Add no-text class to buttons with no text 2014-03-29 23:28:04 -07:00
Régis Hanol
cdeb7445dc Merge pull request #2167 from riking/higher-facebook
Make Facebook login popup taller
2014-03-28 15:11:30 +01:00
Vikhyat Korrapati
49298ec327 Fix post highlighting. 2014-03-28 14:35:19 +05:30
Neil Lalonde
0d57e4b235 FIX: render uncategorized badge in category chooser 2014-03-27 15:25:47 -04:00
Neil Lalonde
5d4995640b Use sub-category badge on categories page too 2014-03-27 15:25:47 -04:00
Régis Hanol
f397a3e157 Revert "BUGFIX: highlight standard code blocks"
This reverts commit d5b1b64bb8.
2014-03-27 19:21:32 +01:00
Neil Lalonde
11c586ed93 Merge pull request #2198 from borhub/prevent_bgcolor_issues_in_basic_topic_list
Align basic-topic-list table structure with Categories page topic-list table structure
2014-03-27 12:26:37 -04:00
Régis Hanol
5edec22e28 fix the build 2014-03-27 16:57:46 +01:00
Régis Hanol
e663d78104 SECURITY: sanitize markdown urls (prevent XSS) 2014-03-27 15:34:35 +01:00
Régis Hanol
d5b1b64bb8 BUGFIX: highlight standard code blocks 2014-03-27 15:17:50 +01:00
Boris
0ad869c256 Align basic-topic-list table structure with Categories page topic-list table structure
This is an optimization for people that choose their table row highlighting to be inverse of the default Discourse theme.
If people choose to have the heading row (or individual th columns) and 'even' rows highlighted in topic-list.scss for the Categories page, the alternate coloring is not carried over to the User Activity page's Messages list. Because the basic-topic-list table there doesn't use the THEAD and TBODY wrappers, the first data row is effectively an 'odd' row, so highlighting is now applied both on the heading row and the first data row.
By adding the THEAD and TBODY wrappers, we make sure that the table structures across the app are the same and global row highlighting styles work out of the box also on the User Activity page.
2014-03-27 17:15:32 +11:00
Neil Lalonde
ec1ea18877 FIX: rendering bug of private categories in category chooser 2014-03-26 16:55:07 -04:00
Régis Hanol
e5a04e3d5c BUGFIX: mismatched braces 2014-03-26 18:17:40 +01:00
Neil Lalonde
4d0035e7fd Remove the quote post button from pagedown editor when creating a topic and editing About Me in preferences 2014-03-26 10:45:22 -04:00
Neil Lalonde
0f98c1644a Remove more admin options code since it's gone from composer 2014-03-26 10:19:01 -04:00
Mikulas
c30a9365e4 add localization to group administration 2014-03-26 13:45:58 +01:00
Sam
49dbb992ad BUGFIX: someone missed a replacement 2014-03-26 13:22:04 +11:00
Neil Lalonde
86244e3a4b New sub-category badges in category chooser. Normalize category badge rendering code. 2014-03-25 17:29:59 -04:00
Neil Lalonde
ac32b1c5a5 Also show new sub-category badge in the message at the bottom of a topic 2014-03-25 16:20:13 -04:00
Neil Lalonde
a40896bb55 Category badge preview uses new sub-category badge styling in create/edit category modal 2014-03-25 16:17:04 -04:00
Neil Lalonde
497a03fc2c Show new sub-category styling in hamburger menu too 2014-03-25 15:29:34 -04:00
Neil Lalonde
bfc8c65212 Remove wrench icon and auto-close options from composer. The same options are available after the topic has been created. 2014-03-25 14:07:05 -04:00
Régis Hanol
9d23cfcece update highlight.js to latest version 2014-03-25 18:13:38 +01:00
Régis Hanol
c10e44c0cf Merge pull request #2171 from Mikulas/patch-missing-localization
add localization to post multiselect
2014-03-25 14:35:36 +01:00
Régis Hanol
ae98bc91a1 Merge pull request #2178 from vikhyat/badge-system
Don't display granted badges in the badge grant combobox
2014-03-25 12:04:23 +01:00
Vikhyat Korrapati
61ec2b390e Don't display granted badges in the badge grant combobox. 2014-03-25 15:45:34 +05:30
Vikhyat Korrapati
fa6ff26061 Update combobox when contents are changed. 2014-03-25 15:29:13 +05:30
Kane York
473201c9a4 Change specified height to 450 2014-03-24 20:02:04 -07:00
Mikulas
fffe3dee6e add localization to multiselect popup 2014-03-24 18:23:29 +01:00
Vikhyat Korrapati
881340213e Fix pasting into the subject field in Firefox. 2014-03-24 22:33:20 +05:30
Neil Lalonde
36cbd0d348 FIX: broken admin user page when must_approve_users is enabled 2014-03-24 11:43:06 -04:00
Neil Lalonde
e823558742 FIX: admin user page for suspended user was busted 2014-03-24 10:19:15 -04:00
Sam
c27c87911e FEATURE: refactor notice code, add optional global notice.
Set the global_notice site setting to notify users of a critical event.
2014-03-24 16:51:48 +11:00
riking
c978eade56 Make Facebook login popup taller 2014-03-23 22:00:15 -07:00
Sam
1cd32ced33 FEATURE: update likes and flags live. 2014-03-24 13:22:03 +11:00
Sam
090f5c99c2 FEATURE: Live update edits 2014-03-24 12:19:08 +11:00
Régis Hanol
6b8a5d1d78 BUGFIX: bound avatars in revision history UI 2014-03-22 17:39:59 +01:00
Neil Lalonde
c3c5ac3ef7 Some tweaks to sub-category badges 2014-03-21 15:33:44 -04:00
Neil Lalonde
c649959e34 Show parent category on category badges 2014-03-21 14:34:50 -04:00
Robin Ward
539890afdf Let's not show tons of extra information about invites unless you're the
person who invited them.
2014-03-21 14:16:11 -04:00
Régis Hanol
88ba80b239 Merge pull request #2160 from borhub/fix-excessive-li-in-category-breadcrumb
Fix visual bug from excessive LIs being rendered around Category breadcrumbs
2014-03-21 10:00:04 +01:00
Boris
0a330544b3 Prevent rendering of excessive <li> wrapper around a category breadcrumb which already is a <li>.
The excessive <li> wrapper coming from the template is automatically closed by the browser during the HTML parsing step, causing an empty <li> being visible in the rendered source (preceding the first breadcrumb). This causes a visual bug when not using the default Discourse stylesheet, because the extra LI element pushes the content to the right and sometimes also renders an extra black pixel.
2014-03-21 16:58:06 +11:00
Vikhyat Korrapati
0f9ea25010 Interface for granting/revoking badges from admin user page. 2014-03-21 11:09:19 +05:30
Vikhyat Korrapati
8163fcade7 Combobox view: escape name string. 2014-03-21 11:09:19 +05:30
Sam
2dc5e3c81e Merge pull request #2118 from vikhyat/firefox-middle-click
Fix Firefox middle-click popup blocker issue
2014-03-21 16:27:02 +11:00
Robin Ward
e8ee490778 Extract breaking up a string into a separate file, include it in
embedded view.
2014-03-20 14:34:51 -04:00
Sam
619fa50d4b BUGFIX: twitter auth asking for a password 2014-03-20 14:49:25 +11:00
Régis Hanol
44888f7acc FEATURE: upload button on mobile composer 2014-03-19 18:34:08 +01:00
Robin Ward
51e3d72461 Merge pull request #2141 from riking/correctness
Lots of JS correctness fixes
2014-03-19 11:20:15 -04:00
Régis Hanol
80bfdeee82 Merge pull request #2147 from vikhyat/serialize-params
Route `serialize` hook argument is the model, not params
2014-03-19 09:30:26 +01:00
Vikhyat Korrapati
28731ea633 Route serialize hook argument is the model, not params. 2014-03-19 12:02:27 +05:30
Sam
eab30d1c28 Merge pull request #2146 from vikhyat/badge-system
Badge creation UI improvements
2014-03-19 17:11:00 +11:00
Vikhyat Korrapati
89d3835d64 Badge creation UI improvements. 2014-03-19 10:43:38 +05:30
Vikhyat Korrapati
a4461022a3 Move badges admin tab to after users, show only if enabled. 2014-03-19 09:48:04 +05:30
riking
4699136d83 Fix this/self usage warning
To clarify the intent of using 'this' inside the closure, it is first assigned to a variable.
2014-03-18 19:09:49 -07:00
riking
8136468ec7 Fix inefficent jQuery usage
Some jQueries can be cached and reused. This commit does that.
2014-03-18 19:09:49 -07:00