Andy Waite
3e50313fdc
Prepare for separation of RSpec helper files
...
Since rspec-rails 3, the default installation creates two helper files:
* `spec_helper.rb`
* `rails_helper.rb`
`spec_helper.rb` is intended as a way of running specs that do not
require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's
current `spec_helper.rb` does).
For more information:
https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files
In this commit, I've simply replaced all instances of `spec_helper` with
`rails_helper`, and renamed the original `spec_helper.rb`.
This brings the Discourse project closer to the standard usage of RSpec
in a Rails app.
At present, every spec relies on loading Rails, but there are likely
many that don't need to. In a future pull request, I hope to introduce a
separate, minimal `spec_helper.rb` which can be used in tests which
don't rely on Rails.
2015-12-01 20:39:42 +00:00
Sam
150ad01111
improve UX remove username said if we have a title
2015-09-25 14:18:38 +10:00
Sam
e5234b38b8
FEATURE: add title expansion for off topic quotes
2015-09-25 13:35:14 +10:00
Sam
568adc49c0
FIX: fenced code blocks not hoisted correctly
...
also fixes unhoisting logic
2015-07-31 17:53:20 +10:00
Guo Xiang Tan
7c1e16da54
FEATURE: Display emojis in user stream.
2015-07-23 23:50:01 +08:00
Sam
4c92f05d8d
more tests
2015-07-20 17:06:00 +10:00
Sam
ecf50a741c
strip classes from table instead of ignoring table
2015-07-20 17:05:24 +10:00
Sam
e93665b9f7
FEATURE: site setting to allow html tables (which may come from imports)
...
(allow_html_tables , disabled by default)
2015-07-20 16:56:46 +10:00
Robin Ward
b52e5d1536
FIX: default_avatars wasn't being used for some server side templates
2015-06-26 13:38:09 -04:00
Sam Saffron
b7a0a295c0
FIX: s3 cdn would break cooking if <img> tag had no src
2015-06-10 19:28:21 +10:00
Sam
93ab03966e
FIX: no-follow not handled correctly for sub domains
...
if a.com was whitelisted aa.com would pass through
2015-05-27 14:31:01 +10:00
Sam
90eaad336d
FEATURE: allow users to pick a CDN for s3 assets
2015-05-26 11:13:12 +10:00
Ben Hadley-Evans
c3b461f58d
Add blank alt attribute to avatars.
...
This was giving an ugly border to avatars in the user card as the full size version loaded in Firefox.
2015-04-14 14:39:40 +01:00
Sam
a82530012a
FEATURE: Allow selection of highlight js languages
...
PERF: stop loading highlight js on load
To get latest highlight js run bin/rake highlightjs:update
2015-03-13 16:18:59 +11:00
Régis Hanol
6a68e8c272
FIX: use CDN for user card/profile background and user avatars (for real this time)
2015-01-29 22:53:48 +01:00
Régis Hanol
b4e5937850
FIX: 🐛 ensure emoji are case insensitive
2015-01-15 19:00:55 +01:00
Luciano Sousa
0fd98b56d8
few components with rspec3 syntax
2015-01-09 13:34:37 -03:00
Sam
e23e008682
FIX: buggy unhoisting of escaped \*
2014-12-23 18:25:10 +11:00
Régis Hanol
6027073547
FIX: properly unescape HTML entities in excerpts
2014-12-10 12:52:51 +01:00
Régis Hanol
a5616146eb
FIX: remove meta data from lightbox in both excerpt (html & text)
2014-11-05 20:37:00 +01:00
Régis Hanol
ada750b384
fixed some more deprecations. 20 to go
2014-10-29 16:06:50 +01:00
Sam
0d1b460f1e
Pending spec for Nokogiri fix
2014-10-03 12:37:07 +10:00
Régis Hanol
de76b512c1
fix most deprecations in the specs (still some left)
2014-09-25 17:44:48 +02:00
Jeff Atwood
5646ebf4c7
fix tests expecting "name said:" to "name:"
2014-09-18 20:39:27 -07:00
Robin Ward
19b4364d79
SECURITY: Stripping links could unescape html fragments
2014-09-17 12:08:00 -04:00
David McClure
d567093756
FEATURE: Allow manual excerpt to be specified anywhere in the post and override max excerpt length
2014-09-03 22:06:53 -07:00
David McClure
0513d02e23
FEATURE: Allow manual excerpt to be defined past the beginning of the post
...
There is still a limitation that the span excerpt must begin before the post_excerpt_max_length.
2014-09-03 00:29:49 -07:00
Sam
84836944e8
FIX: crash on invalid uri component
2014-07-30 17:09:55 +10:00
Robin Ward
b2f2e7b1d2
REFACTOR: Move Markdown tests to Javascript land
2014-07-25 16:08:00 -04:00
Sam
6e9f5f5584
SECURITY: fix XSS in excerpt parser
2014-07-25 12:16:00 +10:00
Sam
de7e6a9545
Feature: allow mods to cut pinned topic excerpts
2014-07-17 21:32:37 +10:00
Sam
c12a131fb4
SECURITY: sanitizer allowing invalid attributes
2014-07-17 16:11:09 +10:00
Sam
89fc989adb
FEATURE: First Quote badge
2014-07-11 14:17:43 +10:00
Sam
d54c28adc1
FIX: better whitelisting
2014-07-10 09:59:54 +10:00
Sam
9828a268b9
Fix: whitelist regex for bbcode too wide
2014-07-10 09:17:04 +10:00
Robin Ward
fc1ce96dbb
FIX: Change the approach to sanitization. Includes a more detailed API
...
for allowing classes and attributes for only certain tag names.
2014-07-03 16:55:36 -04:00
Robin Ward
9c48f8f154
FIX: Don't surround <aside> with <p> as that is malformed HTML.
2014-06-30 18:11:22 -04:00
Sam
e2e36a6df3
FIX: bold and italic handling improved
2014-06-30 17:01:46 +10:00
Sam
24ddb6cfad
FIX: Bold, italic should not expect a space boundary
2014-06-26 17:45:51 +10:00
Sam
b8357aa90a
BUGFIX: newline after bold was not producting a BR
2014-06-26 15:28:08 +10:00
Robin Ward
64355c989e
FIX: Don't extract links from empty quotes
2014-05-20 17:20:52 -04:00
Louis Rose
1574485443
Perform the where(...).first to find_by(...) refactoring.
...
This refactoring was automated using the command: bundle exec "ruby refactorings/where_dot_first_to_find_by/app.rb"
2014-05-06 14:41:59 +01:00
Robin Ward
87682f7539
FIX: Don't include image meta data when embedded in an email
2014-04-17 12:32:51 -04:00
riking
9c4dd1cb35
Change comma-delim site settings to pipe-delim
2014-04-08 14:17:55 -07:00
Vikhyat Korrapati
e781a758ad
Preserve spoiler tags in post excerpts.
2014-02-20 15:01:44 +05:30
Robin Ward
963793549c
FIX: Remove failing ruby tests. The same thing is tested in JS and
...
passes due to the ability to create a document fragment.
2014-01-20 15:28:46 -05:00
Neil Lalonde
4f6b208e8d
Posts by trust level 3 users do not have nofollow on their external links.
2014-01-15 11:40:51 -05:00
Régis Hanol
ad8755aa70
BUGFIX: inline spoiler for text, block spoiler for images
2014-01-15 00:53:06 +01:00
Régis Hanol
70161498b6
BUGFIX: spoiler tag on lightboxed images wasn't working
2014-01-12 19:38:46 +01:00
Neil Lalonde
4ec0543362
FIX: emails with embedded posts should always use absolute URLs
2013-11-28 15:57:21 -05:00
