Commit graph

10061 commits

Author SHA1 Message Date
Régis Hanol
7fbf902d09 FIX: prevent cross-contamination of emojis in multisites 2015-10-30 23:26:34 +01:00
Régis Hanol
5e3da94c46 FIX: prevent infinite loop in PullHotlinkedImages job 2015-10-30 22:46:46 +01:00
Robin Ward
eaa31cf488 Merge pull request #3886 from LeoMcA/filter-by-username
filter by username in email digest preview
2015-10-30 14:44:50 -04:00
Robin Ward
21b29269d0 Remove excessive text on signup CTA 2015-10-30 14:13:16 -04:00
Leo McArdle
fe5264f9e9 filter by username in email digest preview
adds a user prompt on the email digest preview page to generate a preview for a particular user
also fixes some broken styling on the page
2015-10-30 18:11:38 +00:00
Régis Hanol
bde4bc52d7 UX: use 'last poster' avatar for mobile topics list 2015-10-30 16:50:46 +01:00
Arpit Jalan
106cb9874a FIX: show 404 page when user is logged out and navigates to private message 2015-10-30 17:41:55 +05:30
Arpit Jalan
9f8d6b6088 FIX: allow exisiting users to be invited to topic/message when enable_local_logins is disabled 2015-10-30 11:28:05 +05:30
Robin Ward
fe901163cc FIX: Fetch honeypot on init not name change which was error prone 2015-10-29 13:44:27 -04:00
James Kiesel
2fc52e26a6 Optimize all_allowed_users query 2015-10-29 19:39:30 +02:00
Régis Hanol
b9437936ab Merge pull request #3848 from gschlager/patch-2
Remove example CSS selectors from locale file
2015-10-29 10:01:52 +01:00
Régis Hanol
93cb2813cf Merge pull request #3863 from tgxworld/fix_last_posted_at_not_updated
FIX: Topic#last_posted_at was not being set when changing topic times…
2015-10-29 10:00:57 +01:00
Robin Ward
a9823ab59a FIX: Use a cookie to bypass the anon cache 2015-10-28 17:16:56 -04:00
Robin Ward
db5379508e FIX: Don't show an anonymous cache if there is a flash 2015-10-28 15:12:05 -04:00
Régis Hanol
bb79e6aff7 FEATURE: new hide_user_profiles_from_public site setting 2015-10-28 19:56:08 +01:00
Robin Ward
971af6a762 FIX: PostAlerter should ignore deleted posts 2015-10-28 13:03:54 -04:00
Arpit Jalan
734c272de8 UX: universal date format in digest email 2015-10-28 22:18:23 +05:30
Robin Ward
23371b026d FIX: Don't raise an error if you try to assign a group that exists 2015-10-28 12:21:54 -04:00
Robin Ward
6b236d3c83 FEATURE: Bulk Unlisting of topics 2015-10-27 16:57:40 -04:00
Robin Ward
46ca66771b FIX: Better error message for resending activation. Don't limit staff. 2015-10-27 16:25:30 -04:00
Robin Ward
010d847c2d Extensibility point for adding a new main button below topics 2015-10-27 15:05:59 -04:00
cpradio
68660cb9ac UX: Add custom classes to the profile page to permit hiding the invited_by and trust_level fields 2015-10-27 09:57:01 -04:00
Régis Hanol
9ea2d30105 UX: always show the avatar modal now that we have the letter avatars 2015-10-27 10:52:05 +01:00
Arpit Jalan
5dab5ada1c FIX: loading members on group page was broken 2015-10-27 09:20:49 +05:30
Robin Ward
47e25648df FEATURE: Change user groups in bulk via admin 2015-10-26 15:57:30 -04:00
Arpit Jalan
e1d5503053 FIX: flag button was broken for posts 2015-10-26 23:14:14 +05:30
Arpit Jalan
c28843e87b FIX: redirect to return_url when working as SSO provider 2015-10-25 11:30:38 +05:30
Guo Xiang Tan
25161eef39 FIX: 'q' keyboard shortcut not working. 2015-10-24 23:57:55 +08:00
Jeff Atwood
2b64ccb98c clean up portrait .topic-list CSS media query stuff 2015-10-23 17:15:13 -07:00
Jeff Atwood
56c9b4b6e2 UX: hide topic list views column on <= 850px w 2015-10-23 16:35:26 -07:00
Robin Ward
6ad42d4cd2 FIX: Category topics weren't refreshing when changing sort order 2015-10-23 16:39:37 -04:00
Robin Ward
09195768be FIX: Quote button was broken when the quoted post was unloaded 2015-10-23 12:49:13 -04:00
Robin Ward
f3d9d1295a FIX: Support subfolder URLs for middle clicking search 2015-10-23 12:02:10 -04:00
Régis Hanol
9483940244 UX: new topics list for mobile 2015-10-23 10:19:28 +02:00
Jeff Atwood
fac25763ba mobile topic list and user page CSS tweaks 2015-10-22 23:23:13 -07:00
Jeff Atwood
8a5f8d62b2 remove "right" class from profile buttons 2015-10-22 16:54:46 -07:00
Jeff Atwood
352824a3a4 fix mobile layout issues on user page 2015-10-22 16:43:01 -07:00
Jeff Atwood
7b95f8b633 another minor mobile tweak to alert-info 2015-10-22 14:42:37 -07:00
Jeff Atwood
8ea1ad1b2d minor css tweak to mobile alert-info 2015-10-22 14:40:19 -07:00
Jeff Atwood
567bc70391 make #banner full width on mobile 2015-10-22 14:37:00 -07:00
Robin Ward
1e50883d06 FIX: Incorrect search link 2015-10-22 16:37:44 -04:00
Régis Hanol
0ea54e9255 UX: don't show an empty list when all extensions are authorized 2015-10-22 20:11:17 +02:00
Régis Hanol
b46663fab0 FIX: hide full name field on the signup dialog when 'enable_names' is disabled 2015-10-22 18:10:01 +02:00
Jeff Atwood
ed0ac4eed3 FIX: incorrect profile background styles 2015-10-21 22:53:47 -07:00
Arpit Jalan
9793ea2c8a UX: change Dismiss button title and add tooltip 2015-10-22 07:52:47 +05:30
Neil Lalonde
ca98f66f7e FIX: wrong root path on subfolder installs 2015-10-21 13:13:19 -04:00
Neil Lalonde
976692b387 FIX: moderators need to choose a category when uncategorized topics are no allowed 2015-10-20 15:55:17 -04:00
Robin Ward
3ee1dee3eb UX: If you only had a checkbox user field, it was hoisting Location 2015-10-20 14:55:19 -04:00
Robin Ward
f8ff6fc0b5 FIX: Typo in teardown of d-editor 2015-10-20 12:42:14 -04:00
Robin Ward
0428bacfa9 SECURITY: A user could XSS themselves on their preference page 2015-10-20 12:09:59 -04:00
Régis Hanol
e08c9b8c49 Merge pull request #3867 from cpradio/fix-pin-unpin-shortcut
FIX: Fix the shortcut shift+p for pinning/unpinning a topic
2015-10-20 16:06:21 +02:00
cpradio
d2502bd127 FIX: Fix the shortcut shift+p for pinning/unpinning a topic 2015-10-20 09:40:43 -04:00
Régis Hanol
227689d77b Merge pull request #3866 from cpradio/fix-broken-keyboard-shortcuts
FIX: Fix the shortcuts shift+j and shift+k
2015-10-20 15:21:29 +02:00
cpradio
35496cae4f FIX: Fix the shortcuts shift+j and shift+k 2015-10-20 09:17:40 -04:00
Arpit Jalan
4a880a758f FEATURE: new Dismiss posts/topics modal 2015-10-20 16:07:02 +05:30
Jeff Atwood
5d341bef57 remove valign-helper hack, let's go flexbox 2015-10-20 00:46:24 -07:00
Régis Hanol
2fe70f6969 Merge pull request #3862 from tgxworld/emoji_toolbar_mobile
FIX: Emoji toolbar too wide on mobile.
2015-10-20 09:16:21 +02:00
Régis Hanol
18de82afe5 Merge pull request #3864 from tgxworld/push_pixels
UX: Misaligned buttons in image uploader.
2015-10-20 09:15:58 +02:00
Jeff Atwood
5ca93cd79c add opacity to mobile user page details 2015-10-19 23:58:42 -07:00
Jeff Atwood
722cce7400 FIX: mobile logo was too wide 2015-10-19 23:02:32 -07:00
Guo Xiang Tan
63fbab5b29 UX: Misaligned buttons in image uploader. 2015-10-20 11:10:53 +08:00
Guo Xiang Tan
d9fe78da20 FIX: Topic#last_posted_at was not being set when changing topic timestamp. 2015-10-20 10:12:52 +08:00
Guo Xiang Tan
97d11b6656 FIX: Emoji toolbar too wide on mobile. 2015-10-20 09:19:45 +08:00
Robin Ward
eacd75bcf8 SECURITY: Unread post notifications should respect whispers 2015-10-19 16:32:10 -04:00
Neil Lalonde
32bc9a8f93 FIX: some reports ignored date range parameters 2015-10-19 16:30:34 -04:00
Régis Hanol
c618478e88 FIX: sorting in a category isn't working 2015-10-19 19:04:47 +02:00
Robin Ward
cca48ce22f FIX: Default selectionStart/end differences in PhantomJS 2015-10-19 12:18:26 -04:00
Robin Ward
94b60e62a2 FEATURE: New markdown editor re-written in Ember
Note this commit leaves out the biggest occurrence of the editor
which is the post/topic composer.

To avoid major breakage, this replaces it everywhere else it was
used:

* User preferences (About Me)
* Admin Customizations > Text Content
* Category Templates
* Editing Queued Posts

A future commit will replace the main composer with this editor
and will remove the unused pagedown code.
2015-10-19 11:01:20 -04:00
Arpit Jalan
49edffd3c3 FEATURE: support linking to a specific revision of a topic/post 2015-10-19 14:31:29 +05:30
Sam
dfe3ecb914 PERF: disable prepared statements
see: https://github.com/rails/rails/issues/21992
2015-10-19 14:02:22 +11:00
Sam
dc10bdee3d FIX: incorrect localization in flagging dialog
- only happens when multiple locales enabled
2015-10-19 11:42:33 +11:00
Sam
dc859beff3 FEATURE: add handle_mail admin route
you can post full email payloads to this endpoint /admin/email/handle_mail
2015-10-19 08:33:24 +11:00
James D
44b04e4521 Make @mentions following a slash link to usercards
A slash preceding an @mention was causing the markup for the usercard
link to not be generated. For example, the markdown

Pinging @bob/@joe

Would generate a usercard for @bob, but not @joe.
2015-10-16 19:18:46 -04:00
Arpit Jalan
a439500bac FIX: do not mark post as spam if the previous flag was disagreed 2015-10-17 01:30:53 +05:30
Robin Ward
0547fcf799 UX: Show a loading spinner when loading an post you're editing.
cc @coding-horror
2015-10-16 14:57:53 -04:00
Neil Lalonde
14bfeec25e Merge pull request #3844 from gschlager/patch-1
FIX: Pressing Ctrl+F twice should show browser find
2015-10-16 13:16:55 -04:00
Régis Hanol
06b799bfbf Merge pull request #3857 from gdpelican/fix-for-untopiced-posts
Don't error on posts#latest if a post does not have a topic
2015-10-16 14:59:36 +02:00
James Kiesel
695b366a03 Don't error on posts#latest if a post does not have a topic 2015-10-16 14:44:48 +03:00
Guo Xiang Tan
8e8e787ad0 FIX: Whitelist parentheses and brackets in autocomplete. 2015-10-16 13:17:51 +08:00
Jeff Atwood
e744d85c99 move jagged-border gap removal to mobile only 2015-10-15 17:19:10 -07:00
Jeff Atwood
7338f74f14 CSS order of operations incorrect 2015-10-15 17:10:02 -07:00
Régis Hanol
d75cc67d86 FIX: robots.txt should be accessible even when login is required 2015-10-15 11:42:41 +02:00
Régis Hanol
de344bcd7e Merge pull request #3854 from tgxworld/fix_transactional_race_condition
FIX: Race condition when wrapping `PostCreator#create` in a transaction.
2015-10-15 11:07:20 +02:00
Régis Hanol
37c5909a31 FIX: use the first image in the first post in the topic as opengraph image
FEATURE: new 'default_opengraph_image_url' setting
2015-10-15 11:00:47 +02:00
Régis Hanol
73e345fe8f FIX: unescape emojis in digests 2015-10-15 09:59:29 +02:00
Guo Xiang Tan
600e42c2ba FIX: Race condition when wrapping PostCreator#create in a transaction. 2015-10-15 14:42:40 +08:00
Robin Ward
e8424bd54e SECURITY: Moderators should not see API keys 2015-10-14 15:40:23 -04:00
Robin Ward
a527c58c7d UX: Show a nicer "Log In" screen if the user follows /my/preferences 2015-10-14 13:39:31 -04:00
Robin Ward
d66a545dd2 FIX: /my/preferences should prompt users to log in 2015-10-14 12:40:13 -04:00
Neil Lalonde
37c783c348 Merge pull request #3851 from xfalcox/patch-3
Fix impersonate redirect on subfolder install
2015-10-14 11:02:41 -04:00
Arpit Jalan
2eece87206 UX: clip long category names in suggested topics 2015-10-14 19:02:57 +05:30
Robin Ward
bf53938ab7 FIX: On IOS9 the topic entrance was resizing the topic list 2015-10-13 16:59:32 -04:00
Robin Ward
7802757306 FIX: Username for topic creation is required 2015-10-13 16:33:26 -04:00
Rafael dos Santos Silva
dfed999ec8 Remove getUrl on impersonate redirect
As said by  @riking @nlalonde and @ZogStriP
2015-10-13 16:52:35 -03:00
Robin Ward
ae4ef1e70f Add spinner to composer saving 2015-10-13 13:06:24 -04:00
Régis Hanol
7ceecb0989 Merge pull request #3852 from tgxworld/fix_conditions_when_flagging_message
FIX: Conditions broken in flagging modals.
2015-10-13 11:02:35 +02:00
Guo Xiang Tan
aaff46d67f FIX: Conditions broken in flagging modals. 2015-10-13 16:56:32 +08:00
Régis Hanol
d863defd3b convert emoji toolbar to use safe local storage 2015-10-13 10:52:42 +02:00
Régis Hanol
7c369ab2b7 convert desktop notifications to use safe localStorage 2015-10-13 10:34:44 +02:00
Régis Hanol
cafff9bf01 FIX: ensure we can write to the localStorage 2015-10-13 10:21:49 +02:00
Sam
b6c2aa13e6 clean up implementation of non frame login / registration 2015-10-13 14:49:09 +11:00
Sam
fab51496cb correct full screen login feature 2015-10-13 13:11:49 +11:00
Sam
5b16adc0e8 FIX: sharing badges were off by 1 2015-10-13 12:32:29 +11:00
Sam
b3aebca406 FEATURE: allow auto provider to specify "full screen login"
this feature means we attempt to log in without opening a frame.
2015-10-13 12:23:34 +11:00
Sam
57e3323663 redirect back to base uri if there is no window opener. 2015-10-13 12:03:43 +11:00
Neil Lalonde
3ef16a7711 FIX: permalinks redirect on subfolder installs could add the subfolder to the url twice 2015-10-12 16:54:53 -04:00
Régis Hanol
1a3e9cf571 FIX: sorting was not working in /top
PERF: remove double request when sorting topics lists
2015-10-12 21:58:40 +02:00
Rafael dos Santos Silva
ccd46bf431 Fix impersonate redirect on subfolder install
Impersonate was redirecting to base site, instead of Discourse when using subfolder install.
2015-10-12 16:14:39 -03:00
Sam
e17978a203 FIX: do not notify in title if you created the post 2015-10-12 12:45:04 +11:00
Arpit Jalan
b72434d024 FEATURE: add 'change ownership' button in post admin wrench 2015-10-11 23:53:45 +05:30
Gerhard Schlager
11a6b61cbd Remove example CSS selectors from locale file 2015-10-11 14:48:37 +02:00
Gerhard Schlager
d10741170f FIX: Pressing Ctrl+F twice should show browser find 2015-10-08 22:30:33 +02:00
cpradio
979331f762 UX: Add mobile love to admin-nav for Plugin Pages 2015-10-07 09:57:05 -04:00
Sam
845c33e4b1 SECURITY: XSS in search results term
Thanks to Jerbi Nessim
2015-10-07 10:52:24 +11:00
cpradio
8cabc14099 FEATURE: Allow default period to be set for Top Page 2015-10-06 12:04:31 -04:00
Jeff Atwood
af7d51e923 Merge pull request #3831 from tgxworld/fix_emoji_toolbar
UX: Emoji toolbar on mobile.
2015-10-05 17:30:19 +11:00
Régis Hanol
9f14c197f2 less errors in js tests suite 2015-10-05 17:04:19 +11:00
Sam Saffron
4ade6138d3 FIX: suggested topics showing up when last post not loaded
New fix means that was show suggested

1. If all posts are loaded
2. If we are in the process of loading 1 more post due to message bus
2015-10-05 16:10:00 +11:00
scossar
71bc7d2e89 fix typo 2015-10-04 10:49:58 -07:00
Guo Xiang Tan
8b59f76f59 FIX: Don't append when there is nothing to append. 2015-10-03 17:22:13 +08:00
Guo Xiang Tan
904a36eea2 UX: Emoji Toolbar was too wide on mobile. 2015-10-03 17:08:13 +08:00
cpradio
57c1b15911 FIX: Who Liked a Post now shows UserCard when avatar is clicked 2015-10-02 18:10:06 -04:00
Jeff Atwood
ccb55b82e6 adjust alignment of topic progress popup 2015-10-02 02:41:37 -07:00
Sam
1754fcccf7 PERF: instead of N redis operations perform in bulk 2015-10-02 15:00:51 +10:00
Sam
43345063b9 PERF: avoid needless :try invokes respond_to? etc 2015-10-02 15:00:00 +10:00
Sam
6246dd0aa2 PERF: memoize to avoid N+1 query in category page 2015-10-02 12:35:47 +10:00
Sam
55c0f6a20c PERF: avoid method_missing 2015-10-02 12:27:38 +10:00
Sam
38f50d3bcc FIX: stop rendering blank urls for icons
You get an instant double request if you allow rendering of "" as
a favicon or apple touch icon.
2015-10-02 10:12:58 +10:00
Régis Hanol
2c384aec83 FIX: reply as new topic wasn't working in FF when the post was only composed of an image 2015-10-01 21:43:43 +02:00
Jeff Atwood
0237bece88 Revert "FIX: align topic-progress with topic-progress-expanded" 2015-10-01 10:13:31 -07:00
scossar
de61ae272a align topic-progress with topic-progress-expanded 2015-10-01 10:01:57 -07:00
Neil Lalonde
dd0a7107a8 FIX: canonical urls for category and topic pages was wrong when deployed to subfolder 2015-10-01 12:24:07 -04:00
Sam
6f43b575a8 FEATURE: no need to cap new and unread together anymore
- leave unread alone
- cap new at 500 per site, with a site setting
2015-10-01 17:17:15 +10:00
Régis Hanol
9bb7a3884b fix the build 2015-10-01 01:17:34 +02:00
Jeff Atwood
0b295150e7 UX: clearer delete user action buttons 2015-09-30 16:06:55 -07:00
Régis Hanol
25cb19eeca FIX: hide 'Quote Reply' button when there's no selection anymore on iOS 2015-10-01 00:11:18 +02:00
Robin Ward
7bd51e7882 FIX: Don't incldue whispers in context emails 2015-09-30 12:39:56 -04:00
Robin Ward
33e58c0587 FIX: You can click to see your own PMs from flags
Also refactors post action users to be a new object type since they can
have `post_url` which is not a field of a `User`
2015-09-30 12:28:55 -04:00
Arpit Jalan
97fbf09259 UX: post action glyphs color on mobile should match desktop color 2015-09-30 20:30:52 +05:30
Robin Ward
0f7aaf5ab1 Revert "FIX: paginated category and topic pages should not have canonical tag"
This reverts commit ecd93f7efb.
2015-09-29 17:22:28 -04:00
Robin Ward
4986314122 Add "more..." to emoji popup in composer. 2015-09-29 16:16:52 -04:00
Régis Hanol
321d1bd0a9 FIX: allow for more than 1 markdown editor instances 2015-09-29 20:21:47 +02:00
Robin Ward
3cd23b45af PERF: Only render 30 site settings in "All" when filtering 2015-09-29 13:34:09 -04:00
Robin Ward
8e86dbe560 FIX: Avatars weren't tappable on mobile 2015-09-29 12:58:19 -04:00
Régis Hanol
54d6d24cbf FIX: timing issue with edits and cook post processing 2015-09-29 18:51:26 +02:00
Robin Ward
3aaa9a8722 Restrict access to the Email admin tab to Admins 2015-09-29 12:37:46 -04:00
Arpit Jalan
ecd93f7efb FIX: paginated category and topic pages should not have canonical tag 2015-09-29 17:23:49 +05:30
Jeff Atwood
980c0196a8 FIX: similar topics lacked badge left margin 2015-09-29 02:14:44 -07:00
Sam
bc8c6d1a97 PERF: optimise new/unread query
This is part 1 of the work, need some internal cleanup to follow

new query seems to handle very large sets very efficiently
2015-09-29 11:55:09 +10:00
Robin Ward
f734a0731e Use capabilities object for browser sniffing 2015-09-28 11:44:37 -04:00