Sam
e8323fa534
FIX: removing a group from a user was not removing primary group
2015-02-09 16:03:09 +11:00
Robin Ward
7dea65122e
Support a url
field in plugin metadata
2015-02-06 18:08:57 -05:00
Régis Hanol
f7d2fc0524
FEATURE: 'reply by email address' validator
...
Prevent infinite email loophole when the 'reply_by_email_address' site setting is the same as the 'notification_email'.
2015-02-06 12:08:37 +01:00
Sam
820ce8765e
refactor traffic report
...
split traffic report in 2, page view vs raw traffic
hide raw traffic report by default
improve flushing logic for application reqs
2015-02-06 14:39:16 +11:00
Robin Ward
4e64d16a47
FEATURE: Allow plugins to log staff actions
2015-02-05 15:26:34 -05:00
Régis Hanol
2fcd199f48
FIX: send a PM to moderators when a post has been flagged as sockpuppet
2015-02-05 19:58:49 +01:00
Régis Hanol
f1403206ca
Merge pull request #3169 from riking/patch-3
...
SECURITY: Don't leak topic title in the redirect
2015-02-05 12:47:58 +01:00
Sam
08b790b3c2
improve metrics gathered using in our traffic section
...
this also pulls out the middleware into its own home and inserts in front
2015-02-05 16:08:52 +11:00
Sam
eb7a5c251d
freeze time in report spec so it has consistent results
2015-02-05 11:33:13 +11:00
Robin Ward
3b68214210
FIX: Clean up after adding events. Fixes random test failures.
2015-02-04 17:33:18 -05:00
Robin Ward
25daca8f23
Helpers for plugins to support enabling/disabling
2015-02-04 16:23:56 -05:00
riking
4c8850108a
SECURITY: Don't leak topic title in the redirect
2015-02-04 11:55:39 -08:00
Sam
a4b96adfc5
eliminate cross talk in site setting test
2015-02-04 16:57:16 +11:00
Sam
c150c55e2d
FEATURE: rudimentary view tracking wired in
2015-02-04 16:15:16 +11:00
Sam
e105f0965c
infrustructure for tracking application web requests
2015-02-04 16:15:16 +11:00
Robin Ward
aacf2e6f20
Can add shadowed_by_global
to a site setting to override
...
If a site setting has `shadowed_by_global: true` then, if
a `GlobalSetting` exists with the same name then that value
will be used instead. Additionally, the setting will be hidden.
This is useful in a multisite environment for private settings
such as API keys. You want to set it globally, yet not display
the key to customers.
2015-02-03 16:49:22 -05:00
Robin Ward
f15b0d205f
FIX: The "too similar" check happened when trying to make a post a wiki
2015-02-02 12:44:56 -05:00
Dan Singerman
64c4bd5dbf
Fix force_avatar_update.to_i error as force_avatar_update is a boolean
...
If force_avatar_update is passed in sso attributes it errors on
force_avatar_update.to_i. The SingleSignOn class forces avatar_force_update
to a boolean, so it should be treated as such.
2015-01-30 09:51:38 +00:00
Sam
8264dbd971
Merge pull request #3140 from fullfatthings/fix_missing_sso_avatar_bug
...
Fix bug when sso_overrides_avatar is true but no avatar_url is passed
2015-01-30 10:45:25 +11:00
Sam
b1f81c0dca
Merge pull request #3080 from riking/misc
...
Miscellaneous fixes from PR#3000
2015-01-30 10:23:17 +11:00
Sam
ea7af7a83b
Merge pull request #3135 from longhotsummer/fix-no-user-params
...
FIX: creating a user shouldn't error when optional fields aren't given
2015-01-30 10:12:57 +11:00
riking
85a7b925c7
Miscellaneous fixes from PR#3000
...
FIX: Don't require login to view post raw
FIX: Don't submit read-guidelines for anonymous users (causes
unnecessary 403 errors from ensure_logged_in)
FIX: Don't pass nil to an array serializer
2015-01-29 13:56:32 -08:00
Régis Hanol
6a68e8c272
FIX: use CDN for user card/profile background and user avatars (for real this time)
2015-01-29 22:53:48 +01:00
Arpit Jalan
6c410ed093
FIX: strip whitespaces from user email
2015-01-30 01:44:24 +05:30
Robin Ward
e42e9bd010
Merge pull request #3149 from techAPJ/patch-2
...
FIX: allow developer emails to bypass email blacklist/whitelist restrict...
2015-01-29 13:42:59 -05:00
Arpit Jalan
58f46137d6
FIX: allow developer emails to bypass email blacklist/whitelist restriction
2015-01-30 00:10:03 +05:30
Robin Ward
1f40807001
Add extensibility point for whenever a post is created
2015-01-29 12:46:29 -05:00
Régis Hanol
bdb0b45834
Merge pull request #3148 from techAPJ/patch-1
...
Do not allow TL0 users topics in email digest
2015-01-29 17:50:21 +01:00
Robin Ward
6e862e0e59
FIX: Should flush rate limit keys before testing it
2015-01-29 11:45:12 -05:00
Arpit Jalan
21e94859a9
Do not allow TL0 users topics in email digest
2015-01-29 21:10:26 +05:30
Arpit Jalan
e97755ab5d
FIX: remove custom Discourse headers in email
2015-01-29 17:25:50 +05:30
Régis Hanol
cd2c9edb46
FIX: 🐛 upload on IE9 wasn't working :'(
...
- FIX: make sure we set a default name to a pasted image only on Chrome (the only browser that supports it)
- FIX: use ".json" extension to uploads endpoints since IE9 doesn't pass the correct header
- FIX: pass the CSRF token in a query parameter since IE9 doesn't pass it in the headers
- FIX: display error messages comming from the server when there is one over the default error message
- FIX: HACK around IE9 security issue when clicking a file input via JavaScript (use a label and set `visibility:hidden` on the input)
- FIX: hide the "cancel" upload on IE9 since it's not supported
- FIX: return "text/plain" content-type when uploading a file for IE9 in order to prevent it from displaying the save dialog
- FIX: check the maximum file size on the server 💥
- update jQuery File Upload Plugin to v. 5.42.2
- update JQuery IFram Transport Plugin to v. 1.8.5
- update jQuery UI Widget to v. 1.11.1
2015-01-28 19:43:20 +01:00
Robin Ward
d43944b3ed
Extensibility for tracking changes to a topic
2015-01-28 13:37:06 -05:00
Dan Singerman
dbf2f4efec
Fix bug when sso_overrides_avatar is true but no avatar_url is passed
...
If a user has a current avatar, and sso_overrides_avatar is true, but no avatar_url is
passed in the sso attributes, the current code errors, as it tries to parse a nil
as a URL. It seems to me valid that a third party system may not pass an avatar_url in
some cases (e.g. avatars may not be mandatory, so not all users may have them)
This might warrant a discussion about what should happen in this case; maybe the current
avatar in discourse should be removed? This branch merely stops the login process erroring.
2015-01-28 16:01:39 +00:00
Arpit Jalan
b0369061e2
FIX: always set a default Message ID in email
2015-01-28 14:49:38 +05:30
Arpit Jalan
12c82bed59
Disable digest emails site setting
2015-01-27 22:41:36 +05:30
Greg Kempe
d99ccf6d27
FIX: creating a user shouldn't error when optional fields aren't provided
...
This fixes a bug where the server would 500 if the only user fields
where optional ones, and the create_user call didn't provide any
values so that params[:user_fields] was nil.
Additionally, don't bother double-checked for required fields, since we
iterate over all fields and will catch any that are required and blank.
2015-01-27 11:48:27 +02:00
Arpit Jalan
5c2ee8ec2a
FEATURE: suppress digest emails for users not seen on the site for more than (n) days.
2015-01-26 22:04:02 +05:30
riking
1ab0d6bd82
FEATURE: Log username changes by staff
...
Also fix the tests for changing username
2015-01-17 02:26:12 -08:00
Régis Hanol
7a86abd105
Merge pull request #3084 from jmay/group-managers
...
table & model changes for group managers with permission to edit members
2015-01-16 12:02:38 +01:00
Neil Lalonde
4a11bb5227
FIX: on topic page, don't try to render post counts for a deleted user
2015-01-15 15:39:34 -05:00
Robin Ward
dc801bb442
Merge pull request #3102 from techAPJ/patch-2
...
Add username and date-time in exported file name
2015-01-15 15:35:06 -05:00
Robin Ward
505fa9f1cf
FIX: 🐛 Saving the same custom field array twice would raise an error
2015-01-15 15:31:50 -05:00
Arpit Jalan
c619aed8f9
💄 add username and date-time in exported file name
2015-01-16 01:39:46 +05:30
Jason W. May
a2b284a0a4
table & model changes for group managers with permission to edit membership
2015-01-15 11:44:42 -08:00
Régis Hanol
b4e5937850
FIX: 🐛 ensure emoji are case insensitive
2015-01-15 19:00:55 +01:00
Arpit Jalan
c4da9ce62f
FIX: old csv's were not getting deleted
2015-01-15 00:00:39 +05:30
Arpit Jalan
835835832f
FIX: user list export was failing
2015-01-14 16:24:42 +05:30
Arpit Jalan
b94c7922c5
🐎 gzip csv export files
2015-01-14 13:38:37 +05:30
Arpit Jalan
7771d2fb31
remove enable_email_names setting
2015-01-13 13:35:40 +05:30
Régis Hanol
1032fa7262
Merge pull request #3089 from lucianosousa/enhacement/controllers-rspec3
...
controllers with rspec3 syntax
2015-01-12 16:25:31 +01:00
Régis Hanol
5f98be6ec5
Merge pull request #3088 from lucianosousa/enhacement/components-rspec3
...
few components with rspec3 syntax
2015-01-12 16:25:25 +01:00
Régis Hanol
f7f5e39f75
FIX: Minor Admin bug with a setting when creating a new group
2015-01-23 20:31:48 +01:00
Régis Hanol
256519dddf
FEATURE: automatic group membership based on email address
2015-01-23 18:25:43 +01:00
Robin Ward
b3a2c0c45b
SECURITY: The SSO return_path
was an open redirect
...
This security fix needs SSO to be configured, and the user has to go
through the entire auth process before being redirected to the wrong host so
it is probably lower priority for most installs.
2015-01-22 12:20:17 -05:00
Régis Hanol
e300945879
FEATURE: split group admin in 2 tabs (custom & automatic)
...
FIX: clear the user-selector when adding new members
2015-01-21 20:52:48 +01:00
Arpit Jalan
5e751ce90a
FEATURE: 🎁 rate limit invites for non-staff users
2015-01-20 01:12:24 +05:30
Luciano Sousa
bc73238c8f
controllers with rspec3 syntax
2015-01-09 14:04:02 -03:00
Luciano Sousa
0fd98b56d8
few components with rspec3 syntax
2015-01-09 13:34:37 -03:00
Luciano Sousa
16156bdc1d
removing rspec3 warning
2015-01-09 09:55:58 -03:00
Sam
0b14cfa2c3
skip failing spec, something is off with timezones
2015-01-09 12:03:08 +11:00
Régis Hanol
6cec925f26
FIX: all PMs should be flaggable
2015-01-08 16:06:43 +01:00
Sam
03388e11ab
oops, migration was flipping
2015-01-08 15:26:15 +11:00
Sam
3347a48275
FEATURE: add liked and bookmarked classes to topic list item rows
2015-01-08 14:35:56 +11:00
Robin Ward
114cc1c851
FIX: We missed some references to /category/xyz
in the ruby code base.
2015-01-07 11:47:01 -05:00
Sam
ea87f5fd8a
FEATURE: support for filter=bookmarked and filter=liked in topic list
2015-01-07 18:20:10 +11:00
Sam
efc717c14a
FEATURE: remove star concept from Discourse
2015-01-07 13:43:27 +11:00
Jeff Atwood
6953923a03
remove |starred| from topnav default options
2015-01-06 16:03:45 -08:00
Régis Hanol
060cda7772
FIX: proper handling of group memberships
2015-01-05 18:51:45 +01:00
Luciano Sousa
b52f12948a
models with rspec3 syntax
2015-01-05 13:04:23 -03:00
Luciano Sousa
b3d769ff4f
Update rspec syntax to v3
...
update rspec syntax to v3
change syntax to rspec v3
oops. fix typo
mailers classes with rspec3 syntax
helpers with rspec3 syntax
jobs with rspec3 syntax
serializers with rspec3 syntax
views with rspec3 syntax
support to rspec3 syntax
category spec with rspec3 syntax
2015-01-05 11:59:30 -03:00
Robin Ward
6f72f265cb
A trigger when a topic is updated, adds a couple of custom field tests
2015-01-02 15:57:08 -05:00
Neil Lalonde
4c166942ad
FEATURE: Invite admin api has an optional param send_email which can prevent sending an email to the invited user. The api will return the password reset url so that the caller can send an email with it instead.
2015-01-02 15:48:54 -05:00
Régis Hanol
c57a1b393f
clean up 'checked_for_custom_avatars' user history entries
2015-01-02 12:37:17 +01:00
Régis Hanol
9fcaf090ec
Merge pull request #3068 from fantasticfears/category_slug
...
support setting category slug
2015-01-02 11:55:27 +01:00
Arpit Jalan
bfe95966b4
better filenames for export
2015-01-02 15:30:50 +05:30
Robin Ward
35edfb5b91
FIX: Don't truncate groups. @ZogStrIP we need to create a better fix for
...
this in the new year.
2014-12-31 12:58:50 -05:00
Robin Ward
3d42c2d515
Merge pull request #3070 from techAPJ/patch-3
...
FIX: rate limit user posts export
2014-12-31 11:37:11 -05:00
Arpit Jalan
78537aad39
FIX: rate limit user posts export
2014-12-31 00:54:23 +05:30
Erick Guan
97b3914b70
FIX: use utc time when generate reports; set boundary
2014-12-30 22:43:03 +08:00
Régis Hanol
a04f44d65a
Merge pull request #3065 from fantasticfears/fix-visits-report
...
FIX: today visits not shown
2014-12-29 21:23:47 +01:00
Robin Ward
f7955406cc
As an optimization, don't return suspended users in the query that
...
determines who to send digests to.
2014-12-29 15:16:29 -05:00
Erick Guan
1e166d89ff
support setting category slug
2014-12-30 03:14:54 +08:00
Erick Guan
fe7f2c6979
FIX: today visits not shown
2014-12-30 03:09:22 +08:00
Régis Hanol
7ca092da17
Merge pull request #3057 from jaanus/s3-frankfurt-bucket
...
Add eu-central-1 to list of S3 buckets.
2014-12-29 18:02:14 +01:00
jaanus
f6026ad1d0
Added eu-central-1 S3 bucket.
2014-12-29 18:31:21 +02:00
Robin Ward
1055fc0919
Merge pull request #3021 from jmay/custom-category-slug
...
optional custom value for category slug (create and update)
2014-12-29 10:34:23 -05:00
Régis Hanol
267de04e2d
Merge pull request #3061 from techAPJ/patch-1
...
Rename CsvExportLog to UserExport
2014-12-29 12:39:53 +01:00
Régis Hanol
bfbc49ef6f
FIX: log only 1 'show email' record
2014-12-29 11:50:36 +01:00
Sam
ef62933034
Ruby 2.2 fixes
2014-12-29 13:31:15 +11:00
Arpit Jalan
68e66f3a25
Rename CsvExportLog to UserExport
2014-12-28 22:31:12 +05:30
Régis Hanol
9932bea7ce
FEATURE: default emoji override
2014-12-25 17:58:15 +01:00
Arpit Jalan
7c7474aa10
create a new table to maintain csv export log
2014-12-24 16:25:36 +05:30
Arpit Jalan
bb152a5b3f
FEATURE: download user posts archive
2014-12-24 15:13:48 +05:30
Sam
e23e008682
FIX: buggy unhoisting of escaped \*
2014-12-23 18:25:10 +11:00
Sam
5b844f5320
FEATURE: more than 1 site customization can be enabled at once
...
FIX: more robust site customizations
Rewrote site customization to use distributed cache and a much cleaner
css delivery mechanism
2014-12-23 13:03:48 +11:00
Régis Hanol
45dbdb6896
FEATURE: custom emojis
2014-12-23 01:12:26 +01:00
Robin Ward
9bb2ab6265
Merge pull request #3034 from fantasticfears/filter_system_user
...
disable sending email or show presence when forgot system user password
2014-12-19 16:52:01 -05:00
Neil Lalonde
3cb25b019e
FIX: when private messages are disabled in settings, flag modal shouldn't show private message options
2014-12-19 16:47:39 -05:00
Erick Guan
ceca85c9eb
use system user helper and constant when it's referred
2014-12-18 18:21:14 +08:00
Sam
ae16186100
FEATURE: post chunk size should not be configurable
...
If people need to configure post chunk size use a plugin
Core only supports out of the box settings, if changed can lead to
severe performance issues.
2014-12-15 10:57:34 +11:00
Robin Ward
768027f0e3
Merge pull request #3046 from gdpelican/feature/insensitive-group-names
...
Remove group name validation case sensitivity
2014-12-17 10:52:45 -05:00
Régis Hanol
f5317a519f
Merge pull request #3035 from oblakeerickson/update_username_return_json
...
Update username should return a json response
2014-12-17 11:23:33 +01:00
James Kiesel
84bed4f9ce
Remove group name validation case sensitivity
2014-12-17 18:44:30 +13:00
Régis Hanol
521226f4c9
FIX: registration fails with timeout on gravatar
2014-12-15 22:10:27 +01:00
Robin Ward
b2e2a99898
FIX: Don't raise an error when trying to log nothing
2014-12-15 14:14:12 -05:00
Robin Ward
2d6b15a34d
Load fewer posts when the android platform is detected
2014-12-12 11:47:39 -05:00
Régis Hanol
1353557575
FIX: custom flags not possible on very long topic titles
2014-12-11 19:34:52 +01:00
Blake Erickson
02ade72ceb
Update username should return a json response
...
- Have update username return json response that contains the updated
username and id. I figured this would be better than just return "OK".
- Add test to verify that the new username is returned.
2014-12-10 09:43:16 -07:00
Régis Hanol
6027073547
FIX: properly unescape HTML entities in excerpts
2014-12-10 12:52:51 +01:00
Erick Guan
9937af7ac4
disable sending email or show presence when forgot system user password
2014-12-10 14:17:56 +08:00
Robin Ward
663cd93c6d
Move register_asset
into PluginRegistry
-- the logic works better
...
there.
2014-12-09 14:20:53 -05:00
Blake Erickson
1d0eccf710
Have activate user return json
...
- Change activate user from admin controller to return json
- Test that it returns json
- Remove unnessary test from log_out spec
This commit was created so that when you activate a user through the api
it returns a json response.
2014-12-08 11:16:57 -07:00
Sam
fdecd69228
Merge pull request #3026 from oblakeerickson/legacy_avatar
...
Remove legacy avatar code
2014-12-08 11:03:55 +11:00
Blake Erickson
e9e88c9b82
Remove legacy avatar code
...
- Remove method that was only left around because the
[api](https://github.com/discourse/discourse_api/pull/53 ) called it
- Modify test to use new route instead of legacy route
https://meta.discourse.org/t/legacy-route-for-avatars/22838/2
2014-12-07 06:13:14 -07:00
Sam
a4ce039c85
demock spec
2014-12-07 18:11:38 +11:00
Régis Hanol
929ff00741
FIX: use excerpt instead of the summary
2014-12-06 18:48:39 +01:00
Régis Hanol
dec881ac9d
Merge pull request #3024 from oblakeerickson/avatar_return_json
...
Have pick_avatar return json.
2014-12-06 18:20:42 +01:00
Blake Erickson
a61519eebf
Have pick_avatar return json.
...
I'm working on writing a test in the discourse_api gem for uploading
avatars and the pick method needs to return a json response.
I also added a test to make sure json is returned.
2014-12-06 09:26:32 -07:00
Régis Hanol
86c4c947a3
FIX: drastically simplify auto-close topic logic
...
Get rid of this nonsensical maximum-flow algorithm :fired:
2014-12-06 16:29:54 +01:00
Régis Hanol
cd170ca548
FEATURE: auto-close topics based on community flags
2014-12-05 19:37:43 +01:00
Arpit Jalan
d28515792a
FIX: auto response email replies should not be accepted
2014-12-04 22:39:13 +05:30
Sam
4aa0d88c6c
FEATURE: search private messages option
2014-12-04 13:50:36 +11:00
Jason W. May
efa872e426
optional custom value for category slug (create and update)
2014-12-03 16:23:59 -08:00
Régis Hanol
77a775ecd2
Merge pull request #3012 from techAPJ/patch-2
...
Add test for email with inline reply
2014-12-03 15:45:04 +01:00
Arpit Jalan
f84bdfdde3
FIX: if full user name is not provided, username should be present in email From header
2014-12-03 13:12:05 +05:30
Jeff Atwood
ea269ccfb2
rename purge_inactive to purge_unactivated
2014-12-02 21:36:25 -08:00
Sam
a8ff5fe97c
Merge pull request #3002 from jmay/group-membership-api
...
use limit & offset for pagination of group members
2014-12-03 11:11:10 +11:00
Régis Hanol
f226e4efc0
FIX: don't error out when updating a topic with no changes
2014-12-02 02:16:30 +01:00
Arpit Jalan
15c105eba5
Add test for email with inline reply
2014-12-01 23:51:14 +05:30
Régis Hanol
64b06b360a
Merge pull request #3008 from oblakeerickson/log_out_return_success
...
Have log_out method return json
2014-12-01 14:26:06 +01:00
Blake Erickson
bdc92eec70
Have log_out method return json.
...
This commit helps improve the discourse_api experience so that we can
check the json response if it was a success or not. This commit also
checks that a 404 is sent instead of a 500 if a bad user_id is passed
in.
2014-12-01 06:03:25 -07:00
Arpit Jalan
529014d56e
FEATURE: switch to GitHub email_reply_parser library and parse plain text email content
2014-12-01 09:00:35 +05:30
Robin Ward
cb0e7a5724
For performance reasons, use delete_all
when removing a user's email logs
2014-11-28 14:20:43 -05:00
Régis Hanol
5b90ceb71d
FEATURE: rolls up 1.2.*.* IP ranges when number of entries > 10
2014-11-27 19:29:30 +01:00
Sam
013f1a6dd0
FEATURE: allow creating admin and moderator accounts via SSO
2014-11-27 12:39:00 +11:00
Régis Hanol
4e735e8aab
FIX: roll up staff action wasn't working
2014-11-27 01:12:56 +01:00
Régis Hanol
10b5032188
FIX: auto-closing attribution when a TL4 user auto-closes a topic
2014-11-26 19:51:07 +01:00
Régis Hanol
27d78332c4
FEATURE: restrict some user fields for TL0 users when viewed by anonymous users
2014-11-26 19:20:03 +01:00
Régis Hanol
d7ef4f1edd
remove useless 'puts'
2014-11-26 16:40:03 +01:00
Sam
c10e3df012
FEATURE: implement SSO provider on Discourse so Auth can be farmed to it
...
FEATURE: pass return_sso_url to SSO endpoints, for easier return
2014-11-26 17:26:27 +11:00
Sam
d171d6db19
FEATURE: export sso data if sso is enabled
2014-11-26 09:43:28 +11:00
Robin Ward
4c9f55d1e1
FIX: Suspended users should have links stripped from their profiles.
2014-11-25 16:14:39 -05:00
Jason W. May
610c2a4d65
checking actual values in the spec, not just counts
2014-11-25 09:12:24 -08:00
Régis Hanol
0588292dcf
Merge pull request #2999 from riking/fix_top_referrers_topic_count
...
FIX: Topic referrals by user were wrong
2014-11-25 17:46:44 +01:00
riking
728e8a262c
FIX: Admin panel referral stats not counting topics correctly
...
Due to what seems to be a bug in ActiveRecord, the distinct: true option
is not recognized on counts with string column names. This commit fixes
that by moving the DISTINCT into the count string.
For robustness, the integration spec for IncomingLinksReport was
rewritten to be an actual integration spec, running the actual interface
on actual fake data.
2014-11-24 12:16:52 -08:00
Jason W. May
adb570fe53
use limit & offset for pagination of group members
2014-11-24 12:12:48 -08:00
Régis Hanol
7b0ae702e7
FEATURE: log a new staff action when rolling up banned IP addresses
2014-11-24 19:48:54 +01:00
Robin Ward
17b6d3a2fe
FIX: Mailing list mode was not checking for user deleted posts
2014-11-24 11:43:40 -05:00
Régis Hanol
1023191315
FEATURE: roll up function for 123.456.789.* ranges
2014-11-24 17:25:48 +01:00