Commit graph

9961 commits

Author SHA1 Message Date
Robin Ward
f8ff6fc0b5 FIX: Typo in teardown of d-editor 2015-10-20 12:42:14 -04:00
Robin Ward
0428bacfa9 SECURITY: A user could XSS themselves on their preference page 2015-10-20 12:09:59 -04:00
Régis Hanol
e08c9b8c49 Merge pull request #3867 from cpradio/fix-pin-unpin-shortcut
FIX: Fix the shortcut shift+p for pinning/unpinning a topic
2015-10-20 16:06:21 +02:00
cpradio
d2502bd127 FIX: Fix the shortcut shift+p for pinning/unpinning a topic 2015-10-20 09:40:43 -04:00
Régis Hanol
227689d77b Merge pull request #3866 from cpradio/fix-broken-keyboard-shortcuts
FIX: Fix the shortcuts shift+j and shift+k
2015-10-20 15:21:29 +02:00
cpradio
35496cae4f FIX: Fix the shortcuts shift+j and shift+k 2015-10-20 09:17:40 -04:00
Arpit Jalan
4a880a758f FEATURE: new Dismiss posts/topics modal 2015-10-20 16:07:02 +05:30
Jeff Atwood
5d341bef57 remove valign-helper hack, let's go flexbox 2015-10-20 00:46:24 -07:00
Régis Hanol
2fe70f6969 Merge pull request #3862 from tgxworld/emoji_toolbar_mobile
FIX: Emoji toolbar too wide on mobile.
2015-10-20 09:16:21 +02:00
Régis Hanol
18de82afe5 Merge pull request #3864 from tgxworld/push_pixels
UX: Misaligned buttons in image uploader.
2015-10-20 09:15:58 +02:00
Jeff Atwood
5ca93cd79c add opacity to mobile user page details 2015-10-19 23:58:42 -07:00
Jeff Atwood
722cce7400 FIX: mobile logo was too wide 2015-10-19 23:02:32 -07:00
Guo Xiang Tan
63fbab5b29 UX: Misaligned buttons in image uploader. 2015-10-20 11:10:53 +08:00
Guo Xiang Tan
d9fe78da20 FIX: Topic#last_posted_at was not being set when changing topic timestamp. 2015-10-20 10:12:52 +08:00
Guo Xiang Tan
97d11b6656 FIX: Emoji toolbar too wide on mobile. 2015-10-20 09:19:45 +08:00
Robin Ward
eacd75bcf8 SECURITY: Unread post notifications should respect whispers 2015-10-19 16:32:10 -04:00
Neil Lalonde
32bc9a8f93 FIX: some reports ignored date range parameters 2015-10-19 16:30:34 -04:00
Régis Hanol
c618478e88 FIX: sorting in a category isn't working 2015-10-19 19:04:47 +02:00
Robin Ward
cca48ce22f FIX: Default selectionStart/end differences in PhantomJS 2015-10-19 12:18:26 -04:00
Robin Ward
94b60e62a2 FEATURE: New markdown editor re-written in Ember
Note this commit leaves out the biggest occurrence of the editor
which is the post/topic composer.

To avoid major breakage, this replaces it everywhere else it was
used:

* User preferences (About Me)
* Admin Customizations > Text Content
* Category Templates
* Editing Queued Posts

A future commit will replace the main composer with this editor
and will remove the unused pagedown code.
2015-10-19 11:01:20 -04:00
Arpit Jalan
49edffd3c3 FEATURE: support linking to a specific revision of a topic/post 2015-10-19 14:31:29 +05:30
Sam
dfe3ecb914 PERF: disable prepared statements
see: https://github.com/rails/rails/issues/21992
2015-10-19 14:02:22 +11:00
Sam
dc10bdee3d FIX: incorrect localization in flagging dialog
- only happens when multiple locales enabled
2015-10-19 11:42:33 +11:00
Sam
dc859beff3 FEATURE: add handle_mail admin route
you can post full email payloads to this endpoint /admin/email/handle_mail
2015-10-19 08:33:24 +11:00
James D
44b04e4521 Make @mentions following a slash link to usercards
A slash preceding an @mention was causing the markup for the usercard
link to not be generated. For example, the markdown

Pinging @bob/@joe

Would generate a usercard for @bob, but not @joe.
2015-10-16 19:18:46 -04:00
Arpit Jalan
a439500bac FIX: do not mark post as spam if the previous flag was disagreed 2015-10-17 01:30:53 +05:30
Robin Ward
0547fcf799 UX: Show a loading spinner when loading an post you're editing.
cc @coding-horror
2015-10-16 14:57:53 -04:00
Neil Lalonde
14bfeec25e Merge pull request #3844 from gschlager/patch-1
FIX: Pressing Ctrl+F twice should show browser find
2015-10-16 13:16:55 -04:00
Régis Hanol
06b799bfbf Merge pull request #3857 from gdpelican/fix-for-untopiced-posts
Don't error on posts#latest if a post does not have a topic
2015-10-16 14:59:36 +02:00
James Kiesel
695b366a03 Don't error on posts#latest if a post does not have a topic 2015-10-16 14:44:48 +03:00
Guo Xiang Tan
8e8e787ad0 FIX: Whitelist parentheses and brackets in autocomplete. 2015-10-16 13:17:51 +08:00
Jeff Atwood
e744d85c99 move jagged-border gap removal to mobile only 2015-10-15 17:19:10 -07:00
Jeff Atwood
7338f74f14 CSS order of operations incorrect 2015-10-15 17:10:02 -07:00
Régis Hanol
d75cc67d86 FIX: robots.txt should be accessible even when login is required 2015-10-15 11:42:41 +02:00
Régis Hanol
de344bcd7e Merge pull request #3854 from tgxworld/fix_transactional_race_condition
FIX: Race condition when wrapping `PostCreator#create` in a transaction.
2015-10-15 11:07:20 +02:00
Régis Hanol
37c5909a31 FIX: use the first image in the first post in the topic as opengraph image
FEATURE: new 'default_opengraph_image_url' setting
2015-10-15 11:00:47 +02:00
Régis Hanol
73e345fe8f FIX: unescape emojis in digests 2015-10-15 09:59:29 +02:00
Guo Xiang Tan
600e42c2ba FIX: Race condition when wrapping PostCreator#create in a transaction. 2015-10-15 14:42:40 +08:00
Robin Ward
e8424bd54e SECURITY: Moderators should not see API keys 2015-10-14 15:40:23 -04:00
Robin Ward
a527c58c7d UX: Show a nicer "Log In" screen if the user follows /my/preferences 2015-10-14 13:39:31 -04:00
Robin Ward
d66a545dd2 FIX: /my/preferences should prompt users to log in 2015-10-14 12:40:13 -04:00
Neil Lalonde
37c783c348 Merge pull request #3851 from xfalcox/patch-3
Fix impersonate redirect on subfolder install
2015-10-14 11:02:41 -04:00
Arpit Jalan
2eece87206 UX: clip long category names in suggested topics 2015-10-14 19:02:57 +05:30
Robin Ward
bf53938ab7 FIX: On IOS9 the topic entrance was resizing the topic list 2015-10-13 16:59:32 -04:00
Robin Ward
7802757306 FIX: Username for topic creation is required 2015-10-13 16:33:26 -04:00
Rafael dos Santos Silva
dfed999ec8 Remove getUrl on impersonate redirect
As said by  @riking @nlalonde and @ZogStriP
2015-10-13 16:52:35 -03:00
Robin Ward
ae4ef1e70f Add spinner to composer saving 2015-10-13 13:06:24 -04:00
Régis Hanol
7ceecb0989 Merge pull request #3852 from tgxworld/fix_conditions_when_flagging_message
FIX: Conditions broken in flagging modals.
2015-10-13 11:02:35 +02:00
Guo Xiang Tan
aaff46d67f FIX: Conditions broken in flagging modals. 2015-10-13 16:56:32 +08:00
Régis Hanol
d863defd3b convert emoji toolbar to use safe local storage 2015-10-13 10:52:42 +02:00
Régis Hanol
7c369ab2b7 convert desktop notifications to use safe localStorage 2015-10-13 10:34:44 +02:00
Régis Hanol
cafff9bf01 FIX: ensure we can write to the localStorage 2015-10-13 10:21:49 +02:00
Sam
b6c2aa13e6 clean up implementation of non frame login / registration 2015-10-13 14:49:09 +11:00
Sam
fab51496cb correct full screen login feature 2015-10-13 13:11:49 +11:00
Sam
5b16adc0e8 FIX: sharing badges were off by 1 2015-10-13 12:32:29 +11:00
Sam
b3aebca406 FEATURE: allow auto provider to specify "full screen login"
this feature means we attempt to log in without opening a frame.
2015-10-13 12:23:34 +11:00
Sam
57e3323663 redirect back to base uri if there is no window opener. 2015-10-13 12:03:43 +11:00
Neil Lalonde
3ef16a7711 FIX: permalinks redirect on subfolder installs could add the subfolder to the url twice 2015-10-12 16:54:53 -04:00
Régis Hanol
1a3e9cf571 FIX: sorting was not working in /top
PERF: remove double request when sorting topics lists
2015-10-12 21:58:40 +02:00
Rafael dos Santos Silva
ccd46bf431 Fix impersonate redirect on subfolder install
Impersonate was redirecting to base site, instead of Discourse when using subfolder install.
2015-10-12 16:14:39 -03:00
Sam
e17978a203 FIX: do not notify in title if you created the post 2015-10-12 12:45:04 +11:00
Arpit Jalan
b72434d024 FEATURE: add 'change ownership' button in post admin wrench 2015-10-11 23:53:45 +05:30
Gerhard Schlager
11a6b61cbd Remove example CSS selectors from locale file 2015-10-11 14:48:37 +02:00
Gerhard Schlager
d10741170f FIX: Pressing Ctrl+F twice should show browser find 2015-10-08 22:30:33 +02:00
Sam
845c33e4b1 SECURITY: XSS in search results term
Thanks to Jerbi Nessim
2015-10-07 10:52:24 +11:00
cpradio
8cabc14099 FEATURE: Allow default period to be set for Top Page 2015-10-06 12:04:31 -04:00
Jeff Atwood
af7d51e923 Merge pull request #3831 from tgxworld/fix_emoji_toolbar
UX: Emoji toolbar on mobile.
2015-10-05 17:30:19 +11:00
Régis Hanol
9f14c197f2 less errors in js tests suite 2015-10-05 17:04:19 +11:00
Sam Saffron
4ade6138d3 FIX: suggested topics showing up when last post not loaded
New fix means that was show suggested

1. If all posts are loaded
2. If we are in the process of loading 1 more post due to message bus
2015-10-05 16:10:00 +11:00
scossar
71bc7d2e89 fix typo 2015-10-04 10:49:58 -07:00
Guo Xiang Tan
8b59f76f59 FIX: Don't append when there is nothing to append. 2015-10-03 17:22:13 +08:00
Guo Xiang Tan
904a36eea2 UX: Emoji Toolbar was too wide on mobile. 2015-10-03 17:08:13 +08:00
cpradio
57c1b15911 FIX: Who Liked a Post now shows UserCard when avatar is clicked 2015-10-02 18:10:06 -04:00
Jeff Atwood
ccb55b82e6 adjust alignment of topic progress popup 2015-10-02 02:41:37 -07:00
Sam
1754fcccf7 PERF: instead of N redis operations perform in bulk 2015-10-02 15:00:51 +10:00
Sam
43345063b9 PERF: avoid needless :try invokes respond_to? etc 2015-10-02 15:00:00 +10:00
Sam
6246dd0aa2 PERF: memoize to avoid N+1 query in category page 2015-10-02 12:35:47 +10:00
Sam
55c0f6a20c PERF: avoid method_missing 2015-10-02 12:27:38 +10:00
Sam
38f50d3bcc FIX: stop rendering blank urls for icons
You get an instant double request if you allow rendering of "" as
a favicon or apple touch icon.
2015-10-02 10:12:58 +10:00
Régis Hanol
2c384aec83 FIX: reply as new topic wasn't working in FF when the post was only composed of an image 2015-10-01 21:43:43 +02:00
Jeff Atwood
0237bece88 Revert "FIX: align topic-progress with topic-progress-expanded" 2015-10-01 10:13:31 -07:00
scossar
de61ae272a align topic-progress with topic-progress-expanded 2015-10-01 10:01:57 -07:00
Neil Lalonde
dd0a7107a8 FIX: canonical urls for category and topic pages was wrong when deployed to subfolder 2015-10-01 12:24:07 -04:00
Sam
6f43b575a8 FEATURE: no need to cap new and unread together anymore
- leave unread alone
- cap new at 500 per site, with a site setting
2015-10-01 17:17:15 +10:00
Régis Hanol
9bb7a3884b fix the build 2015-10-01 01:17:34 +02:00
Jeff Atwood
0b295150e7 UX: clearer delete user action buttons 2015-09-30 16:06:55 -07:00
Régis Hanol
25cb19eeca FIX: hide 'Quote Reply' button when there's no selection anymore on iOS 2015-10-01 00:11:18 +02:00
Robin Ward
7bd51e7882 FIX: Don't incldue whispers in context emails 2015-09-30 12:39:56 -04:00
Robin Ward
33e58c0587 FIX: You can click to see your own PMs from flags
Also refactors post action users to be a new object type since they can
have `post_url` which is not a field of a `User`
2015-09-30 12:28:55 -04:00
Arpit Jalan
97fbf09259 UX: post action glyphs color on mobile should match desktop color 2015-09-30 20:30:52 +05:30
Robin Ward
0f7aaf5ab1 Revert "FIX: paginated category and topic pages should not have canonical tag"
This reverts commit ecd93f7efb.
2015-09-29 17:22:28 -04:00
Robin Ward
4986314122 Add "more..." to emoji popup in composer. 2015-09-29 16:16:52 -04:00
Régis Hanol
321d1bd0a9 FIX: allow for more than 1 markdown editor instances 2015-09-29 20:21:47 +02:00
Robin Ward
3cd23b45af PERF: Only render 30 site settings in "All" when filtering 2015-09-29 13:34:09 -04:00
Robin Ward
8e86dbe560 FIX: Avatars weren't tappable on mobile 2015-09-29 12:58:19 -04:00
Régis Hanol
54d6d24cbf FIX: timing issue with edits and cook post processing 2015-09-29 18:51:26 +02:00
Robin Ward
3aaa9a8722 Restrict access to the Email admin tab to Admins 2015-09-29 12:37:46 -04:00
Arpit Jalan
ecd93f7efb FIX: paginated category and topic pages should not have canonical tag 2015-09-29 17:23:49 +05:30
Jeff Atwood
980c0196a8 FIX: similar topics lacked badge left margin 2015-09-29 02:14:44 -07:00
Sam
bc8c6d1a97 PERF: optimise new/unread query
This is part 1 of the work, need some internal cleanup to follow

new query seems to handle very large sets very efficiently
2015-09-29 11:55:09 +10:00