Commit graph

3688 commits

Author SHA1 Message Date
Régis Hanol
e7f251c105 LOTS of changes to properly handle post/topic revisions
FIX: history revision can now properly be hidden
FIX: PostRevision serializer is now entirely dynamic to properly handle
hidden revisions
FIX: default history modal to "side by side" view on mobile
FIX: properly hiden which revision has been hidden
UX: inline category/user/wiki/post_type changes with the revision
details
FEATURE: new '/posts/:post_id/revisions/latest' endpoint to retrieve
latest revision
UX: do not show the hide/show revision button on mobile (no room for
them)
UX: remove CSS transitions on the buttons in the history modal
FIX: PostRevisor now handles all the changes that might create new
revisions
FIX: PostRevision.ensure_consistency! was wrong due to off by 1
mistake...
refactored topic's callbacks for better readability
extracted 'PostRevisionGuardian'
2014-10-27 22:06:43 +01:00
Robin Ward
caf31dde1e Revert "GroupedEach helper fix for ember 1.8"
This reverts commit 3075ebf77c.
2014-10-27 15:58:04 -04:00
Robin Ward
3075ebf77c GroupedEach helper fix for ember 1.8 2014-10-27 15:31:35 -04:00
Sam
1cc37e32b9 FEATURE: add max_reply_history to limit number of replies
that can be expanded, when clicking "in-reply-to"
2014-10-27 09:44:42 +11:00
cpradio
00816269fc Call open directly to avoid deprecation warning 2014-10-24 17:08:10 -04:00
cpradio
c6e54741bb Apply comments from eviltrout, using this.get('category.id'), and use snake case for category_id 2014-10-24 17:01:28 -04:00
Robin Ward
2a70c381f7 FIX: Moderators/Admins cannot delete other user's bookmarks 2014-10-24 16:08:52 -04:00
Arpit Jalan
433d218681 user proper naming conversation 2014-10-24 21:23:11 +05:30
Arpit Jalan
6f8c6282fa use ember textarea 2014-10-24 21:09:17 +05:30
cpradio
e013694734 FIX: Make shortcut 'c' global for creating a topic
https://meta.discourse.org/t/keyboard-shortcut-c-create-a-new-topic-does-not-work-globally/18975
2014-10-24 11:23:03 -04:00
Sam
aa9b3bb35a FEATURE: allow long polling to go to a different url
Added the site setting long_polling_base_url , this allows you
to farm long polling to a different server.

This setting is very important if a CDN is serving dynamic content.
2014-10-24 13:38:38 +11:00
cpradio
439f393d89 Show dismiss posts/topics buttons on category filtered lists 2014-10-23 17:41:39 -04:00
Robin Ward
2b2837fa12 FEATURE: Include category / subcategory name in document title when
viewing a topic.
2014-10-23 13:17:44 -04:00
Robin Ward
e2d40c033a FIX: Broken "read more" link on categories view for mobile pinned topics 2014-10-23 12:18:33 -04:00
Robin Ward
d734bdabb6 FIX: When uncategorized badge is not suppressed, the header formatting
was a bit messed up
2014-10-23 12:07:56 -04:00
Robin Ward
5de43930e9 FIX: The whole page was a drag-n-drop target even when there were
multiple file upload components.
2014-10-22 14:37:35 -04:00
Sam
6c58cb982a unbound if is not a perf gain 2014-10-22 18:07:29 +11:00
Kelle Connolly
0d461f16a7 Remove href attribute from tab link to prevent duplicate event on enter.
Because Discourse doesn't preventDefault on links with an href of "#"
this tab-able link was firing a click event when enter was pressed. This
had the unfortunate side effect of breaking the history, making routing
and navigation unreliable.
2014-10-22 17:29:57 +11:00
Sam
c104fbc915 remove unused code 2014-10-22 16:40:21 +11:00
Sam
30a814b105 PERF: unbind some stuff to speed up topic list 2014-10-22 16:37:13 +11:00
Sam
e20e6b4524 PERF: stop using jQuery to sanitize strings 2014-10-22 15:48:18 +11:00
Sam
73486b8ddd FIX: respect anon_polling_interval
FIX: only poll background message bus pages once a minute
FEATURE: background_polling_interval
FEATURE: long polling pushed back to 25 seconds
FEATURE: force a poll when a bg page returns to foreground

also improve copy of message bus settings a bit
2014-10-22 12:49:10 +11:00
Jeff Atwood
d501f003ca fix up /about on mobile 2014-10-21 01:09:54 -07:00
Sam
d4f3f894f4 FEATURE: focus input on modals is optional 2014-10-21 08:12:29 +11:00
Robin Ward
71f211f0b3 FEATURE: Allow users to select a badge with an image to appear on their
user card
2014-10-20 16:35:38 -04:00
Robin Ward
1cf4a0d604 Rename "User Expansion" to the much clearer "User Card" 2014-10-20 12:11:59 -04:00
Régis Hanol
10094a0bcd FIX: resolve flags as good when deleting a spam user 2014-10-20 16:59:06 +02:00
Arpit Jalan
42714d7d25 Hide google search when the instance is private 2014-10-20 16:50:42 +05:30
Sam
bf7ee92d56 Move search help to a more intuative spot 2014-10-18 18:00:54 +11:00
Jeff Atwood
92b615b503 reorganize site settings a bit 2014-10-19 23:14:50 -07:00
Sam
742c5e29c9 FEATURE: advanced search help 2014-10-18 14:27:33 +11:00
Arpit Jalan
e6171c31fb FIX: browser password manager was saving name instead of username 2014-10-20 01:16:07 +05:30
Arpit Jalan
7b81e79b12 Show raw email in text box 2014-10-20 00:51:22 +05:30
Kris Aubuchon
d132b35426 a handful of minor style updates/fixes 2014-10-18 23:07:55 -04:00
Régis Hanol
c59e56ec63 Merge pull request #2882 from techAPJ/patch-1
FEATURE: show raw email for replies/topics created via email
2014-10-18 21:16:17 +02:00
Arpit Jalan
72873b8368 further optimize raw email feature 2014-10-18 00:50:02 +05:30
Arpit Jalan
3854c0a29e only staff can view raw email 2014-10-17 23:21:18 +05:30
Arpit Jalan
2131a37811 FEATURE: show raw email for replies/topics created via email 2014-10-17 22:22:19 +05:30
Robin Ward
569874c2b6 UX: Added help text below profile images 2014-10-17 11:26:30 -04:00
Jeff Atwood
3825b04751 move user-dropdown unread PM badge to right 2014-10-17 16:28:10 -07:00
Robin Ward
0cbdf6f5bb FIX: Many bugs with admin badges interface
* Editing a badge's title would show it as changed in the side even if
  you didn't hit save

* Clicking a badge would not scroll to the top

* If there was an error saving a badge there was a missing i18n key

* URLs were using queryParams instead of paths

* User `label` tags for checkboxes for larger click targets

* Saved! text would persist when viewing another badge

* After creating a new badge it would show nothing

* Validation errors were not being properly released to the client

* Query errors were surrounded by an extra array
2014-10-17 16:14:49 -04:00
Sam
10db8f21d7 FEATURE: experimental reply-to expansion which hides intermediate posts
experimental_reply_expansion
2014-10-15 18:13:13 +11:00
Sam
8b508e704b Merge pull request #2881 from DeanMarkTaylor/patch-1
FIX: Censored word match fail if earlier partial match
2014-10-17 15:03:19 +11:00
Dean Taylor
0a5acba77e FIX: Censored word match fail if earlier partial match 2014-10-17 02:43:28 +01:00
Sam
c2c4e03e0f FIX: when opening links in new window link only worked once 2014-10-15 14:50:20 +11:00
Sam
4f697f234d FIX: Password managers picking name as opposed to username 2014-10-15 11:40:19 +11:00
Robin Ward
08233fc86e FIX: Show images in the admin section list for badges. Add help text to
indicate icons can be images too.
2014-10-16 16:43:34 -04:00
Robin Ward
f3a67a48a3 Merge pull request #2874 from cpradio/clear-notifications
FEATURE: Mark All as Read button for Notifications page
2014-10-16 15:57:19 -04:00
Robin Ward
d439bd274e Merge pull request #2878 from daemonsy/daemonsy_focus_topic_input
UX Improvement: Autofocus the topic field on edit
2014-10-16 15:56:35 -04:00
Robin Ward
4d465362b5 FEATURE: Allow a user to upload an image for their expansion background. 2014-10-16 15:05:36 -04:00
Robin Ward
bde0820cd4 FIX: Category group picker was broken with category path rename 2014-10-16 14:30:58 -04:00
Robin Ward
fe1b561228 UX: Only the title of a quote should have a pointer cursor 2014-10-16 13:05:45 -04:00
Robin Ward
d2ac5a9ac6 Rename /category/xyz paths to /c/xyz -- @SamSaffron did most of the
work even though I'm merging the patch!
2014-10-16 12:15:31 -04:00
Régis Hanol
8bb20f2260 UX: dim hidden revisions 2014-10-16 16:32:02 +02:00
Régis Hanol
5b004f8cce UX: add 'no-text' class to button that only use an icon 2014-10-16 16:25:51 +02:00
Damon Aw
a5e576adca UX Improvement: Autofocus the topic field on edit
- After clicking on the pencil icon to edit a topic, the focus is not set on the input.
- This leads to cases where using keyboard shorcuts (e.g. cmd + left) leads to navigation instead.
- Searching around online, it seems the cleanest way to add a text-field that autofocuses is to create a component.
- I followed the [cookbook](http://emberjs.com/guides/cookbook/user_interface_and_interaction/focusing_a_textfield_after_its_been_inserted/) and did the most naive implementation.
- This focuses the text-field but at the start of the input. Setting selectionStart and selectionEnd solves this problem, but does not work on IE 8 and below.
2014-10-14 23:31:01 -04:00
cpradio
ac708b4068 Don't use __container__ instead use needs: ['user-notifications'], (thanks eviltrout!) 2014-10-14 16:23:20 -04:00
Robin Ward
216f718607 Support /group/xyz paths as well as /groups/xyz 2014-10-14 15:11:22 -04:00
Régis Hanol
1f42e85e0d Merge pull request #2873 from mcwumbly/hide-post-revisions
FEATURE: ability to hide/show specific post revisions
2014-10-14 16:45:17 +02:00
David McClure
19d5362c6b FEATURE: ability to hide or show specific post revisions 2014-10-14 07:19:45 -07:00
Sam
b4c29a9f3b FIX: regression in autocomplete 2014-10-14 18:22:44 +11:00
Sam
737be5e151 Merge pull request #2871 from mamhoff/autocomplete-again
Fix buggy autocomplete behaviour for non-US keyboards
2014-10-16 17:35:48 +11:00
Martin Meyerhoff
f3337ab551 reduce number of times caretPosition() is called 2014-10-15 08:50:47 +02:00
Jeff Atwood
08d1f1ef7c JavaScript does love its commas 2014-10-13 21:27:32 -07:00
Jeff Atwood
825bd0d053 UX: add reply glyph back to topic level reply button 2014-10-13 21:16:44 -07:00
Robin Ward
022ca25fea Remove acccidental console.log 2014-10-15 14:37:14 -04:00
Robin Ward
224f503e6f FIX: refreshTitle error when navigating to a 404 page 2014-10-15 14:33:22 -04:00
Régis Hanol
31e9cafe0e FEATURE: use original filename when clicking the download link in the lightbox 2014-10-15 19:20:04 +02:00
Régis Hanol
65dd05cb41 UX: fix revision history modal on mobile 2014-10-13 23:26:49 +02:00
Régis Hanol
d70bb0e58b UX: fix post admin menu positioning & closing on mobile 2014-10-13 22:38:22 +02:00
Régis Hanol
0555b84e4d UX: different auto-close message when 'based on last post' is checked 2014-10-13 18:58:56 +02:00
cpradio
8f390c979b FEATURE: Mark All as Read button for Notifications page
Added a Mark All as Read button to the top/bottom of the notifications user page
https://meta.discourse.org/t/possibility-to-selectively-or-completely-mark-notifications-as-read/20227

Remove notifications property (no longer used)
2014-10-13 06:31:27 -04:00
Jeff Atwood
1f8e1f8f17 Remove old IE support from WMD, part III 2014-10-12 01:01:40 -07:00
Jeff Atwood
43bcde2060 Remove old IE support froM WMD, part II
native methods that IE8 didn't support but IE9 does
2014-10-12 00:46:08 -07:00
Jeff Atwood
28b9176bbc oh JavaScript, you so crazy 2014-10-12 00:33:13 -07:00
Jeff Atwood
aa29fc3b4a remove old IE support from WMD, part I: uaSniffed 2014-10-12 00:22:14 -07:00
Jeff Atwood
08bdf26e70 Revert "remove old IE support crap from WMD Editor"
This reverts commit 7bbf7d02e3.
2014-10-12 00:14:22 -07:00
Jeff Atwood
7bbf7d02e3 remove old IE support crap from WMD Editor
we barely support IE9 this does not matter at all
2014-10-12 00:05:18 -07:00
Jeff Atwood
053e3fca20 improve 'try again' mobile network error page 2014-10-11 23:36:37 -07:00
Martin Meyerhoff
97b60e6422 Fix buggy autocomplete behaviour for non-US keyboards
This change moves the code for actually entering data from the keydown handler to the
keypress handler, which can reliably catch the character entered (rather than
the key pressed).

This is my second attempt at
https://meta.discourse.org/t/typing-shows-on-non-us-keyboard-layouts/20449
without doing dangerous refactoring.

This does not fix the issue reported in
https://meta.discourse.org/t/overly-aggresive-emoji-autocomplete/20691/7
as that is a different bug.
2014-10-11 17:55:48 +02:00
Jeff Atwood
be43d51536 remove admin-loading in favor of spinner css 2014-10-11 03:46:42 -07:00
Robin Ward
27e68518df FIX: BBCode was trimming leading space in [code] blocks 2014-10-10 15:11:30 -04:00
Robin Ward
bbbec13606 FIX: Cursor would stay on lightbox when hitting the back button 2014-10-10 13:09:24 -04:00
Régis Hanol
5754e8dd0f FEATURE: auto-close topics based on last post 2014-10-10 18:21:44 +02:00
Robin Ward
ac72b0bcf6 FIX: Bug when sorting by category column, navigating to home 2014-10-10 12:17:53 -04:00
Robin Ward
d3b268cd2c FIX: Broken build 2014-10-09 19:42:50 -04:00
Robin Ward
3b38667274 FIX: Check for word boundaries with censored words. 2014-10-09 16:35:27 -04:00
Robin Ward
285c66b899 FIX: Say the file uploaded is too large, not "image" as you can upload
other kinds of files.
2014-10-09 16:03:04 -04:00
Robin Ward
1cda92c753 Minor documentation change to PageTracker 2014-10-09 15:07:10 -04:00
Robin Ward
5fc150e057 A mucher saner API for updating the title of routes, even when nested.
Properly sends the title of the page to google analytics
2014-10-09 14:55:29 -04:00
Robin Ward
a16d483c3c UX: If there is a reply by email icon, don't overlap with the reply tab 2014-10-08 15:58:49 -04:00
Robin Ward
f9a8f6d6ce FEATURE: Support for a required setting on user fields. 2014-10-08 15:10:19 -04:00
Robin Ward
b2d478a6fc Merge branch 'master' of github.com:awesomerobot/discourse into awesomerobot-master
Conflicts:
	app/assets/javascripts/discourse/templates/header.hbs
2014-10-08 13:48:26 -04:00
Robin Ward
32441ebcac FIX: Don't escape HTML content on category descriptions 2014-10-08 13:04:22 -04:00
Robin Ward
a98b8251a6 FIX: Private messages were getting the has-category style 2014-10-08 12:59:00 -04:00
Kris Aubuchon
75cf1a1953 adding animation to extra-info title, and mild restructure 2014-10-08 12:20:44 -04:00
Régis Hanol
dcd4956ea4 remove console.log 2014-10-08 17:37:44 +02:00
Robin Ward
89fdc87402 Add back CSS classes to sortable headings. 2014-10-08 10:50:49 -04:00
Sam
b9a9fb54da FIX: streaming incorrect events into all tab 2014-10-08 13:35:07 +11:00
Sam
67429b29a5 FIX: after visiting "top" unread/new tip rendered in large font 2014-10-08 13:11:26 +11:00
Sam
7ef2f48660 FIX: not showing any search results when scoped on user 2014-10-08 13:03:18 +11:00
Sam
168c690427 FIX: handle paste events for auto completed fields 2014-10-08 11:59:46 +11:00
Robin Ward
11b52d1334 More deprecations to allow us to work on future versions of Ember 2014-10-07 16:04:19 -04:00
Neil Lalonde
0ab9a0867a Merge branch 'master' of github.com:discourse/discourse 2014-10-07 15:53:11 -04:00
Neil Lalonde
a30e70e8f1 FEATURE: trust level 3: likes received must be on min_likes_received/3 different days, and be from min_likes_received/4 different users 2014-10-07 15:52:54 -04:00
Robin Ward
e20c82436d FIX: Clicking "Latest" while ordering by a column should reset the
order.
2014-10-07 15:19:17 -04:00
Robin Ward
bb192dd0a3 UX: Remove sortable column from "Topic" and "Users" column. 2014-10-07 14:45:36 -04:00
Kris Aubuchon
f4f6236902 changes: topic title editor layout, badge alignment in scrolled header 2014-10-07 11:41:04 -04:00
Régis Hanol
c46b9c0ac3 FIX: allow admins to search users by email 2014-10-07 12:05:38 +02:00
Sam
dde8ae7e96 FIX: analytics universal not sending correct location 2014-10-07 12:23:04 +11:00
Robin Ward
e383a8ab01 Merge pull request #2854 from techAPJ/patch-1
Feature: resend invites
2014-10-06 17:25:36 -04:00
Neil Lalonde
ad387a1150 FEATURE: posts will be deleted immediately if delete_removed_posts_after is set to 0 2014-10-06 16:30:07 -04:00
Robin Ward
76a9eca5b0 FIX: Malformed HTML really screws with the renderer 2014-10-06 16:29:13 -04:00
Robin Ward
52298faaa0 Revert "Revert "Add striped category badges under title""
This reverts commit 85b6b2550e.
2014-10-06 16:29:13 -04:00
Robin Ward
02814f0d89 Revert "Revert "new docked title category style - needs additional work""
This reverts commit e886cc2dad.
2014-10-06 16:29:13 -04:00
Robin Ward
e886cc2dad Revert "new docked title category style - needs additional work"
This reverts commit 43467a8aaa.
2014-10-06 16:13:51 -04:00
Robin Ward
85b6b2550e Revert "Add striped category badges under title"
This reverts commit 331e63e3af.
2014-10-06 16:13:51 -04:00
Arpit Jalan
78fd99fc40 Feature: resend invites 2014-10-07 01:43:17 +05:30
Robin Ward
331e63e3af Add striped category badges under title 2014-10-06 15:58:57 -04:00
Kris Aubuchon
43467a8aaa new docked title category style - needs additional work 2014-10-06 15:58:57 -04:00
Régis Hanol
ac069d22a9 FIX: delete spammer modal doesn't show the email address 2014-10-06 21:55:52 +02:00
Régis Hanol
baee5c95ac add more context to allow better translation of 'max' in TL3 requirements 2014-10-06 21:32:19 +02:00
Régis Hanol
67c10a7eab UX: add topic admin button to the bottom of the topic 2014-10-06 20:19:07 +02:00
Jeff Atwood
948f4a59e9 Merge pull request #2852 from awesomerobot/master
restructuring post titles a bit
2014-10-06 09:57:00 -07:00
Robin Ward
90e3242a3c FIX: topic-admin-menu controller was not a proper singleton. 2014-10-06 12:27:12 -04:00
Kris Aubuchon
1224ffa1c5 restructuring post titles a bit 2014-10-06 11:50:18 -04:00
Sam
6391dc7f28 FIX: hitting edit while replying does nothing 2014-10-06 10:51:02 +11:00
Kane York
b79c835c07 Fix data-* behavior (failure to understand own docs) 2014-10-05 15:11:26 -07:00
riking
0532468499 Fix JSHint 2014-10-05 14:58:48 -07:00
riking
1436f75a9f FEATURE: Allow explicit rel="nofollow" on links 2014-10-05 14:58:48 -07:00
riking
0586b3dd25 Clean up validateAttribute() function
Remove code duplication
2014-10-05 14:58:47 -07:00
riking
32cc31319f FIX: Use lang- prefixes for HLJS; add nohighlight for ...
text; use a proper whiteListTag() call.

Old posts are not affected - no global rebake is necessary.
2014-10-05 14:58:47 -07:00
riking
22a4ceceee Auto-anchor attribute regexes, document _validTags 2014-10-05 12:17:56 -07:00
Robin Ward
1e5195e68f FIX: Could sometimes open two category drop downs at once. 2014-10-03 15:42:45 -04:00
Robin Ward
e55b437eb9 Replace the rest of the deprecated {{action xyz}} with `{{action
"xyz"}}`
2014-10-03 14:43:27 -04:00
Robin Ward
41db949e9d FIX: Allow HTML in custom fields 2014-10-03 13:06:54 -04:00
Régis Hanol
d4f9228058 Merge pull request #2841 from lidel/fix-min-username
FIX: fix @mentions for 1 character usernames
2014-10-03 17:37:47 +02:00
Neil Lalonde
83fc88e965 FIX: when site is in read-only mode, create account action should show a warning like login does. 2014-10-03 11:02:05 -04:00
Neil Lalonde
eb473696ff Refactor showLogin and showCreateAccount actions for extensibility 2014-10-03 11:02:05 -04:00
Marcin Rataj
a56f5a9b65 FIX: fix @mentions for usernames shorter than 2 characters
Super short usernames were enabled by
https://github.com/discourse/discourse/pull/2838
This is just a fix for @mentions
2014-10-03 13:20:40 +02:00
Sam
f5912a5500 amend previous fix 2014-10-03 16:35:35 +10:00
Sam
8c214c35e4 FIX: clicking on heading could insert a broken heading 2014-10-03 16:35:02 +10:00
Jeff Atwood
5fe1f99bf5 drop text from loading spinner 2014-10-02 14:50:13 -07:00
Robin Ward
ad5e4f98d9 Revert "Merge pull request #2833 from mamhoff/new-bugfix-autocomplete"
This reverts commit 2450d284c5, reversing
changes made to 489078bfcf.
2014-10-02 16:00:50 -04:00
Robin Ward
381814fd5d Adds support for a description to user fields. 2014-10-02 15:56:52 -04:00
Jeff Atwood
cd3461dde8 remove "Loading more topics.." text 2014-10-02 12:16:16 -07:00
Robin Ward
9564ecde76 FEATURE: Site setting for words to censor in posts 2014-10-02 13:58:58 -04:00
Jeff Atwood
96afdb173d add ▼ to show more in search, remove show less 2014-10-02 03:16:49 -07:00
Sam
2450d284c5 Merge pull request #2833 from mamhoff/new-bugfix-autocomplete
BUGFIX: Handle text input in keypress handler for I18n
2014-10-02 17:04:41 +10:00
lidlanca
725af87980 Fix: remove hardcoded minimum for username length validation 2014-10-02 01:51:23 -04:00