From 75e22086a9d9c1bb8e78259ce007dc5dec11b274 Mon Sep 17 00:00:00 2001 From: Jared Reisinger Date: Wed, 21 Sep 2016 13:15:58 -0700 Subject: [PATCH] Don't look for external facts when benchmarking When running `scripts/bench.rb` via the discourse/discourse_bench docker container, Facter throws an EACCES error attempting to load external puppet facts. Since the benchmark script ends up ignoring everything except for seven specific keys, we can just avoid loading any external fact logic entirely. can just --- script/bench.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/script/bench.rb b/script/bench.rb index 61a3857b8..b4b7514a3 100644 --- a/script/bench.rb +++ b/script/bench.rb @@ -219,6 +219,9 @@ begin puts "Your Results: (note for timings- percentile is first, duration is second in millisecs)" + # Prevent using external facts because it breaks when running in the + # discourse/discourse_bench docker container. + Facter::Util::Config.external_facts_dirs = [] facts = Facter.to_hash facts.delete_if{|k,v| @@ -270,8 +273,6 @@ begin end end - - # TODO include Facter.to_hash ... for all facts ensure Process.kill "KILL", pid end