codeninjasllc/discourse
1
0
Fork 0
mirror of https://github.com/codeninjasllc/discourse.git synced 2025-02-17 12:11:16 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

PERF: avoid cookies for all static, public, cached forever assets

Browse source
This commit is contained in:
Sam 2015-05-22 16:15:46 +10:00
parent e59d5fd0eb
commit fe46d1dd3b
5 changed files with 20 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
app/controllers/application_controller.rb
View file

@ -281,6 +281,13 @@ class ApplicationController < ActionController::Base
post_ids post_ids
end end
def no_cookies
# do your best to ensure response has no cookies
# longer term we may want to push this into middleware
headers.delete 'Set-Cookie'
request.session_options[:skip] = true
end
private private
def preload_anonymous_data def preload_anonymous_data

3
app/controllers/highlight_js_controller.rb
View file

@ -2,6 +2,9 @@ class HighlightJsController < ApplicationController
skip_before_filter :preload_json, :redirect_to_login_if_required, :check_xhr, :verify_authenticity_token, only: [:show] skip_before_filter :preload_json, :redirect_to_login_if_required, :check_xhr, :verify_authenticity_token, only: [:show]
def show def show
no_cookies
RailsMultisite::ConnectionManagement.with_hostname(params[:hostname]) do RailsMultisite::ConnectionManagement.with_hostname(params[:hostname]) do
current_version = HighlightJs.version(SiteSetting.highlighted_languages) current_version = HighlightJs.version(SiteSetting.highlighted_languages)

3
app/controllers/site_customizations_controller.rb
View file

@ -2,6 +2,9 @@ class SiteCustomizationsController < ApplicationController
skip_before_filter :preload_json, :check_xhr, :redirect_to_login_if_required skip_before_filter :preload_json, :check_xhr, :redirect_to_login_if_required
def show def show
no_cookies
cache_time = request.env["HTTP_IF_MODIFIED_SINCE"] cache_time = request.env["HTTP_IF_MODIFIED_SINCE"]
cache_time = Time.rfc2822(cache_time) rescue nil if cache_time cache_time = Time.rfc2822(cache_time) rescue nil if cache_time
stylesheet_time = stylesheet_time =

2
app/controllers/stylesheets_controller.rb
View file

@ -3,6 +3,8 @@ class StylesheetsController < ApplicationController
def show def show
no_cookies
target,digest = params[:name].split("_") target,digest = params[:name].split("_")
cache_time = request.env["HTTP_IF_MODIFIED_SINCE"] cache_time = request.env["HTTP_IF_MODIFIED_SINCE"]

5
app/controllers/user_avatars_controller.rb
View file

@ -24,6 +24,8 @@ class UserAvatarsController < ApplicationController
params.require(:version) params.require(:version)
params.require(:size) params.require(:size)
no_cookies
return render_dot if params[:version] != LetterAvatar.version return render_dot if params[:version] != LetterAvatar.version
image = LetterAvatar.generate(params[:username].to_s, params[:size].to_i) image = LetterAvatar.generate(params[:username].to_s, params[:size].to_i)
@ -35,6 +37,9 @@ class UserAvatarsController < ApplicationController
end end
def show def show
no_cookies
# we need multisite support to keep a single origin pull for CDNs # we need multisite support to keep a single origin pull for CDNs
RailsMultisite::ConnectionManagement.with_hostname(params[:hostname]) do RailsMultisite::ConnectionManagement.with_hostname(params[:hostname]) do
show_in_site(RailsMultisite::ConnectionManagement.current_hostname) show_in_site(RailsMultisite::ConnectionManagement.current_hostname)