From fd035cf7772c068f6201e539bd6ef314dc76841d Mon Sep 17 00:00:00 2001 From: Sam Date: Mon, 22 Apr 2013 10:42:12 +1000 Subject: [PATCH] thinking about it .. WE ALWAYS track external links. WE DON'T display external link counts inside oneboxes. Reverting to old behavior so we can fix properly --- app/assets/javascripts/discourse/components/click_track.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/app/assets/javascripts/discourse/components/click_track.js b/app/assets/javascripts/discourse/components/click_track.js index d6a1014bf..5f7939804 100644 --- a/app/assets/javascripts/discourse/components/click_track.js +++ b/app/assets/javascripts/discourse/components/click_track.js @@ -22,10 +22,6 @@ Discourse.ClickTrack = { // We don't track clicks on quote back buttons if ($link.hasClass('back') || $link.hasClass('quote-other-topic')) return true; - // We don't track clicks in oneboxes - // except when we force it with the "track-link" class - if ($link.closest('.onebox-result').length > 0 && !$link.hasClass('track-link')) return true; - // Remove the href, put it as a data attribute if (!$link.data('href')) { $link.addClass('no-href');