codeninjasllc/discourse
1
0
Fork 0
mirror of https://github.com/codeninjasllc/discourse.git synced 2024-11-30 10:58:31 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

FIX: use 16:9 ratio to detect whether to crop a thumbnail or not

Browse source
This commit is contained in:
Régis Hanol 2016-05-26 19:02:31 +02:00
parent 51dbb966de
commit ebd4b45771
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/cooked_post_processor.rb
View file

@ -186,6 +186,10 @@ class CookedPostProcessor
rescue URI::InvalidURIError rescue URI::InvalidURIError
end end
# only crop when the image is taller than 16:9
# we only use 95% of that to allow for a small margin
MIN_RATIO_TO_CROP ||= (9.0 / 16.0) * 0.95
def convert_to_link!(img) def convert_to_link!(img)
src = img["src"] src = img["src"]
return unless src.present? return unless src.present?
@ -208,7 +212,7 @@ class CookedPostProcessor
return if is_a_hyperlink?(img) return if is_a_hyperlink?(img)
crop = false crop = false
if original_width.to_f / original_height.to_f < 0.75 if original_width.to_f / original_height.to_f < MIN_RATIO_TO_CROP
crop = true crop = true
width, height = ImageSizer.crop(original_width, original_height) width, height = ImageSizer.crop(original_width, original_height)
img["width"] = width img["width"] = width