codeninjasllc/discourse
1
0
Fork 0
mirror of https://github.com/codeninjasllc/discourse.git synced 2024-11-27 09:36:19 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

formally remove IE9 support

Browse source
This commit is contained in:
Jeff Atwood 2016-01-02 23:49:52 -08:00
parent 3251bcb405
commit e1f90d12f1
9 changed files with 10 additions and 38 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
README.md
View file

@ -45,8 +45,6 @@ Discourse is built for the *next* 10 years of the Internet, so our requirements
| Internet Explorer 10+ | Windows 8 | Windows Phone 8 | | Internet Explorer 10+ | Windows 8 | Windows Phone 8 |
| Firefox 16+ | | | Firefox 16+ | |
Internet Explorer 9.0 will no longer be supported in 2016.
## Built With ## Built With
- [Ruby on Rails](https://github.com/rails/rails) — Our back end API is a Rails app. It responds to requests RESTfully in JSON. - [Ruby on Rails](https://github.com/rails/rails) — Our back end API is a Rails app. It responds to requests RESTfully in JSON.

10
app/assets/javascripts/discourse/initializers/ie9-hax.js.es6
View file

@ -1,10 +0,0 @@
export default {
name: 'ie9-hacks',
initialize: function() {
if (!window) { return; }
// IE9 does not support a console object unless the developer tools are open
if (!window.console) { window.console = {}; }
if (!window.console.log) { window.console.log = Ember.K; }
}
};

2
app/assets/javascripts/discourse/routes/discourse.js.es6
View file

@ -89,7 +89,7 @@ export function cleanDOM() {
// Remove any link focus // Remove any link focus
// NOTE: the '.not("body")' is here to prevent a bug in IE10 on Win7 // NOTE: the '.not("body")' is here to prevent a bug in IE10 on Win7
// cf. https://stackoverflow.com/questions/5657371/ie9-window-loses-focus-due-to-jquery-mobile // cf. https://stackoverflow.com/questions/5657371
$(document.activeElement).not("body").not(".no-blur").blur(); $(document.activeElement).not("body").not(".no-blur").blur();
Discourse.set('notifyCount',0); Discourse.set('notifyCount',0);

9
app/assets/stylesheets/common/foundation/mixins.scss
View file

@ -101,15 +101,8 @@
background-color: blend-primary-secondary(5%); background-color: blend-primary-secondary(5%);
} }
// We definately need -webkit for latest iPhone and Safari // We still need -webkit for latest iPhone and Safari
// When we deprecate IE9 we should clean up just to have webkit and non prefixed
// ms is left around for ie9
// moz is for firefox 15 (do we even work with that?)
// -o would be for opera 11.5
@mixin transform($transforms) { @mixin transform($transforms) {
-o-transform: $transforms;
-moz-transform: $transforms;
-ms-transform: $transforms;
-webkit-transform: $transforms; -webkit-transform: $transforms;
transform: $transforms; transform: $transforms;
} }

3
app/assets/stylesheets/desktop/compose.scss
View file

@ -109,9 +109,6 @@
width: calc(50% - 65px); width: calc(50% - 65px);
} }
// hide cancel upload link on IE9 (not supported)
.ie9 #cancel-file-upload { display: none; }
// only disabled when the device is touch-only // only disabled when the device is touch-only
.touch.mobile-device #reply-control.open .grippie { .touch.mobile-device #reply-control.open .grippie {
display: none; display: none;

3
app/controllers/uploads_controller.rb
View file

@ -9,9 +9,6 @@ class UploadsController < ApplicationController
client_id = params[:client_id] client_id = params[:client_id]
synchronous = is_api? && params[:synchronous] synchronous = is_api? && params[:synchronous]
# HACK FOR IE9 to prevent the "download dialog"
response.headers["Content-Type"] = "text/plain" if request.user_agent =~ /MSIE 9/
if type == "avatar" if type == "avatar"
if SiteSetting.sso_overrides_avatar || !SiteSetting.allow_uploaded_avatars if SiteSetting.sso_overrides_avatar || !SiteSetting.allow_uploaded_avatars
return render json: failed_json, status: 422 return render json: failed_json, status: 422

5
app/views/layouts/application.html.erb
View file

@ -1,6 +1,5 @@
<!DOCTYPE html> <!DOCTYPE html>
<!--[if IE 9]><html lang="<%= SiteSetting.default_locale %>" class="ie9 <%= html_classes %>"><![endif]--> <html lang="<%= SiteSetting.default_locale %>" class="<%= html_classes %>">
<!--[if (!IE 9) | (!IE)]><!--><html lang="<%= SiteSetting.default_locale %>" class="<%= html_classes %>"><!--<![endif]-->
<head> <head>
<meta charset="utf-8"> <meta charset="utf-8">
<title><%= content_for?(:title) ? yield(:title) + ' - ' + SiteSetting.title : SiteSetting.title %></title> <title><%= content_for?(:title) ? yield(:title) + ' - ' + SiteSetting.title : SiteSetting.title %></title>
@ -60,8 +59,6 @@
</footer> </footer>
</noscript> </noscript>
<!--[if IE 9]><script type="text/javascript">ie = "new";</script><![endif]-->
<%- unless customization_disabled? || loading_admin? %> <%- unless customization_disabled? || loading_admin? %>
<%= SiteCustomization.custom_header(session[:preview_style], mobile_view? ? :mobile : :desktop) %> <%= SiteCustomization.custom_header(session[:preview_style], mobile_view? ? :mobile : :desktop) %>
<%- end %> <%- end %>

2
plugins/discourse-details/README.md
View file

@ -2,7 +2,7 @@
HTML 5.1 `<details>` polyfill for [Discourse](https://www.discourse.org). HTML 5.1 `<details>` polyfill for [Discourse](https://www.discourse.org).
NOTE: Does not work on IE9. NOTE: Does not work on IE9, but we don't support IE9 as of Jan 1 2016.
## Usage ## Usage

2
vendor/assets/javascripts/browser-update.js.erb vendored
View file

@ -17,7 +17,7 @@ var $buo = function() {
badAndroid = true; badAndroid = true;
} }
// sam: my main concern here is mobile, but its an outlier, for now we support ie9, set conditionally and stuff with pushState // sam: my main concern here is mobile, but its an outlier, for now we support ie10, set conditionally and stuff with pushState
if (window.ie === "new" || (window.history && window.history.pushState && !badAndroid)) { if (window.ie === "new" || (window.history && window.history.pushState && !badAndroid)) {
return; return;
} }