From d85d34bac869b7af29b98491c391ab954a9d696a Mon Sep 17 00:00:00 2001 From: Sam Date: Tue, 17 Jun 2014 13:39:52 +1000 Subject: [PATCH] BUGFIX: use plugin outlet instead of custom code --- .../templates/user/preferences.js.handlebars | 2 +- .../discourse/views/user/preferences_view.js | 29 ------------------- 2 files changed, 1 insertion(+), 30 deletions(-) diff --git a/app/assets/javascripts/discourse/templates/user/preferences.js.handlebars b/app/assets/javascripts/discourse/templates/user/preferences.js.handlebars index 7b35de2a1..3ffbdbc06 100644 --- a/app/assets/javascripts/discourse/templates/user/preferences.js.handlebars +++ b/app/assets/javascripts/discourse/templates/user/preferences.js.handlebars @@ -175,7 +175,7 @@ {{preference-checkbox labelKey="user.enable_quoting" checked=enable_quoting}} {{preference-checkbox labelKey="user.dynamic_favicon" checked=dynamic_favicon}} {{preference-checkbox labelKey="user.disable_jump_reply" checked=disable_jump_reply}} - {{view Discourse.CustomPreferences}} + {{plugin-outlet "user_custom_preferences"}}
diff --git a/app/assets/javascripts/discourse/views/user/preferences_view.js b/app/assets/javascripts/discourse/views/user/preferences_view.js index d67274926..d0728d46f 100644 --- a/app/assets/javascripts/discourse/views/user/preferences_view.js +++ b/app/assets/javascripts/discourse/views/user/preferences_view.js @@ -13,9 +13,6 @@ Discourse.PreferencesView = Discourse.View.extend({ uploading: false, uploadProgress: 0, - customPreferences: function(){ - }.property(), - didInsertElement: function() { var self = this; var $upload = $("#profile-background-input"); @@ -56,29 +53,3 @@ Discourse.PreferencesView = Discourse.View.extend({ $("#profile-background-input").fileupload("destroy"); } }); - -Discourse.PreferencesView.reopenClass({ - registerCustomSection: function(viewClass){ - var customSections = this.customSections; - if(!customSections){ - customSections = Em.A(); - this.customSections = customSections; - } - - customSections.addObject(viewClass); - } -}); - -Discourse.CustomPreferences = Discourse.ContainerView.extend({ - init: function(){ - this._super(); - var self = this; - - var sections = Discourse.PreferencesView.customSections; - if(sections){ - sections.forEach(function(view){ - self.pushObject(view.create({user: self.get('controller.model')})); - }); - } - } -});