mirror of
https://github.com/codeninjasllc/discourse.git
synced 2024-11-27 09:36:19 -05:00
Fix for foreign language titles: Only enforce upper case rule on english alphabet.
This commit is contained in:
parent
b9457197c0
commit
d740d7b25f
2 changed files with 11 additions and 4 deletions
|
@ -54,8 +54,8 @@ class TextSentinel
|
|||
|
||||
return false if @opts[:max_word_length] and @text =~ /\w{#{@opts[:max_word_length]},}(\s|$)/
|
||||
|
||||
# We don't allow all upper case content
|
||||
return false if @text == @text.upcase
|
||||
# We don't allow all upper case content in english
|
||||
return false if (@text =~ /[A-Z]+/) and (@text == @text.upcase)
|
||||
|
||||
true
|
||||
end
|
||||
|
|
|
@ -30,6 +30,10 @@ describe TextSentinel do
|
|||
TextSentinel.new("evil trout is evil").entropy.should == 10
|
||||
end
|
||||
|
||||
it "Works on foreign characters" do
|
||||
TextSentinel.new("去年十社會警告").entropy.should == 7
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
context "cleaning up" do
|
||||
|
@ -78,9 +82,12 @@ describe TextSentinel do
|
|||
TextSentinel.new(valid_string, min_entropy: 17).should_not be_valid
|
||||
end
|
||||
|
||||
it "allows all foreign characters" do
|
||||
TextSentinel.new("去年十二月,北韓不顧國際社會警告").should be_valid
|
||||
end
|
||||
|
||||
it "doesn't allow a long alphanumeric string with no spaces" do
|
||||
TextSentinel.new("jfewjfoejwfojeojfoejofjeo38493824jfkjewfjeoifijeoijfoejofjeojfoewjfo834988394032jfiejoijofijeojfeojfojeofjewojfojeofjeowjfojeofjeojfoe3898439849032jfeijfwoijfoiewj",
|
||||
max_word_length: 30).should_not be_valid
|
||||
TextSentinel.new("jfewjfoejwfojeojfoejofjeo3" * 5, max_word_length: 30).should_not be_valid
|
||||
end
|
||||
|
||||
it "doesn't except junk symbols as a string" do
|
||||
|
|
Loading…
Reference in a new issue